RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase

[Hohensee, Paul]

Thanks for filing the new RFEs!

Paul

From: JC Beyler <jcbeyler at google.com>
Date: Tuesday, October 23, 2018 at 7:49 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: "serguei.spitsyn at oracle.com" <serguei.spitsyn at oracle.com>, "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
Subject: Re: RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase

Hi Paul,

Thanks for the review! I created two new bugs for these two refactoring cases. They seem fairly uncommon so should be easy to fix throughout .cpp files in vmTestbase.
https://bugs.openjdk.java.net/browse/JDK-8212822
https://bugs.openjdk.java.net/browse/JDK-8212824

So I'll keep them out of scope of this change as you recommended to do it separately ;-),
Jc

On Mon, Oct 22, 2018 at 5:10 PM Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> wrote:
Lgtm.
There’s a similar issue with ‘{‘’}’ you might want to fix separately, except in the opposite direction :), e.g., in test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp,
+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str); printf("%d\n",res); return res;}
+#define JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) { printf(str); printf("unexpected error %d\n",res); return res;}
=>

+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str); printf("%d\n",res); return res; }

+#define JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) { printf(str); printf("unexpected error %d\n",res); return res; }

And somewhat different in test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/aod/jvmti_aod.cpp

+            (threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass, "<init>", "()V"))  != NULL)) {

=>

+            (threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass, "<init>", "()V")) != NULL)) {

Paul
From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net<mailto:serviceability-dev-bounces at openjdk.java.net>> on behalf of "serguei.spitsyn at oracle.com<mailto:serguei.spitsyn at oracle.com>" <serguei.spitsyn at oracle.com<mailto:serguei.spitsyn at oracle.com>>
Date: Monday, October 22, 2018 at 3:15 PM
To: JC Beyler <jcbeyler at google.com<mailto:jcbeyler at google.com>>, "serviceability-dev at openjdk.java.net<mailto:serviceability-dev at openjdk.java.net>" <serviceability-dev at openjdk.java.net<mailto:serviceability-dev at openjdk.java.net>>
Subject: Re: RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase

Hi Jc,

It looks good.

Thanks!
Serguei


On 10/22/18 11:30, JC Beyler wrote:
Hi all,

Here is the last webrev (3 out of 3) to remove the spaces after/before () from vmTestbase. It is straightforward and I generated the webrev with white-space changes showing up of course:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8212771/webrev.00/<http://cr.openjdk.java.net/%7Ejcbeyler/8212771/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212771

Could I please get some reviews?

Thanks,
Jc



--

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181023/936c54d7/attachment-0001.html>