RFR: JDK-8158066: SourceDebugExtensionTest fails to rename file

[David Holmes]

Hi Gary,

On 11/01/2019 9:22 pm, gary.adams at oracle.com wrote:
> After ~1000 testruns I hit a failure in MangleTest and a jtreg agent 
> communication issue with SourceDebugExtension.
> 
> https://java.se.oracle.com:10065/mdash/builds/2019-01-10-1159535.gary.adams.jdk-jdb/results?search=status%3Afailed%20AND%20-state%3Ainvalid
> 
> 
> *java.io.IOException: tmpFile.renameTo(inOutClassFile) failed*
> 	at InstallSDE.install(InstallSDE.java:40)
> 	at MangleTest.testSetUp(MangleTest.java:38)
> 	at MangleTest.main(MangleTest.java:31)

You might want to add some code in:

./java.base/windows/native/libjava/WinNTFileSystem_md.c:Java_java_io_WinNTFileSystem_rename0

that checks the result of _wrename to see what error is occurring. I 
suspect it will be EACCES which won't be that helpful:

https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/rename-wrename?view=vs-2017

but it would be good to confirm.

> 
> result: Error. Agent communication error: java.io.IOException:*Agent: unexpected op: 71;*  check console log for any additional details
> 
> I added some additional print outs for the rename issue and have run 
> ~2000 additional
> testruns with no test failures repeated, yet. But there were 2 mach5 
> reported errors:
> 
>     TimeoutException in CLEANUP.

That's a mach5 issue.

David

> 
> I'll do some more investigation with making the rename operation more robust
> before removing SourceDebugExtensionTest from the problem list.
> 
> On 1/10/19 8:28 PM, David Holmes wrote:
>> Hi Gary,
>>
>> On 10/01/2019 11:02 pm, gary.adams at oracle.com wrote:
>>> SourceDebugExtensionTest was placed on the ProblemList
>>> because of filesystem rename issues on Windows 2012 test systems.
>>> The test does not appear to fail on the current mach5 test systems.
>>> There was some question concerning symbolic links that might have
>>> been problematic at that time. Additional testing in progress...
>>
>> Also note that there are two sets of SDE related tests and two 
>> versions of the InstallSDE.java file that both use renameTo. In nsk 
>> the testcase seems to be:
>>
>> ./hotspot/jtreg/vmTestbase/vm/mlvm/share/StratumClassesBuilder.java
>>
>> and AFAICS it is not excluded. So removing the exclusion seems 
>> reasonable to me. It was most like a concurrency issue with the virus 
>> scanner.
>>
>> Thanks,
>> David
>>
>>
>>>    Issue: https://bugs.openjdk.java.net/browse/JDK-8158066
>>>
>>> diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
>>> --- a/test/jdk/ProblemList.txt
>>> +++ b/test/jdk/ProblemList.txt
>>> @@ -838,8 +838,6 @@
>>>
>>>   com/sun/jdi/RepStep.java 8043571 generic-all
>>>
>>> -com/sun/jdi/sde/SourceDebugExtensionTest.java 8158066 windows-all
>>> -
>>>   com/sun/jdi/NashornPopFrameTest.java 8187143 generic-all
>>>
>