RFR: 8217612: (CL)HSDB cannot show some JVM flags

[David Holmes]

Hi Yasumasa,

We're seeing the following test fail on all platforms after this change:

gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java

No real information just:

java.lang.Exception: jmap -heap exited with error code: 1
	at 
CompressedClassSpaceSizeInJmapHeap.run(CompressedClassSpaceSizeInJmapHeap.java:80)
	at 
CompressedClassSpaceSizeInJmapHeap.main(CompressedClassSpaceSizeInJmapHeap.java:68)
	at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
	at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at 
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
	at java.base/java.lang.Thread.run(Thread.java:835)

Can you try it?

Thanks,
David

On 26/01/2019 11:32 am, Yasumasa Suenaga wrote:
> Thanks Chris!
> 
> 
> Yasumasa
> 
> 
> On 2019/01/26 3:53, Chris Plummer wrote:
>> +1
>>
>> Chris
>>
>> On 1/24/19 10:59 PM, Yasumasa Suenaga wrote:
>>> Thanks David!
>>>
>>> I'm waiting for second reviewer.
>>>
>>>
>>> Yasumasa
>>>
>>> 2019年1月25日(金) 15:31 David Holmes <david.holmes at oracle.com>:
>>>> Hi Yasumasa,
>>>>
>>>> This all looks quite reasonable to me.
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>> On 25/01/2019 10:41 am, Yasumasa Suenaga wrote:
>>>>> Hi all,
>>>>>
>>>>> Please review this change.
>>>>>
>>>>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8217612
>>>>>     webrev: 
>>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8217612/webrev.00/
>>>>>
>>>>>
>>>>> "Show -XX flags" on HSDB and `flags` command on CLHSDB show -XX flags.
>>>>> However some flags cannot do so.
>>>>>
>>>>> sun.jvm.hotspot.runtime.VM.Flag handles -XX flags in debuggee, but 
>>>>> it do not
>>>>> handle following types:
>>>>>
>>>>>     - ccstr
>>>>>     - ccstrlist
>>>>>     - double
>>>>>     - uint64_t
>>>>>
>>>>>
>>>>> This webrev has passed all tests on submit repo.
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Yasumasa
>>>>>
>>
>>