RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612

[David Holmes]

Hi Yasumasa,

Please push.

Thanks,
David

On 27/01/2019 11:41 am, Yasumasa Suenaga wrote:
> Hi David,
> 
> On 2019/01/27 8:59, David Holmes wrote:
>> Can you please ensure you have tested all the j* tool using tests 
>> please as we are seeing related failures e.g.
>>
>> sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java
>>
>> Exception in thread "main" java.lang.NumberFormatException: For input 
>> string: "18446744073709486080"
>>      at 
>> java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:68) 
>>
>>      at java.base/java.lang.Long.parseLong(Long.java:699)
>>      at java.base/java.lang.Long.parseLong(Long.java:824)
>>      at 
>> jdk.hotspot.agent/sun.jvm.hotspot.tools.HeapSummary.getFlagValue(HeapSummary.java:298) 
>>
>>      at 
>> jdk.hotspot.agent/sun.jvm.hotspot.tools.HeapSummary.run(HeapSummary.java:86) 
>>
>>      at jdk.hotspot.agent/sun.jvm.hotspot.tools.JMap.run(JMap.java:115)
> 
> This change affects SA, so I grep'ed test code with jhsdb:
> 
> 
> ```
> [ysuenaga at fc29 test]$ grep -lrw jhsdb *
> hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java
> hotspot/jtreg/serviceability/sa/DeadlockDetectionTest.java
> hotspot/jtreg/serviceability/sa/TestClhsdbJstackLock.java
> hotspot/jtreg/serviceability/sa/TestJmapCoreMetaspace.java
> hotspot/jtreg/serviceability/sa/TestIntConstant.java
> hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java
> hotspot/jtreg/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
> hotspot/jtreg/serviceability/sa/TestUniverse.java
> hotspot/jtreg/serviceability/sa/TestJhsdbJstackMixed.java
> hotspot/jtreg/serviceability/sa/TestType.java
> hotspot/jtreg/serviceability/sa/CDSJMapClstats.java
> hotspot/jtreg/serviceability/sa/JhsdbThreadInfoTest.java
> hotspot/jtreg/serviceability/sa/TestJhsdbJstackLock.java
> hotspot/jtreg/serviceability/sa/TestPrintMdo.java
> hotspot/jtreg/serviceability/sa/TestHeapDumpForInvokeDynamic.java
> hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java
> hotspot/jtreg/serviceability/sa/TestJmapCore.java
> hotspot/jtreg/serviceability/sa/ClhsdbLauncher.java
> jdk/sun/tools/jhsdb/heapconfig/TmtoolTestScenario.java
> jdk/sun/tools/jhsdb/HeapDumpTest.java
> jdk/sun/tools/jhsdb/BasicLauncherTest.java
> jdk/tools/launcher/HelpFlagsTest.java
> jdk/ProblemList.txt
> jtreg-ext/requires/VMProps.java
> lib/jdk/test/lib/Platform.java
> ```
> 
> Thuns I run tests as following, and they work fine with JDK-8217850 fix:
> 
> 
> ```
> [ysuenaga at fc29 jdk]$ $JT_HOME/bin/jtreg -ignore:quiet 
> -exclude:ProblemList.txt 
> -nativepath:/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-server-fastdebug/support/test/jdk/jtreg/native/lib 
> sun/tools/jhsdb tools/launcher/HelpFlagsTest.java
> Directory "JTwork" not found: creating
> Directory "JTreport" not found: creating
> Test results: passed: 5
> ```
> 
> Can I push JDK-8217850 change? or should I test more?
> I think hotspot/jtreg/serviceability/sa will be run on submit repo 
> (tier-1 test).
> 
> 
> Thanks,
> 
> Yasumasa
> 
> 
>> Thanks,
>> David
>>
>>
>> On 27/01/2019 9:23 am, David Holmes wrote:
>>> Hi Yasumasa,
>>>
>>> That seems quite reasonable.
>>>
>>> Thanks for the quick fix.
>>>
>>> David
>>> -----
>>>
>>> On 26/01/2019 10:47 pm, Yasumasa Suenaga wrote:
>>>> Sorry, webrev is here:
>>>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8217850/webrev.00/
>>>>
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> On 2019/01/26 21:44, Yasumasa Suenaga wrote:
>>>>> Hi all,
>>>>>
>>>>> Please review this change:
>>>>>
>>>>>    JBS: https://bugs.openjdk.java.net/browse/JDK-8217850
>>>>>    webrev: https://bugs.openjdk.java.net/browse/JDK-8217850
>>>>>
>>>>> This change passed tests on submit repo, and 
>>>>> test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java 
>>>>> on my Linux x64 box.
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Yasumasa