RFR: 8217845: SA should refer const values for JVMFlag from HotSpot

Yasumasa Suenaga yasuenag at gmail.com
Mon Jan 28 00:35:10 UTC 2019


Hi all,

This change has passed tests as below (all of jhsdb related tests):

  - Submit repo
  - All hotspot/jtreg/serviceability/sa
  - hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java
  - All jdk/sun/tools/jhsdb
  - jdk/tools/launcher/HelpFlagsTest.java


Comments are welcome.


Thanks,

Yasumasa


On 2019/01/26 13:43, Yasumasa Suenaga wrote:
> Hi all,
> 
> Please review this change:
> 
>    JBS: https://bugs.openjdk.java.net/browse/JDK-8217845
>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8217845/webrev.00/
> 
> SA will handle `Flags` enums to get flag origin.
> However SA has const value for bitmask for flag, and shows as raw (int) value.
> This issue is commented in [1].
> 
> 
> Thanks,
> 
> Yasumasa
> 
> 
> [1] http://hg.openjdk.java.net/jdk/jdk/file/8c035b34248d/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java#l166


More information about the serviceability-dev mailing list