RFR(s): 8248295: serviceability/jvmti/CompiledMethodLoad/Zombie.java failure with Graal

[Vladimir Kozlov]

Looks good.

Thanks,
Vladimir K

On 8/19/20 5:30 AM, Fairoz Matte wrote:
> Hi Vladimir,
> 
> Thanks for the review.
> 
>> I would suggest to run test with -XX:+PrintCodeCache flag which prints
>> CodeCache usage on exit.
>>
>> Also add '-ea -esa' flags - some runs failed with them because they increase
>> Graal's methods size.
>>
>> Running test with immediately caused OOM error on my local linux machine:
>>
>> '-server -ea -esa -XX:+TieredCompilation -XX:+PrintCodeCache -
>> XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -
>> XX:+UseJVMCICompiler -Djvmci.Compiler=graal'
>>
>> With -XX:ReservedCodeCacheSize=30m I got:
>>
>> [11.217s][warning][codecache] CodeCache is full. Compiler has been
>> disabled.
>> [11.217s][warning][codecache] Try increasing the code cache size using -
>> XX:ReservedCodeCacheSize=
>>
>> With -XX:ReservedCodeCacheSize=50m I got this output:
> 
> Further testing with PrintCodeCache, ReservedCodeCacheSize = 50MB is the safe one to use.
> 
>>
>> CodeCache: size=51200Kb used=34401Kb max_used=34401Kb free=16798Kb
>>
>> May be you need to set it to 35m or better to 50m to be safe.
>>
>> Note, without Graal test uses only 5.5m:
>>
>> CodeCache: size=20480Kb used=5677Kb max_used=5688Kb free=14803Kb
>>
>> -----------------------------
>>
>> I also forgot to ask you to update test's Copyright year.
> 
> I have updated the copyright year.
> Updated webrev for the reference - http://cr.openjdk.java.net/~fmatte/8248295/webrev.01/
> 
> Thanks,
> Fairoz
>>
>> Regards,
>> Vladimir K
>>
>> On 8/18/20 1:10 AM, Fairoz Matte wrote:
>>> Hi Vladimir,
>>>
>>> Thanks for looking into.
>>> This is intermittent crash, and is reproducible in windows debug build
>> environment. Below is the testing performed.
>>>
>>> 1. Issues observed 7/100 runs, ReservedCodeCacheSize=20m with "-
>> XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -
>> XX:+UseJVMCICompiler"
>>> 2. Issues observed 0/300 runs, ReservedCodeCacheSize=30m with "-
>> XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -
>> XX:+UseJVMCICompiler"
>>>
>>> Thanks,
>>> Fairoz
>>>
>>>> -----Original Message-----
>>>> From: Vladimir Kozlov
>>>> Sent: Monday, August 17, 2020 11:22 PM
>>>> To: Fairoz Matte <fairoz.matte at oracle.com>; hotspot-compiler-
>>>> dev at openjdk.java.net; serviceability-dev at openjdk.java.net
>>>> Cc: Coleen Phillimore <coleen.phillimore at oracle.com>; Dean Long
>>>> <dean.long at oracle.com>
>>>> Subject: Re: RFR(s): 8248295:
>>>> serviceability/jvmti/CompiledMethodLoad/Zombie.java failure with
>>>> Graal
>>>>
>>>> Hi Fairoz,
>>>>
>>>> How you determine that +10Mb is enough with Graal?
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 8/17/20 5:46 AM, Fairoz Matte wrote:
>>>>> Hi,
>>>>>
>>>>>
>>>>>
>>>>> Please review this small test change to work with Graal.
>>>>>
>>>>>
>>>>>
>>>>> Background:
>>>>>
>>>>> Graal require more code cache compared to c1/c2. but the test case
>>>>> always
>>>> set it to 20MB. This may not be sufficient when running graal.
>>>>>
>>>>> Default configuration for ReservedCodeCacheSize = 250MB
>>>>>
>>>>> With graal enabled, ReservedCodeCacheSize = 350MB
>>>>>
>>>>>
>>>>>
>>>>> Either we can modify the framework to honor ReservedCodeCacheSize
>>>>> for
>>>> graal or just update the testcase.
>>>>>
>>>>> There are not many test cases they rely on ReservedCodeCacheSize or
>>>> InitialCodeCacheSize. So the fix prefer the later one.
>>>>>
>>>>>
>>>>>
>>>>> JBS - https://bugs.openjdk.java.net/browse/JDK-8248295
>>>>>
>>>>> Webrev - http://cr.openjdk.java.net/~fmatte/8248295/webrev.00/
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Fairoz
>>>>>
>>>>>
>>>>>