RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v2]

Ioi Lam iklam at openjdk.org
Sat Jul 9 05:09:41 UTC 2022


On Fri, 8 Jul 2022 06:54:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @tstuefe comments
>
> src/hotspot/os/posix/perfMemory_posix.cpp line 743:
> 
>> 741: 
>> 742:     // We now have a file name that converts to a valid integer
>> 743:     // that could represent a process id.
> 
> "could"? It does, or? Why being ambiguous? (If we change the scheme later, we can be more specific)

The "could" is from the old comment. Maybe it means that the pid does not represent a live process?

-------------

PR: https://git.openjdk.org/jdk/pull/9406


More information about the serviceability-dev mailing list