RFR: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options

Chris Plummer cjplummer at openjdk.org
Thu Jul 21 23:07:59 UTC 2022


On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the output of non-generation (ZGC) GC as valid.

test/jdk/sun/tools/jstatd/JstatGCUtilParser.java line 48:

> 46:         S0(GcStatisticsType.PERCENTAGE_OR_DASH),
> 47:         S1(GcStatisticsType.PERCENTAGE_OR_DASH),
> 48:         E(GcStatisticsType.PERCENTAGE_OR_DASH),

I don't see jstat tests in the zgc problem list. Is this fixing known test failures?

test/jdk/sun/tools/jstatd/JstatdTest.java line 131:

> 129:     private OutputAnalyzer runJps() throws Exception {
> 130:         JDKToolLauncher launcher = JDKToolLauncher.createUsingTestJDK("jps");
> 131:         launcher.addVMArgs(Utils.getFilteredTestJavaOpts("-XX:+UsePerfData"));

I assume this is removed because jps only requires that the target JVMs be run with UsePerfData, but not jps itself.

-------------

PR: https://git.openjdk.org/jdk/pull/9604


More information about the serviceability-dev mailing list