RFR: 8282475: SafeFetch should not rely on existence of Thread::current

Johannes Bechberger duke at openjdk.java.net
Mon Mar 7 15:11:09 UTC 2022


On Mon, 7 Mar 2022 14:42:56 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> I find the naming a bit misleading. You use this as initialization, so I would call it "init" something.

You're correct.

> AFAIU we use this to initialize wxstate for newly attached threads to "dont execute". But should this not already be the case? 

No, it does not seem to be the case: https://github.com/dotnet/runtime/issues/41991  (and the man page does not give a default value either)

> And if its not - e.g. because that thread had been calling into another library that also does call generated code - is it not impolite to switch the state to "executable false"? I know this is highly unlikely, I just try to understand.

This might be an issue when calling another library with a JIT. But this seems to be highly unlikely. Especially as this would have already been an issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7727


More information about the serviceability-dev mailing list