RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

[Aleksey Shipilev]

On Mon, 7 Mar 2022 16:58:38 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copyright
>
> test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java line 35:
> 
>> 33:  */
>> 34: 
>> 35: package serviceability.jvmti.SetBreakpoint;
> 
> The serviceability tests don't use packages. The default package is used. Please remove it to be consistent.

Done.

> test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.c line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2013, 2022, Oracle and/or its affiliates. All rights reserved.
> 
> Shouldn't it be just 2022?

Done.

> test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.c line 35:
> 
>> 33: void JNICALL classprepare(jvmtiEnv* jvmti_env, JNIEnv* jni_env, jthread thread, jclass klass) {
>> 34:     char* buf;
>> 35:     (*jvmti)->GetClassSignature(jvmti, klass, &buf, NULL);
> 
> It is required to check jvmti error status for every function. So test fails early.
> There is no common library so far so you could just copy-paste 'check_jvmti_status' from other tests.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7554