<div dir="ltr">Hi Paul,<div><br></div><div>Yes base_msg can be doubly const so I did that in my local version. I'll push a new webrev once I get more reviews :)</div><div><br></div><div>Thanks!</div><div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 9, 2018 at 3:54 PM Hohensee, Paul <<a href="mailto:hohensee@amazon.com">hohensee@amazon.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-3028624404834489446WordSection1">
<p class="MsoNormal">Is the pointer itself constant? I.e., “const char* const base_msg”?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Paul<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">serviceability-dev <<a href="mailto:serviceability-dev-bounces@openjdk.java.net" target="_blank">serviceability-dev-bounces@openjdk.java.net</a>> on behalf of JC Beyler <<a href="mailto:jcbeyler@google.com" target="_blank">jcbeyler@google.com</a>><br>
<b>Date: </b>Tuesday, October 9, 2018 at 5:23 PM<br>
<b>To: </b>"<a href="mailto:serviceability-dev@openjdk.java.net" target="_blank">serviceability-dev@openjdk.java.net</a>" <<a href="mailto:serviceability-dev@openjdk.java.net" target="_blank">serviceability-dev@openjdk.java.net</a>><br>
<b>Subject: </b>RFR (S) 8211432: [REDO] Handle JNIGlobalRefLocker.cpp<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<div>
<div>
<div>
<p class="MsoNormal">Hi all, <u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">When I pushed the fix for <a href="https://bugs.openjdk.java.net/browse/JDK-8210842" target="_blank">
JDK-8210842</a>, I failed to realize there was seemingly an issue when using std::string. This provoked a failure for Windows and Solaris builds described in the bug for this fix.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Therefore I offer a solution using const char* instead to not have any issues:<br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8211432/webrev.00/" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8211432/webrev.00/</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8211432" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8211432</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">The incremental between the previous fix and this one is here so that it helps see the differences:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/~jcbeyler/8211432/webrev.inc/" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8211432/webrev.inc/</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Finally, this has passed the submit-repo smoke-screen.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Jc<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>