RFR: 22: Wrong lines for comments
Erik Duveblad via github.com
duke at openjdk.java.net
Wed Aug 7 09:43:25 UTC 2019
On Wed, 7 Aug 2019 06:53:01 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> Please review the following change that translates the position field in a GitHub review comment into the actual line number, which is expected in our common API.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - 967bd1b0: Fix position mapping
> - 01178ecb: wip
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/37
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/37/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/37.diff
>
> Fetch command:
> git fetch https://github.com/openjdk/skara.git pull/37/head:pull/37
vcs/src/main/java/module-info.java line 4:
> 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> 4: *
> 5: * This code is free software; you can redistribute it and/or modify it
```suggestion
```
PR: https://git.openjdk.java.net/skara/pull/37
More information about the skara-dev
mailing list