RFR: 50: Fix failing tests after e8d32c78dc

Erik Duveblad via github.com duke at openjdk.java.net
Wed Aug 7 11:39:38 UTC 2019

On Wed, 7 Aug 2019 10:23:00 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> this patch fixes some test failures after e8d32c78dc was integrated. Turns out there are different bugs in git with regards to unified diffs with zero context :cry: @JornVernee fixed the issues with the regular unified diff printer (when there is exactly one parent), this patch works around the issues with git's combined diff printer. The combined diff printer seems to print _correct_ start for empty hunks as long as the file the hunks belong to isn't added.
> I also updated a number of tests to take the changes in e8d32c78dc into account.
> ## Testing
> - [x] Run `sh gradlew test` on Linux x86-64
> ----------------
> Commits:
>  - 0914742f:	50: Fix failing tests after e8d32c78dc
> Pull request:
> https://git.openjdk.java.net/skara/pull/39
> Webrev:
> https://webrevs.openjdk.java.net/skara/39/webrev.00
> Patch:
> https://git.openjdk.java.net/skara/pull/39.diff
> Fetch command:
> git fetch https://github.com/openjdk/skara.git pull/39/head:pull/39

Thanks @rwestberg for the comments!

PR: https://git.openjdk.java.net/skara/pull/39

More information about the skara-dev mailing list