RFR: Improve the previous empty hunks fix
Erik Duveblad via github.com
duke at openjdk.java.net
Fri Aug 16 14:01:43 UTC 2019
On Fri, 16 Aug 2019 14:01:42 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> The previous fix for generating webrevs with empty source hunks broke other cases. Here's more fixes and tests.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - e33063e5: Improve the previous empty hunks fix
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/52
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/52/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/52.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/52/head:pull/52
This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:
Looks great!
PR: https://git.openjdk.java.net/skara/pull/52
More information about the skara-dev
mailing list