RFR: GitCommitIterator should handle empty commits
Robin Westberg via github.com
duke at openjdk.java.net
Mon Aug 19 08:00:44 UTC 2019
On Fri, 16 Aug 2019 15:19:47 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
> HI all,
>
> the `GitCommitIterator` should be able to handle empty commits. Although empty commits are rare, there are a few in the OpenJDK repositories.
>
> ## Testing
> - [x] Added two new unit tests
> - [x] `sh gradlew test` passes on Linux x86_64
>
> ----------------
>
> Commits:
> - e770a955: GitCommitIterator should handle empty commits
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/54
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/54/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/54.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/54/head:pull/54
This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:
Looks good!
PR: https://git.openjdk.java.net/skara/pull/54
More information about the skara-dev
mailing list