RFR: 62: Proper parsing of GitLab discussions outside of a diff context
Erik Duveblad via github.com
duke at openjdk.java.net
Mon Aug 19 12:10:31 UTC 2019
On Mon, 19 Aug 2019 11:25:31 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> Please review this small fix of a GitLab discussion parsing bug.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - 24f9552d: Parse all comments without a position as regular ones
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/56
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/56/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/56.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/56/head:pull/56
This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:
Hmm, perhaps not the most rock-solid feature detection mechanism, but lets go with it for now :+1:
PR: https://git.openjdk.java.net/skara/pull/56
More information about the skara-dev
mailing list