RFR: Do not catch NoSuchElementException in HgOpenJDKImport

Robin Westberg via github.com duke at openjdk.java.net
Fri Aug 23 05:36:08 UTC 2019


On Thu, 22 Aug 2019 14:16:17 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> this patch removes catching `NoSuchElementException` in the `main` method for `HgOpenJDKImport` to ease debugging.
> 
> ## Testing
> - [x] `sh gradlew test` passes on Linux x86_64
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - 5536e051:	Do not catch NoSuchElementException in HgOpenJDKImport
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/70
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/70/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/70.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/70/head:pull/70

This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:

Looks good!

PR: https://git.openjdk.java.net/skara/pull/70


More information about the skara-dev mailing list