RFR: Add ReadOnlyRepository::dump

Robin Westberg via github.com duke at openjdk.java.net
Fri Aug 23 11:59:46 UTC 2019


On Fri, 23 Aug 2019 09:55:38 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> this patch adds the `ReadOnlyRepository::dump` method and a corresponding unit test.
> 
> ## Testing
> - [x] `sh gradlew test` passes on Linux x86_64
> 
> Thanks!
> Erik
> 
> ----------------
> 
> Commits:
>  - 6057ad07:	Add ReadOnlyRepository::dump
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/78
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/78/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/78.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/78/head:pull/78

vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java line 69:

> 68: 
> 69:     boolean dump(FileEntry entry, Path to) throws IOException;
> 70:     Diff diff(Hash base, Hash head) throws IOException;

Is it useful to have a return value? Perhaps you are planning to use it in the future, but if so, it should probably have a test..

PR: https://git.openjdk.java.net/skara/pull/78


More information about the skara-dev mailing list