RFR: 79: jcheck allows self-reviews when processing pull requests
Erik Duveblad via github.com
duke at openjdk.java.net
Mon Aug 26 09:56:15 UTC 2019
On Mon, 26 Aug 2019 08:07:08 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
>
> Please review the following change that makes the PullRequestBot flag a PR as failing jcheck when a self-review is detected. Creating such a review is only possible on recent versions of GitLab, but doesn't hurt to check it anyway.
>
> Best regards,
> Robin
>
> ----------------
>
> Commits:
> - b349ab2e: The pr bot should disallow self-reviews
>
> Pull request:
> https://git.openjdk.java.net/skara/pull/81
>
> Webrev:
> https://webrevs.openjdk.java.net/skara/81/webrev.00
>
> Patch:
> https://git.openjdk.java.net/skara/pull/81.diff
>
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/81/head:pull/81
This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:
Looks good!
PR: https://git.openjdk.java.net/skara/pull/81
More information about the skara-dev
mailing list