RFR: 53: Decouple review requirement from the jcheck status

Erik Duveblad via github.com duke at openjdk.java.net
Wed Aug 28 13:42:02 UTC 2019


On Wed, 28 Aug 2019 13:26:11 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> Please review this change that avoids marking a PR as having failed jcheck, if it is only missing reviews. This is similar to how the `rfr` label currently works.
> 
> Best regards,
> robin
> 
> ----------------
> 
> Commits:
>  - 00eaf2ac:	Don't flag PR's missing only reviews as having failed jcheck
> 
> Pull request:
> https://git.openjdk.java.net/skara/pull/93
> 
> Webrev:
> https://webrevs.openjdk.java.net/skara/93/webrev.00
> 
> Patch:
> https://git.openjdk.java.net/skara/pull/93.diff
> 
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/93/head:pull/93

This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:

Looks good!

PR: https://git.openjdk.java.net/skara/pull/93


More information about the skara-dev mailing list