RFR: jcheck "repository" property in [general] section not read from .jcheck/conf
Robin Westberg via github.com
duke at openjdk.java.net
Fri Aug 30 05:58:26 UTC 2019
On Thu, 29 Aug 2019 22:33:23 GMT, Kevin Rushforth via github.com <duke at openjdk.java.net> wrote:
> On Thu, 29 Aug 2019 15:58:42 GMT, Kevin Rushforth via github.com <duke at openjdk.java.net> wrote:
>
>> This PR fixes a typo in the `GeneralConfiguration` class of `jcheck` that causes the `repository` property to be set to the same value as `project` rather than being read from the `.jcheck/conf` file.
>>
>> ----------------
>>
>> Commits:
>> - c3a15a15: jcheck "repository" property in [general] section not read from .jcheck/conf
>>
>> Pull request:
>> https://git.openjdk.java.net/skara/pull/107
>>
>> Webrev:
>> https://webrevs.openjdk.java.net/skara/107/webrev.00
>>
>> Patch:
>> https://git.openjdk.java.net/skara/pull/107.diff
>>
>> Fetch command:
>> git fetch https://git.openjdk.java.net/skara pull/107/head:pull/107
>
> I might have expected the `/integrate` in the previous comment to cause the bot to wake up and annotate the PR to indicate that it was now ready to be sponsored. Does it not do that? Should it?
>
> PR: https://git.openjdk.java.net/skara/pull/107
It most certainly should wake up, I've filed https://bugs.openjdk.java.net/browse/SKARA-91 to track the fix.
PR: https://git.openjdk.java.net/skara/pull/107
More information about the skara-dev
mailing list