RFR: 43: Repository.get should return Optional.empty on non-existing directory

Robin Westberg via github.com duke at openjdk.java.net
Thu Jul 4 14:46:06 UTC 2019


On Thu, 4 Jul 2019 14:35:50 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:

> Hi all,
> 
> this small patch ensures that Repository.get returns Optional.empty() for non-existing paths.
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] `sh gradlew test` on Linux x86-64
> 
> ----------------
> 
> Commits:
>  - 6f1cc929:	43: Repository.get should return Optional.empty on non-existing directory
> 
> Pull request:
> http://git.openjdk.java.net/skara/pull/29
> 
> Webrev:
> https://openjdk.github.io/cr/skara/29/webrev.00
> 
> Patch:
> http://git.openjdk.java.net/skara/pull/29.diff
> 
> Fetch command:
> git fetch https://github.com/openjdk/skara.git pull/29/head:pull/29

This PR has been reviewed by Robin Westberg via github.com - changes are approved. Review comment:

Looks good!

PR: http://git.openjdk.java.net/skara/pull/29


More information about the skara-dev mailing list