RFR: SKARA-5 Remove pipeline support from process
Robin Westberg via github.com
duke at openjdk.java.net
Wed Jun 26 06:28:39 UTC 2019
On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com <duke at openjdk.java.net> wrote:
> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :)
>
> ----------------
>
> Commits:
> - cf6700bd: SKARA-5 Remove pipeline support from process
>
> Pull request:
> https://github.com/openjdk/skara/pull/2
>
> Webrev:
> https://openjdk.github.io/cr/skara/2/webrev.00
>
> Patch:
> https://github.com/openjdk/skara/pull/2.diff
>
> Fetch command:
> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2
process/src/main/java/org/openjdk/skara/process/Execution.java line 65:
> 64: this.exception = exception;
> 65: }
> 66:
And without pipes, processBuilders don't even need to be a list.
process/src/main/java/org/openjdk/skara/process/Execution.java line 59:
> 58:
> 59: CheckedResult(String command, List<String> stdout, List<String> stderr, int status, Throwable exception) {
> 60: this.status = status;
The getLastProcessBuilder method could be removed as there is never more than one now.
More information about the skara-dev
mailing list