RFR: 5: Remove pipeline support from process

[Robin Westberg via github.com]

On Thu, 27 Jun 2019 05:40:43 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:

> On Thu, 27 Jun 2019 01:34:41 GMT, Jeyvison Nascimento via github.com <duke at openjdk.java.net> wrote:
> 
>> On Thu, 27 Jun 2019 00:52:40 GMT, Jeyvison Nascimento via github.com <duke at openjdk.java.net> wrote:
>> 
>>> On Wed, 26 Jun 2019 10:51:39 GMT, Jeyvison Nascimento via github.com <duke at openjdk.java.net> wrote:
>>> 
>>>> On Wed, 26 Jun 2019 06:17:37 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
>>>> 
>>>>> On Tue, 25 Jun 2019 00:49:17 GMT, Jeyvison Nascimento via github.com <duke at openjdk.java.net> wrote:
>>>>> 
>>>>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. Also, I think something must be changed in ProcessBuilder, am i right? And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :)
>>>>>> 
>>>>>> ----------------
>>>>>> 
>>>>>> Commits:
>>>>>>  - cf6700bd:	SKARA-5 Remove pipeline support from process
>>>>>> 
>>>>>> Pull request:
>>>>>> https://github.com/openjdk/skara/pull/2
>>>>>> 
>>>>>> Webrev:
>>>>>> https://openjdk.github.io/cr/skara/2/webrev.00
>>>>>> 
>>>>>> Patch:
>>>>>> https://github.com/openjdk/skara/pull/2.diff
>>>>>> 
>>>>>> Fetch command:
>>>>>> git fetch https://github.com/openjdk/skara.git cf6700bd:pr/2
>>>>> 
>>>>>> Hey Folks :) Is that what you meant with removing pipeline support? If it's not, let me know. 
>>>>> 
>>>>> Hi! Thanks for the PR! Yes, this is indeed what we meant. (There's actually even a bit more complexity that can be removed, I'll add a more detailed review).
>>>>> 
>>>>>> Also, I think something must be changed in ProcessBuilder, am i right?
>>>>> 
>>>>> Do you mean java.lang.ProcessBuilder? That should not need any changes, perhaps I'm misunderstanding the question..
>>>>> 
>>>>>> And this PR has a test problem i'm not able to fix but if any of you give me some directions i can fix it and resend :)
>>>>> 
>>>>> All tests pass when I run them in your branch, what kind of problem did you see?
>>>> 
>>>> @rwestberg Done :) Hope it's better now.
>>> 
>>> @edvbld Third time is the luck one. Done :)
>> 
>> Should https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L40 be just a single command too?
> 
> Btw, I changed the title of the PR to conform to our preferred format (this will be automated in the future).

> Should
> 
> https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L40
> 
> be just a single command too?

And no, that one is fine, commands (executable and its arguments) are passed to ProcessBuilder as a list: https://github.com/openjdk/skara/blob/d76aaa2ff9e8809833137c899ec819977d5903a4/process/src/main/java/org/openjdk/skara/process/Process.java#L87