RFR: Add support for building on AArch64

Erik Helin ehelin at openjdk.org
Tue Nov 5 13:17:44 UTC 2019

On Thu, 31 Oct 2019 10:48:09 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> I'm working with OpenJDK on Arm machines so I want to be able to run
> `git webrev' etc. there. At the moment we can't build the Skara tools on
> AArch64 due to an implicit assumption that Linux means X86. I tried to
> refactor the build scripts support multiple architectures on Linux. Only
> X86 and AArch64 for now but should be trivial to add others.
> Using the AdoptOpenJDK AArch64 binary build as there are no prebuilt
> binaries for AArch64 on java.net.
> Currently there are several Gradle sub-projects that use the image
> plugin to build Java images, and each specifies the URL and SHA265 of
> the binary JDK to use. Changed the top-level Gradle script to parse
> deps.env and select the JDK source based on the OS and architecture
> system properties. This gets rid of the duplicated URLs but now each
> image { .. } block has a redundant section like the following for each
> OS:
>         jdk {
>             url = project.jdkUrl
>             sha256 = project.jdkSha256
>         }
> So maybe the plugin should be tweaked to move this up into the image {}
> block itself?
> ----------------
> Commits:
>  - fd6a7291: Add support for building on AArch64
> Changes: https://git.openjdk.java.net/skara/pull/231/files
>  Webrev: https://webrevs.openjdk.java.net/skara/231/webrev.00
>   Stats: 85 lines in 5 files changed: 69 ins; 3 del; 13 mod
>   Patch: https://git.openjdk.java.net/skara/pull/231.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/231/head:pull/231

@nick-arm I thought some more about the build today and ended up implementing something a bit more scalable and future-proof than just adding ARM support on Linux. Please have a look PR #237 and see what you think.

If #237 is fine with you, can I go ahead and close this pull request?


PR: https://git.openjdk.java.net/skara/pull/231

More information about the skara-dev mailing list