[Approved] RFR: Add config option for git-sync --pull

Robin Westberg rwestberg at openjdk.java.net
Wed Nov 20 15:16:51 UTC 2019

On Wed, 20 Nov 2019 14:58:07 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this small patch that enables configuring `git sync` to always pull the active branch (via the `sync.pull` configuration). If `sync.pull` is set to `always`, for example via `git config sync.pull always` then `git sync` will always try to pull the active branch after a successful sync.
> Thanks,
> Erik
> ## Testing
> - [x] Manual testing of `git sync` with and without configuration setting
> ----------------
> Commits:
>  - ae8a592a: Add config option for git-sync --pull
> Changes: https://git.openjdk.java.net/skara/pull/260/files
>  Webrev: https://webrevs.openjdk.java.net/skara/260/webrev.00
>   Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/skara/pull/260.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/260/head:pull/260

Looks good! There is a test failure on mac, but it seems unrelated, so can perhaps be investigated separately.


Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/260

More information about the skara-dev mailing list