[Approved] RFR: Switch to GitHub's new review comment positioning API

Erik Helin ehelin at openjdk.java.net
Tue Nov 26 08:16:47 UTC 2019

On Mon, 25 Nov 2019 16:40:11 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> Please review this change that switches to GitHub's new review comment positioning API. This removes the need for calculating line numbers based on position in the textual diff. Note that support for multi-line comments is not yet done (such comments will be shown as positioned on the last line). We can probably wait a bit with implementing that, as the API is technically still in preview.
> Best regards,
> Robin
> ----------------
> Commits:
>  - 1c1ccd13: Switch to GitHub's new review comment positioning API
> Changes: https://git.openjdk.java.net/skara/pull/269/files
>  Webrev: https://webrevs.openjdk.java.net/skara/269/webrev.00
>   Stats: 491 lines in 5 files changed: 30 ins; 424 del; 37 mod
>   Patch: https://git.openjdk.java.net/skara/pull/269.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/269/head:pull/269

Looks good, very nice to get rid of the position mapper code!


Approved by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/269

More information about the skara-dev mailing list