[Approved] RFR: Add --no-token flag to git-pr

Robin Westberg rwestberg at openjdk.java.net
Tue Nov 26 11:10:33 UTC 2019

On Tue, 26 Nov 2019 11:03:43 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this pull request that adds a `--no-token` flag to `git-pr`. This is useful for those merely wanting to try out the read-only operations of `git-pr` (such as `git pr list` or `git pr show`) or for those that do not want to create a personal access token (PAT). The downside for _not_ using a token for read-only operations is that GitHub quite aggressively rate limits the number of REST API HTTP operations (seems like 60 REST API HTTP operations per minute at the moment).
> Thanks,
> Erik
> ## Testing
> - Manual testing of various `git-pr` subcommands
> ----------------
> Commits:
>  - ac5efe8e: Add --no-token flag
>  - dab55bda: Support read-only commands in git-pr
> Changes: https://git.openjdk.java.net/skara/pull/270/files
>  Webrev: https://webrevs.openjdk.java.net/skara/270/webrev.00
>   Stats: 115 lines in 4 files changed: 43 ins; 41 del; 31 mod
>   Patch: https://git.openjdk.java.net/skara/pull/270.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/270/head:pull/270

Looks good! Perhaps a typo, but the anonymous rate limit is actually 60 requests per hour (not minute) so even worse. :)


Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/270

More information about the skara-dev mailing list