[Approved] RFR: Handle binary patches in webrev

Robin Westberg rwestberg at openjdk.org
Fri Sep 20 09:49:39 UTC 2019


On Fri, 20 Sep 2019 09:46:18 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> this patch makes `git webrev` generate `.patch` files for binary files. Thanks @rwestberg for the initial reproducer!
> 
> ## Testing
> - [x] Added three new unit tests
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - cd9b801d: Handle binary patches in webrev
> 
>   Stats: 221 lines in 7 files changed: 185 ins; 12 del; 24 mod
> Changes: https://git.openjdk.java.net/skara/pull/150/files
>  Webrev: https://webrevs.openjdk.java.net/skara/150/webrev.00
>   Patch: https://git.openjdk.java.net/skara/pull/150.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/150/head:pull/150

Looks good, thanks for fixing!

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/150


More information about the skara-dev mailing list