[Approved] RFR: Make build incremental

Robin Westberg rwestberg at openjdk.org
Tue Sep 24 13:19:37 UTC 2019


On Tue, 24 Sep 2019 12:43:49 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> this larger patch adds proper `@Input` and `@OutputDirectory` annotations to our Gradle plugins. The result is that the build is fully incremental 🎉.
> 
> ## Testing
> - `sh gradlew images` works
> - `sh gradlew test` passes on Linux x86_64
> - Manual testing of CLI binaries
> 
> Thanks,
> Erik
> 
> ----------------
> 
> Commits:
>  - e34a72cc: Make build incremental
> 
> Changes: https://git.openjdk.java.net/skara/pull/160/files
>  Webrev: https://webrevs.openjdk.java.net/skara/160/webrev.00
>   Stats: 209 lines in 6 files changed: 68 ins; 18 del; 123 mod
>   Patch: https://git.openjdk.java.net/skara/pull/160.diff
>   Fetch: git fetch https://git.openjdk.java.net/skara pull/160/head:pull/160

Looks good!

Note: IntelliJ users may need to ensure that they are using gradle 5.6.x, since ImagesPlugin.java uses a new API.

----------------

Approved by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/160


More information about the skara-dev mailing list