From rwestberg at openjdk.java.net  Mon Aug  3 05:12:29 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 3 Aug 2020 05:12:29 GMT
Subject: RFR: Allow a source repository to be removed
Message-ID: <zZYr2E_6rPcIHUeCjF3XI1aDr-642kfW0Ec3P1mJ2OA=.79c62a05-2cba-4bc1-a893-2f820eea5fcd@github.com>

Hi all,

Please review this small change that adds support for PRs where the source repository has been removed.

Best regards,
Robin

-------------

Commit messages:
 - Allow the source repository to be removed

Changes: https://git.openjdk.java.net/skara/pull/708/files
 Webrev: https://webrevs.openjdk.java.net/skara/708/webrev.00
  Stats: 25 lines in 7 files changed: 10 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/skara/pull/708.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/708/head:pull/708

PR: https://git.openjdk.java.net/skara/pull/708

From ehelin at openjdk.java.net  Mon Aug  3 08:19:51 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 3 Aug 2020 08:19:51 GMT
Subject: RFR: Allow a source repository to be removed
In-Reply-To: <zZYr2E_6rPcIHUeCjF3XI1aDr-642kfW0Ec3P1mJ2OA=.79c62a05-2cba-4bc1-a893-2f820eea5fcd@github.com>
References: <zZYr2E_6rPcIHUeCjF3XI1aDr-642kfW0Ec3P1mJ2OA=.79c62a05-2cba-4bc1-a893-2f820eea5fcd@github.com>
Message-ID: <OWN73O3Z7QXYKgssSqT9lfV7itpcqBFDeVaCkrfhVPE=.f08a73dc-ace8-4107-aad8-694e9e032da0@github.com>

On Mon, 3 Aug 2020 04:58:22 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this small change that adds support for PRs where the source repository has been removed.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/708

From rwestberg at openjdk.java.net  Mon Aug  3 08:29:51 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 3 Aug 2020 08:29:51 GMT
Subject: Integrated: Allow a source repository to be removed
In-Reply-To: <zZYr2E_6rPcIHUeCjF3XI1aDr-642kfW0Ec3P1mJ2OA=.79c62a05-2cba-4bc1-a893-2f820eea5fcd@github.com>
References: <zZYr2E_6rPcIHUeCjF3XI1aDr-642kfW0Ec3P1mJ2OA=.79c62a05-2cba-4bc1-a893-2f820eea5fcd@github.com>
Message-ID: <kNYJ0ZhnJa2PfRIo2TIEJcY4jjPjS1KGeBrKLa2pAzE=.3b33b9b5-66e7-48c0-9e0b-2dffbe704d18@github.com>

On Mon, 3 Aug 2020 04:58:22 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this small change that adds support for PRs where the source repository has been removed.
> 
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: 9a388094
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/9a388094
Stats:     25 lines in 7 files changed: 0 ins; 10 del; 15 mod

Allow a source repository to be removed

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/708

From rwestberg at openjdk.java.net  Mon Aug  3 16:29:15 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 3 Aug 2020 16:29:15 GMT
Subject: RFR: 458: Push notification email not sent when new tags are pushed
Message-ID: <soHEsWZ_wJLFvBbPGt8u0_AzSZ00NEAQXKoP33JIXP4=.e8339cd5-1c0a-4b30-af91-d967ad373613@github.com>

Hi all,

Please review this change that fetches tags when running the repository notifier, as they should be acted upon.

Best regards,
Robin

-------------

Commit messages:
 - The repository work item should fetch tags

Changes: https://git.openjdk.java.net/skara/pull/709/files
 Webrev: https://webrevs.openjdk.java.net/skara/709/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-458
  Stats: 19 lines in 3 files changed: 12 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/skara/pull/709.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/709/head:pull/709

PR: https://git.openjdk.java.net/skara/pull/709

From ehelin at openjdk.java.net  Mon Aug  3 16:29:15 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 3 Aug 2020 16:29:15 GMT
Subject: RFR: 458: Push notification email not sent when new tags are
 pushed
In-Reply-To: <soHEsWZ_wJLFvBbPGt8u0_AzSZ00NEAQXKoP33JIXP4=.e8339cd5-1c0a-4b30-af91-d967ad373613@github.com>
References: <soHEsWZ_wJLFvBbPGt8u0_AzSZ00NEAQXKoP33JIXP4=.e8339cd5-1c0a-4b30-af91-d967ad373613@github.com>
Message-ID: <-NldlN86083rFdF_39Z1CtsK37cv68ebkNMU8TIvdk8=.56bb9766-98be-4ce0-b942-1a15fa2ca496@github.com>

On Mon, 3 Aug 2020 13:37:13 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that fetches tags when running the repository notifier, as they should be acted upon.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/709

From rwestberg at openjdk.java.net  Tue Aug  4 04:40:52 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 4 Aug 2020 04:40:52 GMT
Subject: Integrated: 458: Push notification email not sent when new tags are
 pushed
In-Reply-To: <soHEsWZ_wJLFvBbPGt8u0_AzSZ00NEAQXKoP33JIXP4=.e8339cd5-1c0a-4b30-af91-d967ad373613@github.com>
References: <soHEsWZ_wJLFvBbPGt8u0_AzSZ00NEAQXKoP33JIXP4=.e8339cd5-1c0a-4b30-af91-d967ad373613@github.com>
Message-ID: <At39x61AR6GDKuq47I7XpR3Z3F2V5JIyI3dWZ8VtWG0=.cbdd8ca8-7234-436b-93e6-825f0248da2a@github.com>

On Mon, 3 Aug 2020 13:37:13 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that fetches tags when running the repository notifier, as they should be acted upon.
> 
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: 5bf7aac5
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/5bf7aac5
Stats:     19 lines in 3 files changed: 0 ins; 12 del; 7 mod

458: Push notification email not sent when new tags are pushed

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/709

From rwestberg at openjdk.java.net  Wed Aug  5 09:15:08 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 5 Aug 2020 09:15:08 GMT
Subject: RFR: 453: Merge commit not included in notification email
Message-ID: <j_Tquff9W-X2brYwRaxITA6NWkn6yUablH3Mfmn9KKE=.f61d52e7-4f10-4f78-94fa-8e440950423c@github.com>

Hi all,

Please review this change that properly filters out commits brought in through a merge PR when creating a mailing list
notification email.

Best regards,
Robin

-------------

Commit messages:
 - Filter out commits brought in through a merge PR

Changes: https://git.openjdk.java.net/skara/pull/710/files
 Webrev: https://webrevs.openjdk.java.net/skara/710/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-453
  Stats: 205 lines in 2 files changed: 190 ins; 5 del; 10 mod
  Patch: https://git.openjdk.java.net/skara/pull/710.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/710/head:pull/710

PR: https://git.openjdk.java.net/skara/pull/710

From ehelin at openjdk.java.net  Wed Aug  5 12:53:42 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 5 Aug 2020 12:53:42 GMT
Subject: RFR: 453: Merge commit not included in notification email
In-Reply-To: <j_Tquff9W-X2brYwRaxITA6NWkn6yUablH3Mfmn9KKE=.f61d52e7-4f10-4f78-94fa-8e440950423c@github.com>
References: <j_Tquff9W-X2brYwRaxITA6NWkn6yUablH3Mfmn9KKE=.f61d52e7-4f10-4f78-94fa-8e440950423c@github.com>
Message-ID: <tbbrr9uw5SxnobKxj7LWDhW0kDvWthDRMwFTBp_ezE8=.0036ac7c-2ce9-4668-a703-f1b1297a5e2c@github.com>

On Wed, 5 Aug 2020 09:11:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that properly filters out commits brought in through a merge PR when creating a mailing list
> notification email.
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/710

From ehelin at openjdk.java.net  Wed Aug  5 19:09:52 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 5 Aug 2020 19:09:52 GMT
Subject: RFR: 467: git pr create assumes .jcheck/conf file
Message-ID: <FwYVaUQColk0l5mtnBNbn0uc9jG8uDuQGtI0Chb9JZ8=.d24e810f-08d1-45f1-a6db-137e53d703b3@github.com>

Hi all,

please review this patch that makes `git pr create` work for repositories without an `.jcheck/conf` file.

Thanks,
Erik

-------------

Commit messages:
 - skara-467

Changes: https://git.openjdk.java.net/skara/pull/711/files
 Webrev: https://webrevs.openjdk.java.net/skara/711/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-467
  Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/711.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/711/head:pull/711

PR: https://git.openjdk.java.net/skara/pull/711

From rwestberg at openjdk.java.net  Thu Aug  6 06:53:03 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 6 Aug 2020 06:53:03 GMT
Subject: RFR: 467: git pr create assumes .jcheck/conf file
In-Reply-To: <FwYVaUQColk0l5mtnBNbn0uc9jG8uDuQGtI0Chb9JZ8=.d24e810f-08d1-45f1-a6db-137e53d703b3@github.com>
References: <FwYVaUQColk0l5mtnBNbn0uc9jG8uDuQGtI0Chb9JZ8=.d24e810f-08d1-45f1-a6db-137e53d703b3@github.com>
Message-ID: <qN28K5lCoQllp450x9rT6eE4ITn0Fu23D2W938o6qAU=.43894477-9ba3-46fc-acc8-23f7a5c0a770@github.com>

On Wed, 5 Aug 2020 19:05:47 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `git pr create` work for repositories without an `.jcheck/conf` file.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/711

From ehelin at openjdk.java.net  Thu Aug  6 07:18:22 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 6 Aug 2020 07:18:22 GMT
Subject: Integrated: 467: git pr create assumes .jcheck/conf file
In-Reply-To: <FwYVaUQColk0l5mtnBNbn0uc9jG8uDuQGtI0Chb9JZ8=.d24e810f-08d1-45f1-a6db-137e53d703b3@github.com>
References: <FwYVaUQColk0l5mtnBNbn0uc9jG8uDuQGtI0Chb9JZ8=.d24e810f-08d1-45f1-a6db-137e53d703b3@github.com>
Message-ID: <NIj4DJyZ2xDHJiFuo0u6qKLoFi0Lim2DZieVcmZm9hU=.1600db08-ede0-4cca-beb9-735f7672d6f0@github.com>

On Wed, 5 Aug 2020 19:05:47 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `git pr create` work for repositories without an `.jcheck/conf` file.
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 68d7387a
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/68d7387a
Stats:     14 lines in 1 file changed: 0 ins; 12 del; 2 mod

467: git pr create assumes .jcheck/conf file

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/711

From rwestberg at openjdk.java.net  Thu Aug  6 07:27:53 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 6 Aug 2020 07:27:53 GMT
Subject: Integrated: 453: Merge commit not included in notification email
In-Reply-To: <j_Tquff9W-X2brYwRaxITA6NWkn6yUablH3Mfmn9KKE=.f61d52e7-4f10-4f78-94fa-8e440950423c@github.com>
References: <j_Tquff9W-X2brYwRaxITA6NWkn6yUablH3Mfmn9KKE=.f61d52e7-4f10-4f78-94fa-8e440950423c@github.com>
Message-ID: <0hcvLT6-kn4IRorY3gQpZReQHcdTRNSH7NSTpbNuIos=.a3c015b2-cb75-4694-ac80-678c514bf1f3@github.com>

On Wed, 5 Aug 2020 09:11:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that properly filters out commits brought in through a merge PR when creating a mailing list
> notification email.
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: c7890d6c
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/c7890d6c
Stats:     205 lines in 2 files changed: 5 ins; 190 del; 10 mod

453: Merge commit not included in notification email

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/710

From rwestberg at openjdk.java.net  Thu Aug  6 08:25:49 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 6 Aug 2020 08:25:49 GMT
Subject: RFR: cli: add new command hg-export
In-Reply-To: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>
References: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>
Message-ID: <5zfsSboh47ewvCQkT8yTM817cDNYtaV31FDVxi5ZGBY=.8a9fcc21-0963-40b4-959f-e57aebe077af@github.com>

On Thu, 6 Aug 2020 07:48:57 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the new command `git hg-export`. The `git hg-export` command prints information
> about a Git commit in the format expected by `hg import` (i.e. it is very similar to the `hg export --git` command).
> This command is primarily useful for backporting changes from a Git repository to a Mercurial repository as a
> backporter can now run:  $ git clone https://git.openjdk.java.net/jdk $ cd jdk
> $ git hg-export <REV> | hg -R /path/to/hg/repo/for/jdk11u-dev import -
> 
> The command `git hg-export` will output the commit message in the format used by the OpenJDK Mercurial repositories.
> The command will also output the correct author and date.
> Testing:
> - [x] Manual testing of `git hg-export` on Linux x64
> 
> Thanks,
> Erik

Looks good! Perhaps some sort of test would be nice, but can do that later I guess. :)

cli/src/main/java/org/openjdk/skara/cli/GitHgExport.java line 95:

> 94:         if (committer.email() == null || !committer.email().endsWith("@openjdk.org")) {
> 95:             die("commiter is not an OpenJDK committer");
> 96:         }

Suggestion:

            die("committer is not an OpenJDK committer");

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/712

From ehelin at openjdk.java.net  Thu Aug  6 08:25:49 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 6 Aug 2020 08:25:49 GMT
Subject: RFR: cli: add new command hg-export
Message-ID: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>

Hi all,

please review this patch that adds the new command `git hg-export`. The `git hg-export` command prints information
about a Git commit in the format expected by `hg import` (i.e. it is very similar to the `hg export --git` command).
This command is primarily useful for backporting changes from a Git repository to a Mercurial repository as a
backporter can now run:

$ git clone https://git.openjdk.java.net/jdk
$ cd jdk
$ git hg-export <REV> | hg -R /path/to/hg/repo/for/jdk11u-dev import -

The command `git hg-export` will output the commit message in the format used by the OpenJDK Mercurial repositories.
The command will also output the correct author and date.

Testing:
- [x] Manual testing of `git hg-export` on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - Remove trailing whitespace
 - cli: new command hg-export

Changes: https://git.openjdk.java.net/skara/pull/712/files
 Webrev: https://webrevs.openjdk.java.net/skara/712/webrev.00
  Stats: 135 lines in 6 files changed: 131 ins; 3 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/712.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/712/head:pull/712

PR: https://git.openjdk.java.net/skara/pull/712

From ehelin at openjdk.java.net  Thu Aug  6 08:33:24 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 6 Aug 2020 08:33:24 GMT
Subject: RFR: cli: add new command hg-export [v2]
In-Reply-To: <5zfsSboh47ewvCQkT8yTM817cDNYtaV31FDVxi5ZGBY=.8a9fcc21-0963-40b4-959f-e57aebe077af@github.com>
References: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>
 <5zfsSboh47ewvCQkT8yTM817cDNYtaV31FDVxi5ZGBY=.8a9fcc21-0963-40b4-959f-e57aebe077af@github.com>
Message-ID: <QbYwJX7_YIa7Z-X9DJiCwNMumtJUXuMCOjaYJPvpy4o=.01fb61ce-b992-42ff-9f65-124c19410a49@github.com>

On Thu, 6 Aug 2020 07:55:10 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix spelling
>>   
>>   Co-authored-by: Robin Westberg <robin at westberg.se>
>
> Looks good! Perhaps some sort of test would be nice, but can do that later I guess. :)

@rwestberg thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/skara/pull/712

From ehelin at openjdk.java.net  Thu Aug  6 08:33:23 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 6 Aug 2020 08:33:23 GMT
Subject: RFR: cli: add new command hg-export [v2]
In-Reply-To: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>
References: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>
Message-ID: <lvg_qka18QXmjvOD-P-vh59nuttZ_HSEbW8GKteoEmU=.07f160a6-9f75-4bed-91a4-310d592b359d@github.com>

> Hi all,
> 
> please review this patch that adds the new command `git hg-export`. The `git hg-export` command prints information
> about a Git commit in the format expected by `hg import` (i.e. it is very similar to the `hg export --git` command).
> This command is primarily useful for backporting changes from a Git repository to a Mercurial repository as a
> backporter can now run:  $ git clone https://git.openjdk.java.net/jdk $ cd jdk
> $ git hg-export <REV> | hg -R /path/to/hg/repo/for/jdk11u-dev import -
> 
> The command `git hg-export` will output the commit message in the format used by the OpenJDK Mercurial repositories.
> The command will also output the correct author and date.
> Testing:
> - [x] Manual testing of `git hg-export` on Linux x64
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  Fix spelling
  
  Co-authored-by: Robin Westberg <robin at westberg.se>

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/712/files
  - new: https://git.openjdk.java.net/skara/pull/712/files/2b501612..291f1ac5

Webrevs:
 - full: https://webrevs.openjdk.java.net/skara/712/webrev.01
 - incr: https://webrevs.openjdk.java.net/skara/712/webrev.00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/712.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/712/head:pull/712

PR: https://git.openjdk.java.net/skara/pull/712

From ehelin at openjdk.java.net  Thu Aug  6 09:13:12 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 6 Aug 2020 09:13:12 GMT
Subject: Integrated: cli: add new command hg-export
In-Reply-To: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>
References: <3BFnWwX1mroeRBbRZu1hF2k0Dhly5W_lYoICiG7vwzc=.b7c4aab1-6658-4738-b7b3-85e161cdc171@github.com>
Message-ID: <UXZidcMlvuYLIXrSmiTvTl0jS8wK_Bv3A30OeioEi_0=.5f9f111a-efe2-47f0-bf54-e755f8bb2c93@github.com>

On Thu, 6 Aug 2020 07:48:57 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the new command `git hg-export`. The `git hg-export` command prints information
> about a Git commit in the format expected by `hg import` (i.e. it is very similar to the `hg export --git` command).
> This command is primarily useful for backporting changes from a Git repository to a Mercurial repository as a
> backporter can now run:  $ git clone https://git.openjdk.java.net/jdk $ cd jdk
> $ git hg-export <REV> | hg -R /path/to/hg/repo/for/jdk11u-dev import -
> 
> The command `git hg-export` will output the commit message in the format used by the OpenJDK Mercurial repositories.
> The command will also output the correct author and date.
> Testing:
> - [x] Manual testing of `git hg-export` on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: ff9b82bd
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/ff9b82bd
Stats:     135 lines in 6 files changed: 3 ins; 131 del; 1 mod

cli: add new command hg-export

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/712

From ihse at openjdk.java.net  Thu Aug  6 09:22:32 2020
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 6 Aug 2020 09:22:32 GMT
Subject: Withdrawn: json patches introduced to the OpenJDK copy in JDK-8246435
In-Reply-To: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com>
References: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com>
Message-ID: <pMkpfz1EQmnDP2UniXQCAadkerdkyz5btz8e3Ad_U2k=.cf9574ae-89ae-4a1b-a4c6-24032cb1120a@github.com>

On Wed, 3 Jun 2020 12:16:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> This PR contains the proposed changes to the json system made in JDK-8246435. If the same changes are made in Skara,
> tthe two code bases are kept from diverging.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/skara/pull/636

From ehelin at openjdk.java.net  Fri Aug 14 15:52:45 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 14 Aug 2020 15:52:45 GMT
Subject: RFR: webrev: refactor webrev stats
Message-ID: <vO1-JXIruuhHR35blIZq2JtC3fti9UvmVhcU2bcFoQM=.8738751d-b9c4-4a02-96aa-f8dd76641fa8@github.com>

Hi all,

please review this patch that renames some of the stats methods (`added`, `modified`, `removed`) in `Hunk`, `Patch` and
`Diff`. I want to rename them to clarify that they are statistics tailored for webrev (which has a rather peculiar
notion of what a modified line is).

Testing:
- [x] `make test` passes on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - webrev: refactor webrev stats

Changes: https://git.openjdk.java.net/skara/pull/713/files
 Webrev: https://webrevs.openjdk.java.net/skara/713/webrev.00
  Stats: 422 lines in 17 files changed: 174 ins; 170 del; 78 mod
  Patch: https://git.openjdk.java.net/skara/pull/713.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/713/head:pull/713

PR: https://git.openjdk.java.net/skara/pull/713

From ehelin at openjdk.java.net  Fri Aug 14 16:15:39 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 14 Aug 2020 16:15:39 GMT
Subject: RFR: vcs: lower rename detection to 90%
Message-ID: <Oyv7aHJnBX_90-2j-e5L_bxCFEKyhPveC1v7SwAPaCk=.0fa7bd56-127e-479a-b12e-5f010c5b36ba@github.com>

Hi all,

please review this small patch that lowers rename and copy detection for `GitRepository` to `90%`. The default value of
`50%` is too small for most OpenJDK patches given that the copyright + license header can easily be 19 lines. `99%`
turned out to be a bit too strict for generating good looking webrevs, so lets take it down to `90%` and see how it
goes.

Testing:
- [x] `make test` passes on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - vcs: lower rename detection to 90%

Changes: https://git.openjdk.java.net/skara/pull/714/files
 Webrev: https://webrevs.openjdk.java.net/skara/714/webrev.00
  Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/skara/pull/714.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/714/head:pull/714

PR: https://git.openjdk.java.net/skara/pull/714

From rwestberg at openjdk.java.net  Fri Aug 14 17:39:54 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 14 Aug 2020 17:39:54 GMT
Subject: RFR: webrev: refactor webrev stats
In-Reply-To: <vO1-JXIruuhHR35blIZq2JtC3fti9UvmVhcU2bcFoQM=.8738751d-b9c4-4a02-96aa-f8dd76641fa8@github.com>
References: <vO1-JXIruuhHR35blIZq2JtC3fti9UvmVhcU2bcFoQM=.8738751d-b9c4-4a02-96aa-f8dd76641fa8@github.com>
Message-ID: <wGvKKBRgrH4AWZJqbiRExy39FgKb_mnVo1yRMSFI2fM=.a0b0835e-6b6f-423f-a3f2-d7220120dc5c@github.com>

On Fri, 14 Aug 2020 15:47:52 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that renames some of the stats methods (`added`, `modified`, `removed`) in `Hunk`, `Patch` and
> `Diff`. I want to rename them to clarify that they are statistics tailored for webrev (which has a rather peculiar
> notion of what a modified line is).  Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/713

From rwestberg at openjdk.java.net  Fri Aug 14 17:40:32 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 14 Aug 2020 17:40:32 GMT
Subject: RFR: vcs: lower rename detection to 90%
In-Reply-To: <Oyv7aHJnBX_90-2j-e5L_bxCFEKyhPveC1v7SwAPaCk=.0fa7bd56-127e-479a-b12e-5f010c5b36ba@github.com>
References: <Oyv7aHJnBX_90-2j-e5L_bxCFEKyhPveC1v7SwAPaCk=.0fa7bd56-127e-479a-b12e-5f010c5b36ba@github.com>
Message-ID: <mI3ms2tUYZ0mk1hfgf8Yxzs9qdUkNI_NNNhGuc3lbhU=.7a357d27-4e79-46e5-8f21-73cb42dae3fe@github.com>

On Fri, 14 Aug 2020 16:11:50 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that lowers rename and copy detection for `GitRepository` to `90%`. The default value of
> `50%` is too small for most OpenJDK patches given that the copyright + license header can easily be 19 lines. `99%`
> turned out to be a bit too strict for generating good looking webrevs, so lets take it down to `90%` and see how it
> goes.  Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Sounds good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/714

From ehelin at openjdk.java.net  Sat Aug 15 06:30:42 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 06:30:42 GMT
Subject: Integrated: webrev: refactor webrev stats
In-Reply-To: <vO1-JXIruuhHR35blIZq2JtC3fti9UvmVhcU2bcFoQM=.8738751d-b9c4-4a02-96aa-f8dd76641fa8@github.com>
References: <vO1-JXIruuhHR35blIZq2JtC3fti9UvmVhcU2bcFoQM=.8738751d-b9c4-4a02-96aa-f8dd76641fa8@github.com>
Message-ID: <wDeAFgdbaG5Yt7u43HvjzJtVB8XWNNCDQYq_PbF71ng=.c627806b-b0fb-4282-bb1f-e6a697ab23c4@github.com>

On Fri, 14 Aug 2020 15:47:52 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that renames some of the stats methods (`added`, `modified`, `removed`) in `Hunk`, `Patch` and
> `Diff`. I want to rename them to clarify that they are statistics tailored for webrev (which has a rather peculiar
> notion of what a modified line is).  Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 0cd25fd0
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/0cd25fd0
Stats:     422 lines in 17 files changed: 170 ins; 174 del; 78 mod

webrev: refactor webrev stats

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/713

From ehelin at openjdk.java.net  Sat Aug 15 06:31:11 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 06:31:11 GMT
Subject: Integrated: vcs: lower rename detection to 90%
In-Reply-To: <Oyv7aHJnBX_90-2j-e5L_bxCFEKyhPveC1v7SwAPaCk=.0fa7bd56-127e-479a-b12e-5f010c5b36ba@github.com>
References: <Oyv7aHJnBX_90-2j-e5L_bxCFEKyhPveC1v7SwAPaCk=.0fa7bd56-127e-479a-b12e-5f010c5b36ba@github.com>
Message-ID: <omT4NR0CdcEgG1DAKecqnmWX1RHiXdr3exzNm_dD45M=.3f9fd8eb-280b-4b80-af7c-0e23128da684@github.com>

On Fri, 14 Aug 2020 16:11:50 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that lowers rename and copy detection for `GitRepository` to `90%`. The default value of
> `50%` is too small for most OpenJDK patches given that the copyright + license header can easily be 19 lines. `99%`
> turned out to be a bit too strict for generating good looking webrevs, so lets take it down to `90%` and see how it
> goes.  Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 49868fed
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/49868fed
Stats:     6 lines in 2 files changed: 0 ins; 0 del; 6 mod

vcs: lower rename detection to 90%

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/714

From ehelin at openjdk.java.net  Sat Aug 15 10:09:44 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 10:09:44 GMT
Subject: RFR: git-webrev: add --similarity flag
Message-ID: <BGoEn_zy1IR-HmIpTywICYOpBCSUTIGOOcvgsOMN2pM=.c4380ba9-8235-4808-9155-03579b578280@github.com>

Hi all,

please review this patch that adds the `--similarity` flag to `git-webrev`. The `--similarity` flag allows users to
manually tune the threshold for when a file should be considered renamed or copied.

Testing:
- Manual testing on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - git-webrev: add --similarity flag

Changes: https://git.openjdk.java.net/skara/pull/715/files
 Webrev: https://webrevs.openjdk.java.net/skara/715/webrev.00
  Stats: 69 lines in 6 files changed: 46 ins; 0 del; 23 mod
  Patch: https://git.openjdk.java.net/skara/pull/715.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/715/head:pull/715

PR: https://git.openjdk.java.net/skara/pull/715

From ehelin at openjdk.java.net  Sat Aug 15 10:48:11 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 10:48:11 GMT
Subject: RFR: git-webrev: add flags --base and --head
Message-ID: <bXNw7YUnx_81L31dsf472R4C-zEAThwFyFTwKL3d0F0=.24a62493-912d-4d80-9793-d392189c906f@github.com>

Hi all,

please review this patch that adds two new flags to `git-webrev` - `--base` and `--head`. The flag `--base` behaves
like `-r, --rev`, that is determines the base commit to compare against. The flag `--head` determines the commit to use
a `HEAD` for the comparison, that is the most recent commit for the comparison. The two flags `--base` and `--head`
allows a user to create a webrev between two arbitrary commits (without forcing to check out the head commit first).

Testing:
- Manual testing on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - git-webrev: add flags --base and --head

Changes: https://git.openjdk.java.net/skara/pull/716/files
 Webrev: https://webrevs.openjdk.java.net/skara/716/webrev.00
  Stats: 29 lines in 1 file changed: 26 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/716.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/716/head:pull/716

PR: https://git.openjdk.java.net/skara/pull/716

From ehelin at openjdk.java.net  Sat Aug 15 10:53:20 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 10:53:20 GMT
Subject: RFR: git-webrev: add --json flag
Message-ID: <kAVB7-kBqHvnnXfwi1tNV8Cyc8F6uY-Nx85hLLghAbc=.c2e519ed-283c-4e12-9a69-8f3ae47b196d@github.com>

Hi all,

please review this patch that adds the `--json` flag to `git-webrev`. The `--json` flag is not meant to be used by a
humans, it generates a JSON version of a "webrev" that tools can consume (in comparison to HTML that is usually
generated).

Testing:
- [x] Manual testing on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - git-webrev: add --json flag

Changes: https://git.openjdk.java.net/skara/pull/717/files
 Webrev: https://webrevs.openjdk.java.net/skara/717/webrev.00
  Stats: 278 lines in 6 files changed: 248 ins; 5 del; 25 mod
  Patch: https://git.openjdk.java.net/skara/pull/717.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/717/head:pull/717

PR: https://git.openjdk.java.net/skara/pull/717

From rwestberg at openjdk.java.net  Sat Aug 15 11:10:54 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 15 Aug 2020 11:10:54 GMT
Subject: RFR: git-webrev: add --similarity flag
In-Reply-To: <BGoEn_zy1IR-HmIpTywICYOpBCSUTIGOOcvgsOMN2pM=.c4380ba9-8235-4808-9155-03579b578280@github.com>
References: <BGoEn_zy1IR-HmIpTywICYOpBCSUTIGOOcvgsOMN2pM=.c4380ba9-8235-4808-9155-03579b578280@github.com>
Message-ID: <kpQppYZ0Kl6JH6rq_AGgNcAr3wMjkHhIESrVBZnNTEA=.a21054d4-4f1c-432e-8818-5a9481ec8ee4@github.com>

On Sat, 15 Aug 2020 10:04:56 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the `--similarity` flag to `git-webrev`. The `--similarity` flag allows users to
> manually tune the threshold for when a file should be considered renamed or copied.
> Testing:
> - Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/715

From rwestberg at openjdk.java.net  Sat Aug 15 11:11:51 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 15 Aug 2020 11:11:51 GMT
Subject: RFR: git-webrev: add flags --base and --head
In-Reply-To: <bXNw7YUnx_81L31dsf472R4C-zEAThwFyFTwKL3d0F0=.24a62493-912d-4d80-9793-d392189c906f@github.com>
References: <bXNw7YUnx_81L31dsf472R4C-zEAThwFyFTwKL3d0F0=.24a62493-912d-4d80-9793-d392189c906f@github.com>
Message-ID: <-xhgKk3E38M-OaX68tprhFTluPPT_bkN5tPE_Xz0ugA=.8a5bdacc-7649-47e1-8381-3a4f6ab42a0b@github.com>

On Sat, 15 Aug 2020 10:42:37 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds two new flags to `git-webrev` - `--base` and `--head`. The flag `--base` behaves
> like `-r, --rev`, that is determines the base commit to compare against. The flag `--head` determines the commit to use
> a `HEAD` for the comparison, that is the most recent commit for the comparison. The two flags `--base` and `--head`
> allows a user to create a webrev between two arbitrary commits (without forcing to check out the head commit first).
> Testing:
> - Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/716

From rwestberg at openjdk.java.net  Sat Aug 15 11:13:41 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 15 Aug 2020 11:13:41 GMT
Subject: RFR: git-webrev: add --json flag
In-Reply-To: <kAVB7-kBqHvnnXfwi1tNV8Cyc8F6uY-Nx85hLLghAbc=.c2e519ed-283c-4e12-9a69-8f3ae47b196d@github.com>
References: <kAVB7-kBqHvnnXfwi1tNV8Cyc8F6uY-Nx85hLLghAbc=.c2e519ed-283c-4e12-9a69-8f3ae47b196d@github.com>
Message-ID: <tnNYM0IzEQdBF4TB2jG6q5zPJgPvZUXEWhurOKoFYtY=.e9c991fc-f5a2-4b0c-970c-48ef51b50f7c@github.com>

On Sat, 15 Aug 2020 10:49:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the `--json` flag to `git-webrev`. The `--json` flag is not meant to be used by a
> humans, it generates a JSON version of a "webrev" that tools can consume (in comparison to HTML that is usually
> generated).  Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/717

From dev at anthonyv.be  Sat Aug 15 11:45:27 2020
From: dev at anthonyv.be (Anthony Vanelverdinghe)
Date: Sat, 15 Aug 2020 13:45:27 +0200
Subject: Pre-existing OCA without username
Message-ID: <957e070a-84e2-2b9a-ff13-e954f9329ad4@anthonyv.be>

Hi

When opening a PR, I get the OCA-related comment from the bridgekeeper 
[1]. I have already signed the OCA [2], but had left the "Username" 
field blank at the time (since I didn't (& still don't) have an official 
OpenJDK username, and this was way before Skara).
Would you be so kind to mark my GitHub username as having signed the OCA 
please? Thanks in advance.

[1] https://github.com/openjdk/amber-docs/pull/5#issuecomment-674375321
[2] 
https://www.oracle.com/technical-resources/oracle-contributor-agreement.html#v

Kind regards,
Anthony


From ehelin at openjdk.java.net  Sat Aug 15 14:39:11 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 14:39:11 GMT
Subject: Integrated: git-webrev: add --similarity flag
In-Reply-To: <BGoEn_zy1IR-HmIpTywICYOpBCSUTIGOOcvgsOMN2pM=.c4380ba9-8235-4808-9155-03579b578280@github.com>
References: <BGoEn_zy1IR-HmIpTywICYOpBCSUTIGOOcvgsOMN2pM=.c4380ba9-8235-4808-9155-03579b578280@github.com>
Message-ID: <d4iJzebF2OzNBRqJoMV3k7m7ui0u2FCwgrOdF2lde-k=.632e0796-b9f1-4230-aafb-e817eb388506@github.com>

On Sat, 15 Aug 2020 10:04:56 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the `--similarity` flag to `git-webrev`. The `--similarity` flag allows users to
> manually tune the threshold for when a file should be considered renamed or copied.
> Testing:
> - Manual testing on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 1aa66a53
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/1aa66a53
Stats:     69 lines in 6 files changed: 0 ins; 46 del; 23 mod

git-webrev: add --similarity flag

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/715

From ehelin at openjdk.java.net  Sat Aug 15 14:50:58 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 14:50:58 GMT
Subject: RFR: git-webrev: add flags --base and --head [v2]
In-Reply-To: <bXNw7YUnx_81L31dsf472R4C-zEAThwFyFTwKL3d0F0=.24a62493-912d-4d80-9793-d392189c906f@github.com>
References: <bXNw7YUnx_81L31dsf472R4C-zEAThwFyFTwKL3d0F0=.24a62493-912d-4d80-9793-d392189c906f@github.com>
Message-ID: <ZlS7pk7Kr8vuR3doHCUXgFvct5hEOyE5bo1E7K5tSD4=.56f9b9ea-d8a3-45ab-bbe6-c61509d41209@github.com>

> Hi all,
> 
> please review this patch that adds two new flags to `git-webrev` - `--base` and `--head`. The flag `--base` behaves
> like `-r, --rev`, that is determines the base commit to compare against. The flag `--head` determines the commit to use
> a `HEAD` for the comparison, that is the most recent commit for the comparison. The two flags `--base` and `--head`
> allows a user to create a webrev between two arbitrary commits (without forcing to check out the head commit first).
> Testing:
> - Manual testing on Linux x64
> 
> Thanks,
> Erik

Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains two commits:

 - Merge branch 'master'
 - git-webrev: add flags --base and --head

-------------

Changes: https://git.openjdk.java.net/skara/pull/716/files
 Webrev: https://webrevs.openjdk.java.net/skara/716/webrev.01
  Stats: 29 lines in 1 file changed: 26 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/716.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/716/head:pull/716

PR: https://git.openjdk.java.net/skara/pull/716

From ehelin at openjdk.java.net  Sat Aug 15 15:00:12 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 15:00:12 GMT
Subject: Integrated: git-webrev: add flags --base and --head
In-Reply-To: <bXNw7YUnx_81L31dsf472R4C-zEAThwFyFTwKL3d0F0=.24a62493-912d-4d80-9793-d392189c906f@github.com>
References: <bXNw7YUnx_81L31dsf472R4C-zEAThwFyFTwKL3d0F0=.24a62493-912d-4d80-9793-d392189c906f@github.com>
Message-ID: <B_E8ikUaQ8SZxCbJaM_b2NLbHy4YoYyDivhKcvcQwF8=.24e6968a-2b1d-42b8-8717-d3267375ae15@github.com>

On Sat, 15 Aug 2020 10:42:37 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds two new flags to `git-webrev` - `--base` and `--head`. The flag `--base` behaves
> like `-r, --rev`, that is determines the base commit to compare against. The flag `--head` determines the commit to use
> a `HEAD` for the comparison, that is the most recent commit for the comparison. The two flags `--base` and `--head`
> allows a user to create a webrev between two arbitrary commits (without forcing to check out the head commit first).
> Testing:
> - Manual testing on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 0f8ee812
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/0f8ee812
Stats:     29 lines in 1 file changed: 0 ins; 26 del; 3 mod

git-webrev: add flags --base and --head

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/716

From ehelin at openjdk.java.net  Sat Aug 15 15:27:04 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 15:27:04 GMT
Subject: Integrated: git-webrev: add --json flag
In-Reply-To: <kAVB7-kBqHvnnXfwi1tNV8Cyc8F6uY-Nx85hLLghAbc=.c2e519ed-283c-4e12-9a69-8f3ae47b196d@github.com>
References: <kAVB7-kBqHvnnXfwi1tNV8Cyc8F6uY-Nx85hLLghAbc=.c2e519ed-283c-4e12-9a69-8f3ae47b196d@github.com>
Message-ID: <b9eMuv7aG28Lp4pKwN1kkPIgUyVatCGcr3s7F9LPBhs=.1cd847c8-866f-4120-86c8-9d48501614f5@github.com>

On Sat, 15 Aug 2020 10:49:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the `--json` flag to `git-webrev`. The `--json` flag is not meant to be used by a
> humans, it generates a JSON version of a "webrev" that tools can consume (in comparison to HTML that is usually
> generated).  Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 6422bf89
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/6422bf89
Stats:     283 lines in 6 files changed: 5 ins; 252 del; 26 mod

git-webrev: add --json flag

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/717

From ehelin at openjdk.java.net  Sat Aug 15 15:27:04 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 15 Aug 2020 15:27:04 GMT
Subject: RFR: git-webrev: add --json flag [v2]
In-Reply-To: <kAVB7-kBqHvnnXfwi1tNV8Cyc8F6uY-Nx85hLLghAbc=.c2e519ed-283c-4e12-9a69-8f3ae47b196d@github.com>
References: <kAVB7-kBqHvnnXfwi1tNV8Cyc8F6uY-Nx85hLLghAbc=.c2e519ed-283c-4e12-9a69-8f3ae47b196d@github.com>
Message-ID: <d4tEdwqDjxfNk1ZaYS4nLmIjxy1eoZ8snXdJT4HOzP0=.7b228215-60a5-4797-b3d3-c19055f7ad94@github.com>

> Hi all,
> 
> please review this patch that adds the `--json` flag to `git-webrev`. The `--json` flag is not meant to be used by a
> humans, it generates a JSON version of a "webrev" that tools can consume (in comparison to HTML that is usually
> generated).  Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains two commits:

 - Merge branch 'master'
 - git-webrev: add --json flag

-------------

Changes: https://git.openjdk.java.net/skara/pull/717/files
 Webrev: https://webrevs.openjdk.java.net/skara/717/webrev.01
  Stats: 283 lines in 6 files changed: 252 ins; 5 del; 26 mod
  Patch: https://git.openjdk.java.net/skara/pull/717.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/717/head:pull/717

PR: https://git.openjdk.java.net/skara/pull/717

From ehelin at openjdk.java.net  Mon Aug 17 17:48:14 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 17 Aug 2020 17:48:14 GMT
Subject: RFR: mlbridge: drop prefix "webrev" from webrev paths
Message-ID: <e_GM8BwjO3ydSLLUxbnOtx4vErhzgo_wy1tcCLrmJBg=.5f4c1a75-9ab3-485f-b92e-1d405e44e432@github.com>

Hi all,

please review this patch that drops the "webrev" prefix from the last part of the path for URLs to automatically
generated webrevs. For example, the current path looks like `https://webrevs.openjdk.java.net/skara/704/webrev.00`,
they will now look like `https://webrevs.openjdk.java.net/skara/704/00`. This is partly done in preparation for
uploading JSON versions of webrevs.

Testing:
- [x] `make test` passes on Linux x64
- [x] Updated a number of unit tests

Thanks,
Erik

-------------

Commit messages:
 - mlbridge: drop prefix "webrev" from webrev paths

Changes: https://git.openjdk.java.net/skara/pull/718/files
 Webrev: https://webrevs.openjdk.java.net/skara/718/webrev.00
  Stats: 17 lines in 3 files changed: 0 ins; 0 del; 17 mod
  Patch: https://git.openjdk.java.net/skara/pull/718.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/718/head:pull/718

PR: https://git.openjdk.java.net/skara/pull/718

From rwestberg at openjdk.java.net  Tue Aug 18 06:43:03 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 18 Aug 2020 06:43:03 GMT
Subject: RFR: mlbridge: drop prefix "webrev" from webrev paths
In-Reply-To: <e_GM8BwjO3ydSLLUxbnOtx4vErhzgo_wy1tcCLrmJBg=.5f4c1a75-9ab3-485f-b92e-1d405e44e432@github.com>
References: <e_GM8BwjO3ydSLLUxbnOtx4vErhzgo_wy1tcCLrmJBg=.5f4c1a75-9ab3-485f-b92e-1d405e44e432@github.com>
Message-ID: <sS_ItrFzG7qElVG1h2iEr-rl4V0Iyr966BBkuzQmtKQ=.6eb0fc10-2b53-4ed0-a2c1-9f7ece81b548@github.com>

On Mon, 17 Aug 2020 17:43:10 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that drops the "webrev" prefix from the last part of the path for URLs to automatically
> generated webrevs. For example, the current path looks like `https://webrevs.openjdk.java.net/skara/704/webrev.00`,
> they will now look like `https://webrevs.openjdk.java.net/skara/704/00`. This is partly done in preparation for
> uploading JSON versions of webrevs.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated a number of unit tests
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/718

From ehelin at openjdk.java.net  Tue Aug 18 06:59:32 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 06:59:32 GMT
Subject: Integrated: mlbridge: drop prefix "webrev" from webrev paths
In-Reply-To: <e_GM8BwjO3ydSLLUxbnOtx4vErhzgo_wy1tcCLrmJBg=.5f4c1a75-9ab3-485f-b92e-1d405e44e432@github.com>
References: <e_GM8BwjO3ydSLLUxbnOtx4vErhzgo_wy1tcCLrmJBg=.5f4c1a75-9ab3-485f-b92e-1d405e44e432@github.com>
Message-ID: <C4bKblCZt-fHKf15vLuk9EYTvtXr-7XkpUbNccjqA3Q=.86c6f69b-969d-43d8-b596-f24479a75104@github.com>

On Mon, 17 Aug 2020 17:43:10 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that drops the "webrev" prefix from the last part of the path for URLs to automatically
> generated webrevs. For example, the current path looks like `https://webrevs.openjdk.java.net/skara/704/webrev.00`,
> they will now look like `https://webrevs.openjdk.java.net/skara/704/00`. This is partly done in preparation for
> uploading JSON versions of webrevs.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated a number of unit tests
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: cb722aef
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/cb722aef
Stats:     17 lines in 3 files changed: 0 ins; 0 del; 17 mod

mlbridge: drop prefix "webrev" from webrev paths

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/718

From ehelin at openjdk.java.net  Tue Aug 18 07:31:15 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 07:31:15 GMT
Subject: RFR: mlbridge: support generating JSON for webrevs
Message-ID: <ZuRhhoTm-EbgO7zjdQV4p16En3KKNjWN3xe62SYlxTI=.ad3330f9-7eb0-4779-abc1-c553cfa682c4@github.com>

Hi all,

please review this patch that add support to the mlbridge bot for generating JSON versions of webrevs. Repositories can
now be configured to generate HTML webrevs, JSON webrevs or both. I added an additional unit test for verification.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added unit test for new functionality

Thanks,
Erik

-------------

Commit messages:
 - mlbridge: support generating JSON for webrevs

Changes: https://git.openjdk.java.net/skara/pull/719/files
 Webrev: https://webrevs.openjdk.java.net/skara/719/webrev.00
  Stats: 377 lines in 6 files changed: 309 ins; 9 del; 59 mod
  Patch: https://git.openjdk.java.net/skara/pull/719.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/719/head:pull/719

PR: https://git.openjdk.java.net/skara/pull/719

From rwestberg at openjdk.java.net  Tue Aug 18 07:49:00 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 18 Aug 2020 07:49:00 GMT
Subject: RFR: mlbridge: support generating JSON for webrevs
In-Reply-To: <ZuRhhoTm-EbgO7zjdQV4p16En3KKNjWN3xe62SYlxTI=.ad3330f9-7eb0-4779-abc1-c553cfa682c4@github.com>
References: <ZuRhhoTm-EbgO7zjdQV4p16En3KKNjWN3xe62SYlxTI=.ad3330f9-7eb0-4779-abc1-c553cfa682c4@github.com>
Message-ID: <JHiQfKEep3inNgD5jTz2xRDJ-Go-Y1Xl7hCcjh90MgU=.bd0eb603-c5c2-4915-ae9f-9328ea787a19@github.com>

On Tue, 18 Aug 2020 07:26:55 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that add support to the mlbridge bot for generating JSON versions of webrevs. Repositories can
> now be configured to generate HTML webrevs, JSON webrevs or both. I added an additional unit test for verification.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added unit test for new functionality
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/719

From ehelin at openjdk.java.net  Tue Aug 18 07:57:12 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 07:57:12 GMT
Subject: Integrated: mlbridge: support generating JSON for webrevs
In-Reply-To: <ZuRhhoTm-EbgO7zjdQV4p16En3KKNjWN3xe62SYlxTI=.ad3330f9-7eb0-4779-abc1-c553cfa682c4@github.com>
References: <ZuRhhoTm-EbgO7zjdQV4p16En3KKNjWN3xe62SYlxTI=.ad3330f9-7eb0-4779-abc1-c553cfa682c4@github.com>
Message-ID: <aB1SYEqcOz1EmryBf2I-3Pit3DN4b-C9lS2grv04zcg=.100f6d78-468d-4629-8604-c8c8c12332d9@github.com>

On Tue, 18 Aug 2020 07:26:55 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that add support to the mlbridge bot for generating JSON versions of webrevs. Repositories can
> now be configured to generate HTML webrevs, JSON webrevs or both. I added an additional unit test for verification.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added unit test for new functionality
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: a36c35bf
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/a36c35bf
Stats:     372 lines in 6 files changed: 4 ins; 304 del; 64 mod

mlbridge: support generating JSON for webrevs

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/719

From ehelin at openjdk.java.net  Tue Aug 18 10:36:14 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 10:36:14 GMT
Subject: RFR: bridgekeeper: support multiple close messages
Message-ID: <hjomDWKxY_K2Q5rne5hPQJRklfmd149i7nmq1Pf_zME=.11289cc0-3e9b-41cb-b35c-02ec7ae1d571@github.com>

Hi all,

please review this small patch that allows the bridgekeeper bot to close pull requests with different messages
depending on the type of repository.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added an additional unit test

Thanks,
Erik

-------------

Commit messages:
 - bridgekeeper: support multiple close messages

Changes: https://git.openjdk.java.net/skara/pull/720/files
 Webrev: https://webrevs.openjdk.java.net/skara/720/webrev.00
  Stats: 82 lines in 3 files changed: 68 ins; 0 del; 14 mod
  Patch: https://git.openjdk.java.net/skara/pull/720.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/720/head:pull/720

PR: https://git.openjdk.java.net/skara/pull/720

From ehelin at openjdk.java.net  Tue Aug 18 10:45:06 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 10:45:06 GMT
Subject: RFR: mlbridge: configure webrev ref explicitly
Message-ID: <u7GJBIgYC-k3nBnj0Ph4oLGtq6hXdVoMO5a7IC53lBQ=.7bf53840-eafc-4315-8ca2-b585e3266b4b@github.com>

Hi all,

please review this small patch makes the configuration for the ref used for storing webrevs explicit. Now that mlbridge
supports two different kinds of webrevs, the ref applies to both repositories and must therefore be configured
separately.

Testing:
- [x] `make test` passes on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - mlbridge: configure webrev ref explicitly

Changes: https://git.openjdk.java.net/skara/pull/721/files
 Webrev: https://webrevs.openjdk.java.net/skara/721/webrev.00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/721.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/721/head:pull/721

PR: https://git.openjdk.java.net/skara/pull/721

From rwestberg at openjdk.java.net  Tue Aug 18 11:16:50 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 18 Aug 2020 11:16:50 GMT
Subject: RFR: mlbridge: configure webrev ref explicitly
In-Reply-To: <u7GJBIgYC-k3nBnj0Ph4oLGtq6hXdVoMO5a7IC53lBQ=.7bf53840-eafc-4315-8ca2-b585e3266b4b@github.com>
References: <u7GJBIgYC-k3nBnj0Ph4oLGtq6hXdVoMO5a7IC53lBQ=.7bf53840-eafc-4315-8ca2-b585e3266b4b@github.com>
Message-ID: <v8_GfylBkmYXBFZSzfqxSUit1fRvClHs6n_snC7J8b0=.a73a68bf-0040-4fb1-b7d6-f71f5b5a3034@github.com>

On Tue, 18 Aug 2020 10:40:42 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch makes the configuration for the ref used for storing webrevs explicit. Now that mlbridge
> supports two different kinds of webrevs, the ref applies to both repositories and must therefore be configured
> separately.  Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/721

From ehelin at openjdk.java.net  Tue Aug 18 12:03:00 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 12:03:00 GMT
Subject: Integrated: mlbridge: configure webrev ref explicitly
In-Reply-To: <u7GJBIgYC-k3nBnj0Ph4oLGtq6hXdVoMO5a7IC53lBQ=.7bf53840-eafc-4315-8ca2-b585e3266b4b@github.com>
References: <u7GJBIgYC-k3nBnj0Ph4oLGtq6hXdVoMO5a7IC53lBQ=.7bf53840-eafc-4315-8ca2-b585e3266b4b@github.com>
Message-ID: <8J8yeBc8_rQK2TDt0pNKeoyJtXfZ2cHhjvgTiht_ryk=.8d8f424a-4383-4e21-8892-f4b3af1b676c@github.com>

On Tue, 18 Aug 2020 10:40:42 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch makes the configuration for the ref used for storing webrevs explicit. Now that mlbridge
> supports two different kinds of webrevs, the ref applies to both repositories and must therefore be configured
> separately.  Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 7103a3f2
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/7103a3f2
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

mlbridge: configure webrev ref explicitly

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/721

From rwestberg at openjdk.java.net  Tue Aug 18 12:28:22 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 18 Aug 2020 12:28:22 GMT
Subject: RFR: bridgekeeper: support multiple close messages
In-Reply-To: <hjomDWKxY_K2Q5rne5hPQJRklfmd149i7nmq1Pf_zME=.11289cc0-3e9b-41cb-b35c-02ec7ae1d571@github.com>
References: <hjomDWKxY_K2Q5rne5hPQJRklfmd149i7nmq1Pf_zME=.11289cc0-3e9b-41cb-b35c-02ec7ae1d571@github.com>
Message-ID: <AVxlymVLtYL9Heje_5xEbi8hRbALj3leOvSRd_VXdG8=.816dcb36-dadf-4d4e-8a4a-b35571ca86a1@github.com>

On Tue, 18 Aug 2020 10:03:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that allows the bridgekeeper bot to close pull requests with different messages
> depending on the type of repository.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added an additional unit test
> 
> Thanks,
> Erik

Looks good, just one question!

bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java line 71:

> 70:             } else {
> 71:                 message = "Welcome to the OpenJDK organization on GitHub!\n\n" +
> 72:                 "This repository does not currently accept pull requests." +

Guess this can't be reached?

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/720

From ehelin at openjdk.java.net  Tue Aug 18 12:31:00 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 12:31:00 GMT
Subject: RFR: bridgekeeper: support multiple close messages
In-Reply-To: <AVxlymVLtYL9Heje_5xEbi8hRbALj3leOvSRd_VXdG8=.816dcb36-dadf-4d4e-8a4a-b35571ca86a1@github.com>
References: <hjomDWKxY_K2Q5rne5hPQJRklfmd149i7nmq1Pf_zME=.11289cc0-3e9b-41cb-b35c-02ec7ae1d571@github.com>
 <AVxlymVLtYL9Heje_5xEbi8hRbALj3leOvSRd_VXdG8=.816dcb36-dadf-4d4e-8a4a-b35571ca86a1@github.com>
Message-ID: <QTVr-DeIuILnrQIuXmKlF30izjX85FuMlBBQ1NRaH9c=.39baf13b-dfbc-421c-8f47-5459cfc79cd7@github.com>

On Tue, 18 Aug 2020 12:25:57 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this small patch that allows the bridgekeeper bot to close pull requests with different messages
>> depending on the type of repository.
>> Testing:
>> - [x] `make test` passes on Linux x64
>> - [x] Added an additional unit test
>> 
>> Thanks,
>> Erik
>
> bots/bridgekeeper/src/main/java/org/openjdk/skara/bots/bridgekeeper/PullRequestCloserBot.java line 71:
> 
>> 70:             } else {
>> 71:                 message = "Welcome to the OpenJDK organization on GitHub!\n\n" +
>> 72:                 "This repository does not currently accept pull requests." +
> 
> Guess this can't be reached?

No, not at the moment, but I figured I would provide a fallback ??

-------------

PR: https://git.openjdk.java.net/skara/pull/720

From ehelin at openjdk.java.net  Tue Aug 18 12:34:22 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 12:34:22 GMT
Subject: Integrated: bridgekeeper: support multiple close messages
In-Reply-To: <hjomDWKxY_K2Q5rne5hPQJRklfmd149i7nmq1Pf_zME=.11289cc0-3e9b-41cb-b35c-02ec7ae1d571@github.com>
References: <hjomDWKxY_K2Q5rne5hPQJRklfmd149i7nmq1Pf_zME=.11289cc0-3e9b-41cb-b35c-02ec7ae1d571@github.com>
Message-ID: <TQmVmlITMd0YQg7ioYDow4jtDfwX0lBVbJkHPTbyfz4=.5ee3e00c-850f-4bd9-a087-d751565cb551@github.com>

On Tue, 18 Aug 2020 10:03:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that allows the bridgekeeper bot to close pull requests with different messages
> depending on the type of repository.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added an additional unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 0a2cf801
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/0a2cf801
Stats:     82 lines in 3 files changed: 0 ins; 68 del; 14 mod

bridgekeeper: support multiple close messages

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/720

From ehelin at openjdk.java.net  Tue Aug 18 12:57:21 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 12:57:21 GMT
Subject: RFR: build: update to Gradle 6.6
Message-ID: <oSjqpmP3rn_sYO3Ic6CE6amKSIkphJ0kTPOebFfxeyY=.305e67f8-d470-4f3d-9445-b2633dea7336@github.com>

Hi all,

please review this patch that updates Gradle to version 6.6.

Testing:
- [x] `make test` passes on Linux x64
- [x] `make images` passes on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - build: update to Gradle 6.6

Changes: https://git.openjdk.java.net/skara/pull/722/files
 Webrev: https://webrevs.openjdk.java.net/skara/722/00
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/722.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/722/head:pull/722

PR: https://git.openjdk.java.net/skara/pull/722

From rwestberg at openjdk.java.net  Tue Aug 18 13:03:19 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 18 Aug 2020 13:03:19 GMT
Subject: RFR: build: update to Gradle 6.6
In-Reply-To: <oSjqpmP3rn_sYO3Ic6CE6amKSIkphJ0kTPOebFfxeyY=.305e67f8-d470-4f3d-9445-b2633dea7336@github.com>
References: <oSjqpmP3rn_sYO3Ic6CE6amKSIkphJ0kTPOebFfxeyY=.305e67f8-d470-4f3d-9445-b2633dea7336@github.com>
Message-ID: <wuVYjmAZ4EiX-SQfIqvvK3NVh9w6FUnfIjpczBQ3Qpk=.740fea5c-8600-4880-81e7-c780251da7b8@github.com>

On Tue, 18 Aug 2020 12:53:21 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates Gradle to version 6.6.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] `make images` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/722

From ehelin at openjdk.java.net  Tue Aug 18 13:12:19 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 13:12:19 GMT
Subject: Integrated: build: update to Gradle 6.6
In-Reply-To: <oSjqpmP3rn_sYO3Ic6CE6amKSIkphJ0kTPOebFfxeyY=.305e67f8-d470-4f3d-9445-b2633dea7336@github.com>
References: <oSjqpmP3rn_sYO3Ic6CE6amKSIkphJ0kTPOebFfxeyY=.305e67f8-d470-4f3d-9445-b2633dea7336@github.com>
Message-ID: <w1H-oeapjOHzXd6WNUzvMnNhAjDK1OEvpOgXcH8CBkU=.09fda11e-99d5-4a09-8b16-69ec414a8c0e@github.com>

On Tue, 18 Aug 2020 12:53:21 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates Gradle to version 6.6.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] `make images` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 3b088e9f
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/3b088e9f
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

build: update to Gradle 6.6

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/722

From ehelin at openjdk.java.net  Tue Aug 18 13:34:57 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 13:34:57 GMT
Subject: RFR: build: update to JDK 14.0.2
Message-ID: <QTPr_rxMGrDP7iHXFVvEmpsvZBES-3debh1vAPltwd4=.0a624755-cfd0-4b2e-a86f-a04c8b678936@github.com>

Hi all,

please review this small patch that updates the JDK to version 14.0.2.

Testing:
- [x] `make test` passes on Linux x64
- [x] `make images` passes on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - build: update to JDK 14.0.2

Changes: https://git.openjdk.java.net/skara/pull/723/files
 Webrev: https://webrevs.openjdk.java.net/skara/723/00
  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/skara/pull/723.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/723/head:pull/723

PR: https://git.openjdk.java.net/skara/pull/723

From rwestberg at openjdk.java.net  Tue Aug 18 13:42:08 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 18 Aug 2020 13:42:08 GMT
Subject: RFR: build: update to JDK 14.0.2
In-Reply-To: <QTPr_rxMGrDP7iHXFVvEmpsvZBES-3debh1vAPltwd4=.0a624755-cfd0-4b2e-a86f-a04c8b678936@github.com>
References: <QTPr_rxMGrDP7iHXFVvEmpsvZBES-3debh1vAPltwd4=.0a624755-cfd0-4b2e-a86f-a04c8b678936@github.com>
Message-ID: <tbh_HLegvgrbQ22aZ75Bt51SJp0kA24f37BGVlTTXEU=.51aba46a-504a-49db-b49e-df5abdc05954@github.com>

On Tue, 18 Aug 2020 13:31:03 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that updates the JDK to version 14.0.2.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] `make images` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/723

From ehelin at openjdk.java.net  Tue Aug 18 13:57:45 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 13:57:45 GMT
Subject: Integrated: build: update to JDK 14.0.2
In-Reply-To: <QTPr_rxMGrDP7iHXFVvEmpsvZBES-3debh1vAPltwd4=.0a624755-cfd0-4b2e-a86f-a04c8b678936@github.com>
References: <QTPr_rxMGrDP7iHXFVvEmpsvZBES-3debh1vAPltwd4=.0a624755-cfd0-4b2e-a86f-a04c8b678936@github.com>
Message-ID: <gIPhCbwHZN06WirJTVswBX3AW0Yh7RGwXhNA7Ni_ogw=.feb77d69-5d8d-4eb3-a2bd-4fe476bae2ef@github.com>

On Tue, 18 Aug 2020 13:31:03 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that updates the JDK to version 14.0.2.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] `make images` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: edb4d049
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/edb4d049
Stats:     6 lines in 1 file changed: 0 ins; 0 del; 6 mod

build: update to JDK 14.0.2

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/723

From ehelin at openjdk.java.net  Tue Aug 18 13:58:53 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 13:58:53 GMT
Subject: RFR: mlbridge: use consistent conf for webrevs
Message-ID: <HbfuPR3pZpfs5SBVvElgSeRuyOBDZTs7mBgqCtIrkHI=.c14f902d-4c85-4d43-b65c-ea1b244b65aa@github.com>

Hi all,

please review this small patch that makes the configuration for the mlbridge bot use consistent spelling for the
"webrevs" fields.

Testing:
- [x] `make test` on Linux x64 passes

Thanks,
Erik

-------------

Commit messages:
 - mlbridge: use consistent conf for webrevs

Changes: https://git.openjdk.java.net/skara/pull/724/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=724&range=00
  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/skara/pull/724.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/724/head:pull/724

PR: https://git.openjdk.java.net/skara/pull/724

From dalibor.topic at oracle.com  Tue Aug 18 13:59:32 2020
From: dalibor.topic at oracle.com (Dalibor Topic)
Date: Tue, 18 Aug 2020 15:59:32 +0200
Subject: Pre-existing OCA without username
In-Reply-To: <957e070a-84e2-2b9a-ff13-e954f9329ad4@anthonyv.be>
References: <957e070a-84e2-2b9a-ff13-e954f9329ad4@anthonyv.be>
Message-ID: <f50e5c68-9d88-17dc-50b4-2048424c47fc@oracle.com>

On 15.08.2020 13:45, Anthony Vanelverdinghe wrote:
> Hi
> 
> When opening a PR, I get the OCA-related comment from the bridgekeeper 
> [1]. I have already signed the OCA [2], but had left the "Username" 
> field blank at the time (since I didn't (& still don't) have an official 
> OpenJDK username, and this was way before Skara).
> Would you be so kind to mark my GitHub username as having signed the OCA 
> please? Thanks in advance.

Thanks for reaching out, Anthony, it's done.

cheers,
dalibor topic

> [1] https://github.com/openjdk/amber-docs/pull/5#issuecomment-674375321
> [2] 
> https://www.oracle.com/technical-resources/oracle-contributor-agreement.html#v 
> 
> 
> Kind regards,
> Anthony
> 

-- 
<http://www.oracle.com> Dalibor Topic
Consulting Product Manager
Phone: +494089091214 <tel:+494089091214>, Mobile: +491737185961
<tel:+491737185961>, Video: dalibor.topic at oracle.com
<sip:dalibor.topic at oracle.com>

Oracle Global Services Germany GmbH
Hauptverwaltung: Riesstr. 25, D-80992 M?nchen
Registergericht: Amtsgericht M?nchen, HRB 246209
Gesch?ftsf?hrer: Ralf Herrmann


From rwestberg at openjdk.java.net  Tue Aug 18 14:25:04 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 18 Aug 2020 14:25:04 GMT
Subject: RFR: mlbridge: use consistent conf for webrevs
In-Reply-To: <HbfuPR3pZpfs5SBVvElgSeRuyOBDZTs7mBgqCtIrkHI=.c14f902d-4c85-4d43-b65c-ea1b244b65aa@github.com>
References: <HbfuPR3pZpfs5SBVvElgSeRuyOBDZTs7mBgqCtIrkHI=.c14f902d-4c85-4d43-b65c-ea1b244b65aa@github.com>
Message-ID: <2lKXqdJ1-3GQY9Nj6SEGS44TtE0cuXRWXsLk24n8KFA=.4c9fc98f-545c-46c9-bc35-0af777fce3b2@github.com>

On Tue, 18 Aug 2020 13:55:56 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that makes the configuration for the mlbridge bot use consistent spelling for the
> "webrevs" fields.
> Testing:
> - [x] `make test` on Linux x64 passes
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/724

From ehelin at openjdk.java.net  Tue Aug 18 14:51:16 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 18 Aug 2020 14:51:16 GMT
Subject: Integrated: mlbridge: use consistent conf for webrevs
In-Reply-To: <HbfuPR3pZpfs5SBVvElgSeRuyOBDZTs7mBgqCtIrkHI=.c14f902d-4c85-4d43-b65c-ea1b244b65aa@github.com>
References: <HbfuPR3pZpfs5SBVvElgSeRuyOBDZTs7mBgqCtIrkHI=.c14f902d-4c85-4d43-b65c-ea1b244b65aa@github.com>
Message-ID: <W0XBT-dNzCG2rA_rinCJKq7OP7u88SteyJZQ48N5PtY=.99b39bd8-5fbd-42ed-9fc2-8a77cd8937a5@github.com>

On Tue, 18 Aug 2020 13:55:56 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that makes the configuration for the mlbridge bot use consistent spelling for the
> "webrevs" fields.
> Testing:
> - [x] `make test` on Linux x64 passes
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 1dbd418c
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/1dbd418c
Stats:     6 lines in 1 file changed: 0 ins; 0 del; 6 mod

mlbridge: use consistent conf for webrevs

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/724

From ehelin at openjdk.java.net  Fri Aug 21 12:45:51 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 12:45:51 GMT
Subject: RFR: hg: implement hashes for blobs for ls-tree
Message-ID: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>

Hi all,

please review this patch that properly implements `ls-tree` for Mercurial.

Testing:
- [x] `make test` passes on Linux x64
- [x] Updated unit test

Thanks,
Erik

-------------

Commit messages:
 - hg: implement hashes for blobs for ls-tree

Changes: https://git.openjdk.java.net/skara/pull/725/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=725&range=00
  Stats: 12 lines in 2 files changed: 10 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/725.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/725/head:pull/725

PR: https://git.openjdk.java.net/skara/pull/725

From rwestberg at openjdk.java.net  Fri Aug 21 12:58:57 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 21 Aug 2020 12:58:57 GMT
Subject: RFR: hg: implement hashes for blobs for ls-tree
In-Reply-To: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>
References: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>
Message-ID: <JjJh2jFpuJXwjxpN1sMHSRPXs6lRKdu73n2gQVJOVbM=.4a980399-fa8e-43dd-97cf-de90f12a1983@github.com>

On Fri, 21 Aug 2020 12:43:15 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that properly implements `ls-tree` for Mercurial.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated unit test
> 
> Thanks,
> Erik

Looks good!

vcs/src/main/resources/ext.py line 336:

> 335:         m.update(data)
> 336:         write(m.hexdigest())
> 337:         write(b'\t')

Python 3 doesn't like this one, perhaps not that urgent to fix though..

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/725

From ehelin at openjdk.java.net  Fri Aug 21 13:30:56 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 13:30:56 GMT
Subject: RFR: git: allow diffs against initial revision
Message-ID: <mAUxea68kKFLNQ7rQlxv1bpe50oky-Wb81knpnSdbGI=.67374a76-300d-4264-9237-211fdc6ef588@github.com>

Hi all,

please review this patch that makes it possible to do `diff` and `status` against the initial revision of a git
repository.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added two new unit tests

Thanks,
Erik

-------------

Commit messages:
 - git: allow diffs against initial revision

Changes: https://git.openjdk.java.net/skara/pull/726/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=726&range=00
  Stats: 56 lines in 2 files changed: 53 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/726.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/726/head:pull/726

PR: https://git.openjdk.java.net/skara/pull/726

From ehelin at openjdk.java.net  Fri Aug 21 13:41:43 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 13:41:43 GMT
Subject: RFR: git: commitMetadata should return commits in topo order
Message-ID: <QYpRkkYhgzSg3Oi4AXqUwc0LSxDT5y8z6F8EkH0mHiU=.a2e5df37-3fc2-4261-942c-76034e6e7bbb@github.com>

Hi all,

please review this small patch that makes `GitRepository.commitMetadata` return commits topological order (i.e. all
parents first, then the parent). This is already done by `GitRepository.commits`.

Testing:
- [x] `make test` passes on Linux x64
- [ ] Did not add a new unit test since it is hard to force commits to be returned in non-topological order

Thanks,
Erik

-------------

Commit messages:
 - git: commitMetadata should return commits in topo order

Changes: https://git.openjdk.java.net/skara/pull/727/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=727&range=00
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/727.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/727/head:pull/727

PR: https://git.openjdk.java.net/skara/pull/727

From ehelin at openjdk.java.net  Fri Aug 21 13:49:41 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 13:49:41 GMT
Subject: RFR: hg: implement hashes for blobs for ls-tree [v2]
In-Reply-To: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>
References: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>
Message-ID: <KosXYeTlHiSHuPuu4rVtbQxxRUULoGd15ntA3QEBhPE=.4b0fe85d-db73-437d-beee-b8313e0eb08e@github.com>

> Hi all,
> 
> please review this patch that properly implements `ls-tree` for Mercurial.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated unit test
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  Fix Python 3 compatability

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/725/files
  - new: https://git.openjdk.java.net/skara/pull/725/files/9f32a1a2..65b383f0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=725&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=725&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/725.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/725/head:pull/725

PR: https://git.openjdk.java.net/skara/pull/725

From ehelin at openjdk.java.net  Fri Aug 21 14:43:27 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 14:43:27 GMT
Subject: RFR: hg: implement hashes for blobs for ls-tree [v2]
In-Reply-To: <JjJh2jFpuJXwjxpN1sMHSRPXs6lRKdu73n2gQVJOVbM=.4a980399-fa8e-43dd-97cf-de90f12a1983@github.com>
References: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>
 <JjJh2jFpuJXwjxpN1sMHSRPXs6lRKdu73n2gQVJOVbM=.4a980399-fa8e-43dd-97cf-de90f12a1983@github.com>
Message-ID: <Ld4fJhXF_DtFBoR4ysVBBUej-ThcYtKXcWfXorH_Jpc=.1763bb78-1eb2-49c7-8713-c46966469b83@github.com>

On Fri, 21 Aug 2020 12:56:48 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix Python 3 compatability
>
> vcs/src/main/resources/ext.py line 336:
> 
>> 335:         m.update(data)
>> 336:         write(m.hexdigest())
>> 337:         write(b'\t')
> 
> Python 3 doesn't like this one, perhaps not that urgent to fix though..

Thanks for catching, fixed!

-------------

PR: https://git.openjdk.java.net/skara/pull/725

From ehelin at openjdk.java.net  Fri Aug 21 14:43:25 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 14:43:25 GMT
Subject: RFR: git: support unicode filenames
Message-ID: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>

Hi all,

please review this patch that adds support for unicode filenames to `GitRepository`. I also added a unit test
exercising the new functionality.

Testing:
- [x] `make test` passes on Linux x64
- Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - git: support unicode filenames
 - git: commitMetadata should return commits in topo order
 - git: allow diffs against initial revision
 - hg: implement hashes for blobs for ls-tree

Changes: https://git.openjdk.java.net/skara/pull/728/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=728&range=00
  Stats: 45 lines in 4 files changed: 37 ins; 1 del; 7 mod
  Patch: https://git.openjdk.java.net/skara/pull/728.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/728/head:pull/728

PR: https://git.openjdk.java.net/skara/pull/728

From ehelin at openjdk.java.net  Fri Aug 21 14:43:27 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 14:43:27 GMT
Subject: Integrated: hg: implement hashes for blobs for ls-tree
In-Reply-To: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>
References: <xOO0eiicdeozo10CquJAveuoQNCbYM-BiDzF0t946IQ=.078cac56-46b8-42f5-846c-62047615c310@github.com>
Message-ID: <kPgO9MTDV2p3dfFw5dKpsXW2Art_UvPs-Kb5iJgV22k=.c486d3dd-5898-4bd4-a0cd-9a621be29dc3@github.com>

On Fri, 21 Aug 2020 12:43:15 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that properly implements `ls-tree` for Mercurial.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 3916cb70
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/3916cb70
Stats:     12 lines in 2 files changed: 1 ins; 10 del; 1 mod

hg: implement hashes for blobs for ls-tree

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/725

From ehelin at openjdk.java.net  Fri Aug 21 14:55:50 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 14:55:50 GMT
Subject: RFR: git: support unicode filenames [v2]
In-Reply-To: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>
References: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>
Message-ID: <Pg44m-WfPaAv8zRJv55JsUNTWvWRdXeRET5Q5EHd2o0=.69b8a500-8929-4057-9c56-e468c9f9030a@github.com>

> Hi all,
> 
> please review this patch that adds support for unicode filenames to `GitRepository`. I also added a unit test
> exercising the new functionality.
> Testing:
> - [x] `make test` passes on Linux x64
> - Added a new unit test
> 
> Thanks,
> Erik

Erik Helin has refreshed the contents of this pull request, and previous commits have been removed. The incremental
views will show differences compared to the previous content of the PR. The pull request contains one new commit since
the last revision:

  git: support unicode filenames

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/728/files
  - new: https://git.openjdk.java.net/skara/pull/728/files/11c70886..3097f5b7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=728&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=728&range=00-01

  Stats: 16 lines in 2 files changed: 1 ins; 13 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/728.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/728/head:pull/728

PR: https://git.openjdk.java.net/skara/pull/728

From rwestberg at openjdk.java.net  Fri Aug 21 14:57:23 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 21 Aug 2020 14:57:23 GMT
Subject: RFR: git: allow diffs against initial revision
In-Reply-To: <mAUxea68kKFLNQ7rQlxv1bpe50oky-Wb81knpnSdbGI=.67374a76-300d-4264-9237-211fdc6ef588@github.com>
References: <mAUxea68kKFLNQ7rQlxv1bpe50oky-Wb81knpnSdbGI=.67374a76-300d-4264-9237-211fdc6ef588@github.com>
Message-ID: <NqIxSFlg-Q9h3kp_VU0exnKkH6Zp6Ji6Z3eHOz-bhF4=.5a34a51c-f04b-4346-aea7-a2c8663ca257@github.com>

On Fri, 21 Aug 2020 13:28:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it possible to do `diff` and `status` against the initial revision of a git
> repository.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added two new unit tests
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/726

From rwestberg at openjdk.java.net  Fri Aug 21 14:58:21 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 21 Aug 2020 14:58:21 GMT
Subject: RFR: git: commitMetadata should return commits in topo order
In-Reply-To: <QYpRkkYhgzSg3Oi4AXqUwc0LSxDT5y8z6F8EkH0mHiU=.a2e5df37-3fc2-4261-942c-76034e6e7bbb@github.com>
References: <QYpRkkYhgzSg3Oi4AXqUwc0LSxDT5y8z6F8EkH0mHiU=.a2e5df37-3fc2-4261-942c-76034e6e7bbb@github.com>
Message-ID: <34RCErwnPBCpMm5SDnexYqkGiaBxKgcNO9PMqwFp0mA=.fe6d8167-9b71-47ff-bd6f-eb0c85dbcad5@github.com>

On Fri, 21 Aug 2020 13:39:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that makes `GitRepository.commitMetadata` return commits topological order (i.e. all
> parents first, then the parent). This is already done by `GitRepository.commits`.
> Testing:
> - [x] `make test` passes on Linux x64
> - [ ] Did not add a new unit test since it is hard to force commits to be returned in non-topological order
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/727

From rwestberg at openjdk.java.net  Fri Aug 21 14:58:57 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 21 Aug 2020 14:58:57 GMT
Subject: RFR: git: support unicode filenames [v2]
In-Reply-To: <Pg44m-WfPaAv8zRJv55JsUNTWvWRdXeRET5Q5EHd2o0=.69b8a500-8929-4057-9c56-e468c9f9030a@github.com>
References: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>
 <Pg44m-WfPaAv8zRJv55JsUNTWvWRdXeRET5Q5EHd2o0=.69b8a500-8929-4057-9c56-e468c9f9030a@github.com>
Message-ID: <lXBf3fTywhbm2wEwTN920Oho9koqpqdRwuF_qKzZB44=.886830e8-160f-437f-bc4c-594536d89ac4@github.com>

On Fri, 21 Aug 2020 14:55:50 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that adds support for unicode filenames to `GitRepository`. I also added a unit test
>> exercising the new functionality.
>> Testing:
>> - [x] `make test` passes on Linux x64
>> - Added a new unit test
>> 
>> Thanks,
>> Erik
>
> Erik Helin has refreshed the contents of this pull request, and previous commits have been removed. The incremental
> views will show differences compared to the previous content of the PR. The pull request contains one new commit since
> the last revision:
>   git: support unicode filenames

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/728

From ehelin at openjdk.java.net  Fri Aug 21 15:02:26 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 15:02:26 GMT
Subject: Integrated: git: allow diffs against initial revision
In-Reply-To: <mAUxea68kKFLNQ7rQlxv1bpe50oky-Wb81knpnSdbGI=.67374a76-300d-4264-9237-211fdc6ef588@github.com>
References: <mAUxea68kKFLNQ7rQlxv1bpe50oky-Wb81knpnSdbGI=.67374a76-300d-4264-9237-211fdc6ef588@github.com>
Message-ID: <Tv6D-U3ZdL6HxURVyAt0fW-lYZyBRumXy9BIktodHBA=.504bdecb-1f9b-4c42-822e-0d79ce85c544@github.com>

On Fri, 21 Aug 2020 13:28:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it possible to do `diff` and `status` against the initial revision of a git
> repository.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added two new unit tests
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: becfd455
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/becfd455
Stats:     56 lines in 2 files changed: 0 ins; 53 del; 3 mod

git: allow diffs against initial revision

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/726

From ehelin at openjdk.java.net  Fri Aug 21 15:02:46 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 15:02:46 GMT
Subject: Integrated: git: commitMetadata should return commits in topo order
In-Reply-To: <QYpRkkYhgzSg3Oi4AXqUwc0LSxDT5y8z6F8EkH0mHiU=.a2e5df37-3fc2-4261-942c-76034e6e7bbb@github.com>
References: <QYpRkkYhgzSg3Oi4AXqUwc0LSxDT5y8z6F8EkH0mHiU=.a2e5df37-3fc2-4261-942c-76034e6e7bbb@github.com>
Message-ID: <QV0kyX_ax8wDeRe41acHJpmivmv4ux4mAJsHt2Y_tWY=.95b3f951-7821-4c01-9c00-441d6793490d@github.com>

On Fri, 21 Aug 2020 13:39:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that makes `GitRepository.commitMetadata` return commits topological order (i.e. all
> parents first, then the parent). This is already done by `GitRepository.commits`.
> Testing:
> - [x] `make test` passes on Linux x64
> - [ ] Did not add a new unit test since it is hard to force commits to be returned in non-topological order
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 4175a74b
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/4175a74b
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

git: commitMetadata should return commits in topo order

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/727

From ehelin at openjdk.java.net  Fri Aug 21 15:15:42 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 15:15:42 GMT
Subject: RFR: hg: allow tags without email
Message-ID: <rdqkr3Y0mD_Yyq1QBTdaqe6--Z1pohAsIXYoDmslcp4=.a6d88a15-aa66-43d3-b82d-53bef1f80d09@github.com>

Hi all,

please review this patch which allows `HgRepository.tag` to allow a `null` argument for `authorEmail`. Mercurial does
not require e-mails for authors, so neither should `HgRepository`.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - hg: allow tags without email

Changes: https://git.openjdk.java.net/skara/pull/729/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=729&range=00
  Stats: 18 lines in 2 files changed: 17 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/729.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/729/head:pull/729

PR: https://git.openjdk.java.net/skara/pull/729

From ehelin at openjdk.java.net  Fri Aug 21 15:24:07 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 15:24:07 GMT
Subject: RFR: git: support unicode filenames [v3]
In-Reply-To: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>
References: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>
Message-ID: <p7qKJqT7059wx-TXoAxRZvKwhZMUIP31xuTp1rvPSHg=.30ef3c5d-8a65-4d1b-8f8d-3e9d3f149e59@github.com>

> Hi all,
> 
> please review this patch that adds support for unicode filenames to `GitRepository`. I also added a unit test
> exercising the new functionality.
> Testing:
> - [x] `make test` passes on Linux x64
> - Added a new unit test
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  Do not run test with Mercurial

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/728/files
  - new: https://git.openjdk.java.net/skara/pull/728/files/3097f5b7..d4b9902a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=728&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=728&range=01-02

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/728.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/728/head:pull/728

PR: https://git.openjdk.java.net/skara/pull/728

From ehelin at openjdk.java.net  Fri Aug 21 15:39:33 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 21 Aug 2020 15:39:33 GMT
Subject: RFR: hg: implement ReadOnlyRepository.isAncestor
Message-ID: <moyePlajTb0vz6_R1IVoX4KHQV9C3eGZr-6ZfisoW-w=.c898461a-2927-4bb4-8976-a5f599f351b6@github.com>

Hi all,

please review this patch that implements `ReadOnlyRepository.isAncestor` for `HgRepository`.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - hg: implement ReadOnlyRepository.isAncestor

Changes: https://git.openjdk.java.net/skara/pull/730/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=730&range=00
  Stats: 29 lines in 2 files changed: 28 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/730.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/730/head:pull/730

PR: https://git.openjdk.java.net/skara/pull/730

From ehelin at openjdk.java.net  Sat Aug 22 08:31:38 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 22 Aug 2020 08:31:38 GMT
Subject: Integrated: git: support unicode filenames
In-Reply-To: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>
References: <R0GpVUFl8YO--xFG-BOrzRqGplQwqP2gNVjaV1SPvq8=.bb300555-014e-4431-88a0-7c0d72a7e864@github.com>
Message-ID: <yMc0WJzXcJtzAkeKrLulBFVUSAbT6Hvb2HC0jhiSyOk=.292f5862-dda7-4b60-8842-917d91aadec6@github.com>

On Fri, 21 Aug 2020 14:40:42 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds support for unicode filenames to `GitRepository`. I also added a unit test
> exercising the new functionality.
> Testing:
> - [x] `make test` passes on Linux x64
> - Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 2413ed83
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/2413ed83
Stats:     29 lines in 3 files changed: 0 ins; 24 del; 5 mod

git: support unicode filenames

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/728

From rwestberg at openjdk.java.net  Sat Aug 22 08:58:07 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 22 Aug 2020 08:58:07 GMT
Subject: RFR: hg: allow tags without email
In-Reply-To: <rdqkr3Y0mD_Yyq1QBTdaqe6--Z1pohAsIXYoDmslcp4=.a6d88a15-aa66-43d3-b82d-53bef1f80d09@github.com>
References: <rdqkr3Y0mD_Yyq1QBTdaqe6--Z1pohAsIXYoDmslcp4=.a6d88a15-aa66-43d3-b82d-53bef1f80d09@github.com>
Message-ID: <1qMapSgXbdQBMMQaksfAGDEUU8i8yvBAvf-gW7AUUtM=.404d8ef9-2d2d-4f53-98fa-d210c0851c36@github.com>

On Fri, 21 Aug 2020 15:13:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch which allows `HgRepository.tag` to allow a `null` argument for `authorEmail`. Mercurial does
> not require e-mails for authors, so neither should `HgRepository`.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/729

From rwestberg at openjdk.java.net  Sat Aug 22 08:59:16 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 22 Aug 2020 08:59:16 GMT
Subject: RFR: hg: implement ReadOnlyRepository.isAncestor
In-Reply-To: <moyePlajTb0vz6_R1IVoX4KHQV9C3eGZr-6ZfisoW-w=.c898461a-2927-4bb4-8976-a5f599f351b6@github.com>
References: <moyePlajTb0vz6_R1IVoX4KHQV9C3eGZr-6ZfisoW-w=.c898461a-2927-4bb4-8976-a5f599f351b6@github.com>
Message-ID: <WUUCgANw5bv9xj-UDz7oJL6Hr4B7Fhk2p6Hqcqk0qXw=.340fdcb5-174a-41cc-bdef-f59d69ded91f@github.com>

On Fri, 21 Aug 2020 15:36:54 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that implements `ReadOnlyRepository.isAncestor` for `HgRepository`.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Looks great!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/730

From ehelin at openjdk.java.net  Sat Aug 22 09:01:35 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 22 Aug 2020 09:01:35 GMT
Subject: Integrated: hg: allow tags without email
In-Reply-To: <rdqkr3Y0mD_Yyq1QBTdaqe6--Z1pohAsIXYoDmslcp4=.a6d88a15-aa66-43d3-b82d-53bef1f80d09@github.com>
References: <rdqkr3Y0mD_Yyq1QBTdaqe6--Z1pohAsIXYoDmslcp4=.a6d88a15-aa66-43d3-b82d-53bef1f80d09@github.com>
Message-ID: <FtA-pfG137JT2JhZPSesdoIPuxclYk0sgThnyPpHO7s=.9b7501c2-87ac-4698-b554-32ffc3b74d0b@github.com>

On Fri, 21 Aug 2020 15:13:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch which allows `HgRepository.tag` to allow a `null` argument for `authorEmail`. Mercurial does
> not require e-mails for authors, so neither should `HgRepository`.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 3e8fb840
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/3e8fb840
Stats:     18 lines in 2 files changed: 0 ins; 17 del; 1 mod

hg: allow tags without email

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/729

From ehelin at openjdk.java.net  Sat Aug 22 09:02:15 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 22 Aug 2020 09:02:15 GMT
Subject: Integrated: hg: implement ReadOnlyRepository.isAncestor
In-Reply-To: <moyePlajTb0vz6_R1IVoX4KHQV9C3eGZr-6ZfisoW-w=.c898461a-2927-4bb4-8976-a5f599f351b6@github.com>
References: <moyePlajTb0vz6_R1IVoX4KHQV9C3eGZr-6ZfisoW-w=.c898461a-2927-4bb4-8976-a5f599f351b6@github.com>
Message-ID: <VmSIrlhuMvEb6JW5iPXXvjzGWSgqtLpKDnb4wo52_o8=.163f99aa-f27f-4231-971c-f18e2012259d@github.com>

On Fri, 21 Aug 2020 15:36:54 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that implements `ReadOnlyRepository.isAncestor` for `HgRepository`.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 095afaab
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/095afaab
Stats:     29 lines in 2 files changed: 0 ins; 28 del; 1 mod

hg: implement ReadOnlyRepository.isAncestor

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/730

From ehelin at openjdk.java.net  Sat Aug 22 09:27:51 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 22 Aug 2020 09:27:51 GMT
Subject: RFR: vcs: support explicit fast-forward merging
Message-ID: <YbyDelnSjt0vedl3V3OgF6nCDQPsEYselxY0EeD4AeQ=.91402a77-e800-42ef-a067-b9fc8413991f@github.com>

Hi all,

please review this patch that makes it explicit for `Repository.merge` whether a fast-forward merge should be attempted
or not.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added two new unit tests

Thanks,
Erik

-------------

Commit messages:
 - hg: support non-fast-forward merging

Changes: https://git.openjdk.java.net/skara/pull/731/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=731&range=00
  Stats: 122 lines in 5 files changed: 100 ins; 0 del; 22 mod
  Patch: https://git.openjdk.java.net/skara/pull/731.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/731/head:pull/731

PR: https://git.openjdk.java.net/skara/pull/731

From rwestberg at openjdk.java.net  Sat Aug 22 09:58:46 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 22 Aug 2020 09:58:46 GMT
Subject: RFR: vcs: support explicit fast-forward merging
In-Reply-To: <YbyDelnSjt0vedl3V3OgF6nCDQPsEYselxY0EeD4AeQ=.91402a77-e800-42ef-a067-b9fc8413991f@github.com>
References: <YbyDelnSjt0vedl3V3OgF6nCDQPsEYselxY0EeD4AeQ=.91402a77-e800-42ef-a067-b9fc8413991f@github.com>
Message-ID: <IqgAapzlaZjq9Dad8335CNpiYEkrana7_kdb7zocwk0=.c1c557a8-25a2-4b3c-ae18-54e192ae4833@github.com>

On Sat, 22 Aug 2020 09:25:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it explicit for `Repository.merge` whether a fast-forward merge should be attempted
> or not.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added two new unit tests
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/731

From ehelin at openjdk.java.net  Sat Aug 22 10:00:57 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 22 Aug 2020 10:00:57 GMT
Subject: Integrated: vcs: support explicit fast-forward merging
In-Reply-To: <YbyDelnSjt0vedl3V3OgF6nCDQPsEYselxY0EeD4AeQ=.91402a77-e800-42ef-a067-b9fc8413991f@github.com>
References: <YbyDelnSjt0vedl3V3OgF6nCDQPsEYselxY0EeD4AeQ=.91402a77-e800-42ef-a067-b9fc8413991f@github.com>
Message-ID: <xjQ2VeVHxFoU2uSEmTqjEKmTvsXwHhvCggdY0H39PHU=.8d1e4da0-fb3f-4001-bfdc-36190d9d5aaa@github.com>

On Sat, 22 Aug 2020 09:25:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it explicit for `Repository.merge` whether a fast-forward merge should be attempted
> or not.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added two new unit tests
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: cfaa0827
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/cfaa0827
Stats:     122 lines in 5 files changed: 0 ins; 100 del; 22 mod

vcs: support explicit fast-forward merging

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/731

From rwestberg at openjdk.java.net  Mon Aug 24 07:50:34 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 07:50:34 GMT
Subject: Integrated: vcs: add method Repository.deleteUntrackedFiles
In-Reply-To: <kq9t6E5M0gZw7R6--895NPw8YckIfEU6F4iRyHE99do=.b7ce8998-9974-4160-bbb5-1d499878e91a@github.com>
References: <kq9t6E5M0gZw7R6--895NPw8YckIfEU6F4iRyHE99do=.b7ce8998-9974-4160-bbb5-1d499878e91a@github.com>
Message-ID: <YsoQ8-tHSAQrcCNSx5jI_17vw2vH4LpLiJfawykYViQ=.bcc2a5c0-0a44-4126-a68b-80699705c42c@github.com>

On Mon, 24 Aug 2020 07:45:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds a new method to `Repository` - `deleteUntrackedFiles`. As the name suggests, the new
> method deletes all untracked files in a repository. This is useful when you want to clean up a repository after for
> example a `revert`.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/732

From ehelin at openjdk.java.net  Mon Aug 24 07:50:34 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 07:50:34 GMT
Subject: Integrated: vcs: add method Repository.deleteUntrackedFiles
Message-ID: <kq9t6E5M0gZw7R6--895NPw8YckIfEU6F4iRyHE99do=.b7ce8998-9974-4160-bbb5-1d499878e91a@github.com>

Hi all,

please review this patch that adds a new method to `Repository` - `deleteUntrackedFiles`. As the name suggests, the new
method deletes all untracked files in a repository. This is useful when you want to clean up a repository after for
example a `revert`.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - vcs: add method Repository.deleteUntrackedFiles

Changes: https://git.openjdk.java.net/skara/pull/732/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=732&range=00
  Stats: 48 lines in 4 files changed: 48 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/732.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/732/head:pull/732

PR: https://git.openjdk.java.net/skara/pull/732

From ehelin at openjdk.java.net  Mon Aug 24 07:50:34 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 07:50:34 GMT
Subject: Integrated: vcs: add method Repository.deleteUntrackedFiles
In-Reply-To: <kq9t6E5M0gZw7R6--895NPw8YckIfEU6F4iRyHE99do=.b7ce8998-9974-4160-bbb5-1d499878e91a@github.com>
References: <kq9t6E5M0gZw7R6--895NPw8YckIfEU6F4iRyHE99do=.b7ce8998-9974-4160-bbb5-1d499878e91a@github.com>
Message-ID: <x140XveobOXIXM47iNwS9EvCumZWKFBm45ygjwEz7TQ=.be015534-a48a-4a84-86e4-3fa31e970747@github.com>

On Mon, 24 Aug 2020 07:45:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds a new method to `Repository` - `deleteUntrackedFiles`. As the name suggests, the new
> method deletes all untracked files in a repository. This is useful when you want to clean up a repository after for
> example a `revert`.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: b15e755d
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/b15e755d
Stats:     48 lines in 4 files changed: 0 ins; 48 del; 0 mod

vcs: add method Repository.deleteUntrackedFiles

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/732

From rwestberg at openjdk.java.net  Mon Aug 24 10:51:25 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 10:51:25 GMT
Subject: RFR: Mailing list filter rule generator / verifier
Message-ID: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>

Hi all,

Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list
filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when
figuring out on which list(s) a jdk pull request should be reviewed.

The idea is that this command can be used by knowledgeable OpenJDK developers to help improve the quality of the filter
rules that will eventually end up being used when the jdk repository starts using pull requests. Examples of usage,
together with an initial version of these filter rules, will be posted separately.

Best regards,
Robin

-------------

Commit messages:
 - Initial implementation

Changes: https://git.openjdk.java.net/skara/pull/733/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=733&range=00
  Stats: 810 lines in 5 files changed: 810 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/733.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/733/head:pull/733

PR: https://git.openjdk.java.net/skara/pull/733

From rwestberg at openjdk.java.net  Mon Aug 24 12:40:10 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 12:40:10 GMT
Subject: RFR: Mailing list filter rule generator / verifier [v3]
In-Reply-To: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
References: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
Message-ID: <SCkptiiYK0fWq2AVBCxk_E7zLbFBFe47S2MYObnxS4M=.be0c06fd-0db5-4d2c-a46f-992dd1ba35e4@github.com>

> Hi all,
> 
> Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list
> filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when
> figuring out on which list(s) a jdk pull request should be reviewed.  The idea is that this command can be used by
> knowledgeable OpenJDK developers to help improve the quality of the filter rules that will eventually end up being used
> when the jdk repository starts using pull requests. Examples of usage, together with an initial version of these filter
> rules, will be posted separately.  Best regards, Robin

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Fix test running problem

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/733/files
  - new: https://git.openjdk.java.net/skara/pull/733/files/01a83643..ef12979f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=733&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=733&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/733.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/733/head:pull/733

PR: https://git.openjdk.java.net/skara/pull/733

From rwestberg at openjdk.java.net  Mon Aug 24 12:34:49 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 12:34:49 GMT
Subject: RFR: Mailing list filter rule generator / verifier [v2]
In-Reply-To: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
References: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
Message-ID: <65bIFDAeYddbxYJza6kfyd_OawZgcBneqrKiCgJWx8g=.2ac9d7e9-03cb-4ab6-8e3b-b5653e0f63a3@github.com>

> Hi all,
> 
> Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list
> filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when
> figuring out on which list(s) a jdk pull request should be reviewed.  The idea is that this command can be used by
> knowledgeable OpenJDK developers to help improve the quality of the filter rules that will eventually end up being used
> when the jdk repository starts using pull requests. Examples of usage, together with an initial version of these filter
> rules, will be posted separately.  Best regards, Robin

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Create a debug subcategory of commands

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/733/files
  - new: https://git.openjdk.java.net/skara/pull/733/files/65d63c1f..01a83643

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=733&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=733&range=00-01

  Stats: 764 lines in 11 files changed: 475 ins; 278 del; 11 mod
  Patch: https://git.openjdk.java.net/skara/pull/733.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/733/head:pull/733

PR: https://git.openjdk.java.net/skara/pull/733

From ehelin at openjdk.java.net  Mon Aug 24 12:53:49 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 12:53:49 GMT
Subject: RFR: Mailing list filter rule generator / verifier [v3]
In-Reply-To: <SCkptiiYK0fWq2AVBCxk_E7zLbFBFe47S2MYObnxS4M=.be0c06fd-0db5-4d2c-a46f-992dd1ba35e4@github.com>
References: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
 <SCkptiiYK0fWq2AVBCxk_E7zLbFBFe47S2MYObnxS4M=.be0c06fd-0db5-4d2c-a46f-992dd1ba35e4@github.com>
Message-ID: <Uw_gTMz9d1PWsisP2I46Mp0Rcm7RSE4D462MvePzVPw=.e0cf96c1-8bd4-4d70-8ba0-7ae58b411c04@github.com>

On Mon, 24 Aug 2020 12:40:10 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list
>> filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when
>> figuring out on which list(s) a jdk pull request should be reviewed.  The idea is that this command can be used by
>> knowledgeable OpenJDK developers to help improve the quality of the filter rules that will eventually end up being used
>> when the jdk repository starts using pull requests. Examples of usage, together with an initial version of these filter
>> rules, will be posted separately.  Best regards, Robin
>
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix test running problem

Looks good in general! I would suggest renaming `GitDebug.java` to `SkaraDebug.java` (and `GitDebugHelp` to
`SkaraDebugHelp`). I also added a few minor inline comments.

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 38:

> 37:                 Command.name("import-hg")
> 38:                        .helptext("convert hg to git")
> 39:                        .main(GitOpenJDKImport::main),

Suggestion:

                       .helptext("import a hg repository")

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 41:

> 40:                 Command.name("import-git")
> 41:                        .helptext("convert git to hg")
> 42:                        .main(GitOpenJDKImport::main),

Suggestion:

                       .helptext("import git repository")

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 44:

> 43:                 Command.name("verify-import")
> 44:                        .helptext("verify hg to git")
> 45:                        .main(GitVerifyImport::main),

Suggestion:

                       .helptext("verify imported repository")

cli/src/main/java/org/openjdk/skara/cli/GitDebug.java line 53:

> 52:
> 53:         var parser = new MultiCommandParser("git debug", commands);
> 54:         var command = parser.parse(args);

Suggestion:

        var parser = new MultiCommandParser("skara debug", commands);

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/733

From ehelin at openjdk.java.net  Mon Aug 24 13:03:03 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 13:03:03 GMT
Subject: RFR: vcs: don't append newlines to tag messages
Message-ID: <tOkUS-zUfNQKrnUmQrt7ldpgJLCWc7muniecTAHKhRQ=.7d209b3b-c712-4932-a74f-2e49513835f0@github.com>

Hi all,

please review this small patch that ensures that neither git nor hg append any newlines to message used when creating
annotated tag objects.

Testing:
- [x] `make test` passes on Linux x64
- [x] Updated two unit tests

Thanks,
Erik

-------------

Commit messages:
 - vcs: don't append newlines to tag messages

Changes: https://git.openjdk.java.net/skara/pull/734/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=734&range=00
  Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/734.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/734/head:pull/734

PR: https://git.openjdk.java.net/skara/pull/734

From rwestberg at openjdk.java.net  Mon Aug 24 13:16:46 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 13:16:46 GMT
Subject: RFR: vcs: don't append newlines to tag messages
In-Reply-To: <tOkUS-zUfNQKrnUmQrt7ldpgJLCWc7muniecTAHKhRQ=.7d209b3b-c712-4932-a74f-2e49513835f0@github.com>
References: <tOkUS-zUfNQKrnUmQrt7ldpgJLCWc7muniecTAHKhRQ=.7d209b3b-c712-4932-a74f-2e49513835f0@github.com>
Message-ID: <nT7L-j_zJOIgyQelk2-83ALqR4FsqPGz1B8b7fzXX2w=.9aa65433-052e-4a06-a416-a7b4cd579f7d@github.com>

On Mon, 24 Aug 2020 13:00:30 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that ensures that neither git nor hg append any newlines to message used when creating
> annotated tag objects.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated two unit tests
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/734

From ehelin at openjdk.java.net  Mon Aug 24 13:16:47 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 13:16:47 GMT
Subject: Integrated: vcs: don't append newlines to tag messages
In-Reply-To: <tOkUS-zUfNQKrnUmQrt7ldpgJLCWc7muniecTAHKhRQ=.7d209b3b-c712-4932-a74f-2e49513835f0@github.com>
References: <tOkUS-zUfNQKrnUmQrt7ldpgJLCWc7muniecTAHKhRQ=.7d209b3b-c712-4932-a74f-2e49513835f0@github.com>
Message-ID: <bmzWmIvJjdGRwScKORRV0wpIK_exaIsaF3bmNCRbZbk=.2c9a6af8-cced-4db0-bacf-b452eb960b26@github.com>

On Mon, 24 Aug 2020 13:00:30 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that ensures that neither git nor hg append any newlines to message used when creating
> annotated tag objects.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated two unit tests
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 6c52d67a
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/6c52d67a
Stats:     4 lines in 3 files changed: 0 ins; 0 del; 4 mod

vcs: don't append newlines to tag messages

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/734

From ehelin at openjdk.java.net  Mon Aug 24 13:41:54 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 13:41:54 GMT
Subject: RFR: vcs: support setting dates for tags
Message-ID: <Ld3cpNTPbR9j2nPvdlt36x0oRE9OpYKLGH4R3aGW6bk=.90eac048-e3b7-4362-8505-ecd06401694c@github.com>

Hi all,

please review this patch that allows setting the date for tag objects.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - vcs: support setting dates for tags

Changes: https://git.openjdk.java.net/skara/pull/735/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=735&range=00
  Stats: 40 lines in 4 files changed: 32 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/skara/pull/735.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/735/head:pull/735

PR: https://git.openjdk.java.net/skara/pull/735

From rwestberg at openjdk.java.net  Mon Aug 24 14:36:20 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 14:36:20 GMT
Subject: RFR: vcs: support setting dates for tags
In-Reply-To: <Ld3cpNTPbR9j2nPvdlt36x0oRE9OpYKLGH4R3aGW6bk=.90eac048-e3b7-4362-8505-ecd06401694c@github.com>
References: <Ld3cpNTPbR9j2nPvdlt36x0oRE9OpYKLGH4R3aGW6bk=.90eac048-e3b7-4362-8505-ecd06401694c@github.com>
Message-ID: <H9kKiOtILXcs4q1_cW64TvnQurveEE0pAS7lK6hREvU=.5b79f536-b2ba-4f7a-b718-c6644488a984@github.com>

On Mon, 24 Aug 2020 13:39:11 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that allows setting the date for tag objects.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/735

From ehelin at openjdk.java.net  Mon Aug 24 14:56:09 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 14:56:09 GMT
Subject: Integrated: vcs: support setting dates for tags
In-Reply-To: <Ld3cpNTPbR9j2nPvdlt36x0oRE9OpYKLGH4R3aGW6bk=.90eac048-e3b7-4362-8505-ecd06401694c@github.com>
References: <Ld3cpNTPbR9j2nPvdlt36x0oRE9OpYKLGH4R3aGW6bk=.90eac048-e3b7-4362-8505-ecd06401694c@github.com>
Message-ID: <BAy3MIYCYNuO3CFsLH4BFNEHWm-ers6XXHvhBSx8Y0Y=.8900b1c1-2be6-43a8-a40c-fe3807257d99@github.com>

On Mon, 24 Aug 2020 13:39:11 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that allows setting the date for tag objects.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 26902724
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/26902724
Stats:     40 lines in 4 files changed: 0 ins; 32 del; 8 mod

vcs: support setting dates for tags

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/735

From ehelin at openjdk.java.net  Mon Aug 24 15:27:32 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 15:27:32 GMT
Subject: RFR: vcs: improve git->hg converter
Message-ID: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>

Hi all,

please review this patch that significantly improves the `GitToHgConverter`. The new converter handles all OpenJDK Git
repositories and also handles additional Git tags. I also improved the testing by quite a bit, the verification is much
more strict and I added a bunch of more tests. I also added some `@Disabled` tests (since they require an internet
connection), but they are still useful for running locally when working on the converter.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a number of new unit tests

Thanks,
Erik

-------------

Commit messages:
 - Remove trailing whitespace
 - vcs: improve GitToHgConverter

Changes: https://git.openjdk.java.net/skara/pull/736/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=736&range=00
  Stats: 379 lines in 3 files changed: 232 ins; 61 del; 86 mod
  Patch: https://git.openjdk.java.net/skara/pull/736.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/736/head:pull/736

PR: https://git.openjdk.java.net/skara/pull/736

From rwestberg at openjdk.java.net  Mon Aug 24 15:48:49 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 15:48:49 GMT
Subject: RFR: vcs: improve git->hg converter
In-Reply-To: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>
References: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>
Message-ID: <eqOGi1pJPNEm1BcUiVBMRt0p7T15puIShpBHy4qnU2E=.39f54f23-97fa-4082-9feb-093958a4bc74@github.com>

On Mon, 24 Aug 2020 15:19:41 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that significantly improves the `GitToHgConverter`. The new converter handles all OpenJDK Git
> repositories and also handles additional Git tags. I also improved the testing by quite a bit, the verification is much
> more strict and I added a bunch of more tests. I also added some `@Disabled` tests (since they require an internet
> connection), but they are still useful for running locally when working on the converter.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a number of new unit tests
> 
> Thanks,
> Erik

Looks good, just some minor comments!

vcs/src/test/java/org/openjdk/skara/vcs/openjdk/converter/GitToHgConverterTests.java line 46:

> 45:     void assertCommitEquals(ReadOnlyRepository gitRepo, Commit gitCommit, ReadOnlyRepository hgRepo, Commit
> hgCommit) throws IOException { 46:         System.out.println("git commit: " + gitCommit.hash() + ", hg commit: " +
> hgCommit.hash()); 47:         assertEquals(gitCommit.authored(), hgCommit.authored());

Debugging leftover?

vcs/src/test/java/org/openjdk/skara/vcs/openjdk/converter/GitToHgConverterTests.java line 473:

> 472:
> 473:     @Disabled("Depends on internet connection")
> 474:     @Test

There are similar tests for the bridge bot that are skipped if there is no connection:

https://github.com/openjdk/skara/blob/269027247e5c5778560d3031476dfd0ece4e57d3/bots/hgbridge/src/test/java/org/openjdk/skara/bots/hgbridge/BridgeBotTests.java#L131

but not sure if something similar would be appropriate here as well?

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/736

From ehelin at openjdk.java.net  Mon Aug 24 16:02:39 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 16:02:39 GMT
Subject: RFR: vcs: improve git->hg converter [v2]
In-Reply-To: <eqOGi1pJPNEm1BcUiVBMRt0p7T15puIShpBHy4qnU2E=.39f54f23-97fa-4082-9feb-093958a4bc74@github.com>
References: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>
 <eqOGi1pJPNEm1BcUiVBMRt0p7T15puIShpBHy4qnU2E=.39f54f23-97fa-4082-9feb-093958a4bc74@github.com>
Message-ID: <YleBN3Z0KvaXJXlBnLeH_vdzHNf6FGVTqLWwCEsrZ0E=.a37c5b41-6d1d-4983-b906-72d94df8300c@github.com>

On Mon, 24 Aug 2020 15:38:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove debug println
>
> vcs/src/test/java/org/openjdk/skara/vcs/openjdk/converter/GitToHgConverterTests.java line 46:
> 
>> 45:     void assertCommitEquals(ReadOnlyRepository gitRepo, Commit gitCommit, ReadOnlyRepository hgRepo, Commit
>> hgCommit) throws IOException { 46:         System.out.println("git commit: " + gitCommit.hash() + ", hg commit: " +
>> hgCommit.hash()); 47:         assertEquals(gitCommit.authored(), hgCommit.authored());
> 
> Debugging leftover?

Thanks, removed

> vcs/src/test/java/org/openjdk/skara/vcs/openjdk/converter/GitToHgConverterTests.java line 473:
> 
>> 472:
>> 473:     @Disabled("Depends on internet connection")
>> 474:     @Test
> 
> There are similar tests for the bridge bot that are skipped if there is no connection:
> 
> https://github.com/openjdk/skara/blob/269027247e5c5778560d3031476dfd0ece4e57d3/bots/hgbridge/src/test/java/org/openjdk/skara/bots/hgbridge/BridgeBotTests.java#L131
> 
> but not sure if something similar would be appropriate here as well?

Good idea, but these takes also takes a bit too long to run in addition to requiring an internet connection, so I would
prefer to leave them out for now. I might look into conditionally enable them depending on an environment variable so
that we can have them running in CI.

-------------

PR: https://git.openjdk.java.net/skara/pull/736

From ehelin at openjdk.java.net  Mon Aug 24 16:02:38 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 16:02:38 GMT
Subject: RFR: vcs: improve git->hg converter [v2]
In-Reply-To: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>
References: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>
Message-ID: <RSbEGB1uxg9niAj4qZXjsZYojz-eTsdVJpnfmMvpR30=.4363afc9-e1f5-4ebd-9219-65e4e09af04c@github.com>

> Hi all,
> 
> please review this patch that significantly improves the `GitToHgConverter`. The new converter handles all OpenJDK Git
> repositories and also handles additional Git tags. I also improved the testing by quite a bit, the verification is much
> more strict and I added a bunch of more tests. I also added some `@Disabled` tests (since they require an internet
> connection), but they are still useful for running locally when working on the converter.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a number of new unit tests
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  Remove debug println

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/736/files
  - new: https://git.openjdk.java.net/skara/pull/736/files/b957495a..28a0f36c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=736&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=736&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/736.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/736/head:pull/736

PR: https://git.openjdk.java.net/skara/pull/736

From ehelin at openjdk.java.net  Mon Aug 24 16:10:27 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 16:10:27 GMT
Subject: Integrated: vcs: improve git->hg converter
In-Reply-To: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>
References: <qUtaAaSFgcq9zEfA58I2sMUGUzrpCKI_uIlV_ml82Vk=.b3fcc072-42be-49bb-9cc2-cca77636d449@github.com>
Message-ID: <lWOQaSyzE_fSS6s1ppy3vBDh3YZYdeQFdkXJ91hwXfM=.7e2323e9-de56-47ec-a24a-538d8e93203d@github.com>

On Mon, 24 Aug 2020 15:19:41 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that significantly improves the `GitToHgConverter`. The new converter handles all OpenJDK Git
> repositories and also handles additional Git tags. I also improved the testing by quite a bit, the verification is much
> more strict and I added a bunch of more tests. I also added some `@Disabled` tests (since they require an internet
> connection), but they are still useful for running locally when working on the converter.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a number of new unit tests
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 4ba695f1
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/4ba695f1
Stats:     375 lines in 3 files changed: 58 ins; 228 del; 89 mod

vcs: improve git->hg converter

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/736

From ehelin at openjdk.java.net  Mon Aug 24 16:26:44 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 16:26:44 GMT
Subject: RFR: cli: skara debug import-git should always save marks
Message-ID: <gPa2lNNCsP1KQyZ8-sMCHk1T0pEcZbn1mhEknpHg0oE=.611d892c-3f45-405b-9a87-ca8f0cea3134@github.com>

Hi all,

please review this patch that makes `git skara debug import-git` always save the marks that were created as part of a
conversion, even though the conversion might have failed. This allows for incremental git imports.

Testing:
- [x] Manual testing on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - cli: hg-openjdk-import should always save marks

Changes: https://git.openjdk.java.net/skara/pull/737/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=737&range=00
  Stats: 35 lines in 2 files changed: 23 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/skara/pull/737.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/737/head:pull/737

PR: https://git.openjdk.java.net/skara/pull/737

From rwestberg at openjdk.java.net  Mon Aug 24 17:10:46 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 24 Aug 2020 17:10:46 GMT
Subject: RFR: cli: skara debug import-git should always save marks
In-Reply-To: <gPa2lNNCsP1KQyZ8-sMCHk1T0pEcZbn1mhEknpHg0oE=.611d892c-3f45-405b-9a87-ca8f0cea3134@github.com>
References: <gPa2lNNCsP1KQyZ8-sMCHk1T0pEcZbn1mhEknpHg0oE=.611d892c-3f45-405b-9a87-ca8f0cea3134@github.com>
Message-ID: <Q2YiMqjxOuzIDwgtkujtAwO9bghp7rQNhRGREx_D6KE=.0187053d-2685-4b35-90eb-3314bac894ad@github.com>

On Mon, 24 Aug 2020 16:23:47 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `git skara debug import-git` always save the marks that were created as part of a
> conversion, even though the conversion might have failed. This allows for incremental git imports.
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/737

From ehelin at openjdk.java.net  Mon Aug 24 18:08:29 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 24 Aug 2020 18:08:29 GMT
Subject: Integrated: cli: skara debug import-git should always save marks
In-Reply-To: <gPa2lNNCsP1KQyZ8-sMCHk1T0pEcZbn1mhEknpHg0oE=.611d892c-3f45-405b-9a87-ca8f0cea3134@github.com>
References: <gPa2lNNCsP1KQyZ8-sMCHk1T0pEcZbn1mhEknpHg0oE=.611d892c-3f45-405b-9a87-ca8f0cea3134@github.com>
Message-ID: <Wcbh1KiNAfzRM5grgNN72jlGF1Ii_3Gza7fKzLjgaHw=.c7a7a6f0-9f95-48c8-afb9-77412b9896fa@github.com>

On Mon, 24 Aug 2020 16:23:47 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `git skara debug import-git` always save the marks that were created as part of a
> conversion, even though the conversion might have failed. This allows for incremental git imports.
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: d3a1d032
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/d3a1d032
Stats:     35 lines in 2 files changed: 0 ins; 23 del; 12 mod

cli: skara debug import-git should always save marks

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/737

From ehelin at openjdk.java.net  Tue Aug 25 10:40:14 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 10:40:14 GMT
Subject: RFR: hg: use --template instead of ext.py for metadata
Message-ID: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>

Hi all,

please review this patch that makes `HgRepository.commitMetadata` use `--template` instead of `ext.py` for generating
the metadata.

Testing:
- [x] `make test` passes on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - hg: use --template instead of ext.py for metadata

Changes: https://git.openjdk.java.net/skara/pull/739/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=739&range=00
  Stats: 43 lines in 2 files changed: 33 ins; 3 del; 7 mod
  Patch: https://git.openjdk.java.net/skara/pull/739.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/739/head:pull/739

PR: https://git.openjdk.java.net/skara/pull/739

From rwestberg at openjdk.java.net  Tue Aug 25 10:40:15 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 25 Aug 2020 10:40:15 GMT
Subject: RFR: hg: use --template instead of ext.py for metadata
In-Reply-To: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
References: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
Message-ID: <mHms3hpI3aiY5mIvJ-rXWIwQJNKtnQuehlkHqV4Kqo4=.5c59e874-0cc7-4a23-bdf3-aa7b6e064ecc@github.com>

On Tue, 25 Aug 2020 10:35:39 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `HgRepository.commitMetadata` use `--template` instead of `ext.py` for generating
> the metadata.
> Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/739

From ehelin at openjdk.java.net  Tue Aug 25 12:37:41 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 12:37:41 GMT
Subject: RFR: hg: use --template instead of ext.py for metadata [v2]
In-Reply-To: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
References: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
Message-ID: <kmUtUEWNPWcHf5TRm7Q015ClhtdGnYenEhWMQQCxEA4=.9d2e6d56-070f-4f6d-9970-f6e3c4d0c078@github.com>

> Hi all,
> 
> please review this patch that makes `HgRepository.commitMetadata` use `--template` instead of `ext.py` for generating
> the metadata.
> Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  actions: update to Ubuntu 20.04

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/739/files
  - new: https://git.openjdk.java.net/skara/pull/739/files/4b359a5a..f6db5f1a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=739&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=739&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/739.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/739/head:pull/739

PR: https://git.openjdk.java.net/skara/pull/739

From duke at openjdk.java.net  Tue Aug 25 14:45:18 2020
From: duke at openjdk.java.net (duke)
Date: Tue, 25 Aug 2020 14:45:18 GMT
Subject: git: openjdk/skara: actions: Use explicit versions of OS environments
Message-ID: <22184164-cb51-419c-9e4d-197a922ba23f@openjdk.java.net>

Changeset: 87141a35
Author:    Robin Westberg <robin.westberg at oracle.com>
Committer: GitHub <noreply at github.com>
Date:      2020-08-25 16:45:11 +0000
URL:       https://git.openjdk.java.net/skara/commit/87141a35

actions: Use explicit versions of OS environments

! .github/workflows/ci.yml


From ehelin at openjdk.java.net  Tue Aug 25 15:05:06 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 15:05:06 GMT
Subject: RFR: hg: use --template instead of ext.py for metadata [v3]
In-Reply-To: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
References: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
Message-ID: <ZMFf3q5P23mWgMPLADu89UMWNkDqs9pLZKbnsfr0X3Y=.704bfdc0-0c25-418d-a2f3-6907eab85875@github.com>

> Hi all,
> 
> please review this patch that makes `HgRepository.commitMetadata` use `--template` instead of `ext.py` for generating
> the metadata.
> Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains one commit:

  hg: use --template instead of ext.py for metadata

-------------

Changes: https://git.openjdk.java.net/skara/pull/739/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=739&range=02
  Stats: 43 lines in 2 files changed: 33 ins; 3 del; 7 mod
  Patch: https://git.openjdk.java.net/skara/pull/739.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/739/head:pull/739

PR: https://git.openjdk.java.net/skara/pull/739

From ehelin at openjdk.java.net  Tue Aug 25 15:05:08 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 15:05:08 GMT
Subject: Integrated: hg: use --template instead of ext.py for metadata
In-Reply-To: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
References: <sYXC42dm_NI7Ms5aWRJJ5QNWzXV2xeD9hVTeIypCc0A=.1fe8beb4-07da-4a44-914f-21761da7bb81@github.com>
Message-ID: <fE-Rkb7zG0o4gLpekIvw9pjXUOmcvj2_5oU8CPIICjw=.0aec7127-3fbb-4263-a35a-3594099b3571@github.com>

On Tue, 25 Aug 2020 10:35:39 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `HgRepository.commitMetadata` use `--template` instead of `ext.py` for generating
> the metadata.
> Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: d6a5ab49
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/d6a5ab49
Stats:     43 lines in 2 files changed: 3 ins; 33 del; 7 mod

hg: use --template instead of ext.py for metadata

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/739

From ehelin at openjdk.java.net  Tue Aug 25 15:10:17 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 15:10:17 GMT
Subject: RFR: vcs: add method ReadOnlyRepository.follow
Message-ID: <xd1MNVNiFPU8bxTG3l5TH2XNScH9QMSKKzCZ36uZ2eY=.8fc804cd-e2f5-42e3-a729-30635172b572@github.com>

Hi all,

please review this patch that adds the method `ReadOnlyRepository.follow` for getting all commits that changed a
particular file.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - vcs: add method ReadOnlyRepository.follow

Changes: https://git.openjdk.java.net/skara/pull/740/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=740&range=00
  Stats: 131 lines in 4 files changed: 103 ins; 26 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/740.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/740/head:pull/740

PR: https://git.openjdk.java.net/skara/pull/740

From rwestberg at openjdk.java.net  Tue Aug 25 15:10:17 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 25 Aug 2020 15:10:17 GMT
Subject: RFR: vcs: add method ReadOnlyRepository.follow
In-Reply-To: <xd1MNVNiFPU8bxTG3l5TH2XNScH9QMSKKzCZ36uZ2eY=.8fc804cd-e2f5-42e3-a729-30635172b572@github.com>
References: <xd1MNVNiFPU8bxTG3l5TH2XNScH9QMSKKzCZ36uZ2eY=.8fc804cd-e2f5-42e3-a729-30635172b572@github.com>
Message-ID: <niFy7gD6nEoeSFVG_lcZoB_tFxojWA04Ni5iebmPwZY=.4f53d040-f42a-47d8-9e6c-bbacac9c6e0f@github.com>

On Tue, 25 Aug 2020 15:05:13 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the method `ReadOnlyRepository.follow` for getting all commits that changed a
> particular file.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/740

From ehelin at openjdk.java.net  Tue Aug 25 15:20:50 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 15:20:50 GMT
Subject: RFR: vcs: add method ReadOnlyRepository.follow [v2]
In-Reply-To: <xd1MNVNiFPU8bxTG3l5TH2XNScH9QMSKKzCZ36uZ2eY=.8fc804cd-e2f5-42e3-a729-30635172b572@github.com>
References: <xd1MNVNiFPU8bxTG3l5TH2XNScH9QMSKKzCZ36uZ2eY=.8fc804cd-e2f5-42e3-a729-30635172b572@github.com>
Message-ID: <kJpTW_QKPvEmLnXAT5mjOJgUnkzSFlco4bD15nSgzyo=.1344d089-4775-42d7-bd8d-4bea43acd112@github.com>

> Hi all,
> 
> please review this patch that adds the method `ReadOnlyRepository.follow` for getting all commits that changed a
> particular file.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  Fix tests

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/740/files
  - new: https://git.openjdk.java.net/skara/pull/740/files/56466073..c3abb8e7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=740&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=740&range=00-01

  Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/740.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/740/head:pull/740

PR: https://git.openjdk.java.net/skara/pull/740

From ehelin at openjdk.java.net  Tue Aug 25 15:20:50 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 15:20:50 GMT
Subject: Integrated: vcs: add method ReadOnlyRepository.follow
In-Reply-To: <xd1MNVNiFPU8bxTG3l5TH2XNScH9QMSKKzCZ36uZ2eY=.8fc804cd-e2f5-42e3-a729-30635172b572@github.com>
References: <xd1MNVNiFPU8bxTG3l5TH2XNScH9QMSKKzCZ36uZ2eY=.8fc804cd-e2f5-42e3-a729-30635172b572@github.com>
Message-ID: <0SkWlg_OIO5Og9cUeBoi2vArT9hYnKxlAr8mGnqy2Ms=.833c069e-2f98-4b05-a0ca-0948eafa85ac@github.com>

On Tue, 25 Aug 2020 15:05:13 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the method `ReadOnlyRepository.follow` for getting all commits that changed a
> particular file.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 05d9d69b
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/05d9d69b
Stats:     139 lines in 5 files changed: 26 ins; 111 del; 2 mod

vcs: add method ReadOnlyRepository.follow

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/740

From ehelin at openjdk.java.net  Tue Aug 25 15:42:54 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 15:42:54 GMT
Subject: RFR: webrev: follow files for commits.json
Message-ID: <dpjDQIEKJfjkxEfpQJsJlKB50VChA3rD_CdfmjnOAvM=.21f004fa-2074-4363-ad40-cd1cb6061c0f@github.com>

Hi all,

please review this patch that updates `Webrev.generateJSON` to use `ReadOnlyRepository.follow` for getting commit
metadata.

Testing:
- [x] `make test` passes on Linux x64
- [x] Manual testing on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - webrev: follow files for commits.json

Changes: https://git.openjdk.java.net/skara/pull/741/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=741&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/741.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/741/head:pull/741

PR: https://git.openjdk.java.net/skara/pull/741

From rwestberg at openjdk.java.net  Tue Aug 25 15:47:28 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 25 Aug 2020 15:47:28 GMT
Subject: RFR: webrev: follow files for commits.json
In-Reply-To: <dpjDQIEKJfjkxEfpQJsJlKB50VChA3rD_CdfmjnOAvM=.21f004fa-2074-4363-ad40-cd1cb6061c0f@github.com>
References: <dpjDQIEKJfjkxEfpQJsJlKB50VChA3rD_CdfmjnOAvM=.21f004fa-2074-4363-ad40-cd1cb6061c0f@github.com>
Message-ID: <y_paLRks1gNEDYO2GQ9_ru6-eL6vQ6pKi4LkvM266u8=.8e9a2bad-3085-4ea7-bc63-d209c956cbb1@github.com>

On Tue, 25 Aug 2020 15:40:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates `Webrev.generateJSON` to use `ReadOnlyRepository.follow` for getting commit
> metadata.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks great!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/741

From ehelin at openjdk.java.net  Tue Aug 25 15:55:39 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 15:55:39 GMT
Subject: Integrated: webrev: follow files for commits.json
In-Reply-To: <dpjDQIEKJfjkxEfpQJsJlKB50VChA3rD_CdfmjnOAvM=.21f004fa-2074-4363-ad40-cd1cb6061c0f@github.com>
References: <dpjDQIEKJfjkxEfpQJsJlKB50VChA3rD_CdfmjnOAvM=.21f004fa-2074-4363-ad40-cd1cb6061c0f@github.com>
Message-ID: <Ap_yDR3UvoiZG0Ay9XgNnTidkf3s3jrTSIw8HYf9txk=.9358a7a3-f6bc-45ba-9b8c-e4f509b0e89d@github.com>

On Tue, 25 Aug 2020 15:40:14 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates `Webrev.generateJSON` to use `ReadOnlyRepository.follow` for getting commit
> metadata.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 5459a0b4
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/5459a0b4
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

webrev: follow files for commits.json

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/741

From rwestberg at openjdk.java.net  Tue Aug 25 16:53:43 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 25 Aug 2020 16:53:43 GMT
Subject: RFR: Initial mailing list mapping rules for the jdk repository
Message-ID: <_8i6daHZtK8_2f-s7lchFB15gGz7xR9eCfOpF7B-ukc=.3e999195-c804-478e-a2d0-258b7498ccd8@github.com>

Hi all,

This is an initial version of the mailing list mapping rules that will be used after the main jdk repository
transitions to Git and starts accepting pull requests. This is not the final location of this list (currently it is
part of a bot configuration file, but could conceivably also reside in the jdk repository itself) - but in order to
improve it I am going to ask for help from knowledgeable JDK contributors to refine the rules for areas that they are
interested in. Using the Skara repository to coordinate such updates seems reasonable.

This initial version has been created by looking at reviews for existing commits and matching them with a review on a
mailing list. That list has then been adjusted manually by applying the generated rules to existing commits, and
checking if they actually match the lists that were used for reviewing them.

Finally I've also applied the rules found at https://openjdk.java.net/groups/2d/2dawtfiles.html (thanks @prrace!)  and
I suspect that similar lists exists for many more parts of the JDK, but perhaps not written down. So this is the expert
knowledge I am looking for!

When the initial version has been integrated, I'll send out a separate email with more details on how it can be used
and tested.

Best regards,
Robin

-------------

Commit messages:
 - Updated file location
 - Initial version

Changes: https://git.openjdk.java.net/skara/pull/738/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=738&range=00
  Stats: 867 lines in 1 file changed: 867 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/738.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/738/head:pull/738

PR: https://git.openjdk.java.net/skara/pull/738

From ehelin at openjdk.java.net  Tue Aug 25 16:53:43 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 25 Aug 2020 16:53:43 GMT
Subject: RFR: Initial mailing list mapping rules for the jdk repository
In-Reply-To: <_8i6daHZtK8_2f-s7lchFB15gGz7xR9eCfOpF7B-ukc=.3e999195-c804-478e-a2d0-258b7498ccd8@github.com>
References: <_8i6daHZtK8_2f-s7lchFB15gGz7xR9eCfOpF7B-ukc=.3e999195-c804-478e-a2d0-258b7498ccd8@github.com>
Message-ID: <q1Z1FpDoSFXFSi6Dn8o625SuFAq7OaTVSb4Oi1J8xRk=.fbc2ed0b-cfd0-4e7b-b526-c8c1ba082249@github.com>

On Tue, 25 Aug 2020 09:30:51 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> This is an initial version of the mailing list mapping rules that will be used after the main jdk repository
> transitions to Git and starts accepting pull requests. This is not the final location of this list (currently it is
> part of a bot configuration file, but could conceivably also reside in the jdk repository itself) - but in order to
> improve it I am going to ask for help from knowledgeable JDK contributors to refine the rules for areas that they are
> interested in. Using the Skara repository to coordinate such updates seems reasonable.  This initial version has been
> created by looking at reviews for existing commits and matching them with a review on a mailing list. That list has
> then been adjusted manually by applying the generated rules to existing commits, and checking if they actually match
> the lists that were used for reviewing them.   Finally I've also applied the rules found at
> https://openjdk.java.net/groups/2d/2dawtfiles.html (thanks @prrace!)  and I suspect that similar lists exists for many
> more parts of the JDK, but perhaps not written down. So this is the expert knowledge I am looking for!  When the
> initial version has been integrated, I'll send out a separate email with more details on how it can be used and
> tested.  Best regards, Robin

I can't comment on the details of the rules, but looks good to me in general ??

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/738

From rwestberg at openjdk.java.net  Tue Aug 25 16:54:27 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 25 Aug 2020 16:54:27 GMT
Subject: Integrated: Mailing list filter rule generator / verifier
In-Reply-To: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
References: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
Message-ID: <XN5o9bkdpbLgeNf5QdysYe-2wP76n0s29B7zC8PI3-4=.ebc0c710-2552-4bef-8f2d-9a1000dde126@github.com>

On Mon, 24 Aug 2020 10:48:22 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list
> filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when
> figuring out on which list(s) a jdk pull request should be reviewed.  The idea is that this command can be used by
> knowledgeable OpenJDK developers to help improve the quality of the filter rules that will eventually end up being used
> when the jdk repository starts using pull requests. Examples of usage, together with an initial version of these filter
> rules, will be posted separately.  Best regards, Robin

This pull request has now been integrated.

Changeset: 71e10af2
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/71e10af2
Stats:     1294 lines in 11 files changed: 140 ins; 1147 del; 7 mod

Mailing list filter rule generator / verifier

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/733

From rwestberg at openjdk.java.net  Tue Aug 25 16:54:25 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 25 Aug 2020 16:54:25 GMT
Subject: RFR: Mailing list filter rule generator / verifier [v4]
In-Reply-To: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
References: <nmU1FWglPnkSdyqFujIJMelmZuyj5udxG1WleLQAk4w=.aecb3184-3d06-411c-b94a-f0031b73d340@github.com>
Message-ID: <wfxPNgUhH7rB6SPPTa-BrC06-U-ZEB7wshV1wDfO8K0=.9da0374c-9631-4369-8252-60cbbd915e71@github.com>

> Hi all,
> 
> Please review this change that introduces the "mlrules" command, which can be used to generate and verify mailing list
> filter rules for the jdk/jdk family of development mailing lists. These filter rules can be used by the Skara bots when
> figuring out on which list(s) a jdk pull request should be reviewed.  The idea is that this command can be used by
> knowledgeable OpenJDK developers to help improve the quality of the filter rules that will eventually end up being used
> when the jdk repository starts using pull requests. Examples of usage, together with an initial version of these filter
> rules, will be posted separately.  Best regards, Robin

Robin Westberg has updated the pull request incrementally with three additional commits since the last revision:

 - Updated after review
 - Apply suggestions from code review
   
   Co-authored-by: Erik Duveblad <erik.helin at oracle.com>
 - Update cli/src/main/java/org/openjdk/skara/cli/GitDebug.java
   
   Co-authored-by: Erik Duveblad <erik.helin at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/733/files
  - new: https://git.openjdk.java.net/skara/pull/733/files/ef12979f..ff1ec229

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=733&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=733&range=02-03

  Stats: 116 lines in 4 files changed: 57 ins; 57 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/733.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/733/head:pull/733

PR: https://git.openjdk.java.net/skara/pull/733

From kcr at openjdk.java.net  Tue Aug 25 17:44:31 2020
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Tue, 25 Aug 2020 17:44:31 GMT
Subject: RFR: Initial mailing list mapping rules for the jdk repository
In-Reply-To: <q1Z1FpDoSFXFSi6Dn8o625SuFAq7OaTVSb4Oi1J8xRk=.fbc2ed0b-cfd0-4e7b-b526-c8c1ba082249@github.com>
References: <_8i6daHZtK8_2f-s7lchFB15gGz7xR9eCfOpF7B-ukc=.3e999195-c804-478e-a2d0-258b7498ccd8@github.com>
 <q1Z1FpDoSFXFSi6Dn8o625SuFAq7OaTVSb4Oi1J8xRk=.fbc2ed0b-cfd0-4e7b-b526-c8c1ba082249@github.com>
Message-ID: <rZ2PqNChcFa4QPD4TvPmIGE5I2numM5C-Akk216qMoE=.38c0cfec-a2a1-4811-9182-e319bd5d8892@github.com>

On Tue, 25 Aug 2020 09:43:41 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> This is an initial version of the mailing list mapping rules that will be used after the main jdk repository
>> transitions to Git and starts accepting pull requests. This is not the final location of this list (currently it is
>> part of a bot configuration file, but could conceivably also reside in the jdk repository itself) - but in order to
>> improve it I am going to ask for help from knowledgeable JDK contributors to refine the rules for areas that they are
>> interested in. Using the Skara repository to coordinate such updates seems reasonable.  This initial version has been
>> created by looking at reviews for existing commits and matching them with a review on a mailing list. That list has
>> then been adjusted manually by applying the generated rules to existing commits, and checking if they actually match
>> the lists that were used for reviewing them.   Finally I've also applied the rules found at
>> https://openjdk.java.net/groups/2d/2dawtfiles.html (thanks @prrace!)  and I suspect that similar lists exists for many
>> more parts of the JDK, but perhaps not written down. So this is the expert knowledge I am looking for!  When the
>> initial version has been integrated, I'll send out a separate email with more details on how it can be used and
>> tested.  Best regards, Robin
>
> I can't comment on the details of the rules, but looks good to me in general ??

What rules will be used for new files that don't match any of the existing patterns? For example, if a new package is
added to `java.desktop`, where will the RFR go?

Does the logic support adding a later more general pattern that will only be used if an earlier more specific pattern
isn't matched? In that case, it would be possible to add a `src/java.desktop` (for example) that is sent to one of the
client aliases (whichever Phil thinks is the best default) as a "catch all" for anything that is missed by the specific
set of patterns.

-------------

PR: https://git.openjdk.java.net/skara/pull/738

From rwestberg at openjdk.java.net  Wed Aug 26 07:31:57 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 26 Aug 2020 07:31:57 GMT
Subject: RFR: Store target hash before potentially fetching the ref
Message-ID: <eOUEXQ_Z8HlazJ0auO_3euMf3O2Wv4w1uFyscYMPg1I=.29bb0432-c789-4d7a-b37b-b4c2cda8923e@github.com>

Hi all,

Please review this change that determines the hash of the target ref for a PR before returning the ref. This ensures
that subsequently fetching the ref contains the hash (barring concurrent force pushes to the target ref, which should
never happen).

Best regards,
Robin

-------------

Commit messages:
 - Store target hash before potentially fetching the ref

Changes: https://git.openjdk.java.net/skara/pull/742/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=742&range=00
  Stats: 21 lines in 2 files changed: 17 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/742.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/742/head:pull/742

PR: https://git.openjdk.java.net/skara/pull/742

From ehelin at openjdk.java.net  Wed Aug 26 09:57:19 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 26 Aug 2020 09:57:19 GMT
Subject: RFR: bots: add checkout bot
Message-ID: <Sr4p1hV8AA5erpip35ZbTs_Pin3rRNXL8S8-fZBIzhc=.f7a3f656-e9fc-4b6e-ab58-85790c396e63@github.com>

Hi all,

please review this patch that adds a new bot called "checkout". The bot can checkout a remote Git repository to a local
Hg repository using the recently improved `GitToHgConverter`. I also added two new unit tests for verifying the
functionality.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added two new unit tests

Thanks,
Erik

-------------

Commit messages:
 - bots: add checkout bot

Changes: https://git.openjdk.java.net/skara/pull/743/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=743&range=00
  Stats: 429 lines in 8 files changed: 423 ins; 1 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/743.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/743/head:pull/743

PR: https://git.openjdk.java.net/skara/pull/743

From ehelin at openjdk.java.net  Wed Aug 26 10:20:41 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 26 Aug 2020 10:20:41 GMT
Subject: RFR: Store target hash before potentially fetching the ref
In-Reply-To: <eOUEXQ_Z8HlazJ0auO_3euMf3O2Wv4w1uFyscYMPg1I=.29bb0432-c789-4d7a-b37b-b4c2cda8923e@github.com>
References: <eOUEXQ_Z8HlazJ0auO_3euMf3O2Wv4w1uFyscYMPg1I=.29bb0432-c789-4d7a-b37b-b4c2cda8923e@github.com>
Message-ID: <aVl63-WrOnonYvOG_2FQG8RcJI443cnujRdtaJiu4W4=.e3de9565-b3f4-4395-8ebd-e8345384b3a8@github.com>

On Wed, 26 Aug 2020 07:29:24 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that determines the hash of the target ref for a PR before returning the ref. This ensures
> that subsequently fetching the ref contains the hash (barring concurrent force pushes to the target ref, which should
> never happen).  Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/742

From rwestberg at openjdk.java.net  Wed Aug 26 11:48:23 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 26 Aug 2020 11:48:23 GMT
Subject: RFR: bots: add checkout bot
In-Reply-To: <Sr4p1hV8AA5erpip35ZbTs_Pin3rRNXL8S8-fZBIzhc=.f7a3f656-e9fc-4b6e-ab58-85790c396e63@github.com>
References: <Sr4p1hV8AA5erpip35ZbTs_Pin3rRNXL8S8-fZBIzhc=.f7a3f656-e9fc-4b6e-ab58-85790c396e63@github.com>
Message-ID: <ZVZ6-wXDQ8wYcWjEHMwddeZsfHv_6BEs46rVh_hNHAk=.e8b160e3-803c-4b2e-a50d-a4ea17f5b6b3@github.com>

On Wed, 26 Aug 2020 09:54:31 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds a new bot called "checkout". The bot can checkout a remote Git repository to a local
> Hg repository using the recently improved `GitToHgConverter`. I also added two new unit tests for verifying the
> functionality.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added two new unit tests
> 
> Thanks,
> Erik

Looks great!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/743

From rwestberg at openjdk.java.net  Wed Aug 26 11:50:03 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 26 Aug 2020 11:50:03 GMT
Subject: Integrated: Store target hash before potentially fetching the ref
In-Reply-To: <eOUEXQ_Z8HlazJ0auO_3euMf3O2Wv4w1uFyscYMPg1I=.29bb0432-c789-4d7a-b37b-b4c2cda8923e@github.com>
References: <eOUEXQ_Z8HlazJ0auO_3euMf3O2Wv4w1uFyscYMPg1I=.29bb0432-c789-4d7a-b37b-b4c2cda8923e@github.com>
Message-ID: <jbtJ387rjQ0lAgHbhiciAZGh0NKoWUM-omFLuQQvLG0=.95912b95-f3a2-41fd-a300-efdc4b949b7a@github.com>

On Wed, 26 Aug 2020 07:29:24 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that determines the hash of the target ref for a PR before returning the ref. This ensures
> that subsequently fetching the ref contains the hash (barring concurrent force pushes to the target ref, which should
> never happen).  Best regards,
> Robin

This pull request has now been integrated.

Changeset: 089215dc
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/089215dc
Stats:     21 lines in 2 files changed: 0 ins; 17 del; 4 mod

Store target hash before potentially fetching the ref

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/742

From rwestberg at openjdk.java.net  Wed Aug 26 12:00:04 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 26 Aug 2020 12:00:04 GMT
Subject: RFR: Initial mailing list mapping rules for the jdk repository
In-Reply-To: <rZ2PqNChcFa4QPD4TvPmIGE5I2numM5C-Akk216qMoE=.38c0cfec-a2a1-4811-9182-e319bd5d8892@github.com>
References: <_8i6daHZtK8_2f-s7lchFB15gGz7xR9eCfOpF7B-ukc=.3e999195-c804-478e-a2d0-258b7498ccd8@github.com>
 <q1Z1FpDoSFXFSi6Dn8o625SuFAq7OaTVSb4Oi1J8xRk=.fbc2ed0b-cfd0-4e7b-b526-c8c1ba082249@github.com>
 <rZ2PqNChcFa4QPD4TvPmIGE5I2numM5C-Akk216qMoE=.38c0cfec-a2a1-4811-9182-e319bd5d8892@github.com>
Message-ID: <OOcDjddUm-Fq3dmVAhw3mSgtBCJuzhJ3EMBQBeKjfIw=.82b86f76-c026-46b8-9f7f-cd9240fc5f17@github.com>

On Tue, 25 Aug 2020 17:42:22 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I can't comment on the details of the rules, but looks good to me in general ??
>
> What rules will be used for new files that don't match any of the existing patterns? For example, if a new package is
> added to `java.desktop`, where will the RFR go?
> Does the logic support adding a later more general pattern that will only be used if an earlier more specific pattern
> isn't matched? In that case, it would be possible to add a `src/java.desktop` (for example) that is sent to one of the
> client aliases (whichever Phil thinks is the best default) as a "catch all" for anything that is missed by the specific
> set of patterns.

The rules should ideally be written in a form that will match unknown files, for example like this `java.desktop` one
for `awt-dev`:

"src/java.desktop/share/classes/sun/awt/(?!font|sunhints|color/|font/|geom/|im/|image/|print/)",

It's written to be complementary to other rules (in `2d-dev` and `i18n-dev` in this case) so that it matches
anything *not* followed by these specific folder names.

In the case that nothing matches, it will currently log an error that the Skara admins can investigate and hopefully
improve the list. But in the future it is probably a good idea to add a specific category of rules that are used if
none of these specific ones matches. But I'm hoping the first approach will help improve the quality of the primary
filters to begin with.

-------------

PR: https://git.openjdk.java.net/skara/pull/738

From rwestberg at openjdk.java.net  Wed Aug 26 13:35:58 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 26 Aug 2020 13:35:58 GMT
Subject: RFR: 466: Exception during sponsored integration
Message-ID: <gNkT8pYGk3topur9BWNHKV1XnSXtk3E8pfYQHEIgqCQ=.0289a1b4-2b20-4e63-81a4-dcd8b35becf9@github.com>

Hi all,

Please review this change that serializes integrations (per repository), to avoid unnecessary push failures when the
`/integrate` command has been issued in multiple PRs around the same time.

Best regards,
Robin

-------------

Commit messages:
 - Initial implementation

Changes: https://git.openjdk.java.net/skara/pull/744/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=744&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-466
  Stats: 154 lines in 5 files changed: 147 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/skara/pull/744.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/744/head:pull/744

PR: https://git.openjdk.java.net/skara/pull/744

From ehelin at openjdk.java.net  Wed Aug 26 14:02:42 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 26 Aug 2020 14:02:42 GMT
Subject: Integrated: bots: add checkout bot
In-Reply-To: <Sr4p1hV8AA5erpip35ZbTs_Pin3rRNXL8S8-fZBIzhc=.f7a3f656-e9fc-4b6e-ab58-85790c396e63@github.com>
References: <Sr4p1hV8AA5erpip35ZbTs_Pin3rRNXL8S8-fZBIzhc=.f7a3f656-e9fc-4b6e-ab58-85790c396e63@github.com>
Message-ID: <mq16LDWX2NvxCMJLN9_juUaKHPFXV2VWqbGZVgCWdWs=.5fd5f8a9-cf65-4e26-91e3-555909b3f982@github.com>

On Wed, 26 Aug 2020 09:54:31 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds a new bot called "checkout". The bot can checkout a remote Git repository to a local
> Hg repository using the recently improved `GitToHgConverter`. I also added two new unit tests for verifying the
> functionality.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added two new unit tests
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 90bb6406
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/90bb6406
Stats:     502 lines in 8 files changed: 0 ins; 501 del; 1 mod

bots: add checkout bot

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/743

From ehelin at openjdk.java.net  Wed Aug 26 14:29:11 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 26 Aug 2020 14:29:11 GMT
Subject: RFR: 466: Exception during sponsored integration
In-Reply-To: <gNkT8pYGk3topur9BWNHKV1XnSXtk3E8pfYQHEIgqCQ=.0289a1b4-2b20-4e63-81a4-dcd8b35becf9@github.com>
References: <gNkT8pYGk3topur9BWNHKV1XnSXtk3E8pfYQHEIgqCQ=.0289a1b4-2b20-4e63-81a4-dcd8b35becf9@github.com>
Message-ID: <JN5_7hrOiHk5AZJjwgZSpDQV9WyS7bWlFs9t3EThPhc=.8e0232c5-32b4-4fed-a531-6ab9682873e0@github.com>

On Wed, 26 Aug 2020 13:32:46 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that serializes integrations (per repository), to avoid unnecessary push failures when the
> `/integrate` command has been issued in multiple PRs around the same time.
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/744

From rwestberg at openjdk.java.net  Wed Aug 26 15:04:22 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 26 Aug 2020 15:04:22 GMT
Subject: Integrated: 466: Exception during sponsored integration
In-Reply-To: <gNkT8pYGk3topur9BWNHKV1XnSXtk3E8pfYQHEIgqCQ=.0289a1b4-2b20-4e63-81a4-dcd8b35becf9@github.com>
References: <gNkT8pYGk3topur9BWNHKV1XnSXtk3E8pfYQHEIgqCQ=.0289a1b4-2b20-4e63-81a4-dcd8b35becf9@github.com>
Message-ID: <yDri12lHtZuevrzpk-E7W-nfs9zrSeDeXHNcPyTGGr4=.e5bfe790-caa6-43c8-a35e-b41280db2346@github.com>

On Wed, 26 Aug 2020 13:32:46 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that serializes integrations (per repository), to avoid unnecessary push failures when the
> `/integrate` command has been issued in multiple PRs around the same time.
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: 2851535e
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/2851535e
Stats:     154 lines in 5 files changed: 0 ins; 147 del; 7 mod

466: Exception during sponsored integration
528: Exception during integration

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/744

From rwestberg at openjdk.java.net  Wed Aug 26 15:43:00 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 26 Aug 2020 15:43:00 GMT
Subject: Integrated: Initial mailing list mapping rules for the jdk repository
In-Reply-To: <_8i6daHZtK8_2f-s7lchFB15gGz7xR9eCfOpF7B-ukc=.3e999195-c804-478e-a2d0-258b7498ccd8@github.com>
References: <_8i6daHZtK8_2f-s7lchFB15gGz7xR9eCfOpF7B-ukc=.3e999195-c804-478e-a2d0-258b7498ccd8@github.com>
Message-ID: <x1G4aC397yRBt0vEumiU4Yuvp4CExnGnqMTg2m6nU-U=.72836479-d722-450c-935a-08997c55db46@github.com>

On Tue, 25 Aug 2020 09:30:51 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> This is an initial version of the mailing list mapping rules that will be used after the main jdk repository
> transitions to Git and starts accepting pull requests. This is not the final location of this list (currently it is
> part of a bot configuration file, but could conceivably also reside in the jdk repository itself) - but in order to
> improve it I am going to ask for help from knowledgeable JDK contributors to refine the rules for areas that they are
> interested in. Using the Skara repository to coordinate such updates seems reasonable.  This initial version has been
> created by looking at reviews for existing commits and matching them with a review on a mailing list. That list has
> then been adjusted manually by applying the generated rules to existing commits, and checking if they actually match
> the lists that were used for reviewing them.   Finally I've also applied the rules found at
> https://openjdk.java.net/groups/2d/2dawtfiles.html (thanks @prrace!)  and I suspect that similar lists exists for many
> more parts of the JDK, but perhaps not written down. So this is the expert knowledge I am looking for!  When the
> initial version has been integrated, I'll send out a separate email with more details on how it can be used and
> tested.  Best regards, Robin

This pull request has now been integrated.

Changeset: 0d9698bd
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/0d9698bd
Stats:     867 lines in 1 file changed: 0 ins; 867 del; 0 mod

Initial mailing list mapping rules for the jdk repository

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/738

From ehelin at openjdk.java.net  Wed Aug 26 18:42:47 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 26 Aug 2020 18:42:47 GMT
Subject: RFR: checkout bot: use full path for marks files
Message-ID: <sD_AA2PboPSIIZnjGWARFS1ZTzYfiMlzUAS7Pu8QWVk=.6b2dab1a-73f8-40a8-82d7-a014b17fc718@github.com>

Hi all,

please review this small fix that makes the checkout bot use the full path of the from repo as the name for the marks
file. I also had to update `HostedRepositoryStorage` to cope with files in directories.

Testing:
- [x] `make test` passes on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - checkout bot: use full path for marks files

Changes: https://git.openjdk.java.net/skara/pull/745/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=745&range=00
  Stats: 4 lines in 3 files changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/745.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/745/head:pull/745

PR: https://git.openjdk.java.net/skara/pull/745

From rwestberg at openjdk.java.net  Thu Aug 27 04:07:11 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 27 Aug 2020 04:07:11 GMT
Subject: RFR: checkout bot: use full path for marks files
In-Reply-To: <sD_AA2PboPSIIZnjGWARFS1ZTzYfiMlzUAS7Pu8QWVk=.6b2dab1a-73f8-40a8-82d7-a014b17fc718@github.com>
References: <sD_AA2PboPSIIZnjGWARFS1ZTzYfiMlzUAS7Pu8QWVk=.6b2dab1a-73f8-40a8-82d7-a014b17fc718@github.com>
Message-ID: <d1s5yNv4iC-dKNn2evaV0fB5LlySJ966FhEMJu3NacQ=.19e461fc-75a8-4263-be21-1d71e056517a@github.com>

On Wed, 26 Aug 2020 18:39:58 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small fix that makes the checkout bot use the full path of the from repo as the name for the marks
> file. I also had to update `HostedRepositoryStorage` to cope with files in directories.
> Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/745

From ehelin at openjdk.java.net  Thu Aug 27 05:09:01 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 27 Aug 2020 05:09:01 GMT
Subject: Integrated: checkout bot: use full path for marks files
In-Reply-To: <sD_AA2PboPSIIZnjGWARFS1ZTzYfiMlzUAS7Pu8QWVk=.6b2dab1a-73f8-40a8-82d7-a014b17fc718@github.com>
References: <sD_AA2PboPSIIZnjGWARFS1ZTzYfiMlzUAS7Pu8QWVk=.6b2dab1a-73f8-40a8-82d7-a014b17fc718@github.com>
Message-ID: <NOqNEaCVz436QXwi4zY00dYUJljdf8j6Sstjou9z4MY=.8c00d9aa-7ebe-4496-8088-63ac352734e3@github.com>

On Wed, 26 Aug 2020 18:39:58 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small fix that makes the checkout bot use the full path of the from repo as the name for the marks
> file. I also had to update `HostedRepositoryStorage` to cope with files in directories.
> Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 8a2d11c6
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/8a2d11c6
Stats:     4 lines in 3 files changed: 0 ins; 2 del; 2 mod

checkout bot: use full path for marks files

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/745

From rwestberg at openjdk.java.net  Thu Aug 27 11:44:35 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 27 Aug 2020 11:44:35 GMT
Subject: RFR: mlrules: applying off-list suggestions
Message-ID: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>

Hi all,

In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)

Best regards,
Robin

-------------

Commit messages:
 - Remove jdwp from core-libs, remove nio-dev duplicates (alanb)
 - Simplify src/java.net.http (dfuchs)

Changes: https://git.openjdk.java.net/skara/pull/746/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=00
  Stats: 11 lines in 1 file changed: 0 ins; 10 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/746.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/746/head:pull/746

PR: https://git.openjdk.java.net/skara/pull/746

From alanb at openjdk.java.net  Thu Aug 27 11:54:10 2020
From: alanb at openjdk.java.net (Alan Bateman)
Date: Thu, 27 Aug 2020 11:54:10 GMT
Subject: RFR: mlrules: applying off-list suggestions
In-Reply-To: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
Message-ID: <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>

On Thu, 27 Aug 2020 11:42:03 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
> Best regards,
> Robin

Thanks, looks good!

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From weijun at openjdk.java.net  Thu Aug 27 12:44:17 2020
From: weijun at openjdk.java.net (Weijun Wang)
Date: Thu, 27 Aug 2020 12:44:17 GMT
Subject: RFR: Update jdk.json
Message-ID: <OFVCQLOltEpNR1In3EpO2YUVDN5wZFfuLObV6F2GDl8=.e5439309-e97a-4e70-b159-ef4c12fa77d5@github.com>

Add two lines and expand one.

-------------

Commit messages:
 - Update jdk.json

Changes: https://git.openjdk.java.net/skara/pull/747/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=747&range=00
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/747.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/747/head:pull/747

PR: https://git.openjdk.java.net/skara/pull/747

From jlahoda at openjdk.java.net  Thu Aug 27 14:09:37 2020
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Thu, 27 Aug 2020 14:09:37 GMT
Subject: RFR: Updates to config/mailinglist/rules/jdk.json related to
 compiler-dev =?UTF-8?B?4oCm?=
Message-ID: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>

?and kulla-dev.

I tried to keep the sensible stuff, sending to multiple lists where in a real doubt. Some other javac/javadoc
maintainers may disagree with some of the choices, though.

-------------

Commit messages:
 - Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev.

Changes: https://git.openjdk.java.net/skara/pull/748/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=748&range=00
  Stats: 75 lines in 1 file changed: 8 ins; 63 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/748.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/748/head:pull/748

PR: https://git.openjdk.java.net/skara/pull/748

From jlahoda at openjdk.java.net  Thu Aug 27 14:09:40 2020
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Thu, 27 Aug 2020 14:09:40 GMT
Subject: RFR: Updates to config/mailinglist/rules/jdk.json related to
 compiler-dev =?UTF-8?B?4oCm?=
In-Reply-To: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>
References: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>
Message-ID: <ffhnVSfnEVnx8NisNSu3VsyDPdXNkumMoPprICDVfaA=.cf39521c-0fbb-4ab8-841a-afd5bb6a2da6@github.com>

On Thu, 27 Aug 2020 14:05:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> ?and kulla-dev.
> 
> I tried to keep the sensible stuff, sending to multiple lists where in a real doubt. Some other javac/javadoc
> maintainers may disagree with some of the choices, though.

config/mailinglist/rules/jdk.json line 123:

> 122:             "make/scripts/generate-symbol-data.sh",
> 123:             "src/java.base/share/classes/jdk/internal/PreviewFeature.java",
> 124:             "src/java.compiler/",

I think this shows the question on maintenance from the jdk-dev list - the (internal) PreviewFeature may be moved to a
different (internal) place sometime in the foreseeable future. Who will be updating this list?

-------------

PR: https://git.openjdk.java.net/skara/pull/748

From ehelin at openjdk.java.net  Thu Aug 27 15:16:00 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 27 Aug 2020 15:16:00 GMT
Subject: RFR: mlrules: applying off-list suggestions
In-Reply-To: <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>
Message-ID: <WuNg-Y4uk-bmhghGg2VQSHp5-tUxerykx3csYplHJH8=.5d22fd45-e7fa-435a-b561-eaa47af6c014@github.com>

On Thu, 27 Aug 2020 11:51:59 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Hi all,
>> 
>> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
>> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
>> Best regards,
>> Robin
>
> Thanks, looks good!

I got the feedback from a build-dev maintainer off-list that the following for build-dev:
            "bin/idea.sh",
            "bin/jib.sh",
            "bin/unshuffle_list.txt",
            "configure",
            "doc/building.html",
            "doc/building.md",
            "doc/ide.html",
            "doc/ide.md",
            "doc/testing.html",
            "doc/testing.md",
can be simplified to just:
             "bin/",
             "doc/",

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From ehelin at openjdk.java.net  Thu Aug 27 17:08:41 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 27 Aug 2020 17:08:41 GMT
Subject: RFR: mlrules: applying off-list suggestions
In-Reply-To: <WuNg-Y4uk-bmhghGg2VQSHp5-tUxerykx3csYplHJH8=.5d22fd45-e7fa-435a-b561-eaa47af6c014@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>
 <WuNg-Y4uk-bmhghGg2VQSHp5-tUxerykx3csYplHJH8=.5d22fd45-e7fa-435a-b561-eaa47af6c014@github.com>
Message-ID: <gqUMI2L2LbHn_Af_1LJu6sUYS8SkODaqdubSe6pXXz4=.a69474a2-6b2c-4ced-b4dc-31e1f7720cb3@github.com>

On Thu, 27 Aug 2020 15:13:54 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Thanks, looks good!
>
> I got the feedback from a build-dev maintainer off-list that the following for build-dev:
>             "bin/idea.sh",
>             "bin/jib.sh",
>             "bin/unshuffle_list.txt",
>             "configure",
>             "doc/building.html",
>             "doc/building.md",
>             "doc/ide.html",
>             "doc/ide.md",
>             "doc/testing.html",
>             "doc/testing.md",
> can be simplified to just:
>              "bin/",
>              "doc/",

Comment from GC maintainer regarding hotspot-gc-dev - change:
"src/hotspot/share/memory/(heap|oop)",
into
"src/hotspot/share/memory/oop",

The files `src/hotspot/share/memory/heap.{hpp,cpp}` actually for the code heap (and are thus most often reviewed on
hotspot-compiler-dev). As a GC reviewer I should have caught this too ??

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From david.holmes at oracle.com  Fri Aug 28 00:26:46 2020
From: david.holmes at oracle.com (David Holmes)
Date: Fri, 28 Aug 2020 10:26:46 +1000
Subject: Email subject line formatting
In-Reply-To: <3b83157d-3570-129f-d4a7-028c6872885d@oracle.com>
References: <3b83157d-3570-129f-d4a7-028c6872885d@oracle.com>
Message-ID: <7f585de8-a702-f06d-db53-40f49b4db6a0@oracle.com>

As the transition to git/skara is now imminent I wanted to re-raise this 
issue and find out exactly how the email processes will be setup for the 
mainline JDK project - ie what subject will be used in the various cases.

Thanks,
David

On 7/04/2020 9:21 am, David Holmes wrote:
> Hi everyone,
> 
> Erik asked me to raise this here to see if anyone else is bothered by 
> this ...
> 
> When an integration email is sent the subject line of the RFR thread is 
> augmented with [integrated] and also adorned with "Re:" as if a reply to 
> the RFR thread e.g.
> 
> Re: [Integrated] [foreign-abi] RFR: Revert "JDK-8242127: reorganize 
> ABI-dependent layout constants"
> 
> My objection to this is that once the subject has been augmented with 
> [Integrated] it is not appropriate to treat that as a "reply" and use 
> the "Re:". If I see:
> 
> [Integrated] [foreign-abi] RFR: Revert "JDK-8242127: reorganize 
> ABI-dependent layout constants"
> 
> I know its a changeset notification email and I can ignore it. Just as I 
> can ignore:
> 
> git: openjdk/panama-foreign: foreign-jextract: 2 new changesets
> 
> or
> 
> hg: jdk/jdk: 8242217: Shenandoah: Enable GC mode to be 
> diagnostic/experimental and have a name
> 
> but when I see the "Re:" I think "oh someone is commenting on that push, 
> there must be an issue and I should read the email" - which is the case 
> with current hg notification emails!
> 
> This would be less of an issue if the sender of the integration email 
> was a bot account but it isn't, it is the committer.
> 
> So I'd like to suggest that the "Re:" be dropped from the subject line 
> of these automatically generated integration emails.
> 
> Cheers,
> David

From ehelin at openjdk.java.net  Fri Aug 28 08:00:42 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 28 Aug 2020 08:00:42 GMT
Subject: RFR: mlrules: applying off-list suggestions
In-Reply-To: <gqUMI2L2LbHn_Af_1LJu6sUYS8SkODaqdubSe6pXXz4=.a69474a2-6b2c-4ced-b4dc-31e1f7720cb3@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>
 <WuNg-Y4uk-bmhghGg2VQSHp5-tUxerykx3csYplHJH8=.5d22fd45-e7fa-435a-b561-eaa47af6c014@github.com>
 <gqUMI2L2LbHn_Af_1LJu6sUYS8SkODaqdubSe6pXXz4=.a69474a2-6b2c-4ced-b4dc-31e1f7720cb3@github.com>
Message-ID: <j5FBuCf-dRRFkC1XwjxmpHY920X5yeifmBza-TGr5Dw=.921a2aec-da69-4665-81c8-4df534842e4c@github.com>

On Thu, 27 Aug 2020 17:06:32 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> I got the feedback from a build-dev maintainer off-list that the following for build-dev:
>>             "bin/idea.sh",
>>             "bin/jib.sh",
>>             "bin/unshuffle_list.txt",
>>             "configure",
>>             "doc/building.html",
>>             "doc/building.md",
>>             "doc/ide.html",
>>             "doc/ide.md",
>>             "doc/testing.html",
>>             "doc/testing.md",
>> can be simplified to just:
>>              "bin/",
>>              "doc/",
>
> Comment from GC maintainer regarding hotspot-gc-dev - change:
> "src/hotspot/share/memory/(heap|oop)",
> into
> "src/hotspot/share/memory/oop",
> 
> The files `src/hotspot/share/memory/heap.{hpp,cpp}` actually for the code heap (and are thus most often reviewed on
> hotspot-compiler-dev). As a GC reviewer I should have caught this too ??

I received the following feedback regarding `hotspot-compiler-dev` - change:
src/jdk.aot/share/classes/jdk.tools.jaotc
into just
src/jdk.aot/
and add the following files:
src/hotspot/share/runtime/icache.cpp
src/hotspot/share/runtime/icache.hpp
src/hotspot/share/runtime/registerMap.hpp
src/hotspot/share/runtime/sharedRuntime.cpp
src/hotspot/share/runtime/sharedRuntime.hpp
src/hotspot/share/runtime/sharedRuntimeMath.hpp
src/hotspot/share/runtime/sharedRuntimeTrans.cpp
src/hotspot/share/runtime/sharedRuntimeTrig.cpp
src/hotspot/share/runtime/stubCodeGenerator.hpp
src/hotspot/share/runtime/sweeper.cpp
src/hotspot/share/runtime/sweeper.hpp
src/hotspot/share/runtime/vframe.cpp
src/hotspot/share/runtime/vframe.hpp
src/hotspot/share/runtime/vframe.inline.hpp
src/hotspot/share/runtime/vframeArray.cpp
src/hotspot/share/runtime/vframeArray.hpp
src/hotspot/share/runtime/vframe_hp.cpp
src/hotspot/share/runtime/vframe_hp.hpp
As stated in another comment, the following files should also be for `hotspot-compiler-dev`:
src/hotspot/share/memory/heap.hpp
src/hotspot/share/memory/heap.inline.hpp
src/hotspot/share/memory/heap.cpp

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From rwestberg at openjdk.java.net  Fri Aug 28 08:52:01 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 08:52:01 GMT
Subject: RFR: Update jdk.json
In-Reply-To: <OFVCQLOltEpNR1In3EpO2YUVDN5wZFfuLObV6F2GDl8=.e5439309-e97a-4e70-b159-ef4c12fa77d5@github.com>
References: <OFVCQLOltEpNR1In3EpO2YUVDN5wZFfuLObV6F2GDl8=.e5439309-e97a-4e70-b159-ef4c12fa77d5@github.com>
Message-ID: <_Qf7CtoU6fytbxM6ZpqMt9WTIOjXx-TbSggor8v9xOI=.887a0a54-701d-4e26-a87a-6df18837f2d9@github.com>

On Thu, 27 Aug 2020 12:41:42 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> Add two lines and expand one.

Thanks for the update!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/747

From rwestberg at openjdk.java.net  Fri Aug 28 08:59:27 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 08:59:27 GMT
Subject: RFR: 542: Adjust label (cc) command logic
Message-ID: <vhuOO_M_nlPq7ZIeoAnxwGFzSswZ2NgtAW6zffVL6uE=.9382732f-680c-4cf1-aae4-275be8e04677@github.com>

Hi all,

Please review this change that adjusts how the `/labels` (or `/cc`) command works, details in the issue.

Best regards,
Robin

-------------

Commit messages:
 - Initial implementation

Changes: https://git.openjdk.java.net/skara/pull/749/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=749&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-542
  Stats: 210 lines in 7 files changed: 169 ins; 19 del; 22 mod
  Patch: https://git.openjdk.java.net/skara/pull/749.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/749/head:pull/749

PR: https://git.openjdk.java.net/skara/pull/749

From ehelin at openjdk.java.net  Fri Aug 28 09:56:50 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 28 Aug 2020 09:56:50 GMT
Subject: RFR: 542: Adjust label (cc) command logic
In-Reply-To: <vhuOO_M_nlPq7ZIeoAnxwGFzSswZ2NgtAW6zffVL6uE=.9382732f-680c-4cf1-aae4-275be8e04677@github.com>
References: <vhuOO_M_nlPq7ZIeoAnxwGFzSswZ2NgtAW6zffVL6uE=.9382732f-680c-4cf1-aae4-275be8e04677@github.com>
Message-ID: <rgx_k2xlbF3jWpisVSQyPsjXtILHItL0EWe4UiRrfQU=.861aa8db-b2a7-4445-a76b-0fddd2a3ec77@github.com>

On Fri, 28 Aug 2020 08:56:43 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that adjusts how the `/labels` (or `/cc`) command works, details in the issue.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/749

From rwestberg at openjdk.java.net  Fri Aug 28 10:02:53 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 10:02:53 GMT
Subject: RFR: 542: Adjust label (cc) command logic [v2]
In-Reply-To: <vhuOO_M_nlPq7ZIeoAnxwGFzSswZ2NgtAW6zffVL6uE=.9382732f-680c-4cf1-aae4-275be8e04677@github.com>
References: <vhuOO_M_nlPq7ZIeoAnxwGFzSswZ2NgtAW6zffVL6uE=.9382732f-680c-4cf1-aae4-275be8e04677@github.com>
Message-ID: <sahMoljpSSntzp5U-kDmGrcprn92HUBZmK9dt4JdtiQ=.7c98f142-4088-468a-97de-40afcaca7954@github.com>

> Hi all,
> 
> Please review this change that adjusts how the `/labels` (or `/cc`) command works, details in the issue.
> 
> Best regards,
> Robin

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Fix failing test

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/749/files
  - new: https://git.openjdk.java.net/skara/pull/749/files/39ce0d44..3dd145e2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=749&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=749&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/749.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/749/head:pull/749

PR: https://git.openjdk.java.net/skara/pull/749

From ehelin at openjdk.java.net  Fri Aug 28 10:37:50 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 28 Aug 2020 10:37:50 GMT
Subject: RFR: mlrules: applying off-list suggestions
In-Reply-To: <j5FBuCf-dRRFkC1XwjxmpHY920X5yeifmBza-TGr5Dw=.921a2aec-da69-4665-81c8-4df534842e4c@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>
 <WuNg-Y4uk-bmhghGg2VQSHp5-tUxerykx3csYplHJH8=.5d22fd45-e7fa-435a-b561-eaa47af6c014@github.com>
 <gqUMI2L2LbHn_Af_1LJu6sUYS8SkODaqdubSe6pXXz4=.a69474a2-6b2c-4ced-b4dc-31e1f7720cb3@github.com>
 <j5FBuCf-dRRFkC1XwjxmpHY920X5yeifmBza-TGr5Dw=.921a2aec-da69-4665-81c8-4df534842e4c@github.com>
Message-ID: <3S6faJhG7qdY2TbGbE5jHInYyFcYFcxZMIlC0O6Mu7U=.47dcc6a4-3198-423f-b22e-3bea95a9e433@github.com>

On Fri, 28 Aug 2020 07:58:37 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Comment from GC maintainer regarding hotspot-gc-dev - change:
>> "src/hotspot/share/memory/(heap|oop)",
>> into
>> "src/hotspot/share/memory/oop",
>> 
>> The files `src/hotspot/share/memory/heap.{hpp,cpp}` actually for the code heap (and are thus most often reviewed on
>> hotspot-compiler-dev). As a GC reviewer I should have caught this too ??
>
> I received the following feedback regarding `hotspot-compiler-dev` - change:
> src/jdk.aot/share/classes/jdk.tools.jaotc
> into just
> src/jdk.aot/
> and add the following files:
> src/hotspot/share/runtime/icache.cpp
> src/hotspot/share/runtime/icache.hpp
> src/hotspot/share/runtime/registerMap.hpp
> src/hotspot/share/runtime/sharedRuntime.cpp
> src/hotspot/share/runtime/sharedRuntime.hpp
> src/hotspot/share/runtime/sharedRuntimeMath.hpp
> src/hotspot/share/runtime/sharedRuntimeTrans.cpp
> src/hotspot/share/runtime/sharedRuntimeTrig.cpp
> src/hotspot/share/runtime/stubCodeGenerator.hpp
> src/hotspot/share/runtime/sweeper.cpp
> src/hotspot/share/runtime/sweeper.hpp
> src/hotspot/share/runtime/vframe.cpp
> src/hotspot/share/runtime/vframe.hpp
> src/hotspot/share/runtime/vframe.inline.hpp
> src/hotspot/share/runtime/vframeArray.cpp
> src/hotspot/share/runtime/vframeArray.hpp
> src/hotspot/share/runtime/vframe_hp.cpp
> src/hotspot/share/runtime/vframe_hp.hpp
> As stated in another comment, the following files should also be for `hotspot-compiler-dev`:
> src/hotspot/share/memory/heap.hpp
> src/hotspot/share/memory/heap.inline.hpp
> src/hotspot/share/memory/heap.cpp

Additional suggestion to add the following for "jdk-dev":
README.md
CONTRIBUTING.md
LICENSE
ASSEMBLY_EXCEPTION
ADDITIONAL_LICENSE_INFO

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From ehelin at openjdk.java.net  Fri Aug 28 10:44:22 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 28 Aug 2020 10:44:22 GMT
Subject: RFR: mlrules: applying off-list suggestions
In-Reply-To: <3S6faJhG7qdY2TbGbE5jHInYyFcYFcxZMIlC0O6Mu7U=.47dcc6a4-3198-423f-b22e-3bea95a9e433@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>
 <WuNg-Y4uk-bmhghGg2VQSHp5-tUxerykx3csYplHJH8=.5d22fd45-e7fa-435a-b561-eaa47af6c014@github.com>
 <gqUMI2L2LbHn_Af_1LJu6sUYS8SkODaqdubSe6pXXz4=.a69474a2-6b2c-4ced-b4dc-31e1f7720cb3@github.com>
 <j5FBuCf-dRRFkC1XwjxmpHY920X5yeifmBza-TGr5Dw=.921a2aec-da69-4665-81c8-4df534842e4c@github.com>
 <3S6faJhG7qdY2TbGbE5jHInYyFcYFcxZMIlC0O6Mu7U=.47dcc6a4-3198-423f-b22e-3bea95a9e433@github.com>
Message-ID: <t65V2VN_Qz80G3ypfr68PetRDLM7TJ7Oa7Ec-qIJ8gs=.46cb834f-08b2-4d69-b17a-3df4da6fcd47@github.com>

On Fri, 28 Aug 2020 10:35:47 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> I received the following feedback regarding `hotspot-compiler-dev` - change:
>> src/jdk.aot/share/classes/jdk.tools.jaotc
>> into just
>> src/jdk.aot/
>> and add the following files:
>> src/hotspot/share/runtime/icache.cpp
>> src/hotspot/share/runtime/icache.hpp
>> src/hotspot/share/runtime/registerMap.hpp
>> src/hotspot/share/runtime/sharedRuntime.cpp
>> src/hotspot/share/runtime/sharedRuntime.hpp
>> src/hotspot/share/runtime/sharedRuntimeMath.hpp
>> src/hotspot/share/runtime/sharedRuntimeTrans.cpp
>> src/hotspot/share/runtime/sharedRuntimeTrig.cpp
>> src/hotspot/share/runtime/stubCodeGenerator.hpp
>> src/hotspot/share/runtime/sweeper.cpp
>> src/hotspot/share/runtime/sweeper.hpp
>> src/hotspot/share/runtime/vframe.cpp
>> src/hotspot/share/runtime/vframe.hpp
>> src/hotspot/share/runtime/vframe.inline.hpp
>> src/hotspot/share/runtime/vframeArray.cpp
>> src/hotspot/share/runtime/vframeArray.hpp
>> src/hotspot/share/runtime/vframe_hp.cpp
>> src/hotspot/share/runtime/vframe_hp.hpp
>> As stated in another comment, the following files should also be for `hotspot-compiler-dev`:
>> src/hotspot/share/memory/heap.hpp
>> src/hotspot/share/memory/heap.inline.hpp
>> src/hotspot/share/memory/heap.cpp
>
> Additional suggestion to add the following for "jdk-dev":
> README.md
> CONTRIBUTING.md
> LICENSE
> ASSEMBLY_EXCEPTION
> ADDITIONAL_LICENSE_INFO

Furthermore, please drop the `-dev` suffix from the labels, that can be inferred ??

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From rwestberg at openjdk.java.net  Fri Aug 28 10:44:51 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 10:44:51 GMT
Subject: Integrated: 542: Adjust label (cc) command logic
In-Reply-To: <vhuOO_M_nlPq7ZIeoAnxwGFzSswZ2NgtAW6zffVL6uE=.9382732f-680c-4cf1-aae4-275be8e04677@github.com>
References: <vhuOO_M_nlPq7ZIeoAnxwGFzSswZ2NgtAW6zffVL6uE=.9382732f-680c-4cf1-aae4-275be8e04677@github.com>
Message-ID: <kU1PsNUeXiqDHXieDORWxIH1Zf1L4gGzubM3rcBqfCY=.395d52d4-221d-4aee-8e4c-3847ee6b1cf9@github.com>

On Fri, 28 Aug 2020 08:56:43 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that adjusts how the `/labels` (or `/cc`) command works, details in the issue.
> 
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: aca34396
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/aca34396
Stats:     211 lines in 8 files changed: 19 ins; 169 del; 23 mod

542: Adjust label (cc) command logic

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/749

From rwestberg at openjdk.java.net  Fri Aug 28 10:51:03 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 10:51:03 GMT
Subject: RFR: Updates to config/mailinglist/rules/jdk.json related to
 compiler-dev =?UTF-8?B?4oCm?=
In-Reply-To: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>
References: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>
Message-ID: <N2OELRpOf4-S5PB5WqzzC2uKrEgh1IRyFoPEjFjUhnc=.2131e570-2340-4b02-8996-abb615b77793@github.com>

On Thu, 27 Aug 2020 14:05:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> ?and kulla-dev.
> 
> I tried to keep the sensible stuff, sending to multiple lists where in a real doubt. Some other javac/javadoc
> maintainers may disagree with some of the choices, though.

Thanks for the update!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/748

From rwestberg at openjdk.java.net  Fri Aug 28 10:51:03 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 10:51:03 GMT
Subject: RFR: Updates to config/mailinglist/rules/jdk.json related to
 compiler-dev =?UTF-8?B?4oCm?=
In-Reply-To: <ffhnVSfnEVnx8NisNSu3VsyDPdXNkumMoPprICDVfaA=.cf39521c-0fbb-4ab8-841a-afd5bb6a2da6@github.com>
References: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>
 <ffhnVSfnEVnx8NisNSu3VsyDPdXNkumMoPprICDVfaA=.cf39521c-0fbb-4ab8-841a-afd5bb6a2da6@github.com>
Message-ID: <CDsD7OWOO_rpoBlLRC52Nt-kE5jotnxY5uGkPdOTvsg=.9ae264f0-24bf-47a3-8c17-20f44e987add@github.com>

On Thu, 27 Aug 2020 14:07:20 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> ?and kulla-dev.
>> 
>> I tried to keep the sensible stuff, sending to multiple lists where in a real doubt. Some other javac/javadoc
>> maintainers may disagree with some of the choices, though.
>
> config/mailinglist/rules/jdk.json line 123:
> 
>> 122:             "make/scripts/generate-symbol-data.sh",
>> 123:             "src/java.base/share/classes/jdk/internal/PreviewFeature.java",
>> 124:             "src/java.compiler/",
> 
> I think this shows the question on maintenance from the jdk-dev list - the (internal) PreviewFeature may be moved to a
> different (internal) place sometime in the foreseeable future. Who will be updating this list?

When in doubt, I think it's better to err on the side of caution, so perhaps it should not be included in the list at
all. But will expand on this in the jdk-dev thread.

-------------

PR: https://git.openjdk.java.net/skara/pull/748

From rwestberg at openjdk.java.net  Fri Aug 28 11:10:02 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 11:10:02 GMT
Subject: RFR: mlrules: applying off-list suggestions [v2]
In-Reply-To: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
Message-ID: <xi-VcQ_vZjoyoll0jXLZV_zmGpkyLRQkPN82xNHmnIw=.9e1b469f-612b-48f0-96f2-6cefc5dae7ad@github.com>

> Hi all,
> 
> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
> Best regards,
> Robin

Robin Westberg has updated the pull request incrementally with five additional commits since the last revision:

 - Drop the -dev suffix
 - Non-build-related files in the root folder to jdk-dev
 - Updates for hotspot-compiler
 - Simplify gc-dev rules
 - Simplify build-dev rules

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/746/files
  - new: https://git.openjdk.java.net/skara/pull/746/files/3abc6bad..22117120

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=00-01

  Stats: 58 lines in 1 file changed: 4 ins; 19 del; 35 mod
  Patch: https://git.openjdk.java.net/skara/pull/746.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/746/head:pull/746

PR: https://git.openjdk.java.net/skara/pull/746

From ehelin at openjdk.java.net  Fri Aug 28 11:20:31 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 28 Aug 2020 11:20:31 GMT
Subject: RFR: mlrules: applying off-list suggestions
In-Reply-To: <t65V2VN_Qz80G3ypfr68PetRDLM7TJ7Oa7Ec-qIJ8gs=.46cb834f-08b2-4d69-b17a-3df4da6fcd47@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <tLYKf_M610hzieybXSSXqmTsw8YRNsGU9qRzNJ1vs5s=.47a61512-4ea7-4de1-87e9-6ef1248e9c5e@github.com>
 <WuNg-Y4uk-bmhghGg2VQSHp5-tUxerykx3csYplHJH8=.5d22fd45-e7fa-435a-b561-eaa47af6c014@github.com>
 <gqUMI2L2LbHn_Af_1LJu6sUYS8SkODaqdubSe6pXXz4=.a69474a2-6b2c-4ced-b4dc-31e1f7720cb3@github.com>
 <j5FBuCf-dRRFkC1XwjxmpHY920X5yeifmBza-TGr5Dw=.921a2aec-da69-4665-81c8-4df534842e4c@github.com>
 <3S6faJhG7qdY2TbGbE5jHInYyFcYFcxZMIlC0O6Mu7U=.47dcc6a4-3198-423f-b22e-3bea95a9e433@github.com>
 <t65V2VN_Qz80G3ypfr68PetRDLM7TJ7Oa7Ec-qIJ8gs=.46cb834f-08b2-4d69-b17a-3df4da6fcd47@github.com>
Message-ID: <gD6HubGSxtEmLZ1k29ELBKfNEdsqVVnFYf8dn4s9LJ8=.1cefed73-7f8e-4617-ab06-500378f19332@github.com>

On Fri, 28 Aug 2020 10:42:09 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Additional suggestion to add the following for "jdk-dev":
>> README.md
>> CONTRIBUTING.md
>> LICENSE
>> ASSEMBLY_EXCEPTION
>> ADDITIONAL_LICENSE_INFO
>
> Furthermore, please drop the `-dev` suffix from the labels, that can be inferred ??

I think the Shenandoah project want `shenandoah-dev` to be CC:d for changes to files in
`src/hotspot/share/gc/shenandoah`. See https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2020-August/030527.html
for the source.

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From rwestberg at openjdk.java.net  Fri Aug 28 11:28:22 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 11:28:22 GMT
Subject: RFR: mlrules: applying off-list suggestions [v3]
In-Reply-To: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
Message-ID: <fAITNlwFXhN4PTkMtBsmQNTGAW0lrSOZgkGP5JbwTpk=.c482e5f6-3121-438b-9be7-62f3a40580c8@github.com>

> Hi all,
> 
> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
> Best regards,
> Robin

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Add initial set of rules for shenandoah

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/746/files
  - new: https://git.openjdk.java.net/skara/pull/746/files/22117120..9b5e62a5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=01-02

  Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/746.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/746/head:pull/746

PR: https://git.openjdk.java.net/skara/pull/746

From rwestberg at openjdk.java.net  Fri Aug 28 11:54:35 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 11:54:35 GMT
Subject: RFR: mlrules: applying off-list suggestions [v4]
In-Reply-To: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
Message-ID: <iDVbUy3b9BZN4kx1hbNxiggALUCIzHTX7w0XY9-diM4=.e58fa378-9814-4878-be2f-31c7d75c0392@github.com>

> Hi all,
> 
> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
> Best regards,
> Robin

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Simplify nio rules

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/746/files
  - new: https://git.openjdk.java.net/skara/pull/746/files/9b5e62a5..ba7c299a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=02-03

  Stats: 13 lines in 1 file changed: 0 ins; 11 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/746.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/746/head:pull/746

PR: https://git.openjdk.java.net/skara/pull/746

From jlahoda at openjdk.java.net  Fri Aug 28 11:56:29 2020
From: jlahoda at openjdk.java.net (Jan Lahoda)
Date: Fri, 28 Aug 2020 11:56:29 GMT
Subject: Integrated: Updates to config/mailinglist/rules/jdk.json related to
 compiler-dev and kulla-dev.
In-Reply-To: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>
References: <TixuIRvbmNom771qskI9obyea8vO034a15ZFNE7dacw=.17ade5b4-9f7f-4ad0-875c-c19b11b9e7fb@github.com>
Message-ID: <mVucigxUj1L9On8dMasJrfDkhGpEZByNWtR6x_gjw04=.4a750547-0420-40e4-9abb-1f967b7ecbfb@github.com>

On Thu, 27 Aug 2020 14:05:47 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> ?and kulla-dev.
> 
> I tried to keep the sensible stuff, sending to multiple lists where in a real doubt. Some other javac/javadoc
> maintainers may disagree with some of the choices, though.

This pull request has now been integrated.

Changeset: 92a97993
Author:    Jan Lahoda <jlahoda at openjdk.org>
Committer: Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/92a97993
Stats:     75 lines in 1 file changed: 63 ins; 8 del; 4 mod

Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev.

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/748

From ehelin at openjdk.java.net  Fri Aug 28 13:05:39 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 28 Aug 2020 13:05:39 GMT
Subject: RFR: git-pr-create: be explicit about CC:d mailing lists
Message-ID: <_LDbHF6hYEEJm0rg3yWVcsdOlxbPaQgTWJrK3AsLNKs=.84093453-1cb3-4da7-a89e-f2cf4a0adca6@github.com>

Hi all,

please review this patch that makes `git pr create` much more explicit about the
mailing lists that will be CC:d for the "RFR" email generated from a pull
request. A user can now manually specify the mailing lists with `--cc` flag, for
example:

$ git pr create --cc=hotspot-dev,build-dev

Furthermore, `git pr create` will now also prompt the user for confirmation
about the selected mailing lists before proceeding:

$ git pr create --cc=hotspot-dev,build-dev
You have chosen the following mailing lists to be CC:d for the "RFR" e-mail:
- hotspot-dev at openjdk.java.net
- build-dev at openjdk.java.net

Do you want to proceed with this mailing list selection? [Y/n]:

If a user does not specify `--cc`, then `git pr create` will display the mailing
lists that were inferred based on the changes in the pull request:

The following mailing lists will be CC:d for the "RFR" e-mail:
- build-dev at openjdk.java.net

Do you want to proceed with this mailing list selection? [Y/n]:

If a user specify `--cc=auto` then no prompt will be shown and inferred mailing
lists will be used.

Additionally, the selected mailing lists will also be shown in the users
`$EDITOR` when the user writes the pull request message. For example:

  
  
  
  
  
  
  
  
  
  
  
  
  
  
  

As with all flags to Skara's CLI commands, a default value can be configured for
the `--cc` flag. This means that users that so wish can opt in to always use the
inferred mailing lists by running:

$ git config --global pr.create.cc auto

Testing:
- [x] Manual testing on Linux x64

Thanks,
Erik

-------------

Commit messages:
 - git-pr-create: be explicit about CC:d mailing lists
 - git-pr: add --cc flag to git-pr-create

Changes: https://git.openjdk.java.net/skara/pull/750/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=750&range=00
  Stats: 553 lines in 10 files changed: 345 ins; 199 del; 9 mod
  Patch: https://git.openjdk.java.net/skara/pull/750.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/750/head:pull/750

PR: https://git.openjdk.java.net/skara/pull/750

From rwestberg at openjdk.java.net  Fri Aug 28 13:12:21 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 28 Aug 2020 13:12:21 GMT
Subject: RFR: git-pr-create: be explicit about CC:d mailing lists
In-Reply-To: <_LDbHF6hYEEJm0rg3yWVcsdOlxbPaQgTWJrK3AsLNKs=.84093453-1cb3-4da7-a89e-f2cf4a0adca6@github.com>
References: <_LDbHF6hYEEJm0rg3yWVcsdOlxbPaQgTWJrK3AsLNKs=.84093453-1cb3-4da7-a89e-f2cf4a0adca6@github.com>
Message-ID: <IWv8oCYxQxPWrlFoLOpXWtAeHH_RIcX2oNIDr6e-90k=.6a0db53c-9b33-434f-8a88-7bb81d383ac3@github.com>

On Fri, 28 Aug 2020 13:02:41 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `git pr create` much more explicit about the
> mailing lists that will be CC:d for the "RFR" email generated from a pull
> request. A user can now manually specify the mailing lists with `--cc` flag, for
> example:
> 
> $ git pr create --cc=hotspot-dev,build-dev
> 
> Furthermore, `git pr create` will now also prompt the user for confirmation
> about the selected mailing lists before proceeding:
> 
> $ git pr create --cc=hotspot-dev,build-dev
> You have chosen the following mailing lists to be CC:d for the "RFR" e-mail:
> - hotspot-dev at openjdk.java.net
> - build-dev at openjdk.java.net
> 
> Do you want to proceed with this mailing list selection? [Y/n]:
> 
> If a user does not specify `--cc`, then `git pr create` will display the mailing
> lists that were inferred based on the changes in the pull request:
> 
> The following mailing lists will be CC:d for the "RFR" e-mail:
> - build-dev at openjdk.java.net
> 
> Do you want to proceed with this mailing list selection? [Y/n]:
> 
> If a user specify `--cc=auto` then no prompt will be shown and inferred mailing
> lists will be used.
> 
> Additionally, the selected mailing lists will also be shown in the users
> `$EDITOR` when the user writes the pull request message. For example:
> 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
> 
> As with all flags to Skara's CLI commands, a default value can be configured for
> the `--cc` flag. This means that users that so wish can opt in to always use the
> inferred mailing lists by running:
> 
> $ git config --global pr.create.cc auto
> 
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/750

From ehelin at openjdk.java.net  Fri Aug 28 14:49:51 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Fri, 28 Aug 2020 14:49:51 GMT
Subject: RFR: git-pr-create: be explicit about CC:d mailing lists [v2]
In-Reply-To: <_LDbHF6hYEEJm0rg3yWVcsdOlxbPaQgTWJrK3AsLNKs=.84093453-1cb3-4da7-a89e-f2cf4a0adca6@github.com>
References: <_LDbHF6hYEEJm0rg3yWVcsdOlxbPaQgTWJrK3AsLNKs=.84093453-1cb3-4da7-a89e-f2cf4a0adca6@github.com>
Message-ID: <FotXgW6YhzRc1dWKPV4v4A5ifaeP4bevYVhUt2DZo6k=.74671839-9871-4ace-9311-40755dddd7b9@github.com>

> Hi all,
> 
> please review this patch that makes `git pr create` much more explicit about the
> mailing lists that will be CC:d for the "RFR" email generated from a pull
> request. A user can now manually specify the mailing lists with `--cc` flag, for
> example:
> 
> $ git pr create --cc=hotspot-dev,build-dev
> 
> Furthermore, `git pr create` will now also prompt the user for confirmation
> about the selected mailing lists before proceeding:
> 
> $ git pr create --cc=hotspot-dev,build-dev
> You have chosen the following mailing lists to be CC:d for the "RFR" e-mail:
> - hotspot-dev at openjdk.java.net
> - build-dev at openjdk.java.net
> 
> Do you want to proceed with this mailing list selection? [Y/n]:
> 
> If a user does not specify `--cc`, then `git pr create` will display the mailing
> lists that were inferred based on the changes in the pull request:
> 
> The following mailing lists will be CC:d for the "RFR" e-mail:
> - build-dev at openjdk.java.net
> 
> Do you want to proceed with this mailing list selection? [Y/n]:
> 
> If a user specify `--cc=auto` then no prompt will be shown and inferred mailing
> lists will be used.
> 
> Additionally, the selected mailing lists will also be shown in the users
> `$EDITOR` when the user writes the pull request message. For example:
> 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
> 
> As with all flags to Skara's CLI commands, a default value can be configured for
> the `--cc` flag. This means that users that so wish can opt in to always use the
> inferred mailing lists by running:
> 
> $ git config --global pr.create.cc auto
> 
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  Fix tests

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/750/files
  - new: https://git.openjdk.java.net/skara/pull/750/files/f88fd379..59e2cfbb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=750&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=750&range=00-01

  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/750.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/750/head:pull/750

PR: https://git.openjdk.java.net/skara/pull/750

From darcy at openjdk.java.net  Fri Aug 28 21:38:27 2020
From: darcy at openjdk.java.net (Joe Darcy)
Date: Fri, 28 Aug 2020 21:38:27 GMT
Subject: RFR: Small updates to jdk.json mapping
Message-ID: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>

Simplify AIX libjli mapping and remove various HotSpot regression tests from core-libs-dev.

-------------

Commit messages:
 - small update

Changes: https://git.openjdk.java.net/skara/pull/751/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=751&range=00
  Stats: 10 lines in 1 file changed: 0 ins; 9 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/751.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/751/head:pull/751

PR: https://git.openjdk.java.net/skara/pull/751

From ehelin at openjdk.java.net  Sat Aug 29 09:52:51 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 29 Aug 2020 09:52:51 GMT
Subject: Integrated: git-pr-create: be explicit about CC:d mailing lists
In-Reply-To: <_LDbHF6hYEEJm0rg3yWVcsdOlxbPaQgTWJrK3AsLNKs=.84093453-1cb3-4da7-a89e-f2cf4a0adca6@github.com>
References: <_LDbHF6hYEEJm0rg3yWVcsdOlxbPaQgTWJrK3AsLNKs=.84093453-1cb3-4da7-a89e-f2cf4a0adca6@github.com>
Message-ID: <ezR77tjDuR0ea39nbQwkT3hjBu91ZQf34adCCWWxGUQ=.99bc0e08-cedf-46e5-a0cb-c852e6d787b4@github.com>

On Fri, 28 Aug 2020 13:02:41 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `git pr create` much more explicit about the
> mailing lists that will be CC:d for the "RFR" email generated from a pull
> request. A user can now manually specify the mailing lists with `--cc` flag, for
> example:
> 
> $ git pr create --cc=hotspot-dev,build-dev
> 
> Furthermore, `git pr create` will now also prompt the user for confirmation
> about the selected mailing lists before proceeding:
> 
> $ git pr create --cc=hotspot-dev,build-dev
> You have chosen the following mailing lists to be CC:d for the "RFR" e-mail:
> - hotspot-dev at openjdk.java.net
> - build-dev at openjdk.java.net
> 
> Do you want to proceed with this mailing list selection? [Y/n]:
> 
> If a user does not specify `--cc`, then `git pr create` will display the mailing
> lists that were inferred based on the changes in the pull request:
> 
> The following mailing lists will be CC:d for the "RFR" e-mail:
> - build-dev at openjdk.java.net
> 
> Do you want to proceed with this mailing list selection? [Y/n]:
> 
> If a user specify `--cc=auto` then no prompt will be shown and inferred mailing
> lists will be used.
> 
> Additionally, the selected mailing lists will also be shown in the users
> `$EDITOR` when the user writes the pull request message. For example:
> 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
> 
> As with all flags to Skara's CLI commands, a default value can be configured for
> the `--cc` flag. This means that users that so wish can opt in to always use the
> inferred mailing lists by running:
> 
> $ git config --global pr.create.cc auto
> 
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: e954044c
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/e954044c
Stats:     554 lines in 10 files changed: 199 ins; 345 del; 10 mod

git-pr-create: be explicit about CC:d mailing lists

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/750

From ehelin at openjdk.java.net  Sat Aug 29 11:59:56 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 29 Aug 2020 11:59:56 GMT
Subject: RFR: vcs: make follow work with merge commits
Message-ID: <6PUiVlBIJEl3NTvVXaTp-LBrecke3OVdI5lu3DRxJT4=.e07dc903-f474-4c62-a8ac-35e2551dc569@github.com>

Hi all,

please review this patch that makes `ReadOnlyRepository.follow` work with merge commits for Git repositories. I also
added an additional unit test to verify the functionality.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - vcs: make follow work with merge commits

Changes: https://git.openjdk.java.net/skara/pull/752/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=752&range=00
  Stats: 52 lines in 2 files changed: 52 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/752.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/752/head:pull/752

PR: https://git.openjdk.java.net/skara/pull/752

From ehelin at openjdk.java.net  Sat Aug 29 13:37:38 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 29 Aug 2020 13:37:38 GMT
Subject: RFR: tester: allow configurable allowlist
Message-ID: <g455Axj7Br0rdZob63DRtwXng8pVEWbp-Hxu3DbNOgU=.963c2c53-bffc-4273-9851-e9790a0b5adb@github.com>

Hi all,

please review that patch that enables a configurable allowlist for the tester bot. I also added a unit test for the new
functionality.

Testing:
- [x] `make test` passes on Linux x64
- [x] Added a new unit test

Thanks,
Erik

-------------

Commit messages:
 - test-bot: allow configurable allowlist

Changes: https://git.openjdk.java.net/skara/pull/753/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=753&range=00
  Stats: 125 lines in 7 files changed: 96 ins; 0 del; 29 mod
  Patch: https://git.openjdk.java.net/skara/pull/753.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/753/head:pull/753

PR: https://git.openjdk.java.net/skara/pull/753

From philip.race at oracle.com  Sat Aug 29 16:34:49 2020
From: philip.race at oracle.com (Philip Race)
Date: Sat, 29 Aug 2020 09:34:49 -0700
Subject: Request for assistance: Verify and update mailing list filter
 rules for jdk/jdk in preparation for Skara transition
In-Reply-To: <56e127e9-3802-a8d5-9a79-042166f02409@oracle.com>
References: <568BB329-6F50-43B4-BE1D-3A9D7EA60F79@oracle.com>
 <bf02b8ab-6772-77c8-03cb-e9c5832b06df@oracle.com>
 <35347485-216D-42BC-A05A-8D974E3FA581@oracle.com>
 <56e127e9-3802-a8d5-9a79-042166f02409@oracle.com>
Message-ID: <5F4A83A9.1000207@oracle.com>

I have some questions which at least tangentially relate to the list 
mappings which raise
what to me are tricky problems but maybe they've already been thought 
through and solved.

First, what is the minimum number of reviewers required a fix for the 
JDK project ?

Second, how can we have that by default adjusted depending on mailing 
list, with the
ability to either raise or lower that number according to the judgement 
of the fixer.
In the client area 2 reviewers is the big rule, only one has to be a 
Capital R reviewer,
but for trivial and urgent fixes we allow just one reviewer.

Third, if a fix is cross-posted to (say) build-dev and 2d-dev, how do 
you ensure it
gets both a build reviewer and a 2D reviewer's approval before pushing ? 
That
is after all the point of the cross-posting.

-phil.

On 8/27/20, 10:37 AM, Joe Darcy wrote:
> Hello,
>
> The mapping of 
> changed-file-to-OpenJDK-mailing-list(s)-to-review-the-file can be 
> non-obvious, both to new contributors and to experienced contributors 
> working in an unfamiliar area. If an automated mapping gets this 95+% 
> correct, with the ability for manual tweaking, that strikes me as an 
> overall improvement over the current situation.
>
> The current mapping has various entries that should be changed, but 
> that is why it is being sent out for review before the Skara 
> transition :-)
>
> As a general comment, I would expect both the mapping and other 
> aspects of the Skara tooling to get updated in response to feedback 
> after jdk/jdk moves over.
>
> -Joe
>
> On 8/27/2020 9:53 AM, Igor Ignatyev wrote:
>> Hi Robin,
>>
>> although I really like the idea of having mapping b/w files and 
>> groups/components/subcomponents, I agree w/ David that in its 
>> *current* form it's unworkable. having the mapping in Skara repo is 
>> impractical, as it introduces additional overhead for maintenance, 
>> not to speak of possible desynchronization. Thus I suggest moving the 
>> mapping to jdk/jdk repo and updating Skara tooling accordingly.
>>
>> I also have a question regarding the format, why did you decide to 
>> invent your own format instead of using CODEOWNER-like format which 
>> fits the needs rather nicely and is used for similar purposes by 
>> github and gitlab?
>>
>> Thanks,
>> -- Igor
>>
>>> On Aug 27, 2020, at 6:26 AM, David Holmes <david.holmes at oracle.com> 
>>> wrote:
>>>
>>> In all seriousness I just don't think this is a reasonable or 
>>> necessary thing to do. When you create a PR you should specify the 
>>> mailing lists to be used, as you do today with a RFR. Trying to 
>>> maintain a file by file mapping is just a huge initial setup cost 
>>> and a maintenance nightmare. It is not necessary to try and automate 
>>> this IMO.
>>>
>>> I wish this intent had been flagged/discussed some time ago. :(
>>>
>>> David
>>> -----
>>>
>>> On 27/08/2020 8:34 pm, Robin Westberg wrote:
>>>> Hi all,
>>>> As part of transitioning the jdk/jdk repository to Git with project 
>>>> Skara, we have created a set of rules that determine which mailing 
>>>> list(s) should be the default recipient of a review request, 
>>>> depending on which files are changed. The initial version of these 
>>>> rules was created by looking at historical commits and matching 
>>>> them with existing mailing list review threads. This has produced a 
>>>> reasonable basis, but it can most certainly be made better with 
>>>> some additional manual curating.
>>>> Therefore, it would be very helpful if people with good knowledge 
>>>> of the various subsystems and source files that make up the JDK 
>>>> would be willing to take a look at these rules, and also suggest 
>>>> improvements where needed. In addition, lists like [1] would also 
>>>> be very useful insofar they exist.
>>>> The current version of these rules is located in a JSON file in the 
>>>> Skara repository at [2]. In order to check the validity of the 
>>>> rules, there is also a CLI tool that can be used to apply it to 
>>>> either a subset of files or existing commits and produce a 
>>>> suggestion [3] [4]. If you are interested in helping out with 
>>>> curating these rules, these are the steps to get started:
>>>> 1. Install the Skara CLI tools: 
>>>> https://wiki.openjdk.java.net/display/SKARA/CLI+Tools
>>>> 2. Locate a suitable clone of the jdk/jdk repository (either 
>>>> Mercurial or Git is fine)
>>>> 3. Change (cd) to the root of your jdk/jdk repository
>>>> 3. Run the ?debug mlrules? command on your favorite subset of 
>>>> files, for example like this (use the actual location of jdk.json 
>>>> on your system):
>>>> $ git skara debug mlrules -v 
>>>> ~/git/skara/config/mailinglist/rules/jdk.json src/hotspot/share/jfr/
>>>> Reading rules file...
>>>> src/hotspot/share/jfr/dcmd: [hotspot-jfr-dev]
>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp: 
>>>> [hotspot-jfr-dev]
>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.hpp: 
>>>> [hotspot-jfr-dev]
>>>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp: 
>>>> [hotspot-jfr-dev, serviceability-dev]
>>>> ?
>>>> Final list suggestion is: [hotspot-jfr-dev, serviceability-dev]
>>>> The command accepts multiple folder and/or file names to make it 
>>>> possible to simulate a potential change to a given set of files:
>>>> $ git skara debug mlrules -v 
>>>> ../skara/config/mailinglist/rules/jdk.json doc/ide.md 
>>>> src/hotspot/cpu/x86/x86.ad src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
>>>> Reading rules file...
>>>> doc: [build-dev]
>>>> src/hotspot/cpu: [hotspot-compiler-dev]
>>>> src/hotspot/os: [hotspot-runtime-dev, hotspot-gc-dev]
>>>> Combined list suggestion: [build-dev, hotspot-compiler-dev, 
>>>> hotspot-gc-dev, hotspot-runtime-dev]
>>>> Final list suggestion is: [build-dev, hotspot-dev]
>>>> If the suggestions look fine, all is well. If not, you are welcome 
>>>> to propose a change to the rules, preferably by editing the 
>>>> jdk.json file [6] and creating a pull request towards the Skara 
>>>> project as described in [5]. Coincidentally, this is the same way 
>>>> that future changes to the jdk/jdk repository will be integrated, 
>>>> so this exercise could also serve as a way of getting started with 
>>>> Git / Skara!
>>>> Best regards,
>>>> Robin
>>>> [1] https://openjdk.java.net/groups/2d/2dawtfiles.html
>>>> [2] 
>>>> https://git.openjdk.java.net/skara/blob/master/config/mailinglist/rules/jdk.json
>>>> [3]
>>>> $ git skara debug mlrules -v 
>>>> ~/git/skara/config/mailinglist/rules/jdk.json 
>>>> src/java.desktop/unix/native
>>>> Reading rules file...
>>>> src/java.desktop/unix/native/common: [2d-dev]
>>>> src/java.desktop/unix/native/include: []
>>>> src/java.desktop/unix/native/libawt: [2d-dev]
>>>> src/java.desktop/unix/native/libawt_headless: [awt-dev]
>>>> src/java.desktop/unix/native/libawt_xawt: [awt-dev]
>>>> src/java.desktop/unix/native/libfontmanager: [2d-dev]
>>>> src/java.desktop/unix/native/libjawt: [awt-dev]
>>>> src/java.desktop/unix/native/libsplashscreen: [awt-dev]
>>>> Combined list suggestion: [2d-dev, awt-dev]
>>>> Final list suggestion is: [2d-dev, awt-dev]
>>>> [4]
>>>> $ git skara debug mlrules -d 30 -v 
>>>> ~/git/skara/config/mailinglist/rules/jdk.json .
>>>> ...
>>>> ? [2d-dev, awt-dev, serviceability-dev] c32923e0: 8240487: Cleanup 
>>>> whitespace in .cc, .hh, .m, and .mm files
>>>> ? [awt-dev] 7f74c7dd: 8212226: SurfaceManager throws "Invalid Image 
>>>> variant" for MultiResolutionImage (Windows)
>>>>      Suggested lists: [2d-dev, awt-dev]
>>>>      Rules matching unmentioned lists [2d-dev]:
>>>>        src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java 
>>>> - [2d-dev: ^src/java.desktop/share/classes/sun/java2d/]
>>>> ?
>>>> [5] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-Workflow
>>>> [6]
>>>> The rules are made up of sets of regular expressions for the 
>>>> various mailing lists that are used for reviewing changes going 
>>>> into the JDK. If any rule matches, that mailing list will get a 
>>>> copy of the review request email. For directories containing files 
>>>> that belong to different subsystems, it?s usually a good idea to 
>>>> write the rules in a complementary fashion if possible, so that 
>>>> anything not explicitly mentioned gets a reasonable default. As an 
>>>> example, see these rules for a subset of awt / 2d / i18n files:
>>>> ?awt-dev?: 
>>>> "src/java.desktop/share/classes/sun/awt/(?!font|sunhints|color/|font/|geom/|im/|image/|print/)?
>>>> ?2d-dev?: 
>>>> "src/java.desktop/share/classes/sun/awt/(font|sunhints|color/|font/|geom/|image/|print/)"
>>>> ?I18n-dev?: "src/java.desktop/share/classes/sun/awt/im/?
>>>> In this example, anything not explicitly indicated as belonging to 
>>>> either 2d-dev or i18-dev will be matched by awt-dev.

From rwestberg at openjdk.java.net  Sat Aug 29 17:22:01 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 29 Aug 2020 17:22:01 GMT
Subject: RFR: vcs: make follow work with merge commits
In-Reply-To: <6PUiVlBIJEl3NTvVXaTp-LBrecke3OVdI5lu3DRxJT4=.e07dc903-f474-4c62-a8ac-35e2551dc569@github.com>
References: <6PUiVlBIJEl3NTvVXaTp-LBrecke3OVdI5lu3DRxJT4=.e07dc903-f474-4c62-a8ac-35e2551dc569@github.com>
Message-ID: <DUXKL8z7qyAmJiWVwee4f9IWpGwPexmlByJ1mmuZLII=.f4e9ffe8-7aa3-45b2-8ff2-13ddf7968a11@github.com>

On Sat, 29 Aug 2020 11:57:21 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `ReadOnlyRepository.follow` work with merge commits for Git repositories. I also
> added an additional unit test to verify the functionality.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/752

From rwestberg at openjdk.java.net  Sat Aug 29 17:24:12 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 29 Aug 2020 17:24:12 GMT
Subject: RFR: Small updates to jdk.json mapping
In-Reply-To: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>
References: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>
Message-ID: <-Aa0jjTSxpzRv5YwatMLbbvxjDpxCneVUJxKncyEKeU=.22914d38-217e-4159-8e8f-759fef678083@github.com>

On Fri, 28 Aug 2020 21:35:50 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Simplify AIX libjli mapping and remove various HotSpot regression tests from core-libs-dev.

Thanks for the update!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/751

From rwestberg at openjdk.java.net  Sat Aug 29 17:23:33 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 29 Aug 2020 17:23:33 GMT
Subject: RFR: tester: allow configurable allowlist
In-Reply-To: <g455Axj7Br0rdZob63DRtwXng8pVEWbp-Hxu3DbNOgU=.963c2c53-bffc-4273-9851-e9790a0b5adb@github.com>
References: <g455Axj7Br0rdZob63DRtwXng8pVEWbp-Hxu3DbNOgU=.963c2c53-bffc-4273-9851-e9790a0b5adb@github.com>
Message-ID: <Uyg25yPqU_BpSsZsfzsb-P8LeiVy6Tq7Vg5RSlIYx0o=.25f58959-c3be-41b7-95d0-9e40dfe89f43@github.com>

On Sat, 29 Aug 2020 13:34:56 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review that patch that enables a configurable allowlist for the tester bot. I also added a unit test for the new
> functionality.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/753

From darcy at openjdk.java.net  Sat Aug 29 18:34:13 2020
From: darcy at openjdk.java.net (Joe Darcy)
Date: Sat, 29 Aug 2020 18:34:13 GMT
Subject: RFR: Small updates to jdk.json mapping [v2]
In-Reply-To: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>
References: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>
Message-ID: <nqGLa2A3dlyhsznitnJVMQvxm4vy_ncWH9lhCDYyeUE=.79aa0e92-b6b7-4d3d-9698-fb1a93972cb5@github.com>

> Simplify AIX libjli mapping and remove various HotSpot regression tests from core-libs-dev.

Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:

  Condense core libs rules for jdk/internal

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/751/files
  - new: https://git.openjdk.java.net/skara/pull/751/files/a3b54cf4..1e915707

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=751&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=751&range=00-01

  Stats: 14 lines in 1 file changed: 0 ins; 13 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/751.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/751/head:pull/751

PR: https://git.openjdk.java.net/skara/pull/751

From darcy at openjdk.java.net  Sat Aug 29 18:37:12 2020
From: darcy at openjdk.java.net (Joe Darcy)
Date: Sat, 29 Aug 2020 18:37:12 GMT
Subject: RFR: Small updates to jdk.json mapping [v2]
In-Reply-To: <-Aa0jjTSxpzRv5YwatMLbbvxjDpxCneVUJxKncyEKeU=.22914d38-217e-4159-8e8f-759fef678083@github.com>
References: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>
 <-Aa0jjTSxpzRv5YwatMLbbvxjDpxCneVUJxKncyEKeU=.22914d38-217e-4159-8e8f-759fef678083@github.com>
Message-ID: <DlEquOnutb1WuvKqR5acb6FJJNwVBxCf0Y0kSvj5IkM=.35facfa2-978d-49c4-9feb-b2736dbb01c7@github.com>

On Sat, 29 Aug 2020 17:22:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Condense core libs rules for jdk/internal
>
> Thanks for the update!

I condensed down the mappings covering
src/java.base/share/classes/jdk/internal/*
and verified all the previously listed directories where still mapped to core-libs using
git skara debug mlrules -v  $PATH_TO_MODIFIED_FILE

-------------

PR: https://git.openjdk.java.net/skara/pull/751

From ehelin at openjdk.java.net  Sat Aug 29 20:24:21 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 29 Aug 2020 20:24:21 GMT
Subject: Integrated: vcs: make follow work with merge commits
In-Reply-To: <6PUiVlBIJEl3NTvVXaTp-LBrecke3OVdI5lu3DRxJT4=.e07dc903-f474-4c62-a8ac-35e2551dc569@github.com>
References: <6PUiVlBIJEl3NTvVXaTp-LBrecke3OVdI5lu3DRxJT4=.e07dc903-f474-4c62-a8ac-35e2551dc569@github.com>
Message-ID: <7In312KYK8EJFRTflWZZ50gbnRQ3BWg1AzSS_68ZCfo=.660f86e8-3331-4eaf-ad39-515777f5230e@github.com>

On Sat, 29 Aug 2020 11:57:21 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes `ReadOnlyRepository.follow` work with merge commits for Git repositories. I also
> added an additional unit test to verify the functionality.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 8a7eb772
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/8a7eb772
Stats:     52 lines in 2 files changed: 0 ins; 52 del; 0 mod

vcs: make follow work with merge commits

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/752

From ehelin at openjdk.java.net  Sat Aug 29 20:24:40 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 29 Aug 2020 20:24:40 GMT
Subject: Integrated: tester: allow configurable allowlist
In-Reply-To: <g455Axj7Br0rdZob63DRtwXng8pVEWbp-Hxu3DbNOgU=.963c2c53-bffc-4273-9851-e9790a0b5adb@github.com>
References: <g455Axj7Br0rdZob63DRtwXng8pVEWbp-Hxu3DbNOgU=.963c2c53-bffc-4273-9851-e9790a0b5adb@github.com>
Message-ID: <UFBFibQSG7TR6Ovsbz06sGYTxrGaU_xWrVJwVA01w0U=.e4ae925a-d9a2-4ef9-8127-505a818ea0b3@github.com>

On Sat, 29 Aug 2020 13:34:56 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review that patch that enables a configurable allowlist for the tester bot. I also added a unit test for the new
> functionality.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added a new unit test
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 0e4356a0
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/0e4356a0
Stats:     125 lines in 7 files changed: 0 ins; 96 del; 29 mod

tester: allow configurable allowlist

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/753

From rwestberg at openjdk.java.net  Sat Aug 29 20:59:58 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 29 Aug 2020 20:59:58 GMT
Subject: RFR: mlrules: applying off-list suggestions [v5]
In-Reply-To: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
Message-ID: <NgEK5qOwRpcFxvRe9rTrkxzs9hVfzjzVsV9oN2hnctE=.eff16b83-0e32-4ac2-8b81-c1ac8fffd027@github.com>

> Hi all,
> 
> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
> Best regards,
> Robin

Robin Westberg has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains 11 commits:

 - Update the hotspot-compiler rules
 - Merge remote-tracking branch 'upstream/master' into mlrules_update
   
   # Conflicts:
   #	config/mailinglist/rules/jdk.json
 - Simplify nio rules
 - Add initial set of rules for shenandoah
 - Drop the -dev suffix
 - Non-build-related files in the root folder to jdk-dev
 - Updates for hotspot-compiler
 - Simplify gc-dev rules
 - Simplify build-dev rules
 - Remove jdwp from core-libs, remove nio-dev duplicates (alanb)
 - ... and 1 more: https://git.openjdk.java.net/skara/compare/92a97993...772bb65a

-------------

Changes: https://git.openjdk.java.net/skara/pull/746/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=746&range=04
  Stats: 96 lines in 1 file changed: 9 ins; 47 del; 40 mod
  Patch: https://git.openjdk.java.net/skara/pull/746.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/746/head:pull/746

PR: https://git.openjdk.java.net/skara/pull/746

From ehelin at openjdk.java.net  Sat Aug 29 21:00:00 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 29 Aug 2020 21:00:00 GMT
Subject: RFR: mlrules: applying off-list suggestions [v5]
In-Reply-To: <NgEK5qOwRpcFxvRe9rTrkxzs9hVfzjzVsV9oN2hnctE=.eff16b83-0e32-4ac2-8b81-c1ac8fffd027@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <NgEK5qOwRpcFxvRe9rTrkxzs9hVfzjzVsV9oN2hnctE=.eff16b83-0e32-4ac2-8b81-c1ac8fffd027@github.com>
Message-ID: <b18akdAY097Mys2FKIFLjcqCP75cCBomCmYPMmoDSH4=.601036fb-a316-480a-9039-aaa39a6dfa3d@github.com>

On Fri, 28 Aug 2020 13:22:07 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
>> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
>> Best regards,
>> Robin
>
> Robin Westberg has updated the pull request with a new target base due to a merge or a rebase. The pull request now
> contains 11 commits:
>  - Update the hotspot-compiler rules
>  - Merge remote-tracking branch 'upstream/master' into mlrules_update
>    
>    # Conflicts:
>    #	config/mailinglist/rules/jdk.json
>  - Simplify nio rules
>  - Add initial set of rules for shenandoah
>  - Drop the -dev suffix
>  - Non-build-related files in the root folder to jdk-dev
>  - Updates for hotspot-compiler
>  - Simplify gc-dev rules
>  - Simplify build-dev rules
>  - Remove jdwp from core-libs, remove nio-dev duplicates (alanb)
>  - ... and 1 more: https://git.openjdk.java.net/skara/compare/92a97993...772bb65a

Great improvements!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/746

From ehelin at openjdk.java.net  Sat Aug 29 21:00:03 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sat, 29 Aug 2020 21:00:03 GMT
Subject: RFR: mlrules: applying off-list suggestions [v5]
In-Reply-To: <b18akdAY097Mys2FKIFLjcqCP75cCBomCmYPMmoDSH4=.601036fb-a316-480a-9039-aaa39a6dfa3d@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
 <NgEK5qOwRpcFxvRe9rTrkxzs9hVfzjzVsV9oN2hnctE=.eff16b83-0e32-4ac2-8b81-c1ac8fffd027@github.com>
 <b18akdAY097Mys2FKIFLjcqCP75cCBomCmYPMmoDSH4=.601036fb-a316-480a-9039-aaa39a6dfa3d@github.com>
Message-ID: <1H7E3OsllN3hNvW_y3Dy1dMmpQ21ki3AMY5P56aQ3mU=.e87783ec-cdfd-47b8-8c25-1d9c8a9a998c@github.com>

On Fri, 28 Aug 2020 12:44:47 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Robin Westberg has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains 11 commits:
>>  - Update the hotspot-compiler rules
>>  - Merge remote-tracking branch 'upstream/master' into mlrules_update
>>    
>>    # Conflicts:
>>    #	config/mailinglist/rules/jdk.json
>>  - Simplify nio rules
>>  - Add initial set of rules for shenandoah
>>  - Drop the -dev suffix
>>  - Non-build-related files in the root folder to jdk-dev
>>  - Updates for hotspot-compiler
>>  - Simplify gc-dev rules
>>  - Simplify build-dev rules
>>  - Remove jdwp from core-libs, remove nio-dev duplicates (alanb)
>>  - ... and 1 more: https://git.openjdk.java.net/skara/compare/92a97993...772bb65a
>
> Great improvements!

One more addition: I would probably have coalesced hotspot-gc-dev, hotspot-runtime-dev and hotspot-gc-dev into
hotspot-dev.

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From rwestberg at openjdk.java.net  Sat Aug 29 21:00:05 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sat, 29 Aug 2020 21:00:05 GMT
Subject: Integrated: mlrules: applying off-list suggestions
In-Reply-To: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
References: <4CyR0QdSAIUR5aS5qSKfiU3tZzzxIVAHlp-rqySLGd4=.c464867f-069e-4136-8018-781fc9aff36d@github.com>
Message-ID: <IkEBQlEYeyzqfmelTUFRwxsacS0lqw7xLg8fmBWp6-c=.a1bb2d86-abfb-45a8-83a7-d9526acd31a3@github.com>

On Thu, 27 Aug 2020 11:42:03 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> In this PR I'll collect the various updates to the jdk mailing list rules file that I'm receiving off-list (which is
> perfectly fine, feel free to send plain suggestions my way and I'll collect them here!)
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: e3aa0f1b
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/e3aa0f1b
Stats:     96 lines in 1 file changed: 47 ins; 9 del; 40 mod

mlrules: applying off-list suggestions

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/746

From ehelin at openjdk.java.net  Sun Aug 30 04:45:15 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Sun, 30 Aug 2020 04:45:15 GMT
Subject: RFR: webrev: not all commits changes files
Message-ID: <HjdrQiCNwsSamzZp_oX9h1gKrpM0IktcJtvqte5pYCE=.d3bb8fa0-e5ae-4442-98aa-eeb29c9ea6e1@github.com>

Hi all,

please review this small patch that updates webrev's JSON generator to handle commits that don't change any files. This
can happen for example with trivial merges (since we use the `-c` flag to `git log`).

Thanks,
Erik

-------------

Commit messages:
 - webrev: not all commits changes files

Changes: https://git.openjdk.java.net/skara/pull/754/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=754&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/754.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/754/head:pull/754

PR: https://git.openjdk.java.net/skara/pull/754

From rwestberg at openjdk.java.net  Sun Aug 30 12:51:18 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Sun, 30 Aug 2020 12:51:18 GMT
Subject: RFR: webrev: not all commits changes files
In-Reply-To: <HjdrQiCNwsSamzZp_oX9h1gKrpM0IktcJtvqte5pYCE=.d3bb8fa0-e5ae-4442-98aa-eeb29c9ea6e1@github.com>
References: <HjdrQiCNwsSamzZp_oX9h1gKrpM0IktcJtvqte5pYCE=.d3bb8fa0-e5ae-4442-98aa-eeb29c9ea6e1@github.com>
Message-ID: <Ks0RTLzvY96jnC3QXsYtq7cw4s7xUA44lNEbfORMXFY=.d6f13202-e350-441c-81c1-e1f21996e8fd@github.com>

On Sun, 30 Aug 2020 04:42:34 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that updates webrev's JSON generator to handle commits that don't change any files. This
> can happen for example with trivial merges (since we use the `-c` flag to `git log`).
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/754

From darcy at openjdk.java.net  Sun Aug 30 17:53:28 2020
From: darcy at openjdk.java.net (Joe Darcy)
Date: Sun, 30 Aug 2020 17:53:28 GMT
Subject: RFR: Small updates to jdk.json mapping [v3]
In-Reply-To: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>
References: <zh1amTSR3bN-kXTtjHGdnVEMZFpsctsmnPgA_w_uJlg=.a137595a-48c2-4fe4-98cb-b368bdc9d051@github.com>
Message-ID: <cGwJJtV4NNa8_1gKL3-7dgIPhkHLRysT4STb6nwkzS0=.64c29573-b030-448a-9257-c286f808efce@github.com>

> Simplify AIX libjli mapping and remove various HotSpot regression tests from core-libs-dev.

Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:

  Reduce number of unmapped files

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/751/files
  - new: https://git.openjdk.java.net/skara/pull/751/files/1e915707..e346b8f3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=751&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=751&range=01-02

  Stats: 36 lines in 1 file changed: 30 ins; 2 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/751.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/751/head:pull/751

PR: https://git.openjdk.java.net/skara/pull/751

From rwestberg at openjdk.java.net  Mon Aug 31 09:25:34 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 09:25:34 GMT
Subject: RFR: prbot: Allow overriding jcheck configuration
Message-ID: <GmMb9n7m8Yhr8m96Vh4MYeBlKzRkDBAU2Lu1PP5V3sk=.9a6503b5-9728-40f1-ad5b-bc0a78dd3c02@github.com>

Hi all,

Please review this change that allows the pull request bot to use a jcheck configuration file from a separate
repository, overriding the one (if any) present in the checked repository.

Best regards,
Robin

-------------

Commit messages:
 - prbot: Allow overriding jcheck configuration

Changes: https://git.openjdk.java.net/skara/pull/755/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=755&range=00
  Stats: 212 lines in 13 files changed: 180 ins; 10 del; 22 mod
  Patch: https://git.openjdk.java.net/skara/pull/755.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/755/head:pull/755

PR: https://git.openjdk.java.net/skara/pull/755

From ehelin at openjdk.java.net  Mon Aug 31 09:31:47 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 31 Aug 2020 09:31:47 GMT
Subject: RFR: prbot: Allow overriding jcheck configuration
In-Reply-To: <GmMb9n7m8Yhr8m96Vh4MYeBlKzRkDBAU2Lu1PP5V3sk=.9a6503b5-9728-40f1-ad5b-bc0a78dd3c02@github.com>
References: <GmMb9n7m8Yhr8m96Vh4MYeBlKzRkDBAU2Lu1PP5V3sk=.9a6503b5-9728-40f1-ad5b-bc0a78dd3c02@github.com>
Message-ID: <rRMVSFVwPP6_kyX990mRicGeP6cKyNrdzF6gNsy9aLA=.b5473d6d-fd3c-466d-b5fd-77656bd641bc@github.com>

On Mon, 31 Aug 2020 09:22:52 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that allows the pull request bot to use a jcheck configuration file from a separate
> repository, overriding the one (if any) present in the checked repository.
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/755

From ehelin at openjdk.java.net  Mon Aug 31 09:32:19 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 31 Aug 2020 09:32:19 GMT
Subject: Integrated: webrev: not all commits changes files
In-Reply-To: <HjdrQiCNwsSamzZp_oX9h1gKrpM0IktcJtvqte5pYCE=.d3bb8fa0-e5ae-4442-98aa-eeb29c9ea6e1@github.com>
References: <HjdrQiCNwsSamzZp_oX9h1gKrpM0IktcJtvqte5pYCE=.d3bb8fa0-e5ae-4442-98aa-eeb29c9ea6e1@github.com>
Message-ID: <h04G8F78sCnGTf3XpL08cw7JMj6zFDkfgu5kFMsf7DU=.b64dba69-2ecc-4ea1-8adb-33fef75fac99@github.com>

On Sun, 30 Aug 2020 04:42:34 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that updates webrev's JSON generator to handle commits that don't change any files. This
> can happen for example with trivial merges (since we use the `-c` flag to `git log`).
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: b028725b
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/b028725b
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

webrev: not all commits changes files

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/754

From rwestberg at openjdk.java.net  Mon Aug 31 09:58:09 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 09:58:09 GMT
Subject: Integrated: prbot: Allow overriding jcheck configuration
In-Reply-To: <GmMb9n7m8Yhr8m96Vh4MYeBlKzRkDBAU2Lu1PP5V3sk=.9a6503b5-9728-40f1-ad5b-bc0a78dd3c02@github.com>
References: <GmMb9n7m8Yhr8m96Vh4MYeBlKzRkDBAU2Lu1PP5V3sk=.9a6503b5-9728-40f1-ad5b-bc0a78dd3c02@github.com>
Message-ID: <yG2V8nldKTiv6yK4xI1012UHZvQvErTemDqbgZ2ZVKY=.65f71f1a-c59a-4b41-9c09-d8a9b269ca60@github.com>

On Mon, 31 Aug 2020 09:22:52 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that allows the pull request bot to use a jcheck configuration file from a separate
> repository, overriding the one (if any) present in the checked repository.
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: e36b503e
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/e36b503e
Stats:     212 lines in 13 files changed: 10 ins; 180 del; 22 mod

prbot: Allow overriding jcheck configuration

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/755

From robin.westberg at oracle.com  Mon Aug 31 11:56:50 2020
From: robin.westberg at oracle.com (Robin Westberg)
Date: Mon, 31 Aug 2020 13:56:50 +0200
Subject: Email subject line formatting
In-Reply-To: <7f585de8-a702-f06d-db53-40f49b4db6a0@oracle.com>
References: <3b83157d-3570-129f-d4a7-028c6872885d@oracle.com>
 <7f585de8-a702-f06d-db53-40f49b4db6a0@oracle.com>
Message-ID: <84A2E391-7540-464E-8C0A-04808B7688BF@oracle.com>

Hi David,

> On 28 Aug 2020, at 02:26, David Holmes <david.holmes at oracle.com> wrote:
> 
> As the transition to git/skara is now imminent I wanted to re-raise this issue and find out exactly how the email processes will be setup for the mainline JDK project - ie what subject will be used in the various cases.

I think that the current consensus from this thread is what?s currently active for example for changes here on the skara-dev mailing list. A summary of these subject annotations and the threading would be (hopefully the formatting will survive):

RFR: 1234: Title				Initial RFR email from a PR
  Re: RFR: 1234: Title			Comment
    Re: RFR: 1234: Title			Another comment
  Re: RFR: 1234: Title [v2]		A new version of the code (with incremental webrevs, etc)
  Integrated: 1234: Title			Integration notice containing changeset details
    Re: Integrated: 1234: Title		Further PR comment made after integration

If a pull request is closed without integration, the final message will be prefixed with ?Withdrawn? instead of ?Integrated?. Similarly, if a PR has already been integrated by the time the first mail can be sent, it will be prefixed with ?Integrated? instead of ?RFR? from the beginning.

Best regards,
Robin

> 
> Thanks,
> David
> 
> On 7/04/2020 9:21 am, David Holmes wrote:
>> Hi everyone,
>> Erik asked me to raise this here to see if anyone else is bothered by this ...
>> When an integration email is sent the subject line of the RFR thread is augmented with [integrated] and also adorned with "Re:" as if a reply to the RFR thread e.g.
>> Re: [Integrated] [foreign-abi] RFR: Revert "JDK-8242127: reorganize ABI-dependent layout constants"
>> My objection to this is that once the subject has been augmented with [Integrated] it is not appropriate to treat that as a "reply" and use the "Re:". If I see:
>> [Integrated] [foreign-abi] RFR: Revert "JDK-8242127: reorganize ABI-dependent layout constants"
>> I know its a changeset notification email and I can ignore it. Just as I can ignore:
>> git: openjdk/panama-foreign: foreign-jextract: 2 new changesets
>> or
>> hg: jdk/jdk: 8242217: Shenandoah: Enable GC mode to be diagnostic/experimental and have a name
>> but when I see the "Re:" I think "oh someone is commenting on that push, there must be an issue and I should read the email" - which is the case with current hg notification emails!
>> This would be less of an issue if the sender of the integration email was a bot account but it isn't, it is the committer.
>> So I'd like to suggest that the "Re:" be dropped from the subject line of these automatically generated integration emails.
>> Cheers,
>> David


From rwestberg at openjdk.java.net  Mon Aug 31 12:02:04 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 12:02:04 GMT
Subject: RFR: 439: Improve command filtering when bridging mails
Message-ID: <7AwYw8c9zq-rsvGMoPIb97I1xzp_c_IAXO9D0qBcQ8U=.0addc5ef-3b28-4116-b43d-80fc2c772ffd@github.com>

Hi all,

Please review this change that improves the command comment filtering done by the mailinglist bridge bot, to match more
closely what the pull request bot would consider as commands.

Best regards,
Robin

-------------

Commit messages:
 - Improve the command comment filtering

Changes: https://git.openjdk.java.net/skara/pull/756/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=756&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-439
  Stats: 23 lines in 3 files changed: 14 ins; 0 del; 9 mod
  Patch: https://git.openjdk.java.net/skara/pull/756.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/756/head:pull/756

PR: https://git.openjdk.java.net/skara/pull/756

From ehelin at openjdk.java.net  Mon Aug 31 12:16:49 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 31 Aug 2020 12:16:49 GMT
Subject: RFR: 439: Improve command filtering when bridging mails
In-Reply-To: <7AwYw8c9zq-rsvGMoPIb97I1xzp_c_IAXO9D0qBcQ8U=.0addc5ef-3b28-4116-b43d-80fc2c772ffd@github.com>
References: <7AwYw8c9zq-rsvGMoPIb97I1xzp_c_IAXO9D0qBcQ8U=.0addc5ef-3b28-4116-b43d-80fc2c772ffd@github.com>
Message-ID: <-P_MjQ2UtPeJA4Ld_9mKC61cMh_GogyAzBhIGn6iz7s=.7d91005c-7720-4320-9b99-2c04fdd31583@github.com>

On Mon, 31 Aug 2020 11:59:25 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that improves the command comment filtering done by the mailinglist bridge bot, to match more
> closely what the pull request bot would consider as commands.
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/756

From rwestberg at openjdk.java.net  Mon Aug 31 12:33:56 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 12:33:56 GMT
Subject: RFR: 265: Mail bot shows wrong source line for inline review comments
Message-ID: <eyVtySYOrQirAxSptpstLczxi1x8ir2c0h6EmN0M69k=.728257a8-f12a-473e-86c0-e8d083fadfe0@github.com>

Hi all,

Please review this small change that adjusts the quoted source lines in review comments, to have the line the comment
is made about be the last one.

Best regards,
Robin

-------------

Commit messages:
 - Adjust code comment context

Changes: https://git.openjdk.java.net/skara/pull/757/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=757&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-265
  Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/757.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/757/head:pull/757

PR: https://git.openjdk.java.net/skara/pull/757

From ehelin at openjdk.java.net  Mon Aug 31 12:33:56 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 31 Aug 2020 12:33:56 GMT
Subject: RFR: 265: Mail bot shows wrong source line for inline review
 comments
In-Reply-To: <eyVtySYOrQirAxSptpstLczxi1x8ir2c0h6EmN0M69k=.728257a8-f12a-473e-86c0-e8d083fadfe0@github.com>
References: <eyVtySYOrQirAxSptpstLczxi1x8ir2c0h6EmN0M69k=.728257a8-f12a-473e-86c0-e8d083fadfe0@github.com>
Message-ID: <NcyO5Kyo36RLxFbAR7RYdx87pHXO-bKFImqToB9LhgA=.8d95f4e4-1de1-44d6-a406-bed06d47e0d3@github.com>

On Mon, 31 Aug 2020 12:29:29 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this small change that adjusts the quoted source lines in review comments, to have the line the comment
> is made about be the last one.
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/757

From rwestberg at openjdk.java.net  Mon Aug 31 13:09:00 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 13:09:00 GMT
Subject: Integrated: 439: Improve command filtering when bridging mails
In-Reply-To: <7AwYw8c9zq-rsvGMoPIb97I1xzp_c_IAXO9D0qBcQ8U=.0addc5ef-3b28-4116-b43d-80fc2c772ffd@github.com>
References: <7AwYw8c9zq-rsvGMoPIb97I1xzp_c_IAXO9D0qBcQ8U=.0addc5ef-3b28-4116-b43d-80fc2c772ffd@github.com>
Message-ID: <T6wxqKY7g0y37RI_UzPnxaTL6QxdgvnlG3o8D4FfcgQ=.58f510d6-f94b-4f23-b81f-4efc5f176138@github.com>

On Mon, 31 Aug 2020 11:59:25 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that improves the command comment filtering done by the mailinglist bridge bot, to match more
> closely what the pull request bot would consider as commands.
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: b007595e
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/b007595e
Stats:     23 lines in 3 files changed: 0 ins; 14 del; 9 mod

439: Improve command filtering when bridging mails

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/756

From rwestberg at openjdk.java.net  Mon Aug 31 13:09:29 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 13:09:29 GMT
Subject: Integrated: 265: Mail bot shows wrong source line for inline review
 comments
In-Reply-To: <eyVtySYOrQirAxSptpstLczxi1x8ir2c0h6EmN0M69k=.728257a8-f12a-473e-86c0-e8d083fadfe0@github.com>
References: <eyVtySYOrQirAxSptpstLczxi1x8ir2c0h6EmN0M69k=.728257a8-f12a-473e-86c0-e8d083fadfe0@github.com>
Message-ID: <gBhBl1uebiy63AM4xK4ostE44F9uiGnt5QKp3pHTY4Q=.2c8e1a68-8c51-4729-a737-16715b2423a3@github.com>

On Mon, 31 Aug 2020 12:29:29 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this small change that adjusts the quoted source lines in review comments, to have the line the comment
> is made about be the last one.
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: cca94e0a
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/cca94e0a
Stats:     4 lines in 2 files changed: 1 ins; 0 del; 3 mod

265: Mail bot shows wrong source line for inline review comments

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/757

From kevin.rushforth at oracle.com  Mon Aug 31 13:11:42 2020
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Mon, 31 Aug 2020 06:11:42 -0700
Subject: Request for assistance: Verify and update mailing list filter
 rules for jdk/jdk in preparation for Skara transition
In-Reply-To: <5F4A83A9.1000207@oracle.com>
References: <568BB329-6F50-43B4-BE1D-3A9D7EA60F79@oracle.com>
 <bf02b8ab-6772-77c8-03cb-e9c5832b06df@oracle.com>
 <35347485-216D-42BC-A05A-8D974E3FA581@oracle.com>
 <56e127e9-3802-a8d5-9a79-042166f02409@oracle.com>
 <5F4A83A9.1000207@oracle.com>
Message-ID: <52ac2d88-a088-f579-ecf4-b851a97f9607@oracle.com>

The minimum number of reviewers will remain at 1. Any "R"eviewer can 
raise the minimum usnig the `/reviewers` command, for example:

/reviewers 2

This will then require 2 reviewers. We use this for JavaFX and it has 
worked well. Having certain areas (e.g., 2d, swing, awt) default to 
`/reviewers 2` might be a useful RFE for Skara (Erik or Robin can 
comment as to whether they thing this is feasible).

I can't think of any good way for automated tooling to be able to 
recognize that the "right sort" of reviewers with the right expertise 
(someone from 2D someone from build, etc) have reviewed it.

-- Kevin


On 8/29/2020 9:34 AM, Philip Race wrote:
> I have some questions which at least tangentially relate to the list 
> mappings which raise
> what to me are tricky problems but maybe they've already been thought 
> through and solved.
>
> First, what is the minimum number of reviewers required a fix for the 
> JDK project ?
>
> Second, how can we have that by default adjusted depending on mailing 
> list, with the
> ability to either raise or lower that number according to the 
> judgement of the fixer.
> In the client area 2 reviewers is the big rule, only one has to be a 
> Capital R reviewer,
> but for trivial and urgent fixes we allow just one reviewer.
>
> Third, if a fix is cross-posted to (say) build-dev and 2d-dev, how do 
> you ensure it
> gets both a build reviewer and a 2D reviewer's approval before pushing 
> ? That
> is after all the point of the cross-posting.
>
> -phil.
>
> On 8/27/20, 10:37 AM, Joe Darcy wrote:
>> Hello,
>>
>> The mapping of 
>> changed-file-to-OpenJDK-mailing-list(s)-to-review-the-file can be 
>> non-obvious, both to new contributors and to experienced contributors 
>> working in an unfamiliar area. If an automated mapping gets this 95+% 
>> correct, with the ability for manual tweaking, that strikes me as an 
>> overall improvement over the current situation.
>>
>> The current mapping has various entries that should be changed, but 
>> that is why it is being sent out for review before the Skara 
>> transition :-)
>>
>> As a general comment, I would expect both the mapping and other 
>> aspects of the Skara tooling to get updated in response to feedback 
>> after jdk/jdk moves over.
>>
>> -Joe
>>
>> On 8/27/2020 9:53 AM, Igor Ignatyev wrote:
>>> Hi Robin,
>>>
>>> although I really like the idea of having mapping b/w files and 
>>> groups/components/subcomponents, I agree w/ David that in its 
>>> *current* form it's unworkable. having the mapping in Skara repo is 
>>> impractical, as it introduces additional overhead for maintenance, 
>>> not to speak of possible desynchronization. Thus I suggest moving 
>>> the mapping to jdk/jdk repo and updating Skara tooling accordingly.
>>>
>>> I also have a question regarding the format, why did you decide to 
>>> invent your own format instead of using CODEOWNER-like format which 
>>> fits the needs rather nicely and is used for similar purposes by 
>>> github and gitlab?
>>>
>>> Thanks,
>>> -- Igor
>>>
>>>> On Aug 27, 2020, at 6:26 AM, David Holmes <david.holmes at oracle.com> 
>>>> wrote:
>>>>
>>>> In all seriousness I just don't think this is a reasonable or 
>>>> necessary thing to do. When you create a PR you should specify the 
>>>> mailing lists to be used, as you do today with a RFR. Trying to 
>>>> maintain a file by file mapping is just a huge initial setup cost 
>>>> and a maintenance nightmare. It is not necessary to try and 
>>>> automate this IMO.
>>>>
>>>> I wish this intent had been flagged/discussed some time ago. :(
>>>>
>>>> David
>>>> -----
>>>>
>>>> On 27/08/2020 8:34 pm, Robin Westberg wrote:
>>>>> Hi all,
>>>>> As part of transitioning the jdk/jdk repository to Git with 
>>>>> project Skara, we have created a set of rules that determine which 
>>>>> mailing list(s) should be the default recipient of a review 
>>>>> request, depending on which files are changed. The initial version 
>>>>> of these rules was created by looking at historical commits and 
>>>>> matching them with existing mailing list review threads. This has 
>>>>> produced a reasonable basis, but it can most certainly be made 
>>>>> better with some additional manual curating.
>>>>> Therefore, it would be very helpful if people with good knowledge 
>>>>> of the various subsystems and source files that make up the JDK 
>>>>> would be willing to take a look at these rules, and also suggest 
>>>>> improvements where needed. In addition, lists like [1] would also 
>>>>> be very useful insofar they exist.
>>>>> The current version of these rules is located in a JSON file in 
>>>>> the Skara repository at [2]. In order to check the validity of the 
>>>>> rules, there is also a CLI tool that can be used to apply it to 
>>>>> either a subset of files or existing commits and produce a 
>>>>> suggestion [3] [4]. If you are interested in helping out with 
>>>>> curating these rules, these are the steps to get started:
>>>>> 1. Install the Skara CLI tools: 
>>>>> https://wiki.openjdk.java.net/display/SKARA/CLI+Tools
>>>>> 2. Locate a suitable clone of the jdk/jdk repository (either 
>>>>> Mercurial or Git is fine)
>>>>> 3. Change (cd) to the root of your jdk/jdk repository
>>>>> 3. Run the ?debug mlrules? command on your favorite subset of 
>>>>> files, for example like this (use the actual location of jdk.json 
>>>>> on your system):
>>>>> $ git skara debug mlrules -v 
>>>>> ~/git/skara/config/mailinglist/rules/jdk.json src/hotspot/share/jfr/
>>>>> Reading rules file...
>>>>> src/hotspot/share/jfr/dcmd: [hotspot-jfr-dev]
>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp: 
>>>>> [hotspot-jfr-dev]
>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.hpp: 
>>>>> [hotspot-jfr-dev]
>>>>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp: 
>>>>> [hotspot-jfr-dev, serviceability-dev]
>>>>> ?
>>>>> Final list suggestion is: [hotspot-jfr-dev, serviceability-dev]
>>>>> The command accepts multiple folder and/or file names to make it 
>>>>> possible to simulate a potential change to a given set of files:
>>>>> $ git skara debug mlrules -v 
>>>>> ../skara/config/mailinglist/rules/jdk.json doc/ide.md 
>>>>> src/hotspot/cpu/x86/x86.ad src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
>>>>> Reading rules file...
>>>>> doc: [build-dev]
>>>>> src/hotspot/cpu: [hotspot-compiler-dev]
>>>>> src/hotspot/os: [hotspot-runtime-dev, hotspot-gc-dev]
>>>>> Combined list suggestion: [build-dev, hotspot-compiler-dev, 
>>>>> hotspot-gc-dev, hotspot-runtime-dev]
>>>>> Final list suggestion is: [build-dev, hotspot-dev]
>>>>> If the suggestions look fine, all is well. If not, you are welcome 
>>>>> to propose a change to the rules, preferably by editing the 
>>>>> jdk.json file [6] and creating a pull request towards the Skara 
>>>>> project as described in [5]. Coincidentally, this is the same way 
>>>>> that future changes to the jdk/jdk repository will be integrated, 
>>>>> so this exercise could also serve as a way of getting started with 
>>>>> Git / Skara!
>>>>> Best regards,
>>>>> Robin
>>>>> [1] https://openjdk.java.net/groups/2d/2dawtfiles.html
>>>>> [2] 
>>>>> https://git.openjdk.java.net/skara/blob/master/config/mailinglist/rules/jdk.json
>>>>> [3]
>>>>> $ git skara debug mlrules -v 
>>>>> ~/git/skara/config/mailinglist/rules/jdk.json 
>>>>> src/java.desktop/unix/native
>>>>> Reading rules file...
>>>>> src/java.desktop/unix/native/common: [2d-dev]
>>>>> src/java.desktop/unix/native/include: []
>>>>> src/java.desktop/unix/native/libawt: [2d-dev]
>>>>> src/java.desktop/unix/native/libawt_headless: [awt-dev]
>>>>> src/java.desktop/unix/native/libawt_xawt: [awt-dev]
>>>>> src/java.desktop/unix/native/libfontmanager: [2d-dev]
>>>>> src/java.desktop/unix/native/libjawt: [awt-dev]
>>>>> src/java.desktop/unix/native/libsplashscreen: [awt-dev]
>>>>> Combined list suggestion: [2d-dev, awt-dev]
>>>>> Final list suggestion is: [2d-dev, awt-dev]
>>>>> [4]
>>>>> $ git skara debug mlrules -d 30 -v 
>>>>> ~/git/skara/config/mailinglist/rules/jdk.json .
>>>>> ...
>>>>> ? [2d-dev, awt-dev, serviceability-dev] c32923e0: 8240487: Cleanup 
>>>>> whitespace in .cc, .hh, .m, and .mm files
>>>>> ? [awt-dev] 7f74c7dd: 8212226: SurfaceManager throws "Invalid 
>>>>> Image variant" for MultiResolutionImage (Windows)
>>>>> ???? Suggested lists: [2d-dev, awt-dev]
>>>>> ???? Rules matching unmentioned lists [2d-dev]:
>>>>> src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java - 
>>>>> [2d-dev: ^src/java.desktop/share/classes/sun/java2d/]
>>>>> ?
>>>>> [5] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-Workflow
>>>>> [6]
>>>>> The rules are made up of sets of regular expressions for the 
>>>>> various mailing lists that are used for reviewing changes going 
>>>>> into the JDK. If any rule matches, that mailing list will get a 
>>>>> copy of the review request email. For directories containing files 
>>>>> that belong to different subsystems, it?s usually a good idea to 
>>>>> write the rules in a complementary fashion if possible, so that 
>>>>> anything not explicitly mentioned gets a reasonable default. As an 
>>>>> example, see these rules for a subset of awt / 2d / i18n files:
>>>>> ?awt-dev?: 
>>>>> "src/java.desktop/share/classes/sun/awt/(?!font|sunhints|color/|font/|geom/|im/|image/|print/)?
>>>>> ?2d-dev?: 
>>>>> "src/java.desktop/share/classes/sun/awt/(font|sunhints|color/|font/|geom/|image/|print/)"
>>>>> ?I18n-dev?: "src/java.desktop/share/classes/sun/awt/im/?
>>>>> In this example, anything not explicitly indicated as belonging to 
>>>>> either 2d-dev or i18-dev will be matched by awt-dev.


From philip.race at oracle.com  Mon Aug 31 14:04:48 2020
From: philip.race at oracle.com (Philip Race)
Date: Mon, 31 Aug 2020 07:04:48 -0700
Subject: Request for assistance: Verify and update mailing list filter
 rules for jdk/jdk in preparation for Skara transition
In-Reply-To: <52ac2d88-a088-f579-ecf4-b851a97f9607@oracle.com>
References: <568BB329-6F50-43B4-BE1D-3A9D7EA60F79@oracle.com>
 <bf02b8ab-6772-77c8-03cb-e9c5832b06df@oracle.com>
 <35347485-216D-42BC-A05A-8D974E3FA581@oracle.com>
 <56e127e9-3802-a8d5-9a79-042166f02409@oracle.com>
 <5F4A83A9.1000207@oracle.com>
 <52ac2d88-a088-f579-ecf4-b851a97f9607@oracle.com>
Message-ID: <5F4D0380.4040200@oracle.com>


On 8/31/20, 6:11 AM, Kevin Rushforth wrote:
> The minimum number of reviewers will remain at 1. Any "R"eviewer can 
> raise the minimum usnig the `/reviewers` command, for example:
>
> /reviewers 2
>
> This will then require 2 reviewers. We use this for JavaFX and it has 
> worked well. Having certain areas (e.g., 2d, swing, awt) default to 
> `/reviewers 2` might be a useful RFE for Skara (Erik or Robin can 
> comment as to whether they thing this is feasible).

I would hope so, since the github/skara tooling cheerily tells you can 
go right ahead and integrate
once you have the minimum number, and folks will take that message at 
face value,
and at least 8/10 of client bugs should have two reviewers so it should 
be the default.
Relaxing this is exactly the wrong direction once we push directly to 
the main jdk repo
and manually setting them all to two is going to get tedious.

-phil
>
> I can't think of any good way for automated tooling to be able to 
> recognize that the "right sort" of reviewers with the right expertise 
> (someone from 2D someone from build, etc) have reviewed it.

Nor I, but maybe someone on the skara team does.

-phil.

>
> -- Kevin
>
>
> On 8/29/2020 9:34 AM, Philip Race wrote:
>> I have some questions which at least tangentially relate to the list 
>> mappings which raise
>> what to me are tricky problems but maybe they've already been thought 
>> through and solved.
>>
>> First, what is the minimum number of reviewers required a fix for the 
>> JDK project ?
>>
>> Second, how can we have that by default adjusted depending on mailing 
>> list, with the
>> ability to either raise or lower that number according to the 
>> judgement of the fixer.
>> In the client area 2 reviewers is the big rule, only one has to be a 
>> Capital R reviewer,
>> but for trivial and urgent fixes we allow just one reviewer.
>>
>> Third, if a fix is cross-posted to (say) build-dev and 2d-dev, how do 
>> you ensure it
>> gets both a build reviewer and a 2D reviewer's approval before 
>> pushing ? That
>> is after all the point of the cross-posting.
>>
>> -phil.
>>
>> On 8/27/20, 10:37 AM, Joe Darcy wrote:
>>> Hello,
>>>
>>> The mapping of 
>>> changed-file-to-OpenJDK-mailing-list(s)-to-review-the-file can be 
>>> non-obvious, both to new contributors and to experienced 
>>> contributors working in an unfamiliar area. If an automated mapping 
>>> gets this 95+% correct, with the ability for manual tweaking, that 
>>> strikes me as an overall improvement over the current situation.
>>>
>>> The current mapping has various entries that should be changed, but 
>>> that is why it is being sent out for review before the Skara 
>>> transition :-)
>>>
>>> As a general comment, I would expect both the mapping and other 
>>> aspects of the Skara tooling to get updated in response to feedback 
>>> after jdk/jdk moves over.
>>>
>>> -Joe
>>>
>>> On 8/27/2020 9:53 AM, Igor Ignatyev wrote:
>>>> Hi Robin,
>>>>
>>>> although I really like the idea of having mapping b/w files and 
>>>> groups/components/subcomponents, I agree w/ David that in its 
>>>> *current* form it's unworkable. having the mapping in Skara repo is 
>>>> impractical, as it introduces additional overhead for maintenance, 
>>>> not to speak of possible desynchronization. Thus I suggest moving 
>>>> the mapping to jdk/jdk repo and updating Skara tooling accordingly.
>>>>
>>>> I also have a question regarding the format, why did you decide to 
>>>> invent your own format instead of using CODEOWNER-like format which 
>>>> fits the needs rather nicely and is used for similar purposes by 
>>>> github and gitlab?
>>>>
>>>> Thanks,
>>>> -- Igor
>>>>
>>>>> On Aug 27, 2020, at 6:26 AM, David Holmes 
>>>>> <david.holmes at oracle.com> wrote:
>>>>>
>>>>> In all seriousness I just don't think this is a reasonable or 
>>>>> necessary thing to do. When you create a PR you should specify the 
>>>>> mailing lists to be used, as you do today with a RFR. Trying to 
>>>>> maintain a file by file mapping is just a huge initial setup cost 
>>>>> and a maintenance nightmare. It is not necessary to try and 
>>>>> automate this IMO.
>>>>>
>>>>> I wish this intent had been flagged/discussed some time ago. :(
>>>>>
>>>>> David
>>>>> -----
>>>>>
>>>>> On 27/08/2020 8:34 pm, Robin Westberg wrote:
>>>>>> Hi all,
>>>>>> As part of transitioning the jdk/jdk repository to Git with 
>>>>>> project Skara, we have created a set of rules that determine 
>>>>>> which mailing list(s) should be the default recipient of a review 
>>>>>> request, depending on which files are changed. The initial 
>>>>>> version of these rules was created by looking at historical 
>>>>>> commits and matching them with existing mailing list review 
>>>>>> threads. This has produced a reasonable basis, but it can most 
>>>>>> certainly be made better with some additional manual curating.
>>>>>> Therefore, it would be very helpful if people with good knowledge 
>>>>>> of the various subsystems and source files that make up the JDK 
>>>>>> would be willing to take a look at these rules, and also suggest 
>>>>>> improvements where needed. In addition, lists like [1] would also 
>>>>>> be very useful insofar they exist.
>>>>>> The current version of these rules is located in a JSON file in 
>>>>>> the Skara repository at [2]. In order to check the validity of 
>>>>>> the rules, there is also a CLI tool that can be used to apply it 
>>>>>> to either a subset of files or existing commits and produce a 
>>>>>> suggestion [3] [4]. If you are interested in helping out with 
>>>>>> curating these rules, these are the steps to get started:
>>>>>> 1. Install the Skara CLI tools: 
>>>>>> https://wiki.openjdk.java.net/display/SKARA/CLI+Tools
>>>>>> 2. Locate a suitable clone of the jdk/jdk repository (either 
>>>>>> Mercurial or Git is fine)
>>>>>> 3. Change (cd) to the root of your jdk/jdk repository
>>>>>> 3. Run the ?debug mlrules? command on your favorite subset of 
>>>>>> files, for example like this (use the actual location of jdk.json 
>>>>>> on your system):
>>>>>> $ git skara debug mlrules -v 
>>>>>> ~/git/skara/config/mailinglist/rules/jdk.json src/hotspot/share/jfr/
>>>>>> Reading rules file...
>>>>>> src/hotspot/share/jfr/dcmd: [hotspot-jfr-dev]
>>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp: 
>>>>>> [hotspot-jfr-dev]
>>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.hpp: 
>>>>>> [hotspot-jfr-dev]
>>>>>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp: 
>>>>>> [hotspot-jfr-dev, serviceability-dev]
>>>>>> ?
>>>>>> Final list suggestion is: [hotspot-jfr-dev, serviceability-dev]
>>>>>> The command accepts multiple folder and/or file names to make it 
>>>>>> possible to simulate a potential change to a given set of files:
>>>>>> $ git skara debug mlrules -v 
>>>>>> ../skara/config/mailinglist/rules/jdk.json doc/ide.md 
>>>>>> src/hotspot/cpu/x86/x86.ad src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
>>>>>> Reading rules file...
>>>>>> doc: [build-dev]
>>>>>> src/hotspot/cpu: [hotspot-compiler-dev]
>>>>>> src/hotspot/os: [hotspot-runtime-dev, hotspot-gc-dev]
>>>>>> Combined list suggestion: [build-dev, hotspot-compiler-dev, 
>>>>>> hotspot-gc-dev, hotspot-runtime-dev]
>>>>>> Final list suggestion is: [build-dev, hotspot-dev]
>>>>>> If the suggestions look fine, all is well. If not, you are 
>>>>>> welcome to propose a change to the rules, preferably by editing 
>>>>>> the jdk.json file [6] and creating a pull request towards the 
>>>>>> Skara project as described in [5]. Coincidentally, this is the 
>>>>>> same way that future changes to the jdk/jdk repository will be 
>>>>>> integrated, so this exercise could also serve as a way of getting 
>>>>>> started with Git / Skara!
>>>>>> Best regards,
>>>>>> Robin
>>>>>> [1] https://openjdk.java.net/groups/2d/2dawtfiles.html
>>>>>> [2] 
>>>>>> https://git.openjdk.java.net/skara/blob/master/config/mailinglist/rules/jdk.json
>>>>>> [3]
>>>>>> $ git skara debug mlrules -v 
>>>>>> ~/git/skara/config/mailinglist/rules/jdk.json 
>>>>>> src/java.desktop/unix/native
>>>>>> Reading rules file...
>>>>>> src/java.desktop/unix/native/common: [2d-dev]
>>>>>> src/java.desktop/unix/native/include: []
>>>>>> src/java.desktop/unix/native/libawt: [2d-dev]
>>>>>> src/java.desktop/unix/native/libawt_headless: [awt-dev]
>>>>>> src/java.desktop/unix/native/libawt_xawt: [awt-dev]
>>>>>> src/java.desktop/unix/native/libfontmanager: [2d-dev]
>>>>>> src/java.desktop/unix/native/libjawt: [awt-dev]
>>>>>> src/java.desktop/unix/native/libsplashscreen: [awt-dev]
>>>>>> Combined list suggestion: [2d-dev, awt-dev]
>>>>>> Final list suggestion is: [2d-dev, awt-dev]
>>>>>> [4]
>>>>>> $ git skara debug mlrules -d 30 -v 
>>>>>> ~/git/skara/config/mailinglist/rules/jdk.json .
>>>>>> ...
>>>>>> ? [2d-dev, awt-dev, serviceability-dev] c32923e0: 8240487: 
>>>>>> Cleanup whitespace in .cc, .hh, .m, and .mm files
>>>>>> ? [awt-dev] 7f74c7dd: 8212226: SurfaceManager throws "Invalid 
>>>>>> Image variant" for MultiResolutionImage (Windows)
>>>>>>      Suggested lists: [2d-dev, awt-dev]
>>>>>>      Rules matching unmentioned lists [2d-dev]:
>>>>>> src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java - 
>>>>>> [2d-dev: ^src/java.desktop/share/classes/sun/java2d/]
>>>>>> ?
>>>>>> [5] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-Workflow
>>>>>> [6]
>>>>>> The rules are made up of sets of regular expressions for the 
>>>>>> various mailing lists that are used for reviewing changes going 
>>>>>> into the JDK. If any rule matches, that mailing list will get a 
>>>>>> copy of the review request email. For directories containing 
>>>>>> files that belong to different subsystems, it?s usually a good 
>>>>>> idea to write the rules in a complementary fashion if possible, 
>>>>>> so that anything not explicitly mentioned gets a reasonable 
>>>>>> default. As an example, see these rules for a subset of awt / 2d 
>>>>>> / i18n files:
>>>>>> ?awt-dev?: 
>>>>>> "src/java.desktop/share/classes/sun/awt/(?!font|sunhints|color/|font/|geom/|im/|image/|print/)?
>>>>>> ?2d-dev?: 
>>>>>> "src/java.desktop/share/classes/sun/awt/(font|sunhints|color/|font/|geom/|image/|print/)"
>>>>>> ?I18n-dev?: "src/java.desktop/share/classes/sun/awt/im/?
>>>>>> In this example, anything not explicitly indicated as belonging 
>>>>>> to either 2d-dev or i18-dev will be matched by awt-dev.
>

From erik.helin at oracle.com  Mon Aug 31 14:16:59 2020
From: erik.helin at oracle.com (Erik Helin)
Date: Mon, 31 Aug 2020 16:16:59 +0200
Subject: Request for assistance: Verify and update mailing list filter
 rules for jdk/jdk in preparation for Skara transition
In-Reply-To: <5F4A83A9.1000207@oracle.com>
References: <568BB329-6F50-43B4-BE1D-3A9D7EA60F79@oracle.com>
 <bf02b8ab-6772-77c8-03cb-e9c5832b06df@oracle.com>
 <35347485-216D-42BC-A05A-8D974E3FA581@oracle.com>
 <56e127e9-3802-a8d5-9a79-042166f02409@oracle.com>
 <5F4A83A9.1000207@oracle.com>
Message-ID: <f20d6893-f996-c722-3a7d-8e3250f5b944@oracle.com>

On 8/29/20 6:34 PM, Philip Race wrote:
> I have some questions which at least tangentially relate to the list 
> mappings which raise
> what to me are tricky problems but maybe they've already been thought 
> through and solved.
> 
> First, what is the minimum number of reviewers required a fix for the 
> JDK project ?

It is 1 Reviewer as configured by .jcheck/conf.

> Second, how can we have that by default adjusted depending on mailing 
> list, with the
> ability to either raise or lower that number according to the judgement 
> of the fixer.
> In the client area 2 reviewers is the big rule, only one has to be a 
> Capital R reviewer,
> but for trivial and urgent fixes we allow just one reviewer.

Ok, so we have to separate between culture and rules. The .jcheck/conf 
file configures the rules, and the rule is 1 Reviewer.

For several directories in the jdk repository various norms have formed 
with regards to the requirements that needs to be met before one can 
push. For example for the src/hotspot directory you need 1 Reviewer and 
1 Author (or above) to review and you should wait 24 hours before 
pushing. For the client directories you state that 2 Reviewers are 
needed (I wasn't aware, I have never contributed to the client code). 
For the make directory you really ought to get a review from either Erik 
J or Magnus. These norms are not mechanically enforced (not today by 
jcheck, nor tomorrow by Skara), instead they are enforced through 
Reviewers educating contributors about the cultural norms.

> Third, if a fix is cross-posted to (say) build-dev and 2d-dev, how do 
> you ensure it
> gets both a build reviewer and a 2D reviewer's approval before pushing ? 
> That
> is after all the point of the cross-posting.

The norm that a change to the Makefiles must be reviewed by a senior 
build engineer (in most cases Erik J or Magnus) is not mechanically 
enforced, as I explained above. The point of cross-posting to build-dev 
is to allow an experienced build engineer to get the chance to look at 
the patch, otherwise the build engineers would have follow all mailing 
lists.

I agree with Kevin that trying to capture all these cultural norms 
automatically is going to be very tricky (if not impossible). Perhaps 
the developers guide could be a good place to store this information?

Remember that today with Mercurial we don't really enforce anything, as 
you can put any Reviewers OpenJDK username on the "Reviewed-by" line and 
then push. A Committer doing this would probably find themselves losing 
their Committer status very quickly though...

Thanks,
Erik

> -phil.
> 
> On 8/27/20, 10:37 AM, Joe Darcy wrote:
>> Hello,
>>
>> The mapping of 
>> changed-file-to-OpenJDK-mailing-list(s)-to-review-the-file can be 
>> non-obvious, both to new contributors and to experienced contributors 
>> working in an unfamiliar area. If an automated mapping gets this 95+% 
>> correct, with the ability for manual tweaking, that strikes me as an 
>> overall improvement over the current situation.
>>
>> The current mapping has various entries that should be changed, but 
>> that is why it is being sent out for review before the Skara 
>> transition :-)
>>
>> As a general comment, I would expect both the mapping and other 
>> aspects of the Skara tooling to get updated in response to feedback 
>> after jdk/jdk moves over.
>>
>> -Joe
>>
>> On 8/27/2020 9:53 AM, Igor Ignatyev wrote:
>>> Hi Robin,
>>>
>>> although I really like the idea of having mapping b/w files and 
>>> groups/components/subcomponents, I agree w/ David that in its 
>>> *current* form it's unworkable. having the mapping in Skara repo is 
>>> impractical, as it introduces additional overhead for maintenance, 
>>> not to speak of possible desynchronization. Thus I suggest moving the 
>>> mapping to jdk/jdk repo and updating Skara tooling accordingly.
>>>
>>> I also have a question regarding the format, why did you decide to 
>>> invent your own format instead of using CODEOWNER-like format which 
>>> fits the needs rather nicely and is used for similar purposes by 
>>> github and gitlab?
>>>
>>> Thanks,
>>> -- Igor
>>>
>>>> On Aug 27, 2020, at 6:26 AM, David Holmes <david.holmes at oracle.com> 
>>>> wrote:
>>>>
>>>> In all seriousness I just don't think this is a reasonable or 
>>>> necessary thing to do. When you create a PR you should specify the 
>>>> mailing lists to be used, as you do today with a RFR. Trying to 
>>>> maintain a file by file mapping is just a huge initial setup cost 
>>>> and a maintenance nightmare. It is not necessary to try and automate 
>>>> this IMO.
>>>>
>>>> I wish this intent had been flagged/discussed some time ago. :(
>>>>
>>>> David
>>>> -----
>>>>
>>>> On 27/08/2020 8:34 pm, Robin Westberg wrote:
>>>>> Hi all,
>>>>> As part of transitioning the jdk/jdk repository to Git with project 
>>>>> Skara, we have created a set of rules that determine which mailing 
>>>>> list(s) should be the default recipient of a review request, 
>>>>> depending on which files are changed. The initial version of these 
>>>>> rules was created by looking at historical commits and matching 
>>>>> them with existing mailing list review threads. This has produced a 
>>>>> reasonable basis, but it can most certainly be made better with 
>>>>> some additional manual curating.
>>>>> Therefore, it would be very helpful if people with good knowledge 
>>>>> of the various subsystems and source files that make up the JDK 
>>>>> would be willing to take a look at these rules, and also suggest 
>>>>> improvements where needed. In addition, lists like [1] would also 
>>>>> be very useful insofar they exist.
>>>>> The current version of these rules is located in a JSON file in the 
>>>>> Skara repository at [2]. In order to check the validity of the 
>>>>> rules, there is also a CLI tool that can be used to apply it to 
>>>>> either a subset of files or existing commits and produce a 
>>>>> suggestion [3] [4]. If you are interested in helping out with 
>>>>> curating these rules, these are the steps to get started:
>>>>> 1. Install the Skara CLI tools: 
>>>>> https://wiki.openjdk.java.net/display/SKARA/CLI+Tools
>>>>> 2. Locate a suitable clone of the jdk/jdk repository (either 
>>>>> Mercurial or Git is fine)
>>>>> 3. Change (cd) to the root of your jdk/jdk repository
>>>>> 3. Run the ?debug mlrules? command on your favorite subset of 
>>>>> files, for example like this (use the actual location of jdk.json 
>>>>> on your system):
>>>>> $ git skara debug mlrules -v 
>>>>> ~/git/skara/config/mailinglist/rules/jdk.json src/hotspot/share/jfr/
>>>>> Reading rules file...
>>>>> src/hotspot/share/jfr/dcmd: [hotspot-jfr-dev]
>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp: 
>>>>> [hotspot-jfr-dev]
>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.hpp: 
>>>>> [hotspot-jfr-dev]
>>>>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp: 
>>>>> [hotspot-jfr-dev, serviceability-dev]
>>>>> ?
>>>>> Final list suggestion is: [hotspot-jfr-dev, serviceability-dev]
>>>>> The command accepts multiple folder and/or file names to make it 
>>>>> possible to simulate a potential change to a given set of files:
>>>>> $ git skara debug mlrules -v 
>>>>> ../skara/config/mailinglist/rules/jdk.json doc/ide.md 
>>>>> src/hotspot/cpu/x86/x86.ad src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
>>>>> Reading rules file...
>>>>> doc: [build-dev]
>>>>> src/hotspot/cpu: [hotspot-compiler-dev]
>>>>> src/hotspot/os: [hotspot-runtime-dev, hotspot-gc-dev]
>>>>> Combined list suggestion: [build-dev, hotspot-compiler-dev, 
>>>>> hotspot-gc-dev, hotspot-runtime-dev]
>>>>> Final list suggestion is: [build-dev, hotspot-dev]
>>>>> If the suggestions look fine, all is well. If not, you are welcome 
>>>>> to propose a change to the rules, preferably by editing the 
>>>>> jdk.json file [6] and creating a pull request towards the Skara 
>>>>> project as described in [5]. Coincidentally, this is the same way 
>>>>> that future changes to the jdk/jdk repository will be integrated, 
>>>>> so this exercise could also serve as a way of getting started with 
>>>>> Git / Skara!
>>>>> Best regards,
>>>>> Robin
>>>>> [1] https://openjdk.java.net/groups/2d/2dawtfiles.html
>>>>> [2] 
>>>>> https://git.openjdk.java.net/skara/blob/master/config/mailinglist/rules/jdk.json 
>>>>>
>>>>> [3]
>>>>> $ git skara debug mlrules -v 
>>>>> ~/git/skara/config/mailinglist/rules/jdk.json 
>>>>> src/java.desktop/unix/native
>>>>> Reading rules file...
>>>>> src/java.desktop/unix/native/common: [2d-dev]
>>>>> src/java.desktop/unix/native/include: []
>>>>> src/java.desktop/unix/native/libawt: [2d-dev]
>>>>> src/java.desktop/unix/native/libawt_headless: [awt-dev]
>>>>> src/java.desktop/unix/native/libawt_xawt: [awt-dev]
>>>>> src/java.desktop/unix/native/libfontmanager: [2d-dev]
>>>>> src/java.desktop/unix/native/libjawt: [awt-dev]
>>>>> src/java.desktop/unix/native/libsplashscreen: [awt-dev]
>>>>> Combined list suggestion: [2d-dev, awt-dev]
>>>>> Final list suggestion is: [2d-dev, awt-dev]
>>>>> [4]
>>>>> $ git skara debug mlrules -d 30 -v 
>>>>> ~/git/skara/config/mailinglist/rules/jdk.json .
>>>>> ...
>>>>> ? [2d-dev, awt-dev, serviceability-dev] c32923e0: 8240487: Cleanup 
>>>>> whitespace in .cc, .hh, .m, and .mm files
>>>>> ? [awt-dev] 7f74c7dd: 8212226: SurfaceManager throws "Invalid Image 
>>>>> variant" for MultiResolutionImage (Windows)
>>>>> ???? Suggested lists: [2d-dev, awt-dev]
>>>>> ???? Rules matching unmentioned lists [2d-dev]:
>>>>> ?????? src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java 
>>>>> - [2d-dev: ^src/java.desktop/share/classes/sun/java2d/]
>>>>> ?
>>>>> [5] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-Workflow
>>>>> [6]
>>>>> The rules are made up of sets of regular expressions for the 
>>>>> various mailing lists that are used for reviewing changes going 
>>>>> into the JDK. If any rule matches, that mailing list will get a 
>>>>> copy of the review request email. For directories containing files 
>>>>> that belong to different subsystems, it?s usually a good idea to 
>>>>> write the rules in a complementary fashion if possible, so that 
>>>>> anything not explicitly mentioned gets a reasonable default. As an 
>>>>> example, see these rules for a subset of awt / 2d / i18n files:
>>>>> ?awt-dev?: 
>>>>> "src/java.desktop/share/classes/sun/awt/(?!font|sunhints|color/|font/|geom/|im/|image/|print/)? 
>>>>>
>>>>> ?2d-dev?: 
>>>>> "src/java.desktop/share/classes/sun/awt/(font|sunhints|color/|font/|geom/|image/|print/)" 
>>>>>
>>>>> ?I18n-dev?: "src/java.desktop/share/classes/sun/awt/im/?
>>>>> In this example, anything not explicitly indicated as belonging to 
>>>>> either 2d-dev or i18-dev will be matched by awt-dev.

From erik.helin at oracle.com  Mon Aug 31 14:25:07 2020
From: erik.helin at oracle.com (Erik Helin)
Date: Mon, 31 Aug 2020 16:25:07 +0200
Subject: Request for assistance: Verify and update mailing list filter
 rules for jdk/jdk in preparation for Skara transition
In-Reply-To: <5F4D0380.4040200@oracle.com>
References: <568BB329-6F50-43B4-BE1D-3A9D7EA60F79@oracle.com>
 <bf02b8ab-6772-77c8-03cb-e9c5832b06df@oracle.com>
 <35347485-216D-42BC-A05A-8D974E3FA581@oracle.com>
 <56e127e9-3802-a8d5-9a79-042166f02409@oracle.com>
 <5F4A83A9.1000207@oracle.com>
 <52ac2d88-a088-f579-ecf4-b851a97f9607@oracle.com>
 <5F4D0380.4040200@oracle.com>
Message-ID: <23dd9118-2e72-ebfb-cc35-a60de6c27cb0@oracle.com>



On 8/31/20 4:04 PM, Philip Race wrote:
> 
> On 8/31/20, 6:11 AM, Kevin Rushforth wrote:
>> The minimum number of reviewers will remain at 1. Any "R"eviewer can 
>> raise the minimum usnig the `/reviewers` command, for example:
>>
>> /reviewers 2
>>
>> This will then require 2 reviewers. We use this for JavaFX and it has 
>> worked well. Having certain areas (e.g., 2d, swing, awt) default to 
>> `/reviewers 2` might be a useful RFE for Skara (Erik or Robin can 
>> comment as to whether they thing this is feasible).
> 
> I would hope so, since the github/skara tooling cheerily tells you can 
> go right ahead and integrate
> once you have the minimum number, and folks will take that message at 
> face value,
> and at least 8/10 of client bugs should have two reviewers so it should 
> be the default.
> Relaxing this is exactly the wrong direction once we push directly to 
> the main jdk repo
> and manually setting them all to two is going to get tedious.

To be precise, the bot states:

 > This change now passes all automated pre-integration checks. When the
 > change also fulfills all [project specific requirements
 > (https://github.com/openjdk/jdk/blob/master/CONTRIBUTING.md), type
 > /integrate in a new comment to proceed. After integration, the commit
 > message will be:

As you can see above we only state that the changes passes the 
_automated_ pre-integration checks. Furthermore we also provide a link 
to additional project specific requirements. For the jdk project, the 
file CONTRIBUTING.md contains a link to https://openjdk.java.net/contribute.

We could potentially highlight *automated* a bit more and also more 
strongly encourage the contributor read the contributing guidelines. As 
I stated in my earlier reply, I don't think it will be possible to 
capture all the details of the informal rules that apply for various 
sub-directories in the jdk repository in a program.

Remember that the guideline is that you should make 8 non-trivial 
changes before you get nomiated to become a Committer (a person who is 
*not* a Committer cannot use /integrate). Reviewers therefore have 
plenty time to educate and guide newcomers during those 8 reviews.

Thanks,
Erik

> -phil
>>
>> I can't think of any good way for automated tooling to be able to 
>> recognize that the "right sort" of reviewers with the right expertise 
>> (someone from 2D someone from build, etc) have reviewed it.
> 
> Nor I, but maybe someone on the skara team does.
> 
> -phil.
> 
>>
>> -- Kevin
>>
>>
>> On 8/29/2020 9:34 AM, Philip Race wrote:
>>> I have some questions which at least tangentially relate to the list 
>>> mappings which raise
>>> what to me are tricky problems but maybe they've already been thought 
>>> through and solved.
>>>
>>> First, what is the minimum number of reviewers required a fix for the 
>>> JDK project ?
>>>
>>> Second, how can we have that by default adjusted depending on mailing 
>>> list, with the
>>> ability to either raise or lower that number according to the 
>>> judgement of the fixer.
>>> In the client area 2 reviewers is the big rule, only one has to be a 
>>> Capital R reviewer,
>>> but for trivial and urgent fixes we allow just one reviewer.
>>>
>>> Third, if a fix is cross-posted to (say) build-dev and 2d-dev, how do 
>>> you ensure it
>>> gets both a build reviewer and a 2D reviewer's approval before 
>>> pushing ? That
>>> is after all the point of the cross-posting.
>>>
>>> -phil.
>>>
>>> On 8/27/20, 10:37 AM, Joe Darcy wrote:
>>>> Hello,
>>>>
>>>> The mapping of 
>>>> changed-file-to-OpenJDK-mailing-list(s)-to-review-the-file can be 
>>>> non-obvious, both to new contributors and to experienced 
>>>> contributors working in an unfamiliar area. If an automated mapping 
>>>> gets this 95+% correct, with the ability for manual tweaking, that 
>>>> strikes me as an overall improvement over the current situation.
>>>>
>>>> The current mapping has various entries that should be changed, but 
>>>> that is why it is being sent out for review before the Skara 
>>>> transition :-)
>>>>
>>>> As a general comment, I would expect both the mapping and other 
>>>> aspects of the Skara tooling to get updated in response to feedback 
>>>> after jdk/jdk moves over.
>>>>
>>>> -Joe
>>>>
>>>> On 8/27/2020 9:53 AM, Igor Ignatyev wrote:
>>>>> Hi Robin,
>>>>>
>>>>> although I really like the idea of having mapping b/w files and 
>>>>> groups/components/subcomponents, I agree w/ David that in its 
>>>>> *current* form it's unworkable. having the mapping in Skara repo is 
>>>>> impractical, as it introduces additional overhead for maintenance, 
>>>>> not to speak of possible desynchronization. Thus I suggest moving 
>>>>> the mapping to jdk/jdk repo and updating Skara tooling accordingly.
>>>>>
>>>>> I also have a question regarding the format, why did you decide to 
>>>>> invent your own format instead of using CODEOWNER-like format which 
>>>>> fits the needs rather nicely and is used for similar purposes by 
>>>>> github and gitlab?
>>>>>
>>>>> Thanks,
>>>>> -- Igor
>>>>>
>>>>>> On Aug 27, 2020, at 6:26 AM, David Holmes 
>>>>>> <david.holmes at oracle.com> wrote:
>>>>>>
>>>>>> In all seriousness I just don't think this is a reasonable or 
>>>>>> necessary thing to do. When you create a PR you should specify the 
>>>>>> mailing lists to be used, as you do today with a RFR. Trying to 
>>>>>> maintain a file by file mapping is just a huge initial setup cost 
>>>>>> and a maintenance nightmare. It is not necessary to try and 
>>>>>> automate this IMO.
>>>>>>
>>>>>> I wish this intent had been flagged/discussed some time ago. :(
>>>>>>
>>>>>> David
>>>>>> -----
>>>>>>
>>>>>> On 27/08/2020 8:34 pm, Robin Westberg wrote:
>>>>>>> Hi all,
>>>>>>> As part of transitioning the jdk/jdk repository to Git with 
>>>>>>> project Skara, we have created a set of rules that determine 
>>>>>>> which mailing list(s) should be the default recipient of a review 
>>>>>>> request, depending on which files are changed. The initial 
>>>>>>> version of these rules was created by looking at historical 
>>>>>>> commits and matching them with existing mailing list review 
>>>>>>> threads. This has produced a reasonable basis, but it can most 
>>>>>>> certainly be made better with some additional manual curating.
>>>>>>> Therefore, it would be very helpful if people with good knowledge 
>>>>>>> of the various subsystems and source files that make up the JDK 
>>>>>>> would be willing to take a look at these rules, and also suggest 
>>>>>>> improvements where needed. In addition, lists like [1] would also 
>>>>>>> be very useful insofar they exist.
>>>>>>> The current version of these rules is located in a JSON file in 
>>>>>>> the Skara repository at [2]. In order to check the validity of 
>>>>>>> the rules, there is also a CLI tool that can be used to apply it 
>>>>>>> to either a subset of files or existing commits and produce a 
>>>>>>> suggestion [3] [4]. If you are interested in helping out with 
>>>>>>> curating these rules, these are the steps to get started:
>>>>>>> 1. Install the Skara CLI tools: 
>>>>>>> https://wiki.openjdk.java.net/display/SKARA/CLI+Tools
>>>>>>> 2. Locate a suitable clone of the jdk/jdk repository (either 
>>>>>>> Mercurial or Git is fine)
>>>>>>> 3. Change (cd) to the root of your jdk/jdk repository
>>>>>>> 3. Run the ?debug mlrules? command on your favorite subset of 
>>>>>>> files, for example like this (use the actual location of jdk.json 
>>>>>>> on your system):
>>>>>>> $ git skara debug mlrules -v 
>>>>>>> ~/git/skara/config/mailinglist/rules/jdk.json src/hotspot/share/jfr/
>>>>>>> Reading rules file...
>>>>>>> src/hotspot/share/jfr/dcmd: [hotspot-jfr-dev]
>>>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp: 
>>>>>>> [hotspot-jfr-dev]
>>>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.hpp: 
>>>>>>> [hotspot-jfr-dev]
>>>>>>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp: 
>>>>>>> [hotspot-jfr-dev, serviceability-dev]
>>>>>>> ?
>>>>>>> Final list suggestion is: [hotspot-jfr-dev, serviceability-dev]
>>>>>>> The command accepts multiple folder and/or file names to make it 
>>>>>>> possible to simulate a potential change to a given set of files:
>>>>>>> $ git skara debug mlrules -v 
>>>>>>> ../skara/config/mailinglist/rules/jdk.json doc/ide.md 
>>>>>>> src/hotspot/cpu/x86/x86.ad src/hotspot/os/linux/gc/z/zNUMA_linux.cpp
>>>>>>> Reading rules file...
>>>>>>> doc: [build-dev]
>>>>>>> src/hotspot/cpu: [hotspot-compiler-dev]
>>>>>>> src/hotspot/os: [hotspot-runtime-dev, hotspot-gc-dev]
>>>>>>> Combined list suggestion: [build-dev, hotspot-compiler-dev, 
>>>>>>> hotspot-gc-dev, hotspot-runtime-dev]
>>>>>>> Final list suggestion is: [build-dev, hotspot-dev]
>>>>>>> If the suggestions look fine, all is well. If not, you are 
>>>>>>> welcome to propose a change to the rules, preferably by editing 
>>>>>>> the jdk.json file [6] and creating a pull request towards the 
>>>>>>> Skara project as described in [5]. Coincidentally, this is the 
>>>>>>> same way that future changes to the jdk/jdk repository will be 
>>>>>>> integrated, so this exercise could also serve as a way of getting 
>>>>>>> started with Git / Skara!
>>>>>>> Best regards,
>>>>>>> Robin
>>>>>>> [1] https://openjdk.java.net/groups/2d/2dawtfiles.html
>>>>>>> [2] 
>>>>>>> https://git.openjdk.java.net/skara/blob/master/config/mailinglist/rules/jdk.json 
>>>>>>>
>>>>>>> [3]
>>>>>>> $ git skara debug mlrules -v 
>>>>>>> ~/git/skara/config/mailinglist/rules/jdk.json 
>>>>>>> src/java.desktop/unix/native
>>>>>>> Reading rules file...
>>>>>>> src/java.desktop/unix/native/common: [2d-dev]
>>>>>>> src/java.desktop/unix/native/include: []
>>>>>>> src/java.desktop/unix/native/libawt: [2d-dev]
>>>>>>> src/java.desktop/unix/native/libawt_headless: [awt-dev]
>>>>>>> src/java.desktop/unix/native/libawt_xawt: [awt-dev]
>>>>>>> src/java.desktop/unix/native/libfontmanager: [2d-dev]
>>>>>>> src/java.desktop/unix/native/libjawt: [awt-dev]
>>>>>>> src/java.desktop/unix/native/libsplashscreen: [awt-dev]
>>>>>>> Combined list suggestion: [2d-dev, awt-dev]
>>>>>>> Final list suggestion is: [2d-dev, awt-dev]
>>>>>>> [4]
>>>>>>> $ git skara debug mlrules -d 30 -v 
>>>>>>> ~/git/skara/config/mailinglist/rules/jdk.json .
>>>>>>> ...
>>>>>>> ? [2d-dev, awt-dev, serviceability-dev] c32923e0: 8240487: 
>>>>>>> Cleanup whitespace in .cc, .hh, .m, and .mm files
>>>>>>> ? [awt-dev] 7f74c7dd: 8212226: SurfaceManager throws "Invalid 
>>>>>>> Image variant" for MultiResolutionImage (Windows)
>>>>>>> ???? Suggested lists: [2d-dev, awt-dev]
>>>>>>> ???? Rules matching unmentioned lists [2d-dev]:
>>>>>>> src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java - 
>>>>>>> [2d-dev: ^src/java.desktop/share/classes/sun/java2d/]
>>>>>>> ?
>>>>>>> [5] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-Workflow
>>>>>>> [6]
>>>>>>> The rules are made up of sets of regular expressions for the 
>>>>>>> various mailing lists that are used for reviewing changes going 
>>>>>>> into the JDK. If any rule matches, that mailing list will get a 
>>>>>>> copy of the review request email. For directories containing 
>>>>>>> files that belong to different subsystems, it?s usually a good 
>>>>>>> idea to write the rules in a complementary fashion if possible, 
>>>>>>> so that anything not explicitly mentioned gets a reasonable 
>>>>>>> default. As an example, see these rules for a subset of awt / 2d 
>>>>>>> / i18n files:
>>>>>>> ?awt-dev?: 
>>>>>>> "src/java.desktop/share/classes/sun/awt/(?!font|sunhints|color/|font/|geom/|im/|image/|print/)? 
>>>>>>>
>>>>>>> ?2d-dev?: 
>>>>>>> "src/java.desktop/share/classes/sun/awt/(font|sunhints|color/|font/|geom/|image/|print/)" 
>>>>>>>
>>>>>>> ?I18n-dev?: "src/java.desktop/share/classes/sun/awt/im/?
>>>>>>> In this example, anything not explicitly indicated as belonging 
>>>>>>> to either 2d-dev or i18-dev will be matched by awt-dev.
>>

From rwestberg at openjdk.java.net  Mon Aug 31 15:09:15 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 15:09:15 GMT
Subject: RFR: 448: Rerun check after updating title
Message-ID: <s4e3K-mn4RDf5DzcOWUkum02NbK_HX5DMINiMLq_U7Y=.91465600-17cd-4b08-99ee-852f0fa2860e@github.com>

Hi all,

Please review this change that ensure that auto-expansion of an issue ID in a PR title results in rerunning a check.

Best regards,
Robin

-------------

Commit messages:
 - Perform title expansion before running checks

Changes: https://git.openjdk.java.net/skara/pull/758/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=758&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-448
  Stats: 107 lines in 3 files changed: 81 ins; 24 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/758.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/758/head:pull/758

PR: https://git.openjdk.java.net/skara/pull/758

From ehelin at openjdk.java.net  Mon Aug 31 15:13:09 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 31 Aug 2020 15:13:09 GMT
Subject: RFR: 448: Rerun check after updating title
In-Reply-To: <s4e3K-mn4RDf5DzcOWUkum02NbK_HX5DMINiMLq_U7Y=.91465600-17cd-4b08-99ee-852f0fa2860e@github.com>
References: <s4e3K-mn4RDf5DzcOWUkum02NbK_HX5DMINiMLq_U7Y=.91465600-17cd-4b08-99ee-852f0fa2860e@github.com>
Message-ID: <7roJrR89aHQvISyGBlFxq-T-fGEVpzv6sMjA9C4sx88=.71990709-37fa-48f5-ae02-c12fedb435f2@github.com>

On Mon, 31 Aug 2020 15:06:30 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that ensure that auto-expansion of an issue ID in a PR title results in rerunning a check.
> 
> Best regards,
> Robin

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/758

From rwestberg at openjdk.java.net  Mon Aug 31 16:29:29 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 31 Aug 2020 16:29:29 GMT
Subject: Integrated: 448: Rerun check after updating title
In-Reply-To: <s4e3K-mn4RDf5DzcOWUkum02NbK_HX5DMINiMLq_U7Y=.91465600-17cd-4b08-99ee-852f0fa2860e@github.com>
References: <s4e3K-mn4RDf5DzcOWUkum02NbK_HX5DMINiMLq_U7Y=.91465600-17cd-4b08-99ee-852f0fa2860e@github.com>
Message-ID: <x8ukaboZDVCw1ahrs6LQWKAXt0_D-jGv0NXcKBGP7x4=.439eca98-76fb-4c90-af66-00fdc72b9c6e@github.com>

On Mon, 31 Aug 2020 15:06:30 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that ensure that auto-expansion of an issue ID in a PR title results in rerunning a check.
> 
> Best regards,
> Robin

This pull request has now been integrated.

Changeset: 159f939a
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/159f939a
Stats:     107 lines in 3 files changed: 24 ins; 81 del; 2 mod

448: Rerun check after updating title

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/758

From david.holmes at oracle.com  Mon Aug 31 22:35:55 2020
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 1 Sep 2020 08:35:55 +1000
Subject: Email subject line formatting
In-Reply-To: <84A2E391-7540-464E-8C0A-04808B7688BF@oracle.com>
References: <3b83157d-3570-129f-d4a7-028c6872885d@oracle.com>
 <7f585de8-a702-f06d-db53-40f49b4db6a0@oracle.com>
 <84A2E391-7540-464E-8C0A-04808B7688BF@oracle.com>
Message-ID: <8dfbadc4-7539-ea31-982c-671e45a4708c@oracle.com>

Thanks Robin, that seems mostly okay to me.

One nit is that the "Integrated" mail will sort before the RFR mails 
when sorting by subject.

Cheers,
David

On 31/08/2020 9:56 pm, Robin Westberg wrote:
> Hi David,
> 
>> On 28 Aug 2020, at 02:26, David Holmes <david.holmes at oracle.com> wrote:
>>
>> As the transition to git/skara is now imminent I wanted to re-raise this issue and find out exactly how the email processes will be setup for the mainline JDK project - ie what subject will be used in the various cases.
> 
> I think that the current consensus from this thread is what?s currently active for example for changes here on the skara-dev mailing list. A summary of these subject annotations and the threading would be (hopefully the formatting will survive):
> 
> RFR: 1234: Title				Initial RFR email from a PR
>    Re: RFR: 1234: Title			Comment
>      Re: RFR: 1234: Title			Another comment
>    Re: RFR: 1234: Title [v2]		A new version of the code (with incremental webrevs, etc)
>    Integrated: 1234: Title			Integration notice containing changeset details
>      Re: Integrated: 1234: Title		Further PR comment made after integration
> 
> If a pull request is closed without integration, the final message will be prefixed with ?Withdrawn? instead of ?Integrated?. Similarly, if a PR has already been integrated by the time the first mail can be sent, it will be prefixed with ?Integrated? instead of ?RFR? from the beginning.
> 
> Best regards,
> Robin
> 
>>
>> Thanks,
>> David
>>
>> On 7/04/2020 9:21 am, David Holmes wrote:
>>> Hi everyone,
>>> Erik asked me to raise this here to see if anyone else is bothered by this ...
>>> When an integration email is sent the subject line of the RFR thread is augmented with [integrated] and also adorned with "Re:" as if a reply to the RFR thread e.g.
>>> Re: [Integrated] [foreign-abi] RFR: Revert "JDK-8242127: reorganize ABI-dependent layout constants"
>>> My objection to this is that once the subject has been augmented with [Integrated] it is not appropriate to treat that as a "reply" and use the "Re:". If I see:
>>> [Integrated] [foreign-abi] RFR: Revert "JDK-8242127: reorganize ABI-dependent layout constants"
>>> I know its a changeset notification email and I can ignore it. Just as I can ignore:
>>> git: openjdk/panama-foreign: foreign-jextract: 2 new changesets
>>> or
>>> hg: jdk/jdk: 8242217: Shenandoah: Enable GC mode to be diagnostic/experimental and have a name
>>> but when I see the "Re:" I think "oh someone is commenting on that push, there must be an issue and I should read the email" - which is the case with current hg notification emails!
>>> This would be less of an issue if the sender of the integration email was a bot account but it isn't, it is the committer.
>>> So I'd like to suggest that the "Re:" be dropped from the subject line of these automatically generated integration emails.
>>> Cheers,
>>> David
>