RFR: hg: implement hashes for blobs for ls-tree

Robin Westberg rwestberg at openjdk.java.net
Fri Aug 21 12:58:57 UTC 2020


On Fri, 21 Aug 2020 12:43:15 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that properly implements `ls-tree` for Mercurial.
> 
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Updated unit test
> 
> Thanks,
> Erik

Looks good!

vcs/src/main/resources/ext.py line 336:

> 335:         m.update(data)
> 336:         write(m.hexdigest())
> 337:         write(b'\t')

Python 3 doesn't like this one, perhaps not that urgent to fix though..

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/725


More information about the skara-dev mailing list