From rwestberg at openjdk.java.net  Tue Dec  1 08:39:35 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 1 Dec 2020 08:39:35 GMT
Subject: RFR: Move testing information from the PR body to checks [v3]
In-Reply-To: <6T7nJYX8wCNqN4Z3Y5UEpEF3MluIJyceCvqfDbPPMr0=.7a9b26fd-4a9e-4f5f-b93c-8c0b74aa036a@github.com>
References: <6T7nJYX8wCNqN4Z3Y5UEpEF3MluIJyceCvqfDbPPMr0=.7a9b26fd-4a9e-4f5f-b93c-8c0b74aa036a@github.com>
Message-ID: <NrsWrcksT-XhpdYlHb-WP3S6QsXouX_iPJkYhGlBzVM=.9eea22e8-a0b5-4ec3-9977-1bed99d0b2ec@github.com>

> When summarizing pre-submit test results for a PR, show the results as a number of checks instead of a table in the PR body. This makes them more similar to the source information, and avoids excessive PR body updates.

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Update bots/testinfo/src/main/java/org/openjdk/skara/bots/testinfo/TestInfoBot.java
  
  Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/962/files
  - new: https://git.openjdk.java.net/skara/pull/962/files/39cf8c41..c8f4c2d9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=962&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=962&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/962.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/962/head:pull/962

PR: https://git.openjdk.java.net/skara/pull/962

From rwestberg at openjdk.java.net  Tue Dec  1 08:39:35 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 1 Dec 2020 08:39:35 GMT
Subject: Integrated: Move testing information from the PR body to checks
In-Reply-To: <6T7nJYX8wCNqN4Z3Y5UEpEF3MluIJyceCvqfDbPPMr0=.7a9b26fd-4a9e-4f5f-b93c-8c0b74aa036a@github.com>
References: <6T7nJYX8wCNqN4Z3Y5UEpEF3MluIJyceCvqfDbPPMr0=.7a9b26fd-4a9e-4f5f-b93c-8c0b74aa036a@github.com>
Message-ID: <hKHFKIB8gY7geL1lBSJ7jvUDrVdzU2iMpU-wq-GBpDk=.5feab0ef-58b0-4867-b8dc-600eddf5614c@github.com>

On Wed, 25 Nov 2020 14:07:50 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When summarizing pre-submit test results for a PR, show the results as a number of checks instead of a table in the PR body. This makes them more similar to the source information, and avoids excessive PR body updates.

This pull request has now been integrated.

Changeset: cd1a2851
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/cd1a2851
Stats:     1160 lines in 14 files changed: 688 ins; 467 del; 5 mod

Move testing information from the PR body to checks

Reviewed-by: jvernee

-------------

PR: https://git.openjdk.java.net/skara/pull/962

From thomas.stuefe at gmail.com  Tue Dec  1 11:10:49 2020
From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=)
Date: Tue, 1 Dec 2020 12:10:49 +0100
Subject: jcheck complains about tabs in Makefiles?
Message-ID: <CAA-vtUxbkTC_EL--g2zDrQr0Ur_O4jKpLmRr-fYUvWrqYAfvOw@mail.gmail.com>

Hi,

I am not sure when this started, but git jcheck complains about tabs in
Makefiles:

[whitespace] error: 4c86e46d: tab in make/common/NativeCompilation.gmk:245
                                  $(SED) \
                              ^^^^
[whitespace] error: 4c86e46d: tab in make/common/NativeCompilation.gmk:246
                                      -e 's|^\([ ]*\)\./|\1|' \
                              ^^^^
...

This seems wrong.

Cheers, Thomas

From shade at redhat.com  Tue Dec  1 11:23:09 2020
From: shade at redhat.com (Aleksey Shipilev)
Date: Tue, 1 Dec 2020 12:23:09 +0100
Subject: jcheck complains about tabs in Makefiles?
In-Reply-To: <CAA-vtUxbkTC_EL--g2zDrQr0Ur_O4jKpLmRr-fYUvWrqYAfvOw@mail.gmail.com>
References: <CAA-vtUxbkTC_EL--g2zDrQr0Ur_O4jKpLmRr-fYUvWrqYAfvOw@mail.gmail.com>
Message-ID: <184757aa-f1ed-132b-4368-93f560fe2a47@redhat.com>

On 12/1/20 12:10 PM, Thomas St?fe wrote:
> Hi,
> 
> I am not sure when this started, but git jcheck complains about tabs in
> Makefiles:
> 
> [whitespace] error: 4c86e46d: tab in make/common/NativeCompilation.gmk:245
>                                    $(SED) \
>                                ^^^^
> [whitespace] error: 4c86e46d: tab in make/common/NativeCompilation.gmk:246
>                                        -e 's|^\([ ]*\)\./|\1|' \
>                                ^^^^

I think you need a whole fix in your repo:
   https://bugs.openjdk.java.net/browse/JDK-8255526

Note how it does "ignore-tabs".

IIRC, I caught the same trouble before, and pull from master resolved it.

-- 
Thanks,
-Aleksey


From thomas.stuefe at gmail.com  Tue Dec  1 11:40:24 2020
From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=)
Date: Tue, 1 Dec 2020 12:40:24 +0100
Subject: jcheck complains about tabs in Makefiles?
In-Reply-To: <184757aa-f1ed-132b-4368-93f560fe2a47@redhat.com>
References: <CAA-vtUxbkTC_EL--g2zDrQr0Ur_O4jKpLmRr-fYUvWrqYAfvOw@mail.gmail.com>
 <184757aa-f1ed-132b-4368-93f560fe2a47@redhat.com>
Message-ID: <CAA-vtUyBb6Xb1kmM=0sf2H4EsU9b_Lis5okwsU3e4nkLcB55Ag@mail.gmail.com>

Thanks, Aleksey!

On Tue, Dec 1, 2020 at 12:23 PM Aleksey Shipilev <shade at redhat.com> wrote:

> On 12/1/20 12:10 PM, Thomas St?fe wrote:
> > Hi,
> >
> > I am not sure when this started, but git jcheck complains about tabs in
> > Makefiles:
> >
> > [whitespace] error: 4c86e46d: tab in
> make/common/NativeCompilation.gmk:245
> >                                    $(SED) \
> >                                ^^^^
> > [whitespace] error: 4c86e46d: tab in
> make/common/NativeCompilation.gmk:246
> >                                        -e 's|^\([ ]*\)\./|\1|' \
> >                                ^^^^
>
> I think you need a whole fix in your repo:
>    https://bugs.openjdk.java.net/browse/JDK-8255526
>
> Note how it does "ignore-tabs".
>
> IIRC, I caught the same trouble before, and pull from master resolved it.
>
> --
> Thanks,
> -Aleksey
>
>

From jvernee at openjdk.java.net  Tue Dec  1 11:46:43 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Tue, 1 Dec 2020 11:46:43 GMT
Subject: RFR: Handle trailing blank lines in commit message
In-Reply-To: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
References: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
Message-ID: <tkaU6rbeORDvciukw72iUOM3r_VdG1MJq-WAnTXSBkk=.c3d333b0-4270-4786-bc2e-980e07de33af@github.com>

On Thu, 19 Nov 2020 13:51:24 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> This change ensures that a commit message ending with a blank line does not generate an exception.

vcs/src/main/java/org/openjdk/skara/vcs/openjdk/CommitMessageParsers.java line 121:

> 119:                 if (i >= lines.size()) {
> 120:                     break;
> 121:                 }

I guess I'm a little confused as to how this fixes the problem :/ Is it because `firstDelimiter` is false after the first line and then it adds a blank?

Does it make sense to move the `i++` to the end of the while loop, and then increment it one time separately before the loop, so that the while loop condition can use the `i < lines.size()` condition, and no separate `if` is needed?

-------------

PR: https://git.openjdk.java.net/skara/pull/959

From jvernee at openjdk.java.net  Tue Dec  1 12:28:35 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Tue, 1 Dec 2020 12:28:35 GMT
Subject: RFR: Only consider backports with a proper link relationship
In-Reply-To: <i6B22AeTNf8Sghol2ZOH8jnunUdvSJoWK_M7stNK47E=.cf01eea8-adf3-4349-b9f8-dbdb1c6e3e7a@github.com>
References: <i6B22AeTNf8Sghol2ZOH8jnunUdvSJoWK_M7stNK47E=.cf01eea8-adf3-4349-b9f8-dbdb1c6e3e7a@github.com>
Message-ID: <rgpTr8A9CC1Evx9gyCJI_GunCvSfQWXdV_GIUFPvkhE=.3df6a1ff-d350-41d0-b96a-6dd13e67faf4@github.com>

On Thu, 19 Nov 2020 14:17:40 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> If an issue links to a backport, it should only be consider an actual backport if the link type is correct (to avoid looking at backport issues linked as "related to" for example).

Marked as reviewed by jvernee (Reviewer).

-------------

PR: https://git.openjdk.java.net/skara/pull/960

From jvernee at openjdk.java.net  Tue Dec  1 15:30:56 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Tue, 1 Dec 2020 15:30:56 GMT
Subject: RFR: 819: Backports created by Robo Duke inherit all labels of
 original
In-Reply-To: <Pv5yfQ0fys2j9-j4xZ4qPSsMCrq1SHl9LSctNHC_ZrU=.742bfa3a-5ecc-4838-82c8-212b9548243a@github.com>
References: <Pv5yfQ0fys2j9-j4xZ4qPSsMCrq1SHl9LSctNHC_ZrU=.742bfa3a-5ecc-4838-82c8-212b9548243a@github.com>
Message-ID: <6c1jLYcTfRzgPRHVz-zn7PesaspRvLebBR27lhBS1b0=.1adbd38f-bf38-4a79-9935-e06e4ea2c8ce@github.com>

On Tue, 24 Nov 2020 11:28:39 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Instead of using the custom JBS endpoint for creating backport issues, simply create them directly. Retain the same fields that "hgupdater" does.

Marked as reviewed by jvernee (Reviewer).

-------------

PR: https://git.openjdk.java.net/skara/pull/961

From stuefe at openjdk.java.net  Wed Dec  2 10:20:51 2020
From: stuefe at openjdk.java.net (Thomas Stuefe)
Date: Wed, 2 Dec 2020 10:20:51 GMT
Subject: RFR: Move testing information from the PR body to checks [v2]
In-Reply-To: <AzRen2J4jY5k9XlNd-Zmsyciyl0ClB3cGL-vjoSX2Gc=.ff1ff854-5daa-4b34-a2e1-c67ed1320672@github.com>
References: <6T7nJYX8wCNqN4Z3Y5UEpEF3MluIJyceCvqfDbPPMr0=.7a9b26fd-4a9e-4f5f-b93c-8c0b74aa036a@github.com>
 <ys1IRrTBnFWnrNWjkR-stKHnXb7MjRFBfsdq0NeqbXg=.13441708-35fd-478c-b3b2-c86df240605e@github.com>
 <AzRen2J4jY5k9XlNd-Zmsyciyl0ClB3cGL-vjoSX2Gc=.ff1ff854-5daa-4b34-a2e1-c67ed1320672@github.com>
Message-ID: <uHq5sFRcP_cyRzoJ4f9a22c0EOekoNQ2EhqaPCGDleo=.5c011fb1-48d2-437e-b9b7-e268181781e7@github.com>

On Fri, 27 Nov 2020 17:01:54 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only create summarized checks and put the individual job details in the check summary
>
> Marked as reviewed by jvernee (Reviewer).

Hi,

I don't see the results now at all. See e.g. https://github.com/openjdk/jdk/pull/1390 .

Am I doing something wrong?

Thanks, Thomas

-------------

PR: https://git.openjdk.java.net/skara/pull/962

From rwestberg at openjdk.java.net  Wed Dec  2 10:21:06 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 2 Dec 2020 10:21:06 GMT
Subject: RFR: Handle trailing blank lines in commit message [v2]
In-Reply-To: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
References: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
Message-ID: <SIUPJIswJ1ooUwSeG3LPVKVt6kH20grNzkkretyq2t8=.2ebbd81c-9933-4ac5-8697-a1547a2a10c0@github.com>

> This change ensures that a commit message ending with a blank line does not generate an exception.

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Trailing blank lines end up in "additional"

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/959/files
  - new: https://git.openjdk.java.net/skara/pull/959/files/696fb633..f7ca521d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=959&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=959&range=00-01

  Stats: 5 lines in 2 files changed: 0 ins; 3 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/959.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/959/head:pull/959

PR: https://git.openjdk.java.net/skara/pull/959

From rwestberg at openjdk.java.net  Wed Dec  2 11:13:07 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 2 Dec 2020 11:13:07 GMT
Subject: RFR: Handle trailing blank lines in commit message [v2]
In-Reply-To: <tkaU6rbeORDvciukw72iUOM3r_VdG1MJq-WAnTXSBkk=.c3d333b0-4270-4786-bc2e-980e07de33af@github.com>
References: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
 <tkaU6rbeORDvciukw72iUOM3r_VdG1MJq-WAnTXSBkk=.c3d333b0-4270-4786-bc2e-980e07de33af@github.com>
Message-ID: <SSflQKvpM7A1Q6u4AxcagYIb7h1C5_m3cY-Hcx16Kqc=.23640a4e-bf39-4cf1-ba15-f7b7441cb33f@github.com>

On Tue, 1 Dec 2020 11:43:24 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Trailing blank lines end up in "additional"
>
> vcs/src/main/java/org/openjdk/skara/vcs/openjdk/CommitMessageParsers.java line 121:
> 
>> 119:                 if (i >= lines.size()) {
>> 120:                     break;
>> 121:                 }
> 
> I guess I'm a little confused as to how this fixes the problem :/ Is it because `firstDelimiter` is false after the first line and then it adds a blank?
> 
> Does it make sense to move the `i++` to the end of the while loop, and then increment it one time separately before the loop, so that the while loop condition can use the `i < lines.size()` condition, and no separate `if` is needed?

I agree that the code is a bit unintuitive, have had to look at it a few times.. :) But no, incrementing should only be done if we're at a blank line, so can't do it unconditionally outside of the loop..

I pushed a different version that is perhaps a bit more clear.

-------------

PR: https://git.openjdk.java.net/skara/pull/959

From rwestberg at openjdk.java.net  Wed Dec  2 11:14:03 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 2 Dec 2020 11:14:03 GMT
Subject: Integrated: 819: Backports created by Robo Duke inherit all labels of
 original
In-Reply-To: <Pv5yfQ0fys2j9-j4xZ4qPSsMCrq1SHl9LSctNHC_ZrU=.742bfa3a-5ecc-4838-82c8-212b9548243a@github.com>
References: <Pv5yfQ0fys2j9-j4xZ4qPSsMCrq1SHl9LSctNHC_ZrU=.742bfa3a-5ecc-4838-82c8-212b9548243a@github.com>
Message-ID: <UwjP7VpcrTxtdpXsdoyU8r90AZohfh5UERjUGofWZZs=.784fc524-51d4-4f3d-a888-1a27a04ac822@github.com>

On Tue, 24 Nov 2020 11:28:39 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Instead of using the custom JBS endpoint for creating backport issues, simply create them directly. Retain the same fields that "hgupdater" does.

This pull request has now been integrated.

Changeset: 9a98403e
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/9a98403e
Stats:     242 lines in 7 files changed: 31 ins; 203 del; 8 mod

819: Backports created by Robo Duke inherit all labels of original

Reviewed-by: jvernee

-------------

PR: https://git.openjdk.java.net/skara/pull/961

From rwestberg at openjdk.java.net  Wed Dec  2 11:14:29 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 2 Dec 2020 11:14:29 GMT
Subject: Integrated: Only consider backports with a proper link relationship
In-Reply-To: <i6B22AeTNf8Sghol2ZOH8jnunUdvSJoWK_M7stNK47E=.cf01eea8-adf3-4349-b9f8-dbdb1c6e3e7a@github.com>
References: <i6B22AeTNf8Sghol2ZOH8jnunUdvSJoWK_M7stNK47E=.cf01eea8-adf3-4349-b9f8-dbdb1c6e3e7a@github.com>
Message-ID: <Pzgaxgu_hbdii4J-ApROO33PeGAe-xo_ph0kuJbhwXU=.c0a3e2d9-0e8b-4a27-8fe0-6f1e1079e0d4@github.com>

On Thu, 19 Nov 2020 14:17:40 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> If an issue links to a backport, it should only be consider an actual backport if the link type is correct (to avoid looking at backport issues linked as "related to" for example).

This pull request has now been integrated.

Changeset: 2c4d8792
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/2c4d8792
Stats:     12 lines in 2 files changed: 12 ins; 0 del; 0 mod

Only consider backports with a proper link relationship

Reviewed-by: jvernee

-------------

PR: https://git.openjdk.java.net/skara/pull/960

From jvernee at openjdk.java.net  Wed Dec  2 12:27:59 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Wed, 2 Dec 2020 12:27:59 GMT
Subject: RFR: Handle trailing blank lines in commit message [v2]
In-Reply-To: <SIUPJIswJ1ooUwSeG3LPVKVt6kH20grNzkkretyq2t8=.2ebbd81c-9933-4ac5-8697-a1547a2a10c0@github.com>
References: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
 <SIUPJIswJ1ooUwSeG3LPVKVt6kH20grNzkkretyq2t8=.2ebbd81c-9933-4ac5-8697-a1547a2a10c0@github.com>
Message-ID: <bMH9Ff2oRi7SrOr-79FB70awHZVo9iHLQx4BI9pQcQ8=.9b860e00-fd9b-4511-9845-11b964f74d2b@github.com>

On Wed, 2 Dec 2020 10:21:06 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> This change ensures that a commit message ending with a blank line does not generate an exception.
>
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Trailing blank lines end up in "additional"

Okay, thanks for explaining. I think the new version looks a little better. (but it does need a test change?)

-------------

Marked as reviewed by jvernee (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/959

From rwestberg at openjdk.java.net  Wed Dec  2 12:59:48 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 2 Dec 2020 12:59:48 GMT
Subject: RFR: Handle trailing blank lines in commit message [v2]
In-Reply-To: <bMH9Ff2oRi7SrOr-79FB70awHZVo9iHLQx4BI9pQcQ8=.9b860e00-fd9b-4511-9845-11b964f74d2b@github.com>
References: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
 <SIUPJIswJ1ooUwSeG3LPVKVt6kH20grNzkkretyq2t8=.2ebbd81c-9933-4ac5-8697-a1547a2a10c0@github.com>
 <bMH9Ff2oRi7SrOr-79FB70awHZVo9iHLQx4BI9pQcQ8=.9b860e00-fd9b-4511-9845-11b964f74d2b@github.com>
Message-ID: <62JAYdLV0bn5dhVIRdFR6_zzU_Mpr8N6sDn7w8mEJBQ=.19787bbc-8566-4f16-9b3f-241aa3428161@github.com>

On Wed, 2 Dec 2020 12:25:49 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Trailing blank lines end up in "additional"
>
> Okay, thanks for explaining. I think the new version looks a little better. (but it does need a test change?)

Well, the test is new so I don't think it matters - a commit message like this could never be generated by the bots, but a similar one was pushed directly to a repo and made the notifier fail.. So perhaps this is more correct than the first version. :)

-------------

PR: https://git.openjdk.java.net/skara/pull/959

From rwestberg at openjdk.java.net  Wed Dec  2 15:41:22 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 2 Dec 2020 15:41:22 GMT
Subject: Integrated: Handle trailing blank lines in commit message
In-Reply-To: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
References: <i4fIamv2PhVilHO4rawlFY4laofsVKhQC1cB1SPkgUw=.0019ef51-56dd-4b16-b8e7-097838250b17@github.com>
Message-ID: <G890A_Vp3ZilSv5FGfj2xglN5T_eFhr8LOLzxltY7NA=.56215c7f-ee50-4634-8527-ca3c0c84a15f@github.com>

On Thu, 19 Nov 2020 13:51:24 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> This change ensures that a commit message ending with a blank line does not generate an exception.

This pull request has now been integrated.

Changeset: a7b4297b
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/a7b4297b
Stats:     25 lines in 2 files changed: 19 ins; 5 del; 1 mod

Handle trailing blank lines in commit message

Reviewed-by: jvernee

-------------

PR: https://git.openjdk.java.net/skara/pull/959

From rwestberg at openjdk.java.net  Thu Dec  3 10:12:12 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 3 Dec 2020 10:12:12 GMT
Subject: RFR: Revert "819: Backports created by Robo Duke inherit all labels
 of original"
Message-ID: <E9Oncka14afVLXFvX1CxYKur0Zj0vrfMJdbEH5MSgoU=.8dc70833-f6fd-4f1e-8962-027465f94922@github.com>

This reverts commit 9a98403ebfa74a8e0ab7d520b77f9ac6a3a730bc.

Preparation for a different method of avoiding label propagation.

-------------

Commit messages:
 - Revert "819: Backports created by Robo Duke inherit all labels of original"

Changes: https://git.openjdk.java.net/skara/pull/964/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=964&range=00
  Stats: 242 lines in 7 files changed: 203 ins; 31 del; 8 mod
  Patch: https://git.openjdk.java.net/skara/pull/964.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/964/head:pull/964

PR: https://git.openjdk.java.net/skara/pull/964

From rwestberg at openjdk.java.net  Thu Dec  3 10:14:00 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 3 Dec 2020 10:14:00 GMT
Subject: RFR: Ensure that labels do not propagate to backports
Message-ID: <-NyVSGNlKSmdVwEwLZxtMEK3hU9cTIiuIE6Tt0Phv74=.33c946ea-fe7f-4d86-8f7a-b0a0c6f80fbe@github.com>

If the backport creation endpoint does not clear the labels, we can do it manually.

-------------

Commit messages:
 - Ensure that labels do not propagate to backports

Changes: https://git.openjdk.java.net/skara/pull/965/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=965&range=00
  Stats: 24 lines in 2 files changed: 10 ins; 9 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/965.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/965/head:pull/965

PR: https://git.openjdk.java.net/skara/pull/965

From jvernee at openjdk.java.net  Thu Dec  3 11:06:31 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Thu, 3 Dec 2020 11:06:31 GMT
Subject: RFR: Revert "819: Backports created by Robo Duke inherit all
 labels of original"
In-Reply-To: <E9Oncka14afVLXFvX1CxYKur0Zj0vrfMJdbEH5MSgoU=.8dc70833-f6fd-4f1e-8962-027465f94922@github.com>
References: <E9Oncka14afVLXFvX1CxYKur0Zj0vrfMJdbEH5MSgoU=.8dc70833-f6fd-4f1e-8962-027465f94922@github.com>
Message-ID: <INk1ydcdFSXg6UY_YdKm5dNPrmmqrcbV6uHSNg0Bfnw=.24940ff5-b64c-4ad7-8950-ac9d22779900@github.com>

On Thu, 3 Dec 2020 10:09:26 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> This reverts commit 9a98403ebfa74a8e0ab7d520b77f9ac6a3a730bc.
> 
> Preparation for a different method of avoiding label propagation.

Marked as reviewed by jvernee (Reviewer).

-------------

PR: https://git.openjdk.java.net/skara/pull/964

From jvernee at openjdk.java.net  Thu Dec  3 11:07:38 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Thu, 3 Dec 2020 11:07:38 GMT
Subject: RFR: Ensure that labels do not propagate to backports
In-Reply-To: <-NyVSGNlKSmdVwEwLZxtMEK3hU9cTIiuIE6Tt0Phv74=.33c946ea-fe7f-4d86-8f7a-b0a0c6f80fbe@github.com>
References: <-NyVSGNlKSmdVwEwLZxtMEK3hU9cTIiuIE6Tt0Phv74=.33c946ea-fe7f-4d86-8f7a-b0a0c6f80fbe@github.com>
Message-ID: <FeBYxVnIhJTRFIrlsfzxCZMorixJJWPc8-fuGpFIWTY=.7894a34a-395b-409e-9bac-13b9b0c4a7ae@github.com>

On Thu, 3 Dec 2020 10:11:14 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> If the backport creation endpoint does not clear the labels, we can do it manually.

Marked as reviewed by jvernee (Reviewer).

-------------

PR: https://git.openjdk.java.net/skara/pull/965

From rwestberg at openjdk.java.net  Thu Dec  3 11:16:29 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 3 Dec 2020 11:16:29 GMT
Subject: Integrated: Revert "819: Backports created by Robo Duke inherit all
 labels of original"
In-Reply-To: <E9Oncka14afVLXFvX1CxYKur0Zj0vrfMJdbEH5MSgoU=.8dc70833-f6fd-4f1e-8962-027465f94922@github.com>
References: <E9Oncka14afVLXFvX1CxYKur0Zj0vrfMJdbEH5MSgoU=.8dc70833-f6fd-4f1e-8962-027465f94922@github.com>
Message-ID: <HyuKYDOtofgYtxSpGR6cY4lF9-lGMfo_B9X3z0WcFh4=.324ae612-f1be-473d-a2ea-192afb78c6a0@github.com>

On Thu, 3 Dec 2020 10:09:26 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> This reverts commit 9a98403ebfa74a8e0ab7d520b77f9ac6a3a730bc.
> 
> Preparation for a different method of avoiding label propagation.

This pull request has now been integrated.

Changeset: 793cea05
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/793cea05
Stats:     242 lines in 7 files changed: 203 ins; 31 del; 8 mod

Revert "819: Backports created by Robo Duke inherit all labels of original"

Reviewed-by: jvernee

-------------

PR: https://git.openjdk.java.net/skara/pull/964

From rwestberg at openjdk.java.net  Thu Dec  3 11:17:44 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 3 Dec 2020 11:17:44 GMT
Subject: RFR: Ensure that labels do not propagate to backports [v2]
In-Reply-To: <-NyVSGNlKSmdVwEwLZxtMEK3hU9cTIiuIE6Tt0Phv74=.33c946ea-fe7f-4d86-8f7a-b0a0c6f80fbe@github.com>
References: <-NyVSGNlKSmdVwEwLZxtMEK3hU9cTIiuIE6Tt0Phv74=.33c946ea-fe7f-4d86-8f7a-b0a0c6f80fbe@github.com>
Message-ID: <jR9It_t6XKsSJXnlzuYJbcBjHhpveQMSqSemtyBVx7c=.cd5ed230-9ab1-4db6-b546-0f7e2e9d1bc5@github.com>

> If the backport creation endpoint does not clear the labels, we can do it manually.

Robin Westberg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/965/files
  - new: https://git.openjdk.java.net/skara/pull/965/files/3dde36a2..3dde36a2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=965&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=965&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/965.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/965/head:pull/965

PR: https://git.openjdk.java.net/skara/pull/965

From rwestberg at openjdk.java.net  Thu Dec  3 11:17:44 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 3 Dec 2020 11:17:44 GMT
Subject: Integrated: Ensure that labels do not propagate to backports
In-Reply-To: <-NyVSGNlKSmdVwEwLZxtMEK3hU9cTIiuIE6Tt0Phv74=.33c946ea-fe7f-4d86-8f7a-b0a0c6f80fbe@github.com>
References: <-NyVSGNlKSmdVwEwLZxtMEK3hU9cTIiuIE6Tt0Phv74=.33c946ea-fe7f-4d86-8f7a-b0a0c6f80fbe@github.com>
Message-ID: <OroqJzeokEwbNyAgqKxzGWMh79iyW0opHFlTOgpuwSY=.3f310ab5-b207-4e3e-9003-07bccfffff0b@github.com>

On Thu, 3 Dec 2020 10:11:14 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> If the backport creation endpoint does not clear the labels, we can do it manually.

This pull request has now been integrated.

Changeset: 4d1bcbac
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/4d1bcbac
Stats:     24 lines in 2 files changed: 10 ins; 9 del; 5 mod

Ensure that labels do not propagate to backports

Reviewed-by: jvernee

-------------

PR: https://git.openjdk.java.net/skara/pull/965

From rwestberg at openjdk.java.net  Mon Dec  7 12:19:02 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 7 Dec 2020 12:19:02 GMT
Subject: RFR: Backport issues can be open, use proper link relationship
Message-ID: <8hKQ79tYCVr57e2_MbMHzPkDqtLVWbAQS6EQjs7CjAQ=.f512450c-77b6-4615-beca-83b3abd4b814@github.com>

When looking for eligible backport issues, consider open ones as well.

-------------

Commit messages:
 - Backport issues can be open, use proper link relationship

Changes: https://git.openjdk.java.net/skara/pull/966/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=966&range=00
  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/966.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/966/head:pull/966

PR: https://git.openjdk.java.net/skara/pull/966

From rwestberg at openjdk.java.net  Mon Dec  7 12:34:39 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 7 Dec 2020 12:34:39 GMT
Subject: RFR: Backport issues can be open,
 use proper link relationship [v2]
In-Reply-To: <8hKQ79tYCVr57e2_MbMHzPkDqtLVWbAQS6EQjs7CjAQ=.f512450c-77b6-4615-beca-83b3abd4b814@github.com>
References: <8hKQ79tYCVr57e2_MbMHzPkDqtLVWbAQS6EQjs7CjAQ=.f512450c-77b6-4615-beca-83b3abd4b814@github.com>
Message-ID: <AKXfu9sDvLCk2UrM40GFWk-hW5cUrMJgyqd5feLooi0=.e51c16a7-eafc-443d-94fc-f4ed5bdac03d@github.com>

> When looking for eligible backport issues, consider open ones as well.

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Allow considering only resolved backport issues (for sync labelling)

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/966/files
  - new: https://git.openjdk.java.net/skara/pull/966/files/38abf8bb..1212cb66

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=966&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=966&range=00-01

  Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/966.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/966/head:pull/966

PR: https://git.openjdk.java.net/skara/pull/966

From ehelin at openjdk.java.net  Mon Dec  7 13:18:00 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 7 Dec 2020 13:18:00 GMT
Subject: RFR: Backport issues can be open,
 use proper link relationship [v2]
In-Reply-To: <AKXfu9sDvLCk2UrM40GFWk-hW5cUrMJgyqd5feLooi0=.e51c16a7-eafc-443d-94fc-f4ed5bdac03d@github.com>
References: <8hKQ79tYCVr57e2_MbMHzPkDqtLVWbAQS6EQjs7CjAQ=.f512450c-77b6-4615-beca-83b3abd4b814@github.com>
 <AKXfu9sDvLCk2UrM40GFWk-hW5cUrMJgyqd5feLooi0=.e51c16a7-eafc-443d-94fc-f4ed5bdac03d@github.com>
Message-ID: <d4zjlDJNfxZTX-v0RK3y8VvpJTS4lZsU4BnPi8p7X_I=.bff321dc-f414-40d4-9da4-36bdb0eea504@github.com>

On Mon, 7 Dec 2020 12:34:39 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> When looking for eligible backport issues, consider open ones as well.
>
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Allow considering only resolved backport issues (for sync labelling)

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/966

From rwestberg at openjdk.java.net  Mon Dec  7 13:40:50 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 7 Dec 2020 13:40:50 GMT
Subject: Integrated: Backport issues can be open, use proper link relationship
In-Reply-To: <8hKQ79tYCVr57e2_MbMHzPkDqtLVWbAQS6EQjs7CjAQ=.f512450c-77b6-4615-beca-83b3abd4b814@github.com>
References: <8hKQ79tYCVr57e2_MbMHzPkDqtLVWbAQS6EQjs7CjAQ=.f512450c-77b6-4615-beca-83b3abd4b814@github.com>
Message-ID: <KXLqQZOhfLHqW4UWyx5T28JwygQJKIM8to53AS6-3fQ=.b6bb6e9a-9955-411f-ae3a-9ea437b89bf5@github.com>

On Mon, 7 Dec 2020 12:16:18 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When looking for eligible backport issues, consider open ones as well.

This pull request has now been integrated.

Changeset: fe6e3dec
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/fe6e3dec
Stats:     9 lines in 2 files changed: 3 ins; 0 del; 6 mod

Backport issues can be open, use proper link relationship

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/966

From rwestberg at openjdk.java.net  Mon Dec  7 13:47:12 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 7 Dec 2020 13:47:12 GMT
Subject: Integrated: 839: GitHub actions test results not always added to a PR
Message-ID: <Vc00VUgJZ9WNd2jjMsAQ8HiYrt1Xyd_Ct8wNBwdm5tU=.e66155d8-d25d-4488-9bbc-03d80a1ce350@github.com>

The test info propagator did not take changes to a PR's head hash into account.

-------------

Commit messages:
 - Ensure that test info expiration times are reset if the PR head hash changes

Changes: https://git.openjdk.java.net/skara/pull/967/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=967&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-839
  Stats: 70 lines in 2 files changed: 65 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/skara/pull/967.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/967/head:pull/967

PR: https://git.openjdk.java.net/skara/pull/967

From ehelin at openjdk.java.net  Mon Dec  7 13:47:12 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 7 Dec 2020 13:47:12 GMT
Subject: Integrated: 839: GitHub actions test results not always added to
 a PR
In-Reply-To: <Vc00VUgJZ9WNd2jjMsAQ8HiYrt1Xyd_Ct8wNBwdm5tU=.e66155d8-d25d-4488-9bbc-03d80a1ce350@github.com>
References: <Vc00VUgJZ9WNd2jjMsAQ8HiYrt1Xyd_Ct8wNBwdm5tU=.e66155d8-d25d-4488-9bbc-03d80a1ce350@github.com>
Message-ID: <MxCh2omlSZIPc4LK3o1xgbDmDUyqpsY5ZucCEm8LCfo=.5864eede-9759-43cc-aeb2-8e8ca7058ad4@github.com>

On Mon, 7 Dec 2020 13:40:34 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The test info propagator did not take changes to a PR's head hash into account.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/967

From rwestberg at openjdk.java.net  Mon Dec  7 13:47:13 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 7 Dec 2020 13:47:13 GMT
Subject: Integrated: 839: GitHub actions test results not always added to a PR
In-Reply-To: <Vc00VUgJZ9WNd2jjMsAQ8HiYrt1Xyd_Ct8wNBwdm5tU=.e66155d8-d25d-4488-9bbc-03d80a1ce350@github.com>
References: <Vc00VUgJZ9WNd2jjMsAQ8HiYrt1Xyd_Ct8wNBwdm5tU=.e66155d8-d25d-4488-9bbc-03d80a1ce350@github.com>
Message-ID: <9ftDNsVrEbdwG7tFzDgoro8kQ-9cV-LD8W7TlA28gKg=.4c30ac67-a90c-4d48-b6a3-2485aa9b4196@github.com>

On Mon, 7 Dec 2020 13:40:34 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The test info propagator did not take changes to a PR's head hash into account.

This pull request has now been integrated.

Changeset: 8e0b4ab3
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/8e0b4ab3
Stats:     70 lines in 2 files changed: 65 ins; 0 del; 5 mod

839: GitHub actions test results not always added to a PR

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/967

From ehelin at openjdk.java.net  Tue Dec  8 09:37:31 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 8 Dec 2020 09:37:31 GMT
Subject: RFR: build: update to Gradle 6.7.1
Message-ID: <8gOcm3f31qbrcW6gb0BZ_MApG-oqenMW4sJPStsE8tk=.5e8dff4a-1680-406d-81b3-dedfd88cf0a0@github.com>

Hi all,

please review this patch that updates the Gradle version used to build Skara to 6.7.1.

Testing:
- [x] `make`
- [x] `make images`
- [x] `make test`

Thanks,
Erik

-------------

Commit messages:
 - build: update to Gradle 6.7.1

Changes: https://git.openjdk.java.net/skara/pull/968/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=968&range=00
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/968.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/968/head:pull/968

PR: https://git.openjdk.java.net/skara/pull/968

From rwestberg at openjdk.java.net  Tue Dec  8 09:41:34 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 8 Dec 2020 09:41:34 GMT
Subject: RFR: build: update to Gradle 6.7.1
In-Reply-To: <8gOcm3f31qbrcW6gb0BZ_MApG-oqenMW4sJPStsE8tk=.5e8dff4a-1680-406d-81b3-dedfd88cf0a0@github.com>
References: <8gOcm3f31qbrcW6gb0BZ_MApG-oqenMW4sJPStsE8tk=.5e8dff4a-1680-406d-81b3-dedfd88cf0a0@github.com>
Message-ID: <IQ971m_47FBjarBR92aeKXY5QgEVmNjEyl7FOyCKjn4=.6d0d2c31-412e-4167-825d-ec96e56c7a4a@github.com>

On Tue, 8 Dec 2020 09:34:39 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates the Gradle version used to build Skara to 6.7.1.
> 
> Testing:
> - [x] `make`
> - [x] `make images`
> - [x] `make test`
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/968

From ehelin at openjdk.java.net  Tue Dec  8 14:49:34 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 8 Dec 2020 14:49:34 GMT
Subject: Integrated: build: update to Gradle 6.7.1
In-Reply-To: <8gOcm3f31qbrcW6gb0BZ_MApG-oqenMW4sJPStsE8tk=.5e8dff4a-1680-406d-81b3-dedfd88cf0a0@github.com>
References: <8gOcm3f31qbrcW6gb0BZ_MApG-oqenMW4sJPStsE8tk=.5e8dff4a-1680-406d-81b3-dedfd88cf0a0@github.com>
Message-ID: <LMjUvylZfglWbhsueOuxCoyXJqT1LqU260jwC-o1oRs=.89ecaaa8-e127-4126-96d3-a7247dfc6a61@github.com>

On Tue, 8 Dec 2020 09:34:39 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates the Gradle version used to build Skara to 6.7.1.
> 
> Testing:
> - [x] `make`
> - [x] `make images`
> - [x] `make test`
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: daf3ff6a
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/daf3ff6a
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

build: update to Gradle 6.7.1

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/968

From ehelin at openjdk.java.net  Tue Dec  8 14:56:34 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 8 Dec 2020 14:56:34 GMT
Subject: RFR: build: update to JDK 15.0.1
Message-ID: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>

Hi all,

please review this patch that updates the JDK used for building Skara to 15.0.1.

Testing:
- [x] `make images`
- [x] `make test`

Thanks,
Erik

-------------

Commit messages:
 - build: update to JDK 15.0.1

Changes: https://git.openjdk.java.net/skara/pull/969/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=969&range=00
  Stats: 15 lines in 4 files changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/skara/pull/969.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/969/head:pull/969

PR: https://git.openjdk.java.net/skara/pull/969

From rwestberg at openjdk.java.net  Tue Dec  8 14:56:35 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 8 Dec 2020 14:56:35 GMT
Subject: RFR: build: update to JDK 15.0.1
In-Reply-To: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>
References: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>
Message-ID: <6tNspjHp3PEbK756FqRuDb8hs0cK827FoYvFrVVHSm4=.f30019fe-f90c-46e1-9787-726d31eadd21@github.com>

On Tue, 8 Dec 2020 14:51:18 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates the JDK used for building Skara to 15.0.1.
> 
> Testing:
> - [x] `make images`
> - [x] `make test`
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/969

From jvernee at openjdk.java.net  Wed Dec  9 11:57:54 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Wed, 9 Dec 2020 11:57:54 GMT
Subject: RFR: Allow '+' to be in branch names in merge PR titles
Message-ID: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>

Allow '+' to be in branch names in merge PR titles. I've also sharpened the error message to include the exact pattern the bot checks for.

-------------

Commit messages:
 - Add test, make error message clearer
 - Allow '+' characters in branch names of Merge PRs

Changes: https://git.openjdk.java.net/skara/pull/970/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=970&range=00
  Stats: 52 lines in 2 files changed: 48 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/skara/pull/970.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/970/head:pull/970

PR: https://git.openjdk.java.net/skara/pull/970

From jvernee at openjdk.java.net  Wed Dec  9 12:27:29 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Wed, 9 Dec 2020 12:27:29 GMT
Subject: RFR: Allow '+' to be in branch names in merge PR titles [v2]
In-Reply-To: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
References: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
Message-ID: <yIeI9Fd0WIn4017KJR1k4fTK1oxmy4wNQpD0aJD2Ttw=.c631a464-9e81-44fd-bfca-cff55a0082cf@github.com>

> Allow '+' to be in branch names in merge PR titles. I've also sharpened the error message to include the exact pattern the bot checks for.

Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:

 - Fix test failure
 - Fix existing typo

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/970/files
  - new: https://git.openjdk.java.net/skara/pull/970/files/f12e232c..5ea7abcf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=970&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=970&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/970.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/970/head:pull/970

PR: https://git.openjdk.java.net/skara/pull/970

From rwestberg at openjdk.java.net  Wed Dec  9 16:13:04 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 9 Dec 2020 16:13:04 GMT
Subject: RFR: Allow '+' to be in branch names in merge PR titles [v2]
In-Reply-To: <yIeI9Fd0WIn4017KJR1k4fTK1oxmy4wNQpD0aJD2Ttw=.c631a464-9e81-44fd-bfca-cff55a0082cf@github.com>
References: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
 <yIeI9Fd0WIn4017KJR1k4fTK1oxmy4wNQpD0aJD2Ttw=.c631a464-9e81-44fd-bfca-cff55a0082cf@github.com>
Message-ID: <7E1aVrraji-euwWSxi3LZoeY4MFr9EIoLTIaBzf5u2o=.4fa7a564-0a6e-4494-8e42-ffe27316e2c9@github.com>

On Wed, 9 Dec 2020 12:27:29 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Allow '+' to be in branch names in merge PR titles. I've also sharpened the error message to include the exact pattern the bot checks for.
>
> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix test failure
>  - Fix existing typo

Looks good!

forge/src/main/java/org/openjdk/skara/forge/PullRequestUtils.java line 65:

> 63:         var sourceMatcher = mergeSourcePattern.matcher(pr.title());
> 64:         if (!sourceMatcher.matches()) {
> 65:             throw new CommitFailure("Could not determine the source for this merge. A Merge PR title must be specified of the format: `" +

Perhaps "specified *in* the format:" would sound better, but I'm not a native speaker. :)

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/970

From jvernee at openjdk.java.net  Wed Dec  9 16:34:50 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Wed, 9 Dec 2020 16:34:50 GMT
Subject: RFR: Allow '+' to be in branch names in merge PR titles [v2]
In-Reply-To: <7E1aVrraji-euwWSxi3LZoeY4MFr9EIoLTIaBzf5u2o=.4fa7a564-0a6e-4494-8e42-ffe27316e2c9@github.com>
References: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
 <yIeI9Fd0WIn4017KJR1k4fTK1oxmy4wNQpD0aJD2Ttw=.c631a464-9e81-44fd-bfca-cff55a0082cf@github.com>
 <7E1aVrraji-euwWSxi3LZoeY4MFr9EIoLTIaBzf5u2o=.4fa7a564-0a6e-4494-8e42-ffe27316e2c9@github.com>
Message-ID: <1qvPnqgKtRegYcMoxJbNStoV6oGIXiBbTUpb4eHsHaQ=.3bb01d5b-6132-4423-b49b-8b25cbf17786@github.com>

On Wed, 9 Dec 2020 16:10:41 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix test failure
>>  - Fix existing typo
>
> forge/src/main/java/org/openjdk/skara/forge/PullRequestUtils.java line 65:
> 
>> 63:         var sourceMatcher = mergeSourcePattern.matcher(pr.title());
>> 64:         if (!sourceMatcher.matches()) {
>> 65:             throw new CommitFailure("Could not determine the source for this merge. A Merge PR title must be specified of the format: `" +
> 
> Perhaps "specified *in* the format:" would sound better, but I'm not a native speaker. :)

Yeah, that sounds nicer (though I think technically both are correct).

-------------

PR: https://git.openjdk.java.net/skara/pull/970

From jvernee at openjdk.java.net  Wed Dec  9 16:40:46 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Wed, 9 Dec 2020 16:40:46 GMT
Subject: RFR: Allow '+' to be in branch names in merge PR titles [v3]
In-Reply-To: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
References: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
Message-ID: <FCte12HDCEkt43GiosAASSb5bmgBsiDo2dkesEo33Ws=.4400eaf9-b5e3-4a50-9cdf-6133a65ccd7f@github.com>

> Allow '+' to be in branch names in merge PR titles. I've also sharpened the error message to include the exact pattern the bot checks for.

Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:

  of -> in

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/970/files
  - new: https://git.openjdk.java.net/skara/pull/970/files/5ea7abcf..48242706

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=970&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=970&range=01-02

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/skara/pull/970.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/970/head:pull/970

PR: https://git.openjdk.java.net/skara/pull/970

From jvernee at openjdk.java.net  Wed Dec  9 18:24:52 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Wed, 9 Dec 2020 18:24:52 GMT
Subject: Integrated: Allow '+' to be in branch names in merge PR titles
In-Reply-To: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
References: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
Message-ID: <3b_7QNEoa6ffpN8j0rpm19Ty53Sq_uubOlZNBWCPQpc=.6d388b24-1625-44e8-a70d-973afcc4acb8@github.com>

On Wed, 9 Dec 2020 11:55:01 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Allow '+' to be in branch names in merge PR titles. I've also sharpened the error message to include the exact pattern the bot checks for.

This pull request has now been integrated.

Changeset: 939cea1c
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/939cea1c
Stats:     52 lines in 2 files changed: 48 ins; 0 del; 4 mod

Allow '+' to be in branch names in merge PR titles

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/970

From jvernee at openjdk.java.net  Wed Dec  9 18:24:51 2020
From: jvernee at openjdk.java.net (Jorn Vernee)
Date: Wed, 9 Dec 2020 18:24:51 GMT
Subject: RFR: Allow '+' to be in branch names in merge PR titles [v2]
In-Reply-To: <7E1aVrraji-euwWSxi3LZoeY4MFr9EIoLTIaBzf5u2o=.4fa7a564-0a6e-4494-8e42-ffe27316e2c9@github.com>
References: <iNzjnYQ7tTVfwnsx3YEZX_gV6FBzllcZ9Mrjgx63WEc=.cdf214d3-aba9-4ba7-ab36-158ba2ca27f9@github.com>
 <yIeI9Fd0WIn4017KJR1k4fTK1oxmy4wNQpD0aJD2Ttw=.c631a464-9e81-44fd-bfca-cff55a0082cf@github.com>
 <7E1aVrraji-euwWSxi3LZoeY4MFr9EIoLTIaBzf5u2o=.4fa7a564-0a6e-4494-8e42-ffe27316e2c9@github.com>
Message-ID: <cApuc-Txc4vfM3t7evF4fn2wq6UpbH8zw5CWKJCrhWw=.3230a7db-ffc5-4ee4-ae54-82cbe06fc2b0@github.com>

On Wed, 9 Dec 2020 16:10:51 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix test failure
>>  - Fix existing typo
>
> Looks good!

The check is supposedly in progress, but the action run has already completed, so I'll just integrate this now

-------------

PR: https://git.openjdk.java.net/skara/pull/970

From magnus.ihse.bursie at oracle.com  Thu Dec 10 12:54:04 2020
From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie)
Date: Thu, 10 Dec 2020 13:54:04 +0100
Subject: Leave backslashes in backticks
In-Reply-To: <vuhKBLrRr1El3lzmVvRj3d6gxBy_FWOX8Kv7H5qN6Cs=.cb78087d-4a3d-43bb-9ad7-6f0dd9b5ec1a@github.com>
References: <vuhKBLrRr1El3lzmVvRj3d6gxBy_FWOX8Kv7H5qN6Cs=.cb78087d-4a3d-43bb-9ad7-6f0dd9b5ec1a@github.com>
Message-ID: <52edbe1c-92b6-dd94-6b3c-ef6d1a1edfa5@oracle.com>

It seems that the mail bot converted `\` into just `` (and `\\` into 
`\`) when sending the mail. It should leave everything inside backticks 
be, since it should not be processed for quoting.

/Magnus


-------- Forwarded Message --------
Subject: 	RFR: 8258005: JDK build fails with incorrect fixpath script
Date: 	Thu, 10 Dec 2020 12:47:44 GMT
From: 	Magnus Ihse Bursie <ihse at openjdk.java.net>
To: 	build-dev at openjdk.java.net



The Leaning Toothpick Syndrome[1] strikes back!

In the fixpath shell script wrapper, we transform single `` to `\`, to 
make them correctly escaped. Unfortunately, the bas variable 
substitution pattern I used were missing a `/`, so it only replaced the 
first backslash, not all of them.

Thanks to @vidmik for analysis and fix!

[1] https://en.wikipedia.org/wiki/Leaning_toothpick_syndrome

-------------

Commit messages:
- 8258005: JDK build fails with incorrect fixpath script

Changes: https://git.openjdk.java.net/jdk/pull/1731/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1731&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8258005
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/1731.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1731/head:pull/1731

PR: https://git.openjdk.java.net/jdk/pull/1731

From rwestberg at openjdk.java.net  Thu Dec 10 16:03:53 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 10 Dec 2020 16:03:53 GMT
Subject: RFR: Use headers and other info from the most recent response
Message-ID: <gEHJ7nl4W0iszxvXOKzlGryKXqV7ej7OJG52Zbh1X_A=.d3d58d7f-875a-4660-bf1a-d4979293e82e@github.com>

When a 304 response is received from a GET request, we retrieve the original request from the cache and return it instead. However, we should only reuse the cached body as other headers (such as links to further result pages) may have been updated.

-------------

Commit messages:
 - Use headers and other info from the most recent response, even if the body itself is retrieved from the cache.

Changes: https://git.openjdk.java.net/skara/pull/971/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=971&range=00
  Stats: 92 lines in 2 files changed: 89 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/971.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/971/head:pull/971

PR: https://git.openjdk.java.net/skara/pull/971

From ehelin at openjdk.java.net  Thu Dec 10 16:19:04 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 10 Dec 2020 16:19:04 GMT
Subject: RFR: Use headers and other info from the most recent response
In-Reply-To: <gEHJ7nl4W0iszxvXOKzlGryKXqV7ej7OJG52Zbh1X_A=.d3d58d7f-875a-4660-bf1a-d4979293e82e@github.com>
References: <gEHJ7nl4W0iszxvXOKzlGryKXqV7ej7OJG52Zbh1X_A=.d3d58d7f-875a-4660-bf1a-d4979293e82e@github.com>
Message-ID: <3IRNOn-eyQoYQaLgvX4mFAlOm0XzN3shbovbBnc0Qq4=.5f1a03a6-0d6e-4b70-9981-ac176f43b8cf@github.com>

On Thu, 10 Dec 2020 15:54:34 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When a 304 response is received from a GET request, we retrieve the original request from the cache and return it instead. However, we should only reuse the cached body as other headers (such as links to further result pages) may have been updated.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/971

From rwestberg at openjdk.java.net  Fri Dec 11 08:03:50 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Fri, 11 Dec 2020 08:03:50 GMT
Subject: Integrated: Use headers and other info from the most recent response
In-Reply-To: <gEHJ7nl4W0iszxvXOKzlGryKXqV7ej7OJG52Zbh1X_A=.d3d58d7f-875a-4660-bf1a-d4979293e82e@github.com>
References: <gEHJ7nl4W0iszxvXOKzlGryKXqV7ej7OJG52Zbh1X_A=.d3d58d7f-875a-4660-bf1a-d4979293e82e@github.com>
Message-ID: <yhE9sBQax53elf_cumHP5sdFnjFBOwlGFutv_I9-k9I=.bbfbccd0-2f62-4a5a-819b-8ff8cba1aa51@github.com>

On Thu, 10 Dec 2020 15:54:34 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When a 304 response is received from a GET request, we retrieve the original request from the cache and return it instead. However, we should only reuse the cached body as other headers (such as links to further result pages) may have been updated.

This pull request has now been integrated.

Changeset: af218cab
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/af218cab
Stats:     92 lines in 2 files changed: 89 ins; 0 del; 3 mod

Use headers and other info from the most recent response

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/971

From rwestberg at openjdk.java.net  Mon Dec 14 10:18:34 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 14 Dec 2020 10:18:34 GMT
Subject: RFR: The latest request may not contain the full set of headers
Message-ID: <tSxGaMgewDgl1XADmcNHE8V3WSRylWe4J3rC6UGGsWI=.c1adcc41-f409-4a92-8f57-fc0b9d474d10@github.com>

When returning a cached result as a response to a 304, use the combined set of headers.

-------------

Commit messages:
 - The latest request may not contain the full set of headers

Changes: https://git.openjdk.java.net/skara/pull/972/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=972&range=00
  Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/972.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/972/head:pull/972

PR: https://git.openjdk.java.net/skara/pull/972

From ehelin at openjdk.java.net  Mon Dec 14 10:21:50 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 14 Dec 2020 10:21:50 GMT
Subject: RFR: The latest request may not contain the full set of headers
In-Reply-To: <tSxGaMgewDgl1XADmcNHE8V3WSRylWe4J3rC6UGGsWI=.c1adcc41-f409-4a92-8f57-fc0b9d474d10@github.com>
References: <tSxGaMgewDgl1XADmcNHE8V3WSRylWe4J3rC6UGGsWI=.c1adcc41-f409-4a92-8f57-fc0b9d474d10@github.com>
Message-ID: <12csDN2fsH4Gkkejr7EM20Z94GgLR6AUcqSK1pOBhno=.9031d8cc-d043-489a-ad09-9bf0668b289e@github.com>

On Mon, 14 Dec 2020 10:15:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When returning a cached result as a response to a 304, use the combined set of headers.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/972

From rwestberg at openjdk.java.net  Mon Dec 14 10:31:36 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 14 Dec 2020 10:31:36 GMT
Subject: Integrated: The latest request may not contain the full set of headers
In-Reply-To: <tSxGaMgewDgl1XADmcNHE8V3WSRylWe4J3rC6UGGsWI=.c1adcc41-f409-4a92-8f57-fc0b9d474d10@github.com>
References: <tSxGaMgewDgl1XADmcNHE8V3WSRylWe4J3rC6UGGsWI=.c1adcc41-f409-4a92-8f57-fc0b9d474d10@github.com>
Message-ID: <Dblga_kez3JcEC_P3a5xMgw8YFYOt7DQYKRmz0D4xKY=.0463d7c9-634d-49ce-bf20-9e5ce605b043@github.com>

On Mon, 14 Dec 2020 10:15:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When returning a cached result as a response to a 304, use the combined set of headers.

This pull request has now been integrated.

Changeset: 20a8550a
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/20a8550a
Stats:     8 lines in 1 file changed: 7 ins; 0 del; 1 mod

The latest request may not contain the full set of headers

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/972

From ehelin at openjdk.java.net  Mon Dec 14 11:45:10 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 14 Dec 2020 11:45:10 GMT
Subject: RFR: build: update to JDK 15.0.1 [v2]
In-Reply-To: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>
References: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>
Message-ID: <ZCnRxPcjFwSSjys8dbrhvSDm6fpdSOSU1Il5slNyhJA=.d6bb0700-602a-45f0-bfb3-a062aa0668dc@github.com>

> Hi all,
> 
> please review this patch that updates the JDK used for building Skara to 15.0.1.
> 
> Testing:
> - [x] `make images`
> - [x] `make test`
> 
> Thanks,
> Erik

Erik Helin has updated the pull request incrementally with one additional commit since the last revision:

  Use explicit newline pattern

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/969/files
  - new: https://git.openjdk.java.net/skara/pull/969/files/f5f30956..26c700c3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=969&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=969&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/969.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/969/head:pull/969

PR: https://git.openjdk.java.net/skara/pull/969

From rwestberg at openjdk.java.net  Mon Dec 14 14:06:41 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 14 Dec 2020 14:06:41 GMT
Subject: RFR: build: update to JDK 15.0.1 [v2]
In-Reply-To: <ZCnRxPcjFwSSjys8dbrhvSDm6fpdSOSU1Il5slNyhJA=.d6bb0700-602a-45f0-bfb3-a062aa0668dc@github.com>
References: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>
 <ZCnRxPcjFwSSjys8dbrhvSDm6fpdSOSU1Il5slNyhJA=.d6bb0700-602a-45f0-bfb3-a062aa0668dc@github.com>
Message-ID: <3lbHDurxWJ_LCCsVZztdabFeI6upYbjeqbjntBL_j-U=.15791bb6-7872-4863-a397-710c3b707224@github.com>

On Mon, 14 Dec 2020 11:45:10 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that updates the JDK used for building Skara to 15.0.1.
>> 
>> Testing:
>> - [x] `make images`
>> - [x] `make test`
>> 
>> Thanks,
>> Erik
>
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use explicit newline pattern

Looks good, I guess an alternative would have been to simply disable the tests on Windows and hope that \R becomes usable again in the future. But this works too. :)

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/969

From ehelin at openjdk.java.net  Mon Dec 14 14:33:17 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Mon, 14 Dec 2020 14:33:17 GMT
Subject: Integrated: build: update to JDK 15.0.1
In-Reply-To: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>
References: <3WWG-5rqleeMbXsKBGuRnoZIUYDwI0IyMl3x5QZC9oU=.acb177ff-c1b4-4d68-833d-8e16e2742be8@github.com>
Message-ID: <1Rn5OIzH3Ibu-ZVj3Kaz3dVPIu_zcjetMYmPKHkaDmM=.1e61f727-60c9-4a7e-a960-206a931fd737@github.com>

On Tue, 8 Dec 2020 14:51:18 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that updates the JDK used for building Skara to 15.0.1.
> 
> Testing:
> - [x] `make images`
> - [x] `make test`
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 8cce2b56
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/8cce2b56
Stats:     16 lines in 5 files changed: 0 ins; 0 del; 16 mod

build: update to JDK 15.0.1

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/969

From rwestberg at openjdk.java.net  Mon Dec 14 16:10:54 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Mon, 14 Dec 2020 16:10:54 GMT
Subject: Withdrawn: Switch to using GitLab approvals instead of award_emojis
In-Reply-To: <JzA4U4iF2anUPigZTs69mVRxqdw6jyf95753-FQz_KU=.ed183739-6757-4ee5-8a5c-0670c1f550db@github.com>
References: <JzA4U4iF2anUPigZTs69mVRxqdw6jyf95753-FQz_KU=.ed183739-6757-4ee5-8a5c-0670c1f550db@github.com>
Message-ID: <WcrngjcI5DrSktGI9BMv8Fz2UfjNqaohakQiVrbBHr4=.1d57ea93-40f6-46ad-9099-7c9b7f17c9c9@github.com>

On Mon, 2 Nov 2020 13:27:32 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Later versions of GitLab allows Merge Request approvals even in the CE version, so we can start to use that instead of the award-emoji workaround used previously.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/skara/pull/937

From ehelin at openjdk.java.net  Tue Dec 15 14:09:15 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Tue, 15 Dec 2020 14:09:15 GMT
Subject: RFR: pr: show diff of diffs for backports
Message-ID: <czLlkYUBZGIPPsCETclE58jODHHflgip47fItY09kA0=.3140acde-213d-4a76-8166-552255604108@github.com>

Hi all,

please review this patch that shows a "diff of diffs" for backports - i.e. the backport commit will be compared to the original commit and the differences will be shown (for non-clean backports). I also added some unit tests for the new `DiffComparator` utility.

Thanks,
Erik

-------------

Commit messages:
 - pr: show diff of diffs for backports

Changes: https://git.openjdk.java.net/skara/pull/973/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=973&range=00
  Stats: 389 lines in 6 files changed: 373 ins; 0 del; 16 mod
  Patch: https://git.openjdk.java.net/skara/pull/973.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/973/head:pull/973

PR: https://git.openjdk.java.net/skara/pull/973

From rwestberg at openjdk.java.net  Tue Dec 15 14:12:42 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 15 Dec 2020 14:12:42 GMT
Subject: RFR: pr: show diff of diffs for backports
In-Reply-To: <czLlkYUBZGIPPsCETclE58jODHHflgip47fItY09kA0=.3140acde-213d-4a76-8166-552255604108@github.com>
References: <czLlkYUBZGIPPsCETclE58jODHHflgip47fItY09kA0=.3140acde-213d-4a76-8166-552255604108@github.com>
Message-ID: <y1QEd1Whkw5YkLtyPI67-Q5jvlMG8AILIffLM0eON-o=.c3bd7632-3dd3-46ec-8d86-86885a3eac6d@github.com>

On Tue, 15 Dec 2020 14:06:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that shows a "diff of diffs" for backports - i.e. the backport commit will be compared to the original commit and the differences will be shown (for non-clean backports). I also added some unit tests for the new `DiffComparator` utility.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/973

From rwestberg at openjdk.java.net  Tue Dec 15 16:00:51 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Tue, 15 Dec 2020 16:00:51 GMT
Subject: RFR: 846: Document the need to enable Github Actions on personal
 forks that offer testing
Message-ID: <TifCBCSXcQv5kX3bAjpQllgO0u6aZv5uvimI_VZ0yDw=.46f31783-12d4-43c4-8f8b-d848836b93e4@github.com>

Forks created after pre-submit testing using GitHub actions was introduced need to explicitly allow GitHub actions. Post a notice as a separate check result if we detect this condition.

-------------

Commit messages:
 - Initial implementation

Changes: https://git.openjdk.java.net/skara/pull/974/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=974&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-846
  Stats: 135 lines in 10 files changed: 84 ins; 29 del; 22 mod
  Patch: https://git.openjdk.java.net/skara/pull/974.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/974/head:pull/974

PR: https://git.openjdk.java.net/skara/pull/974

From magnus.ihse.bursie at oracle.com  Tue Dec 15 22:00:30 2020
From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie)
Date: Tue, 15 Dec 2020 23:00:30 +0100
Subject: Old OCA use with GitHub/Poject Skara
In-Reply-To: <c3b0d940-b51f-e48d-d399-31cb355f4843@j-kuhn.de>
References: <c3b0d940-b51f-e48d-d399-31cb355f4843@j-kuhn.de>
Message-ID: <296e7e9a-dd11-96af-1ffc-5183391a0df1@oracle.com>

On 2020-12-14 17:11, Johannes Kuhn wrote:
> Back in Nov 21, 2019 I signed the OCA, but I did not supply a username.
>
> Now I tried to create a draft PR[1], but the bridgekeeper bot doesn't 
> recognize me as OCA signer.
>
> It supplied instructions for the following cases:
> * Not already signed the OCA: Not applicable, as I already signed it. [2]
> * If I'm already an Author, Committer or Reviewer: Not applicable, as 
> I did not reach that yet.
> * If the OCA was signed by my employer: Not applicable, as I did sign 
> it myself.
Sounds like the informational text provided by the bot needs to have a 
fourth case:

"If you have already signed the OCA, but not provided a GitHub user 
name, nor have at least OpenJDK Author status, please <do something to 
notify Dalibor>".

Dalibor, what would the recommended course of action be? Write "/signed" 
as a pull request comment, even if there is no github user name 
associated with the OCA? Modify "/signed" so it takes an argument with 
the email the OCA was registered under, so you can verify?

/Magnus
>
> Anyway, I left a /signed comment, and now it tells me to wait until my 
> OCA is processed (it already is).
> So in all, I'm now in a limbo - what is the right thing to do now?
>
> - Johannes
>
> [1]: https://github.com/openjdk/jdk/pull/1767
> [2]: 
> https://www.oracle.com/technical-resources/oracle-contributor-agreement.html
>


From ehelin at openjdk.java.net  Wed Dec 16 08:35:06 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 16 Dec 2020 08:35:06 GMT
Subject: RFR: 846: Document the need to enable Github Actions on personal
 forks that offer testing
In-Reply-To: <TifCBCSXcQv5kX3bAjpQllgO0u6aZv5uvimI_VZ0yDw=.46f31783-12d4-43c4-8f8b-d848836b93e4@github.com>
References: <TifCBCSXcQv5kX3bAjpQllgO0u6aZv5uvimI_VZ0yDw=.46f31783-12d4-43c4-8f8b-d848836b93e4@github.com>
Message-ID: <-aOxFa3BGGvPY0jKG6u_6fXJN9Bn0cBL5-BGE2r5NI4=.e6a7e81c-686a-434e-8334-33c45b15d013@github.com>

On Tue, 15 Dec 2020 15:57:55 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Forks created after pre-submit testing using GitHub actions was introduced need to explicitly allow GitHub actions. Post a notice as a separate check result if we detect this condition.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/974

From ehelin at openjdk.java.net  Wed Dec 16 08:59:09 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 16 Dec 2020 08:59:09 GMT
Subject: RFR: git-pr-create: allow --cc for all jdk[0-9]* repos
Message-ID: <c6VPSQidPHLTYn_hzIv72FmrS2TIBPb4WuSmKuyBnas=.7214752a-cbf9-425b-b6d9-26beda3cf533@github.com>

Hi all,

please review this small patch that makes the `--cc` flag for `git pr create` work for jdk release repositories like [jdk16](https://github.com/openjdk/jdk16).

Thanks,
Erik

-------------

Commit messages:
 - git-pr-create: allow --cc for all jdk[0-9]* repos

Changes: https://git.openjdk.java.net/skara/pull/975/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=975&range=00
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/975.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/975/head:pull/975

PR: https://git.openjdk.java.net/skara/pull/975

From rwestberg at openjdk.java.net  Wed Dec 16 09:02:08 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 16 Dec 2020 09:02:08 GMT
Subject: RFR: 846: Document the need to enable Github Actions on personal
 forks that offer testing [v2]
In-Reply-To: <TifCBCSXcQv5kX3bAjpQllgO0u6aZv5uvimI_VZ0yDw=.46f31783-12d4-43c4-8f8b-d848836b93e4@github.com>
References: <TifCBCSXcQv5kX3bAjpQllgO0u6aZv5uvimI_VZ0yDw=.46f31783-12d4-43c4-8f8b-d848836b93e4@github.com>
Message-ID: <sZdkqPRjAySkxTdwyuCy_gmzPDGi_V_oWInCPM8rP3Y=.4bbbaf3d-dafc-4c68-a815-b9281164b541@github.com>

> Forks created after pre-submit testing using GitHub actions was introduced need to explicitly allow GitHub actions. Post a notice as a separate check result if we detect this condition.

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Better GitHub check

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/974/files
  - new: https://git.openjdk.java.net/skara/pull/974/files/e9734bd2..191a7a8a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=974&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=974&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/974.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/974/head:pull/974

PR: https://git.openjdk.java.net/skara/pull/974

From rwestberg at openjdk.java.net  Wed Dec 16 09:06:19 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 16 Dec 2020 09:06:19 GMT
Subject: RFR: git-pr-create: allow --cc for all jdk[0-9]* repos
In-Reply-To: <c6VPSQidPHLTYn_hzIv72FmrS2TIBPb4WuSmKuyBnas=.7214752a-cbf9-425b-b6d9-26beda3cf533@github.com>
References: <c6VPSQidPHLTYn_hzIv72FmrS2TIBPb4WuSmKuyBnas=.7214752a-cbf9-425b-b6d9-26beda3cf533@github.com>
Message-ID: <CbwshUdIBDD5Yj7kLH2eCfPjBNd_htiNoSvzIDUJ-wg=.0ad04572-5dbf-4ac0-b270-b7ce1d689b7a@github.com>

On Wed, 16 Dec 2020 08:56:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that makes the `--cc` flag for `git pr create` work for jdk release repositories like [jdk16](https://github.com/openjdk/jdk16).
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/975

From rwestberg at openjdk.java.net  Wed Dec 16 09:09:39 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 16 Dec 2020 09:09:39 GMT
Subject: Integrated: 846: Document the need to enable Github Actions on
 personal forks that offer testing
In-Reply-To: <TifCBCSXcQv5kX3bAjpQllgO0u6aZv5uvimI_VZ0yDw=.46f31783-12d4-43c4-8f8b-d848836b93e4@github.com>
References: <TifCBCSXcQv5kX3bAjpQllgO0u6aZv5uvimI_VZ0yDw=.46f31783-12d4-43c4-8f8b-d848836b93e4@github.com>
Message-ID: <tmCLNmly-IljmcdwhmkGXOa3gWeOjdhhkXIEywX46do=.2dfce84b-1b1c-480e-97b6-9b1b4246eff0@github.com>

On Tue, 15 Dec 2020 15:57:55 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Forks created after pre-submit testing using GitHub actions was introduced need to explicitly allow GitHub actions. Post a notice as a separate check result if we detect this condition.

This pull request has now been integrated.

Changeset: f3fdd3b3
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/f3fdd3b3
Stats:     135 lines in 10 files changed: 84 ins; 29 del; 22 mod

846: Document the need to enable Github Actions on personal forks that offer testing

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/974

From rwestberg at openjdk.java.net  Wed Dec 16 13:42:34 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 16 Dec 2020 13:42:34 GMT
Subject: RFR: Avoid updating unchanged checks
Message-ID: <GjirfUsAo_U_6eY3Pkdh9XPenVoDUzD_tMX_8UJW3L4=.fd989f3a-cf84-4e91-bad3-dbe2c85e99d7@github.com>

When the test info bot summarizes checks, there's no need to update summarized items that haven't changed. Also update the not-configured notice properly.

-------------

Commit messages:
 - Avoid updating unchanged checks

Changes: https://git.openjdk.java.net/skara/pull/976/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=976&range=00
  Stats: 132 lines in 2 files changed: 67 ins; 56 del; 9 mod
  Patch: https://git.openjdk.java.net/skara/pull/976.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/976/head:pull/976

PR: https://git.openjdk.java.net/skara/pull/976

From dalibor.topic at oracle.com  Wed Dec 16 13:47:46 2020
From: dalibor.topic at oracle.com (Dalibor Topic)
Date: Wed, 16 Dec 2020 14:47:46 +0100
Subject: Old OCA use with GitHub/Poject Skara
In-Reply-To: <296e7e9a-dd11-96af-1ffc-5183391a0df1@oracle.com>
References: <c3b0d940-b51f-e48d-d399-31cb355f4843@j-kuhn.de>
 <296e7e9a-dd11-96af-1ffc-5183391a0df1@oracle.com>
Message-ID: <a37643fb-e4c6-fcd6-46b8-ad9fadec8ccb@oracle.com>



On 15.12.2020 23:00, Magnus Ihse Bursie wrote:
> On 2020-12-14 17:11, Johannes Kuhn wrote:
> Dalibor, what would the recommended course of action be? Write "/signed" 
> as a pull request comment, even if there is no github user name 
> associated with the OCA? 

Yes, please.

Typically it's easy to look at an account and figure out which OCA it 
belongs to, and to do the necessary steps to verify that.

In the rare cases where that's not the case, I simply leave a comment 
for the submitter to contact me directly, and that usually happens 
within a day or two.

cheers,
dalibor topic
-- 
<http://www.oracle.com> Dalibor Topic
Consulting Product Manager
Phone: +494089091214 <tel:+494089091214>, Mobile: +491737185961
<tel:+491737185961>, Video: dalibor.topic at oracle.com
<sip:dalibor.topic at oracle.com>

Oracle Global Services Germany GmbH
Hauptverwaltung: Riesstr. 25, D-80992 M?nchen
Registergericht: Amtsgericht M?nchen, HRB 246209
Gesch?ftsf?hrer: Ralf Herrmann


From ehelin at openjdk.java.net  Wed Dec 16 13:55:16 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 16 Dec 2020 13:55:16 GMT
Subject: RFR: Avoid updating unchanged checks
In-Reply-To: <GjirfUsAo_U_6eY3Pkdh9XPenVoDUzD_tMX_8UJW3L4=.fd989f3a-cf84-4e91-bad3-dbe2c85e99d7@github.com>
References: <GjirfUsAo_U_6eY3Pkdh9XPenVoDUzD_tMX_8UJW3L4=.fd989f3a-cf84-4e91-bad3-dbe2c85e99d7@github.com>
Message-ID: <mFW088IifUdHnwsf0ihvYUAY6AHQGa3DTCx-qgQHD9E=.0d4d8e68-1993-4859-9047-d0deb6eb5e1f@github.com>

On Wed, 16 Dec 2020 13:40:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When the test info bot summarizes checks, there's no need to update summarized items that haven't changed. Also update the not-configured notice properly.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/976

From ehelin at openjdk.java.net  Wed Dec 16 13:56:10 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 16 Dec 2020 13:56:10 GMT
Subject: Integrated: git-pr-create: allow --cc for all jdk[0-9]* repos
In-Reply-To: <c6VPSQidPHLTYn_hzIv72FmrS2TIBPb4WuSmKuyBnas=.7214752a-cbf9-425b-b6d9-26beda3cf533@github.com>
References: <c6VPSQidPHLTYn_hzIv72FmrS2TIBPb4WuSmKuyBnas=.7214752a-cbf9-425b-b6d9-26beda3cf533@github.com>
Message-ID: <TljDLeB7iMseW1I_0d-LN-Uh1Hwz2u2IRRp93KPwTJg=.5fcee14e-a7cd-405b-8614-65f0434e61ba@github.com>

On Wed, 16 Dec 2020 08:56:16 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this small patch that makes the `--cc` flag for `git pr create` work for jdk release repositories like [jdk16](https://github.com/openjdk/jdk16).
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: b3703b1f
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/b3703b1f
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

git-pr-create: allow --cc for all jdk[0-9]* repos

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/975

From rwestberg at openjdk.java.net  Wed Dec 16 14:15:55 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 16 Dec 2020 14:15:55 GMT
Subject: RFR: Avoid updating unchanged checks [v2]
In-Reply-To: <GjirfUsAo_U_6eY3Pkdh9XPenVoDUzD_tMX_8UJW3L4=.fd989f3a-cf84-4e91-bad3-dbe2c85e99d7@github.com>
References: <GjirfUsAo_U_6eY3Pkdh9XPenVoDUzD_tMX_8UJW3L4=.fd989f3a-cf84-4e91-bad3-dbe2c85e99d7@github.com>
Message-ID: <6L0B9W8yi-vFzvzKDbJ_eugmse0byQj0JsTwvi8jjcE=.e187119f-e289-4299-9f10-540cd34a4106@github.com>

> When the test info bot summarizes checks, there's no need to update summarized items that haven't changed. Also update the not-configured notice properly.

Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:

  Fix build

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/976/files
  - new: https://git.openjdk.java.net/skara/pull/976/files/b9d61755..67b3bbfd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=976&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=976&range=00-01

  Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/976.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/976/head:pull/976

PR: https://git.openjdk.java.net/skara/pull/976

From ehelin at openjdk.java.net  Wed Dec 16 14:20:25 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 16 Dec 2020 14:20:25 GMT
Subject: RFR: 732: Large changes cause empty webrevs
Message-ID: <wSbaCJLCaKyPoHkZec0b0KzUoCdXf9JSWd8LwaLlAB8=.ce669b39-29e9-4f92-8229-b2cf57cf025a@github.com>

Hi all,

please review this patch that makes sure that we don't replace `commits.json`, `comparison.json` nor `metadata.json` with placeholders for webrevs.

Thanks,
Erik

-------------

Commit messages:
 - skara-732

Changes: https://git.openjdk.java.net/skara/pull/977/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=977&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-732
  Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/977.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/977/head:pull/977

PR: https://git.openjdk.java.net/skara/pull/977

From rwestberg at openjdk.java.net  Wed Dec 16 14:23:10 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 16 Dec 2020 14:23:10 GMT
Subject: RFR: 732: Large changes cause empty webrevs
In-Reply-To: <wSbaCJLCaKyPoHkZec0b0KzUoCdXf9JSWd8LwaLlAB8=.ce669b39-29e9-4f92-8229-b2cf57cf025a@github.com>
References: <wSbaCJLCaKyPoHkZec0b0KzUoCdXf9JSWd8LwaLlAB8=.ce669b39-29e9-4f92-8229-b2cf57cf025a@github.com>
Message-ID: <3-xHVez9dK2_jYthwHAIOAbe2gAiyQsNkKS4AFAQhx8=.4ff55b2a-1730-4caa-a1a8-8c060eb94dc6@github.com>

On Wed, 16 Dec 2020 14:17:23 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes sure that we don't replace `commits.json`, `comparison.json` nor `metadata.json` with placeholders for webrevs.
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/977

From ehelin at openjdk.java.net  Wed Dec 16 15:31:51 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Wed, 16 Dec 2020 15:31:51 GMT
Subject: Integrated: 732: Large changes cause empty webrevs
In-Reply-To: <wSbaCJLCaKyPoHkZec0b0KzUoCdXf9JSWd8LwaLlAB8=.ce669b39-29e9-4f92-8229-b2cf57cf025a@github.com>
References: <wSbaCJLCaKyPoHkZec0b0KzUoCdXf9JSWd8LwaLlAB8=.ce669b39-29e9-4f92-8229-b2cf57cf025a@github.com>
Message-ID: <PpWxRqPbpJHsTTazHalgGorm_qC424fd-rl-IbLuneE=.77c8384e-28c9-4c44-b39d-c525e9228510@github.com>

On Wed, 16 Dec 2020 14:17:23 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes sure that we don't replace `commits.json`, `comparison.json` nor `metadata.json` with placeholders for webrevs.
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 1f0394e7
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/1f0394e7
Stats:     7 lines in 1 file changed: 6 ins; 0 del; 1 mod

732: Large changes cause empty webrevs

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/977

From rwestberg at openjdk.java.net  Wed Dec 16 16:33:56 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Wed, 16 Dec 2020 16:33:56 GMT
Subject: Integrated: Avoid updating unchanged checks
In-Reply-To: <GjirfUsAo_U_6eY3Pkdh9XPenVoDUzD_tMX_8UJW3L4=.fd989f3a-cf84-4e91-bad3-dbe2c85e99d7@github.com>
References: <GjirfUsAo_U_6eY3Pkdh9XPenVoDUzD_tMX_8UJW3L4=.fd989f3a-cf84-4e91-bad3-dbe2c85e99d7@github.com>
Message-ID: <cd-nixRIHsG1TN1aIu1bPvs_JWl28P0kzyMzfvxVUZA=.3661c0e9-25e6-4182-a2a8-2a7c50ac6cd2@github.com>

On Wed, 16 Dec 2020 13:40:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When the test info bot summarizes checks, there's no need to update summarized items that haven't changed. Also update the not-configured notice properly.

This pull request has now been integrated.

Changeset: a08a15c8
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/a08a15c8
Stats:     137 lines in 3 files changed: 72 ins; 56 del; 9 mod

Avoid updating unchanged checks

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/976

From rwestberg at openjdk.java.net  Thu Dec 17 09:51:06 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 17 Dec 2020 09:51:06 GMT
Subject: Integrated: Ensure that GitLab approvals are processed in the correct
 order
Message-ID: <N3cIthVPZfQm7QL2p9v7PHzO8_sozC4wIh4BbypWyU8=.dc244a1f-ae15-4d2f-ab6e-d2787444c49e@github.com>

The reviews() call should return reviews in descending chronological order, ensure that GitLab approvals are sorted correctly.

-------------

Commit messages:
 - Ensure that GitLab approvals are processed in the correct orders

Changes: https://git.openjdk.java.net/skara/pull/978/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=978&range=00
  Stats: 54 lines in 1 file changed: 2 ins; 0 del; 52 mod
  Patch: https://git.openjdk.java.net/skara/pull/978.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/978/head:pull/978

PR: https://git.openjdk.java.net/skara/pull/978

From ehelin at openjdk.java.net  Thu Dec 17 09:51:06 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 17 Dec 2020 09:51:06 GMT
Subject: Integrated: Ensure that GitLab approvals are processed in the
 correct order
In-Reply-To: <N3cIthVPZfQm7QL2p9v7PHzO8_sozC4wIh4BbypWyU8=.dc244a1f-ae15-4d2f-ab6e-d2787444c49e@github.com>
References: <N3cIthVPZfQm7QL2p9v7PHzO8_sozC4wIh4BbypWyU8=.dc244a1f-ae15-4d2f-ab6e-d2787444c49e@github.com>
Message-ID: <5WV7uO48w8w9GWjKaNHMdwxE9kCxDIl75RHCCYxDktI=.0235fef6-a076-4023-90d9-41ccb7a89799@github.com>

On Thu, 17 Dec 2020 09:46:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The reviews() call should return reviews in descending chronological order, ensure that GitLab approvals are sorted correctly.

Looks good!

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/978

From rwestberg at openjdk.java.net  Thu Dec 17 09:51:06 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 17 Dec 2020 09:51:06 GMT
Subject: Integrated: Ensure that GitLab approvals are processed in the correct
 order
In-Reply-To: <N3cIthVPZfQm7QL2p9v7PHzO8_sozC4wIh4BbypWyU8=.dc244a1f-ae15-4d2f-ab6e-d2787444c49e@github.com>
References: <N3cIthVPZfQm7QL2p9v7PHzO8_sozC4wIh4BbypWyU8=.dc244a1f-ae15-4d2f-ab6e-d2787444c49e@github.com>
Message-ID: <VaSiWafEm9RbA-6O-ceY97Vq4VBFymP9rkXqq8vR-Ps=.df95e905-80ca-4091-94c0-9f25e6571b84@github.com>

On Thu, 17 Dec 2020 09:46:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The reviews() call should return reviews in descending chronological order, ensure that GitLab approvals are sorted correctly.

This pull request has now been integrated.

Changeset: 58e360ac
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/58e360ac
Stats:     54 lines in 1 file changed: 2 ins; 0 del; 52 mod

Ensure that GitLab approvals are processed in the correct order

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/978

From rwestberg at openjdk.java.net  Thu Dec 17 10:03:46 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 17 Dec 2020 10:03:46 GMT
Subject: Integrated: Ensure that GitLab approvals are processed in the correct
 order, take 2
Message-ID: <Xy9piRqazPzSADMvyzgRMwL9pwUzAHSglO2Z5zPCc3o=.321dd394-e6b4-4373-9c8a-7246064d1790@github.com>

The actual problem was in the combined sort, fixing that instead.

-------------

Commit messages:
 - Ensure that GitLab approvals are processed in the correct order, take 2

Changes: https://git.openjdk.java.net/skara/pull/979/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=979&range=00
  Stats: 7 lines in 1 file changed: 0 ins; 4 del; 3 mod
  Patch: https://git.openjdk.java.net/skara/pull/979.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/979/head:pull/979

PR: https://git.openjdk.java.net/skara/pull/979

From ehelin at openjdk.java.net  Thu Dec 17 10:03:46 2020
From: ehelin at openjdk.java.net (Erik Helin)
Date: Thu, 17 Dec 2020 10:03:46 GMT
Subject: Integrated: Ensure that GitLab approvals are processed in the
 correct order, take 2
In-Reply-To: <Xy9piRqazPzSADMvyzgRMwL9pwUzAHSglO2Z5zPCc3o=.321dd394-e6b4-4373-9c8a-7246064d1790@github.com>
References: <Xy9piRqazPzSADMvyzgRMwL9pwUzAHSglO2Z5zPCc3o=.321dd394-e6b4-4373-9c8a-7246064d1790@github.com>
Message-ID: <4uTtQeKr1vKmfaGYxDkJwu640627k21-k2AJuJ9V8eM=.80bcb477-d889-4616-ae60-2759843ba91c@github.com>

On Thu, 17 Dec 2020 09:57:00 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The actual problem was in the combined sort, fixing that instead.

The sequel is always better than the first one ??

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/979

From rwestberg at openjdk.java.net  Thu Dec 17 10:03:46 2020
From: rwestberg at openjdk.java.net (Robin Westberg)
Date: Thu, 17 Dec 2020 10:03:46 GMT
Subject: Integrated: Ensure that GitLab approvals are processed in the correct
 order, take 2
In-Reply-To: <Xy9piRqazPzSADMvyzgRMwL9pwUzAHSglO2Z5zPCc3o=.321dd394-e6b4-4373-9c8a-7246064d1790@github.com>
References: <Xy9piRqazPzSADMvyzgRMwL9pwUzAHSglO2Z5zPCc3o=.321dd394-e6b4-4373-9c8a-7246064d1790@github.com>
Message-ID: <clvve9X8ThL3vqDqTMuzH52joDLrhB6poMcAqCHFBw8=.27600655-cd09-45fd-a782-1edf13f187eb@github.com>

On Thu, 17 Dec 2020 09:57:00 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The actual problem was in the combined sort, fixing that instead.

This pull request has now been integrated.

Changeset: 02007d79
Author:    Robin Westberg <rwestberg at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/02007d79
Stats:     7 lines in 1 file changed: 0 ins; 4 del; 3 mod

Ensure that GitLab approvals are processed in the correct order, take 2

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/979

From thomas.stuefe at gmail.com  Sat Dec 19 06:46:02 2020
From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=)
Date: Sat, 19 Dec 2020 07:46:02 +0100
Subject: commits not associated with github user?
In-Reply-To: <CAA-vtUxWn==39nWfXwN5Qw-hYF2d_kXrcXoyWNLzSStDxmPHOw@mail.gmail.com>
References: <CAA-vtUzjDPou5LX2KWx3Wcq0vXTjpsZPvUPbHMsLMiMQ=UF9UQ@mail.gmail.com>
 <CAEQxcvGHsfzLJ6dvD12GHvYXs0=i5F1UHczr+WkOhHsA2ewhRg@mail.gmail.com>
 <CAA-vtUwWp6SxvN1B-bYTdaHOX7ZOjOMU1hrxEHqL+Z6GbFsghg@mail.gmail.com>
 <CAA-vtUwDXUYxZiC3k6cAxzE5om-WUgUJgbbmUo9sZdh-pXwprQ@mail.gmail.com>
 <66acdba3-8b67-b021-e312-7f3997ed396a@oracle.com>
 <CAA-vtUxWn==39nWfXwN5Qw-hYF2d_kXrcXoyWNLzSStDxmPHOw@mail.gmail.com>
Message-ID: <CAA-vtUywZ7PKcPVoqUv7YfD_iRQxV7qhnii+gfzioFC73izBAw@mail.gmail.com>

Hi,

this continues to be a problem. None of the suggested workarounds (adding
the fake openjdk mail address to the account) worked.

Any more suggestions?

Thanks, Thomas


On Mon, Nov 2, 2020 at 3:52 PM Thomas St?fe <thomas.stuefe at gmail.com> wrote:

> Thank you for the clarification, Magnus.
>
> I added my fake openjdk mail address to my Github account yesterday,
> without any effects yet, but it may just take some time. I'll be patient :)
>
> Cheers, Thomas
>
> On Mon, Nov 2, 2020 at 2:58 PM Magnus Ihse Bursie <
> magnus.ihse.bursie at oracle.com> wrote:
>
>> It's a bit weird (since the openjdk.org domain has still not gotten live
>> for MX), but this is indeed the correct way to get your github account
>> associated with your commits. You'll just have to live with the address
>> being "unverified" in github for the moment, and be thankful that github
>> still trusts it enough to use it for linking commits with accounts. :)
>>
>> I assure you we do not want this limbo to continue any longer than
>> necessary.
>>
>> /Magnus
>>
>>
>> On 2020-11-01 08:10, Thomas St?fe wrote:
>> > Okay, I tried this and as expected the mail address remains unverified
>> in
>> > Github since it is not a real mail address (or is it? At least I have no
>> > idea how to access this mail box, if it exists). Did this still work for
>> > you with the mail address left unverified?
>> >
>> > Thanks, Thomas
>> >
>> > On Sat, Oct 31, 2020 at 10:49 AM Thomas St?fe <thomas.stuefe at gmail.com>
>> > wrote:
>> >
>> >> Hi Anirvan,
>> >>
>> >> interesting idea, thank you!
>> >>
>> >> But the openjdk mail addresses are not valid. I hesitate to add an
>> invalid
>> >> mail address to my Github profile. I'd rather that the correct mail
>> >> addresses be used by the Skara tools, those we are registered in the
>> census
>> >> with and which are used by the Github account. Especially since these
>> fake
>> >> addresses also add confusion to mailing list traffic.
>> >>
>> >> Thanks, Thomas
>> >>
>> >>
>> >> On Sat, Oct 31, 2020 at 9:16 AM Anirvan Sarkar <
>> powers.anirvan at gmail.com>
>> >> wrote:
>> >>
>> >>> Hi Thomas,
>> >>>
>> >>> I had also observed the same behaviour.
>> >>> Then I noticed that OpenJDK commits are committed with OpenJDK email
>> >>> address [1].
>> >>> So I added my OpenJDK email address to GitHub email settings [2] and
>> >>> after some days when I checked again, I found my commit was linked to
>> my
>> >>> GitHub user [3].
>> >>>
>> >>> Can you add your OpenJDK email address in your GitHub settings and
>> see if
>> >>> it works for you?
>> >>> If it works then we can ask the Skara team to add this step in the
>> Wiki.
>> >>>
>> >>> [1]
>> >>>
>> https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a.patch
>> >>> [2] https://github.com/settings/emails
>> >>> [3]
>> >>>
>> https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a
>> >>>
>> >>> On Wed, 28 Oct 2020 at 19:40, Thomas St?fe <thomas.stuefe at gmail.com>
>> >>> wrote:
>> >>>
>> >>>> Hi,
>> >>>>
>> >>>> a small question: I associated my OpenJDK user with my GitHub user as
>> >>>> explained in [1]. But I still do not see my github user associated
>> with
>> >>>> commits in the OpenJDK, e.g. for
>> >>>>
>> >>>>
>> https://github.com/openjdk/jdk/commit/7ba6a6bf003b810e9f48cb755abe39b1376ad3fe#diff-40f3361acaecc2d05896655fa532ab5b6cba2885cbcc5796cac4e81d010763ba
>> >>>>
>> >>>> It says my name, fully written, not clickable. Seems to be the case
>> for
>> >>>> many developers, but not all of them. For some, the commit is
>> actually
>> >>>> linked to the Github user.
>> >>>>
>> >>>> Did I miss some step somewhere when setting up my user?
>> >>>>
>> >>>> Thanks!
>> >>>> Thomas
>> >>>>
>> >>>> [1]
>> >>>>
>> https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-GettingStarted
>> >>>>
>> >>>
>> >>> --
>> >>> Anirvan
>> >>>
>>
>>

From weijun at openjdk.java.net  Tue Dec 22 16:34:19 2020
From: weijun at openjdk.java.net (Weijun Wang)
Date: Tue, 22 Dec 2020 16:34:19 GMT
Subject: RFR: "java.se" matches "java.security.jgss" as well
Message-ID: <J2xtDkugSWtQmLEpMYEvBXGg7hPM1rwNBiJJoBP8ViA=.faf1f56b-82b3-473d-b467-6d57466f983a@github.com>

core-libs does not need to care about these security-related modules.

-------------

Commit messages:
 - "java.se" matches "java.security.jgss" as well

Changes: https://git.openjdk.java.net/skara/pull/980/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=980&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/980.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/980/head:pull/980

PR: https://git.openjdk.java.net/skara/pull/980

From xuelei at openjdk.java.net  Tue Dec 22 16:43:53 2020
From: xuelei at openjdk.java.net (Xue-Lei Andrew Fan)
Date: Tue, 22 Dec 2020 16:43:53 GMT
Subject: RFR: "java.se" matches "java.security.jgss" as well
In-Reply-To: <J2xtDkugSWtQmLEpMYEvBXGg7hPM1rwNBiJJoBP8ViA=.faf1f56b-82b3-473d-b467-6d57466f983a@github.com>
References: <J2xtDkugSWtQmLEpMYEvBXGg7hPM1rwNBiJJoBP8ViA=.faf1f56b-82b3-473d-b467-6d57466f983a@github.com>
Message-ID: <Nt4rlHvmk7RzS3POHDTtZ63uKqR1BeeQCI95XFc8_bE=.f47b8389-a060-43c4-af62-31012fec1fa1@github.com>

On Tue, 22 Dec 2020 16:31:21 GMT, Weijun Wang <weijun at openjdk.org> wrote:

> core-libs does not need to care about these security-related modules.

Marked as reviewed by xuelei (no project role).

-------------

PR: https://git.openjdk.java.net/skara/pull/980