RFR: Add toString methods to all WorkItems

Robin Westberg rwestberg at openjdk.java.net
Thu Feb 6 10:52:57 UTC 2020


On Thu, 6 Feb 2020 10:49:56 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this small patch that adds proper `toString` implementations to
>> all classes implementing `WorkItem` (to get better logging).
>> 
>> Thanks,
>> Erik
> 
> bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java line 88:
> 
>> 87:     public String toString() {
>> 88:         return "MirrorBot@" + from.name() + "-> " + to.name();
>> 89:     }
> 
> Suggestion:
> 
>         return "MirrorBot@" + from.name() + " -> " + to.name();

Or the other way around ��

-------------

PR: https://git.openjdk.java.net/skara/pull/403


More information about the skara-dev mailing list