RFR: Fix parsing of editor commandline in git-pr

[Christoph Langer]

On Mon, 25 Nov 2019 11:09:49 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Christopher, as Robin says, we unfortunately only have a man page at the moment (which won't help you very much since you are on Windows). You can get more abbreviated help information by running `git pr -h`. Robin is also right in how you add a longer multiline description to the pull request.
>> 
>> As for the regular expression, could you please add a comments above with a few examples. Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice:
>> 
>> core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin
>> 
>> Thanks,
>> Erik
> 
> @RealCLanger did you see mine and Robin's comments?

Hi,

finally I got back to this.

> As for the regular expression, could you please add a comments above with a few examples.

I've done that.

> Also, do you really need the quotation marks around the path to `notepad.exe` for `core.editor`? Won't the following suffice:
> 
> ```
> core.editor = C:\Program Files\Notepad++\notepad++.exe -multiInst -notabbar -nosession -noPlugin

Probably yes, but that's how I found my git configuration without manual changes that I'm aware of. So it should work. And I think, even if I remove the quotation marks, it still wouldn't work.

Please review :)

-------------

PR: https://git.openjdk.java.net/skara/pull/259