RFR: Add checkout instructions to PR body

Erik Helin ehelin at openjdk.java.net
Thu Feb 13 14:28:40 UTC 2020


On Thu, 13 Feb 2020 13:29:44 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Hi,
> 
> I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well.
> 
> This adds a new "Instructions" section to the body of the PR message:
> 
>> ## Instructions
>> To checkout these changes locally:
>> ```bash
>> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16
>> $ git checkout pull/16
>> ```
> 
> Testing:
> - Running `.\gradlew test`
> 
> Any other recommendations for testing this?
> 
> Thanks,
> Jorn

Thanks Jorn, good idea �� I think we might want to overhaul the design a little bit to accommodate for this new section. I added in some more section that might appear in a pull request -  what do you think about the following?

> -----------------------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [ ] Change must be properly reviewed (1/2)
> 
> ### Reviewers
> * Erik Duveblad ([ehelin](localhost) - **Reviewer**)
> * Joe Darcy ([darcy](locahost) - **Reviewer**) �� Re-review required (review applies to 7de15f5c44a6f4f5a18afda090d52b7b69c7d09c)
>
> ### Issue
> * [JDK-8712393](localhost): Add download instructions to pull request
>
>
> ### Contributors
> * Robin Westberg ([rwestberg](localhost))
>
> ### Download
> `$ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16`
> `$ git checkout pull/16`

-------------

PR: https://git.openjdk.java.net/skara/pull/434


More information about the skara-dev mailing list