RFR: Add checkout instructions to PR body
jvernee at openjdk.java.net
Mon Feb 17 11:16:21 UTC 2020
On Thu, 13 Feb 2020 14:26:29 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well.
>> This adds a new "Instructions" section to the body of the PR message:
>>> ## Instructions
>>> To checkout these changes locally:
>>> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16
>>> $ git checkout pull/16
>> - Running `.\gradlew test`
>> Any other recommendations for testing this?
> Thanks Jorn, good idea I think we might want to overhaul the design a little bit to accommodate for this new section. I added in some more sections that might appear in a pull request - what do you think about the following?
>> ### Progress
>> - [x] Change must not contain extraneous whitespace
>> - [ ] Change must be properly reviewed (1/2)
>> ### Issues
>> * [JDK-8712393](localhost): Add download instructions to pull request
>> ### Contributors
>> * Robin Westberg ([rwestberg](localhost))
>> ### Reviewers
>> * Erik Duveblad ([ehelin](localhost) - **Reviewer**)
>> * Joe Darcy ([darcy](locahost) - **Reviewer**) Re-review required (review applies to 7de15f5c44a6f4f5a18afda090d52b7b69c7d09c)
>> ### Download
>> `$ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16`
>> `$ git checkout pull/16`
I like the new format that you suggest as well :) I've applied the suggestions.
More information about the skara-dev