[Rev 01] RFR: Add checkout instructions to PR body

Erik Helin ehelin at openjdk.java.net
Mon Feb 17 15:01:35 UTC 2020


On Mon, 17 Feb 2020 11:16:20 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Hi,
>> 
>> I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well.
>> 
>> This adds a new "Instructions" section to the body of the PR message:
>> 
>>> ## Instructions
>>> To checkout these changes locally:
>>> ```bash
>>> $ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16
>>> $ git checkout pull/16
>>> ```
>> 
>> Testing:
>> - Running `.\gradlew test`
>> 
>> Any other recommendations for testing this?
>> 
>> Thanks,
>> Jorn
> 
> The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Nice work! Just a small nit, you can use a Markdown [thematic break](https://spec.commonmark.org/0.29/#thematic-break) instead of using the `<hr />` HTML tag directly.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 305:

> 304:         var progressBody = new StringBuilder();
> 305:         progressBody.append("</hr>");
> 306:         progressBody.append("### Progress\n");

Suggestion:

        progressBody.append("---------");

-------------



PR: https://git.openjdk.java.net/skara/pull/434


More information about the skara-dev mailing list