RFR: 235: git-webrev can't handle empty files

Erik Helin ehelin at openjdk.java.net
Tue Jan 21 07:24:12 UTC 2020


Hi all,

please review this patch that makes `git-webrev` work with empty files (either
added or removed). The addition or removal of an empty file can't unfortunately
be represented using the unified diff output format (one needs "extended
headers" like `git`), but we can still make the HTML view work.

Thanks,
Erik

## Testing
- [x] Manual testing of `git-webrev` on repositories with empty files

-------------

Commits:
 - 071de9e1: skara-235

Changes: https://git.openjdk.java.net/skara/pull/369/files
 Webrev: https://webrevs.openjdk.java.net/skara/369/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-235
  Stats: 46 lines in 2 files changed: 2 ins; 0 del; 44 mod
  Patch: https://git.openjdk.java.net/skara/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/369/head:pull/369

PR: https://git.openjdk.java.net/skara/pull/369


More information about the skara-dev mailing list