RFR: 244: Legacy reviewers jcheck configuration does not reset default
Erik Helin
ehelin at openjdk.java.net
Thu Jan 23 17:28:51 UTC 2020
Hi all,
please review this patch that fixes an issue with the parsing of the older
format of the "reviewers" jcheck configuration. The problem is that the defaults
weren't reset when parsing the older format, so if a repository has a
`.jcheck/conf` containing the following
[checks "reviewer"]
minimum = 1
role = committer
then the outcome would be the that jcheck would require 1 Reviewer and 1
Committer (since the default is 1 Reviewer).
The fix is to reset the defaults to zero when parsing the older format.
Thanks,
Erik
## Testing
- [x] Added a new unit test for the above scenario
-------------
Commits:
- 691d0f26: Reset defaults to 0
Changes: https://git.openjdk.java.net/skara/pull/378/files
Webrev: https://webrevs.openjdk.java.net/skara/378/webrev.00
Issue: https://bugs.openjdk.java.net/browse/SKARA-244
Stats: 39 lines in 2 files changed: 39 ins; 0 del; 0 mod
Patch: https://git.openjdk.java.net/skara/pull/378.diff
Fetch: git fetch https://git.openjdk.java.net/skara pull/378/head:pull/378
PR: https://git.openjdk.java.net/skara/pull/378
More information about the skara-dev
mailing list