RFR: 218: Enforce check on approval of CSRs

[Erik Helin]

On Tue, 28 Jan 2020 13:42:42 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that adds a CSR bot. The CSR bot allows a reviewer to
>> issue the command `/csr` in a pull request comment. Once issued, the PR cannot
>> be integrated until the CSR for the issue associated with the PR is in state
>> "Closed" and "Approved". A reviewer can cancel this requirement by issuing the
>> command `/csr unneeded` in a pull request comment.
>> 
>> Testing:
>> - Added a bunch of new unit tests for the `/csr` command and the CSR bot
>> - `sh gradlew test` passes on Linux x64
>> 
>> Thanks,
>> Erik
> 
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java line 98:
> 
>> 97:     private void processCommand(PullRequest pr, CensusInstance censusInstance, Path scratchPath, String command, Comment comment, List<Comment> allComments) {
>> 98:         System.out.println("processing command " + command);
>> 99:         var writer = new StringWriter();
> 
> Revert?

Right, thanks!

-------------

PR: https://git.openjdk.java.net/skara/pull/385