RFR: pr: improve message for unexpected merge commits

Kevin Rushforth kcr at openjdk.java.net
Sat Jul 4 14:58:31 UTC 2020


On Sat, 4 Jul 2020 10:08:38 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that improves the warning when a pull request contains a merge request that brings in commits
> not present in the target repository. This indicates that the user might wanted to do a "merge style" pull request, but
> can also arise in other scenarios.  Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Looks good (aside from Robin's comment).

-------------

Marked as reviewed by kcr (no project role).

PR: https://git.openjdk.java.net/skara/pull/693


More information about the skara-dev mailing list