RFR: git-pr: add contributor sub-command

Jorn Vernee jvernee at openjdk.java.net
Thu Jul 9 12:59:12 UTC 2020


On Thu, 9 Jul 2020 12:48:53 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the `git pr contributor` sub-command that corresponds to the
> [`/contributor`](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/contributor)
> pull request command. Contributors who prefer the command line can now add contributors to a pull request, for example
> `git pr contributor --add='@edvbld'` or `git pr contributor --add=ehelin`.  Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Marked as reviewed by jvernee (Reviewer).

cli/src/main/java/org/openjdk/skara/cli/pr/GitPrContributor.java line 39:

> 38:               .describe("USERNAME")
> 39:               .helptext("Consider pull request reviewed by this user")
> 40:               .optional(),

Need to change the help text here it seems.
Suggestion:

              .helptext("Consider pull request contributed to by this user")

cli/src/main/java/org/openjdk/skara/cli/pr/GitPrContributor.java line 44:

> 43:               .describe("USERNAME")
> 44:               .helptext("Do not consider pull request reviewed by this user")
> 45:               .optional(),

Same here
Suggestion:

              .helptext("Do not consider pull request contributed to by this user")

-------------

PR: https://git.openjdk.java.net/skara/pull/701


More information about the skara-dev mailing list