RFR: SKARA-461: Do a git version check

Kevin Rushforth kcr at openjdk.java.net
Wed Jul 29 15:21:41 UTC 2020

On Wed, 29 Jul 2020 15:18:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Hi,
>> This PR adds a git version check to the `git skara` CLI. This will print a warning if the git version is not a known
>> working version. Since outdated versions can lead to IOExceptions due to e.g. unsupported git CLI options, hopefully
>> the warning message will help to inform users about their use of an unsupported git version, and a potential way to
>> solve the problem i.e. upgrading to a more recent version.  Currently at least git 2.22 is required since we use the
>> `--combined-all-paths` option of git log (see GitCommits), which was added in 2.22.  Thanks,
>> Jorn
> How hard would it be to actually support older versions? Requiring 2.22 might be a barrier for some users. I just
> checked and 2 of the 4 machines I use, including my main development platform, have versions older than that. I'm not a
> heavy user of the Skara CLI tools, but am concerned about those who are.

Btw, I think this PR is fine unless / until the Skara CLI tools support older versions.


PR: https://git.openjdk.java.net/skara/pull/707

More information about the skara-dev mailing list