From rwestberg at openjdk.java.net Mon Jun 1 04:35:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 1 Jun 2020 04:35:04 GMT Subject: RFR: Handle empty GitLab merge requests Message-ID: <5L61BzlFxXDSAp567hDIwfhUQ_Z34_QS0RtcV0z-2KE=.0e1ab9b5-81e5-42b8-b704-50bdb9f9b13a@github.com> Hi all, Please review this small change that allows empty GitLab merge requests to be inspected. Best regards, Robin ------------- Commit messages: - Handle empty GitLab merge requests Changes: https://git.openjdk.java.net/skara/pull/633/files Webrev: https://webrevs.openjdk.java.net/skara/633/webrev.00 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/633.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/633/head:pull/633 PR: https://git.openjdk.java.net/skara/pull/633 From rwestberg at openjdk.java.net Mon Jun 1 08:24:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 1 Jun 2020 08:24:31 GMT Subject: [Integrated] RFR: 404: Add a blank line after quoted blocks in TextToMarkdown In-Reply-To: References: Message-ID: <6JwEACfMkzLFlbLiNZb3a6OXXP3QIhXcvBClTRkutk8=.7fbf1692-dfda-4258-ba70-4bc5684ad2c8@github.com> On Thu, 28 May 2020 13:02:25 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that inserts an blank line after quoted blocks in case there isn't one already, which matches > how an email client would render the text. > Best regards, > Robin This pull request has now been integrated. Changeset: f4d9b6e8 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/f4d9b6e8 Stats: 28 lines in 2 files changed: 0 ins; 27 del; 1 mod 404: Add a blank line after quoted blocks in TextToMarkdown Reviewed-by: jvernee ------------- PR: https://git.openjdk.java.net/skara/pull/632 From rwestberg at openjdk.java.net Mon Jun 1 08:57:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 1 Jun 2020 08:57:31 GMT Subject: [Integrated] RFR: Handle empty GitLab merge requests In-Reply-To: <5L61BzlFxXDSAp567hDIwfhUQ_Z34_QS0RtcV0z-2KE=.0e1ab9b5-81e5-42b8-b704-50bdb9f9b13a@github.com> References: <5L61BzlFxXDSAp567hDIwfhUQ_Z34_QS0RtcV0z-2KE=.0e1ab9b5-81e5-42b8-b704-50bdb9f9b13a@github.com> Message-ID: On Mon, 1 Jun 2020 04:28:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that allows empty GitLab merge requests to be inspected. > > Best regards, > Robin This pull request has now been integrated. Changeset: 6b9b00c8 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/6b9b00c8 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Handle empty GitLab merge requests Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/633 From ehelin at openjdk.java.net Mon Jun 1 08:57:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 1 Jun 2020 08:57:31 GMT Subject: RFR: Handle empty GitLab merge requests In-Reply-To: <5L61BzlFxXDSAp567hDIwfhUQ_Z34_QS0RtcV0z-2KE=.0e1ab9b5-81e5-42b8-b704-50bdb9f9b13a@github.com> References: <5L61BzlFxXDSAp567hDIwfhUQ_Z34_QS0RtcV0z-2KE=.0e1ab9b5-81e5-42b8-b704-50bdb9f9b13a@github.com> Message-ID: On Mon, 1 Jun 2020 04:28:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that allows empty GitLab merge requests to be inspected. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/633 From rwestberg at openjdk.java.net Mon Jun 1 13:10:49 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 1 Jun 2020 13:10:49 GMT Subject: RFR: Fix equals check for non-web links Message-ID: Hi all, Please review this small change that fixes the equals function for non-web issue links. Best regards, Robin ------------- Commit messages: - Fix equals check for non-web links Changes: https://git.openjdk.java.net/skara/pull/634/files Webrev: https://webrevs.openjdk.java.net/skara/634/webrev.00 Stats: 30 lines in 2 files changed: 28 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/634.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/634/head:pull/634 PR: https://git.openjdk.java.net/skara/pull/634 From youngty1997 at gmail.com Mon Jun 1 16:31:58 2020 From: youngty1997 at gmail.com (Ty Young) Date: Mon, 1 Jun 2020 11:31:58 -0500 Subject: Feature request: automatic JDK builds & build status badge for each platform In-Reply-To: <135d4642-2dff-789d-c01e-ea3bd226cd75@gmail.com> References: <135d4642-2dff-789d-c01e-ea3bd226cd75@gmail.com> Message-ID: Anything on this? Could it be done? On 5/29/20 10:46 AM, Ty Young wrote: > (Apologies if this isn't within the scope of Skara or has been > discussed before. Please don't shoot me if either are true.) > > > Hi, > > > I frequently compile-from-source and use Project Panama's > Foreign-Memory-Access(FMA) builds from Github[1]. While this works, it > requires a lot of processing power, memory, and time to do and JDK > builds sometimes fail to build or have JVM bugs that result in > unexpected crashes. It is also fairly common in places such as the > U.S. to have data caps that can easily be eaten up by downloading JDK > source code that doesn't even compile. > > > So, I'm wondering if automatic JDK builds and a checkmark badge for > each and every JDK platform could be added to resolve these issues. I > know it's a bit of a tall order, but doing so would really help people > like myself who frequently use in-development JDK features. Perhaps it > could help increase the amount of people playing around with these > in-development features as well since the bar to enter will be lowered. > > > Presumably these builds are already being built somewhere and go > through testing, but if not or if making them public isn't an option, > perhaps using Github's "Actions" feature would suffice for building? > Just an idea. > > > [1] https://github.com/openjdk/panama-foreign > From joe.darcy at oracle.com Tue Jun 2 03:28:37 2020 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 1 Jun 2020 20:28:37 -0700 Subject: Feature request: automatic JDK builds & build status badge for each platform In-Reply-To: References: <135d4642-2dff-789d-c01e-ea3bd226cd75@gmail.com> Message-ID: We have an Oracle-internal CI system for JDK builds and have thought it would be useful to publish some information from that system externally in a way that can be associated with changesets. -Joe On 6/1/2020 9:31 AM, Ty Young wrote: > Anything on this? Could it be done? > > > On 5/29/20 10:46 AM, Ty Young wrote: >> (Apologies if this isn't within the scope of Skara or has been >> discussed before. Please don't shoot me if either are true.) >> >> >> Hi, >> >> >> I frequently compile-from-source and use Project Panama's >> Foreign-Memory-Access(FMA) builds from Github[1]. While this works, >> it requires a lot of processing power, memory, and time to do and JDK >> builds sometimes fail to build or have JVM bugs that result in >> unexpected crashes. It is also fairly common in places such as the >> U.S. to have data caps that can easily be eaten up by downloading JDK >> source code that doesn't even compile. >> >> >> So, I'm wondering if automatic JDK builds and a checkmark badge for >> each and every JDK platform could be added to resolve these issues. I >> know it's a bit of a tall order, but doing so would really help >> people like myself who frequently use in-development JDK features. >> Perhaps it could help increase the amount of people playing around >> with these in-development features as well since the bar to enter >> will be lowered. >> >> >> Presumably these builds are already being built somewhere and go >> through testing, but if not or if making them public isn't an option, >> perhaps using Github's "Actions" feature would suffice for building? >> Just an idea. >> >> >> [1] https://github.com/openjdk/panama-foreign >> From youngty1997 at gmail.com Tue Jun 2 06:12:51 2020 From: youngty1997 at gmail.com (Ty Young) Date: Tue, 2 Jun 2020 01:12:51 -0500 Subject: Feature request: automatic JDK builds & build status badge for each platform In-Reply-To: References: <135d4642-2dff-789d-c01e-ea3bd226cd75@gmail.com> Message-ID: <0f9ba7d3-660d-a2b3-f9e4-88e3b49fd166@gmail.com> On 6/1/20 10:28 PM, Joe Darcy wrote: > We have an Oracle-internal CI system for JDK builds and have thought > it would be useful to publish some information from that system > externally in a way that can be associated with changesets. Thanks for the reply! Sounds great. Are you at all considering public automatic builds too? > > -Joe > > On 6/1/2020 9:31 AM, Ty Young wrote: >> Anything on this? Could it be done? >> >> >> On 5/29/20 10:46 AM, Ty Young wrote: >>> (Apologies if this isn't within the scope of Skara or has been >>> discussed before. Please don't shoot me if either are true.) >>> >>> >>> Hi, >>> >>> >>> I frequently compile-from-source and use Project Panama's >>> Foreign-Memory-Access(FMA) builds from Github[1]. While this works, >>> it requires a lot of processing power, memory, and time to do and >>> JDK builds sometimes fail to build or have JVM bugs that result in >>> unexpected crashes. It is also fairly common in places such as the >>> U.S. to have data caps that can easily be eaten up by downloading >>> JDK source code that doesn't even compile. >>> >>> >>> So, I'm wondering if automatic JDK builds and a checkmark badge for >>> each and every JDK platform could be added to resolve these issues. >>> I know it's a bit of a tall order, but doing so would really help >>> people like myself who frequently use in-development JDK features. >>> Perhaps it could help increase the amount of people playing around >>> with these in-development features as well since the bar to enter >>> will be lowered. >>> >>> >>> Presumably these builds are already being built somewhere and go >>> through testing, but if not or if making them public isn't an >>> option, perhaps using Github's "Actions" feature would suffice for >>> building? Just an idea. >>> >>> >>> [1] https://github.com/openjdk/panama-foreign >>> From ehelin at openjdk.java.net Tue Jun 2 07:12:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 2 Jun 2020 07:12:27 GMT Subject: RFR: Fix equals check for non-web links In-Reply-To: References: Message-ID: On Mon, 1 Jun 2020 13:05:18 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that fixes the equals function for non-web issue links. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/634 From rwestberg at openjdk.java.net Tue Jun 2 07:12:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 2 Jun 2020 07:12:27 GMT Subject: [Integrated] RFR: Fix equals check for non-web links In-Reply-To: References: Message-ID: On Mon, 1 Jun 2020 13:05:18 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that fixes the equals function for non-web issue links. > > Best regards, > Robin This pull request has now been integrated. Changeset: 648f1bea Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/648f1bea Stats: 30 lines in 2 files changed: 0 ins; 28 del; 2 mod Fix equals check for non-web links Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/634 From ehelin at openjdk.java.net Tue Jun 2 09:53:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 2 Jun 2020 09:53:21 GMT Subject: RFR: Update to Gradle 6.4.1 Message-ID: Hi all. please review this patch that updates Gradle to 6.4.1. I also went over the README to document the versions of tools used for building and testing. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - Update to Gradle 6.4.1 Changes: https://git.openjdk.java.net/skara/pull/635/files Webrev: https://webrevs.openjdk.java.net/skara/635/webrev.00 Stats: 11 lines in 3 files changed: 1 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/635.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/635/head:pull/635 PR: https://git.openjdk.java.net/skara/pull/635 From rwestberg at openjdk.java.net Tue Jun 2 09:55:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 2 Jun 2020 09:55:27 GMT Subject: RFR: Update to Gradle 6.4.1 In-Reply-To: References: Message-ID: On Tue, 2 Jun 2020 09:47:35 GMT, Erik Helin wrote: > Hi all. > > please review this patch that updates Gradle to 6.4.1. I also went over the README to document the versions of tools > used for building and testing. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/635 From ehelin at openjdk.java.net Tue Jun 2 10:05:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 2 Jun 2020 10:05:17 GMT Subject: [Integrated] RFR: Update to Gradle 6.4.1 In-Reply-To: References: Message-ID: On Tue, 2 Jun 2020 09:47:35 GMT, Erik Helin wrote: > Hi all. > > please review this patch that updates Gradle to 6.4.1. I also went over the README to document the versions of tools > used for building and testing. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: eed788f0 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/eed788f0 Stats: 11 lines in 3 files changed: 0 ins; 1 del; 10 mod Update to Gradle 6.4.1 Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/635 From ihse at openjdk.java.net Wed Jun 3 12:22:43 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Wed, 3 Jun 2020 12:22:43 GMT Subject: RFR: json patches introduced to the OpenJDK copy in JDK-8246435 Message-ID: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> json patches introduced to the OpenJDK copy in JDK-8246435 ------------- Commit messages: - Patches introduced to the OpenJDK copy in JDK-8246435. Changes: https://git.openjdk.java.net/skara/pull/636/files Webrev: https://webrevs.openjdk.java.net/skara/636/webrev.00 Stats: 44 lines in 7 files changed: 26 ins; 0 del; 18 mod Patch: https://git.openjdk.java.net/skara/pull/636.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/636/head:pull/636 PR: https://git.openjdk.java.net/skara/pull/636 From ehelin at openjdk.java.net Wed Jun 3 12:41:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 3 Jun 2020 12:41:12 GMT Subject: RFR: webrev: proper index.html fix and charset fixes Message-ID: Hi all, please review this patch that fixes two issues in webrev: 1. Use a more robust band-aid for the problem when generating a webrev for a file named `index.html` 2. Try multiple charsets when reading files from disk Testing: - Manual testing of `git webrev` on Linux x64 - `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - webrev: proper index.html fix and charset fixes Changes: https://git.openjdk.java.net/skara/pull/637/files Webrev: https://webrevs.openjdk.java.net/skara/637/webrev.00 Stats: 49 lines in 4 files changed: 35 ins; 2 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/637.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/637/head:pull/637 PR: https://git.openjdk.java.net/skara/pull/637 From rwestberg at openjdk.java.net Wed Jun 3 12:44:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 3 Jun 2020 12:44:56 GMT Subject: RFR: webrev: proper index.html fix and charset fixes In-Reply-To: References: Message-ID: <8D1SHzE_tJCTles2uIV08elIm0v0nQ7fU3D6jIQAMB4=.adc6e315-c56d-4b39-85d9-8152c8e59a2b@github.com> On Wed, 3 Jun 2020 12:35:36 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes two issues in webrev: > > 1. Use a more robust band-aid for the problem when generating a webrev for a file named `index.html` > 2. Try multiple charsets when reading files from disk > > Testing: > - Manual testing of `git webrev` on Linux x64 > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/637 From ehelin at openjdk.java.net Wed Jun 3 12:47:26 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 3 Jun 2020 12:47:26 GMT Subject: RFR: json patches introduced to the OpenJDK copy in JDK-8246435 In-Reply-To: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> References: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> Message-ID: On Wed, 3 Jun 2020 12:16:36 GMT, Magnus Ihse Bursie wrote: > This PR contains the proposed changes to the json system made in JDK-8246435. If the same changes are made in Skara, > tthe two code bases are kept from diverging. Hi Magnus, thanks for contributing! Looks really nice in general, I just had two small comments about the changes to `JSONArray`. Thanks! Erik json/src/main/java/org/openjdk/skara/json/JSONArray.java line 42: > 41: > 42: private void append(JSONValue value) { > 43: if (value instanceof JSONArray) { Could you rename this to `concat` and explicitly take a `JSONArray` instead as parameter? I'm fine with having `append`, but `append` should be just `append` (that is, append a single item to the array). json/src/main/java/org/openjdk/skara/json/JSONArray.java line 52: > 51: > 52: public JSONArray(JSONValue value, JSONValue... values) { > 53: this.values = new ArrayList(values.length + 1); Related to the comment about `concat` vs `append`, I would prefer that the constructor does `append` and not `concat`. One could imagine a `static` version of `concat` as well, e.g. `public static JSONArray concat(JSONArray... arrays)`. ------------- Changes requested by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/636 From ehelin at openjdk.java.net Wed Jun 3 12:48:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 3 Jun 2020 12:48:37 GMT Subject: [Integrated] RFR: webrev: proper index.html fix and charset fixes In-Reply-To: References: Message-ID: On Wed, 3 Jun 2020 12:35:36 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes two issues in webrev: > > 1. Use a more robust band-aid for the problem when generating a webrev for a file named `index.html` > 2. Try multiple charsets when reading files from disk > > Testing: > - Manual testing of `git webrev` on Linux x64 > - `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: ff0c4d50 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ff0c4d50 Stats: 49 lines in 4 files changed: 2 ins; 35 del; 12 mod webrev: proper index.html fix and charset fixes Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/637 From ihse at openjdk.java.net Wed Jun 3 14:36:48 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Wed, 3 Jun 2020 14:36:48 GMT Subject: RFR: json patches introduced to the OpenJDK copy in JDK-8246435 In-Reply-To: <8-p_hCyPWSKRK-sImmzwdXWZwuKm-YEZgVMOuqOzdNA=.290d5f0e-49b5-4ddd-b1ca-4de5521e2462@github.com> References: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> <8-p_hCyPWSKRK-sImmzwdXWZwuKm-YEZgVMOuqOzdNA=.290d5f0e-49b5-4ddd-b1ca-4de5521e2462@github.com> Message-ID: On Wed, 3 Jun 2020 14:31:39 GMT, Magnus Ihse Bursie wrote: >> json/src/main/java/org/openjdk/skara/json/JSONArray.java line 42: >> >>> 41: >>> 42: private void append(JSONValue value) { >>> 43: if (value instanceof JSONArray) { >> >> Could you rename this to `concat` and explicitly take a `JSONArray` instead as parameter? I'm fine with having >> `append`, but `append` should be just `append` (that is, append a single item to the array). > > To me there's no deeper semantic difference between "append" and "concat". To be precise, this method do a flattening > append/concat, and should probably be named something like addAndFlatten to be completely unambiguous. But that kind of > naming did not seem to fit in with the rest of the design here. If you insist that "concat" means "flatten while > adding" but "append" does not, sure, I can rename it. Ah, sorry, now I see what you mean. You want a concat(JSONArray a) instead. Well, it might be good to have, but that does not really solve my problem, does it? :-) ------------- PR: https://git.openjdk.java.net/skara/pull/636 From ihse at openjdk.java.net Wed Jun 3 14:36:47 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Wed, 3 Jun 2020 14:36:47 GMT Subject: RFR: json patches introduced to the OpenJDK copy in JDK-8246435 In-Reply-To: References: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> Message-ID: <8-p_hCyPWSKRK-sImmzwdXWZwuKm-YEZgVMOuqOzdNA=.290d5f0e-49b5-4ddd-b1ca-4de5521e2462@github.com> On Wed, 3 Jun 2020 12:42:45 GMT, Erik Helin wrote: >> This PR contains the proposed changes to the json system made in JDK-8246435. If the same changes are made in Skara, >> tthe two code bases are kept from diverging. > > json/src/main/java/org/openjdk/skara/json/JSONArray.java line 42: > >> 41: >> 42: private void append(JSONValue value) { >> 43: if (value instanceof JSONArray) { > > Could you rename this to `concat` and explicitly take a `JSONArray` instead as parameter? I'm fine with having > `append`, but `append` should be just `append` (that is, append a single item to the array). To me there's no deeper semantic difference between "append" and "concat". To be precise, this method do a flattening append/concat, and should probably be named something like addAndFlatten to be completely unambiguous. But that kind of naming did not seem to fit in with the rest of the design here. If you insist that "concat" means "flatten while adding" but "append" does not, sure, I can rename it. > json/src/main/java/org/openjdk/skara/json/JSONArray.java line 52: > >> 51: >> 52: public JSONArray(JSONValue value, JSONValue... values) { >> 53: this.values = new ArrayList(values.length + 1); > > Related to the comment about `concat` vs `append`, I would prefer that the constructor does `append` and not `concat`. > One could imagine a `static` version of `concat` as well, e.g. `public static JSONArray concat(JSONArray... arrays)`. I don't care about a non-flattening constructor. You can add one if you need one. But I can change it to a static factory method instead, if you want. It's probably clearer, given that we can agree on a suitable name. (I'll accept "concat" if you insist, but I'm not persuaded that it's really better...) ------------- PR: https://git.openjdk.java.net/skara/pull/636 From ehelin at openjdk.java.net Thu Jun 4 05:47:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 4 Jun 2020 05:47:17 GMT Subject: RFR: json patches introduced to the OpenJDK copy in JDK-8246435 In-Reply-To: References: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> <8-p_hCyPWSKRK-sImmzwdXWZwuKm-YEZgVMOuqOzdNA=.290d5f0e-49b5-4ddd-b1ca-4de5521e2462@github.com> Message-ID: On Wed, 3 Jun 2020 14:34:38 GMT, Magnus Ihse Bursie wrote: >> To me there's no deeper semantic difference between "append" and "concat". To be precise, this method do a flattening >> append/concat, and should probably be named something like addAndFlatten to be completely unambiguous. But that kind of >> naming did not seem to fit in with the rest of the design here. If you insist that "concat" means "flatten while >> adding" but "append" does not, sure, I can rename it. > > Ah, sorry, now I see what you mean. You want a concat(JSONArray a) instead. Well, it might be good to have, but that > does not really solve my problem, does it? :-) Well, if you have `append(JSONValue v)` and `concat(JSONArray a)` then code using such an API can easily have the code: void appendOrConcat(JSONArray a, JSONValue v) { if (v.isArray()) { a.concat(v.asArray()); } else { a.append(v); } } I'm fine with having `appendOrConcat` in `JSONArray` as well, but then I want it named `appendOrConcat`, not `append`. I agree that `append` is shorter, but it is too misleading of a name IMHO for a method that really does `appendOrConcat`. ------------- PR: https://git.openjdk.java.net/skara/pull/636 From ihse at openjdk.java.net Thu Jun 4 07:32:56 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 4 Jun 2020 07:32:56 GMT Subject: RFR: json patches introduced to the OpenJDK copy in JDK-8246435 In-Reply-To: References: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> <8-p_hCyPWSKRK-sImmzwdXWZwuKm-YEZgVMOuqOzdNA=.290d5f0e-49b5-4ddd-b1ca-4de5521e2462@github.com> Message-ID: On Thu, 4 Jun 2020 05:45:09 GMT, Erik Helin wrote: >> Ah, sorry, now I see what you mean. You want a concat(JSONArray a) instead. Well, it might be good to have, but that >> does not really solve my problem, does it? :-) > > Well, if you have `append(JSONValue v)` and `concat(JSONArray a)` then code using such an API can easily have the code: > > void appendOrConcat(JSONArray a, JSONValue v) { > if (v.isArray()) { > a.concat(v.asArray()); > } else { > a.append(v); > } > } > > I'm fine with having `appendOrConcat` in `JSONArray` as well, but then I want it named `appendOrConcat`, not `append`. > I agree that `append` is shorter, but it is too misleading of a name IMHO for a method that really does > `appendOrConcat`. I still don't get it. Your example code would not recursively inline arrays; it will only work for a single nested layer. I can't see how that would be helpful to anything but the most specific situations. What is it you want to achieve? ------------- PR: https://git.openjdk.java.net/skara/pull/636 From ehelin at openjdk.java.net Thu Jun 4 14:52:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 4 Jun 2020 14:52:05 GMT Subject: RFR: publish: add flag --follow Message-ID: Hi all, please review this patch that adds the `--follow` switch and the `--browser` flag to `git publish`. These flags can be used to automatically open a browser with the link that a remote host replies with in the response to the `git push --set-upstream` command that `git publish` runs. The effect is a "poor mans" `git pr create` for those that can't (or don't want) to have a personal access token on their machine. For example, running `git publish --follow --browser=firefox` will open the "Open a pull request" page in Firefox. Testing: - [x] Manual testing of `git publish --follow --browser=firefox` on Linux x64 Thanks, Erik ------------- Commit messages: - publish: add flag --follow Changes: https://git.openjdk.java.net/skara/pull/638/files Webrev: https://webrevs.openjdk.java.net/skara/638/webrev.00 Stats: 100 lines in 1 file changed: 78 ins; 1 del; 21 mod Patch: https://git.openjdk.java.net/skara/pull/638.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/638/head:pull/638 PR: https://git.openjdk.java.net/skara/pull/638 From ehelin at openjdk.java.net Thu Jun 4 16:14:47 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 4 Jun 2020 16:14:47 GMT Subject: RFR: forge: support commit comments Message-ID: Hi all, please review this patch that adds the possibility to add a comment on a particular commit to `HostedRepository` via the method `addCommitComment`. To start out with I've only added support for adding a general comment about a whole commit, not a comment for a particular line in a commit. The comments for a commit can also be listed with the method `commitComments`. Testing: - Not that much, later patches will build upon the APIs introduced in this patch Thanks, Erik ------------- Commit messages: - forge: support commit comments Changes: https://git.openjdk.java.net/skara/pull/639/files Webrev: https://webrevs.openjdk.java.net/skara/639/webrev.00 Stats: 218 lines in 7 files changed: 211 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/639.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/639/head:pull/639 PR: https://git.openjdk.java.net/skara/pull/639 From ehelin at openjdk.java.net Thu Jun 4 16:50:49 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 4 Jun 2020 16:50:49 GMT Subject: RFR: notify: rename PullRequestIssues to PullRequestState Message-ID: Hi all, please review this patch that just renames `PullRequestIssues` to `PullRequestState`. This patch is just a pure refactoring, future patches will add additional fields to `PullRequestState`. I also tried to update all variable and method names that referred to e.g. `prIssues`. Finally I made the class `PullRequestState` package-private. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - notify: rename PullRequestIssues to PullRequestState Changes: https://git.openjdk.java.net/skara/pull/640/files Webrev: https://webrevs.openjdk.java.net/skara/640/webrev.00 Stats: 215 lines in 10 files changed: 76 ins; 76 del; 63 mod Patch: https://git.openjdk.java.net/skara/pull/640.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/640/head:pull/640 PR: https://git.openjdk.java.net/skara/pull/640 From rwestberg at openjdk.java.net Fri Jun 5 08:31:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 5 Jun 2020 08:31:37 GMT Subject: RFR: publish: add flag --follow In-Reply-To: References: Message-ID: On Thu, 4 Jun 2020 14:45:42 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--follow` switch and the `--browser` flag to `git publish`. These flags can be > used to automatically open a browser with the link that a remote host replies with in the response to the `git > push --set-upstream` command that `git publish` runs. The effect is a "poor mans" `git pr create` for those that can't > (or don't want) to have a personal access token on their machine. For example, running `git > publish --follow --browser=firefox` will open the "Open a pull request" page in Firefox. Testing: > - [x] Manual testing of `git publish --follow --browser=firefox` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/638 From rwestberg at openjdk.java.net Fri Jun 5 08:37:48 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 5 Jun 2020 08:37:48 GMT Subject: RFR: forge: support commit comments In-Reply-To: References: Message-ID: On Thu, 4 Jun 2020 16:08:33 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the possibility to add a comment on a particular commit to `HostedRepository` via > the method `addCommitComment`. To start out with I've only added support for adding a general comment about a whole > commit, not a comment for a particular line in a commit. The comments for a commit can also be listed with the method > `commitComments`. > Testing: > - Not that much, later patches will build upon the APIs introduced in this patch > > Thanks, > Erik Looks good in general, just had a comment regarding simplifying the API slightly. forge/src/main/java/org/openjdk/skara/forge/CommitComment.java line 2: > 1: /* > 2: * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. > 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 2020! forge/src/main/java/org/openjdk/skara/forge/CommitComment.java line 65: > 64: */ > 65: public Optional position() { > 66: return position == -1 ? Optional.empty() : Optional.of(position); Perhaps drop this one? The other API's only expose a line number ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/639 From rwestberg at openjdk.java.net Fri Jun 5 08:39:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 5 Jun 2020 08:39:18 GMT Subject: RFR: notify: rename PullRequestIssues to PullRequestState In-Reply-To: References: Message-ID: <-gvu6eHI7QRb87a6Em7zySb2w5PQtUb7AFNVDqMbUrY=.a5da5ccf-ca78-470b-9523-6516b16901c0@github.com> On Thu, 4 Jun 2020 16:43:12 GMT, Erik Helin wrote: > Hi all, > > please review this patch that just renames `PullRequestIssues` to `PullRequestState`. This patch is just a pure > refactoring, future patches will add additional fields to `PullRequestState`. I also tried to update all variable and > method names that referred to e.g. `prIssues`. Finally I made the class `PullRequestState` package-private. Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/640 From ehelin at openjdk.java.net Fri Jun 5 08:45:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 08:45:17 GMT Subject: [Integrated] RFR: publish: add flag --follow In-Reply-To: References: Message-ID: On Thu, 4 Jun 2020 14:45:42 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--follow` switch and the `--browser` flag to `git publish`. These flags can be > used to automatically open a browser with the link that a remote host replies with in the response to the `git > push --set-upstream` command that `git publish` runs. The effect is a "poor mans" `git pr create` for those that can't > (or don't want) to have a personal access token on their machine. For example, running `git > publish --follow --browser=firefox` will open the "Open a pull request" page in Firefox. Testing: > - [x] Manual testing of `git publish --follow --browser=firefox` on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 68d3dd6e Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/68d3dd6e Stats: 100 lines in 1 file changed: 1 ins; 78 del; 21 mod publish: add flag --follow Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/638 From ehelin at openjdk.java.net Fri Jun 5 08:45:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 08:45:57 GMT Subject: [Integrated] RFR: notify: rename PullRequestIssues to PullRequestState In-Reply-To: References: Message-ID: On Thu, 4 Jun 2020 16:43:12 GMT, Erik Helin wrote: > Hi all, > > please review this patch that just renames `PullRequestIssues` to `PullRequestState`. This patch is just a pure > refactoring, future patches will add additional fields to `PullRequestState`. I also tried to update all variable and > method names that referred to e.g. `prIssues`. Finally I made the class `PullRequestState` package-private. Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 69b126b4 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/69b126b4 Stats: 215 lines in 10 files changed: 76 ins; 76 del; 63 mod notify: rename PullRequestIssues to PullRequestState Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/640 From ehelin at openjdk.java.net Fri Jun 5 11:50:58 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 11:50:58 GMT Subject: RFR: forge: support commit comments In-Reply-To: References: Message-ID: On Fri, 5 Jun 2020 08:30:08 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this patch that adds the possibility to add a comment on a particular commit to `HostedRepository` via >> the method `addCommitComment`. To start out with I've only added support for adding a general comment about a whole >> commit, not a comment for a particular line in a commit. The comments for a commit can also be listed with the method >> `commitComments`. >> Testing: >> - Not that much, later patches will build upon the APIs introduced in this patch >> >> Thanks, >> Erik > > forge/src/main/java/org/openjdk/skara/forge/CommitComment.java line 2: > >> 1: /* >> 2: * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. >> 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > 2020! Thanks, will fix! > forge/src/main/java/org/openjdk/skara/forge/CommitComment.java line 65: > >> 64: */ >> 65: public Optional position() { >> 66: return position == -1 ? Optional.empty() : Optional.of(position); > > Perhaps drop this one? The other API's only expose a line number Ok, yeah, sounds good ?? ------------- PR: https://git.openjdk.java.net/skara/pull/639 From ehelin at openjdk.java.net Fri Jun 5 12:10:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 12:10:37 GMT Subject: RFR: notify: store resulting commit in PullRequestState Message-ID: Hi all, please review this patch that the resulting (integrated) commit from a PR in the `PullRequestState`. This data will be used in future patches for more easier handling of notifications. Note that all data in the `Storage` might not have the `"commit"` field. If that is the case, then the code will lazily populate the `"commit"` field. Testing: - [x] `make test` on Linux x64 Thanks, Erik ------------- Commit messages: - notify: store resulting commit in PullRequestState Changes: https://git.openjdk.java.net/skara/pull/641/files Webrev: https://webrevs.openjdk.java.net/skara/641/webrev.00 Stats: 80 lines in 2 files changed: 57 ins; 0 del; 23 mod Patch: https://git.openjdk.java.net/skara/pull/641.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/641/head:pull/641 PR: https://git.openjdk.java.net/skara/pull/641 From ehelin at openjdk.java.net Fri Jun 5 12:31:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 12:31:57 GMT Subject: [Rev 01] RFR: forge: support commit comments In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that adds the possibility to add a comment on a particular commit to `HostedRepository` via > the method `addCommitComment`. To start out with I've only added support for adding a general comment about a whole > commit, not a comment for a particular line in a commit. The comments for a commit can also be listed with the method > `commitComments`. > Testing: > - Not that much, later patches will build upon the APIs introduced in this patch > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Remove position field ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/639/files - new: https://git.openjdk.java.net/skara/pull/639/files/b5a30420..284eb0a8 Webrevs: - full: https://webrevs.openjdk.java.net/skara/639/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/639/webrev.00-01 Stats: 19 lines in 4 files changed: 0 ins; 15 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/639.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/639/head:pull/639 PR: https://git.openjdk.java.net/skara/pull/639 From ehelin at openjdk.java.net Fri Jun 5 13:05:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 13:05:57 GMT Subject: [Integrated] RFR: forge: support commit comments In-Reply-To: References: Message-ID: On Thu, 4 Jun 2020 16:08:33 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the possibility to add a comment on a particular commit to `HostedRepository` via > the method `addCommitComment`. To start out with I've only added support for adding a general comment about a whole > commit, not a comment for a particular line in a commit. The comments for a commit can also be listed with the method > `commitComments`. > Testing: > - Not that much, later patches will build upon the APIs introduced in this patch > > Thanks, > Erik This pull request has now been integrated. Changeset: dd947454 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/dd947454 Stats: 203 lines in 7 files changed: 0 ins; 196 del; 7 mod forge: support commit comments Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/639 From ehelin at openjdk.java.net Fri Jun 5 13:23:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 13:23:19 GMT Subject: RFR: forge: add commitMetadata method to HostedRepository Message-ID: Hi all, please review this patch that adds the method `CommitMetadata HostedRepository.commitMetadata(Hash h)`. This is useful for getting the metadata for a commit from a `HostedRepository` instance without having to clone it first to a local repository. Testing: - [ ] not in this commit, will be part of follow-up patches Thanks, Erik ------------- Commit messages: - forge: add commitMetadata method to HostedRepository Changes: https://git.openjdk.java.net/skara/pull/642/files Webrev: https://webrevs.openjdk.java.net/skara/642/webrev.00 Stats: 66 lines in 6 files changed: 66 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/642.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/642/head:pull/642 PR: https://git.openjdk.java.net/skara/pull/642 From rwestberg at openjdk.java.net Fri Jun 5 13:50:08 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 5 Jun 2020 13:50:08 GMT Subject: RFR: notify: store resulting commit in PullRequestState In-Reply-To: References: Message-ID: <2uQQ5l9OcB69v8W30aHb_AbrzCdQ6a4ty6ZIfs0AWQI=.ccc00a9b-2179-4ac4-a42a-305572047325@github.com> On Fri, 5 Jun 2020 12:04:10 GMT, Erik Helin wrote: > Hi all, > > please review this patch that the resulting (integrated) commit from a PR in the `PullRequestState`. This data will be > used in future patches for more easier handling of notifications. Note that all data in the `Storage` might not have > the `"commit"` field. If that is the case, then the code will lazily populate the `"commit"` field. Testing: > - [x] `make test` on Linux x64 > > Thanks, > Erik Looks good, but may need to add an extra configuration field. bots/notify/src/main/java/org/openjdk/skara/bots/notify/PullRequestWorkItem.java line 179: > 178: var issues = parseIssues(); > 179: var commit = resultingCommitHashFor(pr, pr.repository().forge().currentUser()); > 180: var state = new PullRequestState(pr, issues, commit); The notifier bot may not be running with the same credentials as the commit bot, so this is possibly the wrong user to look for. The other bots (mlbridge, pr) takes a username from the configuration to use for matching comment poster ids. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/641 From rwestberg at openjdk.java.net Fri Jun 5 13:51:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 5 Jun 2020 13:51:27 GMT Subject: RFR: forge: add commitMetadata method to HostedRepository In-Reply-To: References: Message-ID: On Fri, 5 Jun 2020 13:16:46 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `CommitMetadata HostedRepository.commitMetadata(Hash h)`. This is useful > for getting the metadata for a commit from a `HostedRepository` instance without having to clone it first to a local > repository. Testing: > - [ ] not in this commit, will be part of follow-up patches > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/642 From ehelin at openjdk.java.net Fri Jun 5 14:49:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 5 Jun 2020 14:49:37 GMT Subject: [Integrated] RFR: forge: add commitMetadata method to HostedRepository In-Reply-To: References: Message-ID: <5tqSsNAGONLXsWxka8c77YEn9qwp8kEZqgPUBO8NWvg=.3897ff5d-6f8f-43c2-b3f2-36d058796188@github.com> On Fri, 5 Jun 2020 13:16:46 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `CommitMetadata HostedRepository.commitMetadata(Hash h)`. This is useful > for getting the metadata for a commit from a `HostedRepository` instance without having to clone it first to a local > repository. Testing: > - [ ] not in this commit, will be part of follow-up patches > > Thanks, > Erik This pull request has now been integrated. Changeset: c11028a0 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/c11028a0 Stats: 66 lines in 6 files changed: 0 ins; 66 del; 0 mod forge: add commitMetadata method to HostedRepository Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/642 From ehelin at openjdk.java.net Mon Jun 8 10:15:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 8 Jun 2020 10:15:03 GMT Subject: [Rev 01] RFR: notify: store resulting commit in PullRequestState In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that the resulting (integrated) commit from a PR in the `PullRequestState`. This data will be > used in future patches for more easier handling of notifications. Note that all data in the `Storage` might not have > the `"commit"` field. If that is the case, then the code will lazily populate the `"commit"` field. Testing: > - [x] `make test` on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Configure integrator id ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/641/files - new: https://git.openjdk.java.net/skara/pull/641/files/4f70c74e..95e3f668 Webrevs: - full: https://webrevs.openjdk.java.net/skara/641/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/641/webrev.00-01 Stats: 24 lines in 4 files changed: 16 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/641.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/641/head:pull/641 PR: https://git.openjdk.java.net/skara/pull/641 From ehelin at openjdk.java.net Mon Jun 8 10:17:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 8 Jun 2020 10:17:10 GMT Subject: [Integrated] RFR: notify: store resulting commit in PullRequestState In-Reply-To: References: Message-ID: On Fri, 5 Jun 2020 12:04:10 GMT, Erik Helin wrote: > Hi all, > > please review this patch that the resulting (integrated) commit from a PR in the `PullRequestState`. This data will be > used in future patches for more easier handling of notifications. Note that all data in the `Storage` might not have > the `"commit"` field. If that is the case, then the code will lazily populate the `"commit"` field. Testing: > - [x] `make test` on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 1d063900 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/1d063900 Stats: 100 lines in 5 files changed: 0 ins; 73 del; 27 mod notify: store resulting commit in PullRequestState Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/641 From ehelin at openjdk.java.net Mon Jun 8 14:14:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 8 Jun 2020 14:14:19 GMT Subject: RFR: notify: add handleIntegratedPullRequest callback Message-ID: Hi all, please review this patch that adds the `handleIntegratedPullRequest` callback to `PullRequestUpdateConsumer`. I have also updated `IssueUpdater` to make use of this new callback, as well as updated the unit tests for `IssueUpdater`. Testing: - [x] `make test` passes on Linux x64 - [x] Updated two unit tests Thanks, Erik ------------- Commit messages: - notify: add handleIntegratedPullRequest callback Changes: https://git.openjdk.java.net/skara/pull/643/files Webrev: https://webrevs.openjdk.java.net/skara/643/webrev.00 Stats: 70 lines in 5 files changed: 25 ins; 13 del; 32 mod Patch: https://git.openjdk.java.net/skara/pull/643.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/643/head:pull/643 PR: https://git.openjdk.java.net/skara/pull/643 From rwestberg at openjdk.java.net Mon Jun 8 14:14:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 8 Jun 2020 14:14:19 GMT Subject: RFR: notify: add handleIntegratedPullRequest callback In-Reply-To: References: Message-ID: On Mon, 8 Jun 2020 14:04:05 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `handleIntegratedPullRequest` callback to `PullRequestUpdateConsumer`. I have > also updated `IssueUpdater` to make use of this new callback, as well as updated the unit tests for `IssueUpdater`. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Updated two unit tests > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/643 From ehelin at openjdk.java.net Mon Jun 8 14:43:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 8 Jun 2020 14:43:28 GMT Subject: [Integrated] RFR: notify: add handleIntegratedPullRequest callback In-Reply-To: References: Message-ID: On Mon, 8 Jun 2020 14:04:05 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `handleIntegratedPullRequest` callback to `PullRequestUpdateConsumer`. I have > also updated `IssueUpdater` to make use of this new callback, as well as updated the unit tests for `IssueUpdater`. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Updated two unit tests > > Thanks, > Erik This pull request has now been integrated. Changeset: e601083c Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/e601083c Stats: 74 lines in 5 files changed: 17 ins; 29 del; 28 mod notify: add handleIntegratedPullRequest callback Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/643 From rwestberg at openjdk.java.net Tue Jun 9 14:43:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 9 Jun 2020 14:43:04 GMT Subject: RFR: 329: Add /cc command Message-ID: Hi all, Please review this change that introduces the `/label` (aliased as `/cc`) command to add or remove additional labels from a PR. The set of allowed labels are configured for each project. The command may be executed by the PR author as well as other project Committers and above. Best regards, Robin ------------- Commit messages: - Add label / cc command, introduce separate labeler configuration Changes: https://git.openjdk.java.net/skara/pull/645/files Webrev: https://webrevs.openjdk.java.net/skara/645/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-329 Stats: 619 lines in 10 files changed: 574 ins; 16 del; 29 mod Patch: https://git.openjdk.java.net/skara/pull/645.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/645/head:pull/645 PR: https://git.openjdk.java.net/skara/pull/645 From ehelin at openjdk.java.net Tue Jun 9 14:53:38 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 9 Jun 2020 14:53:38 GMT Subject: RFR: 329: Add /cc command In-Reply-To: References: Message-ID: On Tue, 9 Jun 2020 14:35:25 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces the `/label` (aliased as `/cc`) command to add or remove additional labels > from a PR. The set of allowed labels are configured for each project. The command may be executed by the PR author as > well as other project Committers and above. Best regards, > Robin Stellar work as always @rwestberg ? You thought about way more cases than I originally did, really nice work ?? ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/645 From rwestberg at openjdk.java.net Tue Jun 9 15:17:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 9 Jun 2020 15:17:57 GMT Subject: RFR: 329: Add /cc command In-Reply-To: References: Message-ID: On Tue, 9 Jun 2020 14:51:29 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this change that introduces the `/label` (aliased as `/cc`) command to add or remove additional labels >> from a PR. The set of allowed labels are configured for each project. The command may be executed by the PR author as >> well as other project Committers and above. Best regards, >> Robin > > Stellar work as always @rwestberg ? You thought about way more cases than I originally did, really nice work ?? Thanks for reviewing! ------------- PR: https://git.openjdk.java.net/skara/pull/645 From rwestberg at openjdk.java.net Tue Jun 9 15:22:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 9 Jun 2020 15:22:18 GMT Subject: [Integrated] RFR: 329: Add /cc command In-Reply-To: References: Message-ID: On Tue, 9 Jun 2020 14:35:25 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that introduces the `/label` (aliased as `/cc`) command to add or remove additional labels > from a PR. The set of allowed labels are configured for each project. The command may be executed by the PR author as > well as other project Committers and above. Best regards, > Robin This pull request has now been integrated. Changeset: 0878fd39 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/0878fd39 Stats: 619 lines in 10 files changed: 16 ins; 574 del; 29 mod 329: Add /cc command Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/645 From ehelin at openjdk.java.net Tue Jun 9 15:36:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 9 Jun 2020 15:36:27 GMT Subject: RFR: notify: rename MailingListUpdater to MailingListNotifier Message-ID: <_mPEFt7OQiRnAOqlRhRPmGouFnbDYKmz_qq5zBaRdaw=.ba74a614-be3a-45e4-a24c-2567eb8f9120@github.com> Hi all, please review this refactoring that renames `MailingListUpdater` to `MailingListNotifier`. More refactorings will follow after this one for the other notifiers. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - notify: rename MailingListUpdater to MailingListNotifier Changes: https://git.openjdk.java.net/skara/pull/646/files Webrev: https://webrevs.openjdk.java.net/skara/646/webrev.00 Stats: 3092 lines in 10 files changed: 1547 ins; 1544 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/646.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/646/head:pull/646 PR: https://git.openjdk.java.net/skara/pull/646 From rwestberg at openjdk.java.net Wed Jun 10 04:16:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 04:16:58 GMT Subject: RFR: notify: rename MailingListUpdater to MailingListNotifier In-Reply-To: <_mPEFt7OQiRnAOqlRhRPmGouFnbDYKmz_qq5zBaRdaw=.ba74a614-be3a-45e4-a24c-2567eb8f9120@github.com> References: <_mPEFt7OQiRnAOqlRhRPmGouFnbDYKmz_qq5zBaRdaw=.ba74a614-be3a-45e4-a24c-2567eb8f9120@github.com> Message-ID: On Tue, 9 Jun 2020 15:29:18 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that renames `MailingListUpdater` to `MailingListNotifier`. More refactorings will > follow after this one for the other notifiers. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/646 From ehelin at openjdk.java.net Wed Jun 10 07:37:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 07:37:37 GMT Subject: [Integrated] RFR: notify: rename MailingListUpdater to MailingListNotifier In-Reply-To: <_mPEFt7OQiRnAOqlRhRPmGouFnbDYKmz_qq5zBaRdaw=.ba74a614-be3a-45e4-a24c-2567eb8f9120@github.com> References: <_mPEFt7OQiRnAOqlRhRPmGouFnbDYKmz_qq5zBaRdaw=.ba74a614-be3a-45e4-a24c-2567eb8f9120@github.com> Message-ID: On Tue, 9 Jun 2020 15:29:18 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that renames `MailingListUpdater` to `MailingListNotifier`. More refactorings will > follow after this one for the other notifiers. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 99c40da7 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/99c40da7 Stats: 3092 lines in 10 files changed: 1544 ins; 1547 del; 1 mod notify: rename MailingListUpdater to MailingListNotifier Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/646 From rwestberg at openjdk.java.net Wed Jun 10 08:39:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 08:39:43 GMT Subject: RFR: Allow a WorkItem to return follow-up items Message-ID: Hi all, Please review this change that allows a WorkItem to return follow-up items to schedule after itself has run. Use this to run another CheckWorkItem after a CommandWorkItem successfully has executed commands. Best regards, Robin ------------- Commit messages: - Allow a WorkItem to return follow-up items that will be scheduled after the item has run Changes: https://git.openjdk.java.net/skara/pull/648/files Webrev: https://webrevs.openjdk.java.net/skara/648/webrev.00 Stats: 144 lines in 24 files changed: 72 ins; 21 del; 51 mod Patch: https://git.openjdk.java.net/skara/pull/648.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/648/head:pull/648 PR: https://git.openjdk.java.net/skara/pull/648 From ehelin at openjdk.java.net Wed Jun 10 08:39:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 08:39:50 GMT Subject: RFR: Allow a WorkItem to return follow-up items In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 08:32:09 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows a WorkItem to return follow-up items to schedule after itself has run. Use this > to run another CheckWorkItem after a CommandWorkItem successfully has executed commands. > Best regards, > Robin Looks good, just a minor comment on documentation! bot/src/main/java/org/openjdk/skara/bot/WorkItem.java line 38: > 37: * Execute the appropriate tasks with the provided scratch folder. > 38: * @param scratchPath > 39: */ Maybe want to update the doc? ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/648 From ehelin at openjdk.java.net Wed Jun 10 08:43:38 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 08:43:38 GMT Subject: FYI: notify: rename JsonUpdater to JsonNotifier Message-ID: <-GElpLTiMjJCe-oSbVvFtz4TRjHpnK1MMJU8EZIzLCw=.e0970d2a-f22a-4b7a-bfe3-3e3ec87c2c74@github.com> Hi all, please review this small refactoring that renames `JsonUpdater` to `JsonNotifier`. Testing: - `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - notify: rename JsonUpdater to JsonNotifier Changes: https://git.openjdk.java.net/skara/pull/647/files Webrev: https://webrevs.openjdk.java.net/skara/647/webrev.00 Stats: 810 lines in 10 files changed: 401 ins; 408 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/647.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/647/head:pull/647 PR: https://git.openjdk.java.net/skara/pull/647 From ehelin at openjdk.java.net Wed Jun 10 08:43:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 08:43:39 GMT Subject: [Integrated] FYI: notify: rename JsonUpdater to JsonNotifier In-Reply-To: <-GElpLTiMjJCe-oSbVvFtz4TRjHpnK1MMJU8EZIzLCw=.e0970d2a-f22a-4b7a-bfe3-3e3ec87c2c74@github.com> References: <-GElpLTiMjJCe-oSbVvFtz4TRjHpnK1MMJU8EZIzLCw=.e0970d2a-f22a-4b7a-bfe3-3e3ec87c2c74@github.com> Message-ID: On Wed, 10 Jun 2020 08:32:02 GMT, Erik Helin wrote: > Hi all, > > please review this small refactoring that renames `JsonUpdater` to `JsonNotifier`. > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: a0d76c5e Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/a0d76c5e Stats: 810 lines in 10 files changed: 408 ins; 401 del; 1 mod notify: rename JsonUpdater to JsonNotifier Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/647 From rwestberg at openjdk.java.net Wed Jun 10 08:43:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 08:43:38 GMT Subject: FYI: notify: rename JsonUpdater to JsonNotifier In-Reply-To: <-GElpLTiMjJCe-oSbVvFtz4TRjHpnK1MMJU8EZIzLCw=.e0970d2a-f22a-4b7a-bfe3-3e3ec87c2c74@github.com> References: <-GElpLTiMjJCe-oSbVvFtz4TRjHpnK1MMJU8EZIzLCw=.e0970d2a-f22a-4b7a-bfe3-3e3ec87c2c74@github.com> Message-ID: On Wed, 10 Jun 2020 08:32:02 GMT, Erik Helin wrote: > Hi all, > > please review this small refactoring that renames `JsonUpdater` to `JsonNotifier`. > > Testing: > - `make test` passes on Linux x64 > > Thanks, > Erik Looks good! We could also consider deleting this notifier as there are no consumers of the output, but it doesn't hurt anything either.. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/647 From rwestberg at openjdk.java.net Wed Jun 10 09:35:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 09:35:06 GMT Subject: [Rev 01] RFR: Allow a WorkItem to return follow-up items In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that allows a WorkItem to return follow-up items to schedule after itself has run. Use this > to run another CheckWorkItem after a CommandWorkItem successfully has executed commands. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Update documentation, fix test failure ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/648/files - new: https://git.openjdk.java.net/skara/pull/648/files/d76eda50..c4d427dd Webrevs: - full: https://webrevs.openjdk.java.net/skara/648/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/648/webrev.00-01 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/648.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/648/head:pull/648 PR: https://git.openjdk.java.net/skara/pull/648 From rwestberg at openjdk.java.net Wed Jun 10 09:52:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 09:52:58 GMT Subject: [Integrated] RFR: Allow a WorkItem to return follow-up items In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 08:32:09 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows a WorkItem to return follow-up items to schedule after itself has run. Use this > to run another CheckWorkItem after a CommandWorkItem successfully has executed commands. > Best regards, > Robin This pull request has now been integrated. Changeset: 2ff9a38c Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/2ff9a38c Stats: 150 lines in 25 files changed: 16 ins; 75 del; 59 mod Allow a WorkItem to return follow-up items Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/648 From ehelin at openjdk.java.net Wed Jun 10 10:06:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 10:06:52 GMT Subject: RFR: notify: rename SlackUpdater to SlackNotifier Message-ID: <6Ph9qhPT5ITmixDROgt2aFGX0GGTxZxqTUPgxQ9TtPc=.e9456c95-cc78-4bd5-a5c2-ab057a7a3cf0@github.com> Hi all, please review this refactoring that renames `SlackUpdater` to `SlackNotifier`. Testing: - [x] `make test` passes Thanks, Erik ------------- Commit messages: - notify: rename SlackUpdater to SlackNotifier Changes: https://git.openjdk.java.net/skara/pull/649/files Webrev: https://webrevs.openjdk.java.net/skara/649/webrev.00 Stats: 318 lines in 5 files changed: 158 ins; 159 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/649.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/649/head:pull/649 PR: https://git.openjdk.java.net/skara/pull/649 From rwestberg at openjdk.java.net Wed Jun 10 10:09:07 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 10:09:07 GMT Subject: RFR: notify: rename SlackUpdater to SlackNotifier In-Reply-To: <6Ph9qhPT5ITmixDROgt2aFGX0GGTxZxqTUPgxQ9TtPc=.e9456c95-cc78-4bd5-a5c2-ab057a7a3cf0@github.com> References: <6Ph9qhPT5ITmixDROgt2aFGX0GGTxZxqTUPgxQ9TtPc=.e9456c95-cc78-4bd5-a5c2-ab057a7a3cf0@github.com> Message-ID: On Wed, 10 Jun 2020 09:59:14 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that renames `SlackUpdater` to `SlackNotifier`. > > Testing: > - [x] `make test` passes > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/649 From ehelin at openjdk.java.net Wed Jun 10 12:26:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 12:26:27 GMT Subject: [Integrated] RFR: notify: rename SlackUpdater to SlackNotifier In-Reply-To: <6Ph9qhPT5ITmixDROgt2aFGX0GGTxZxqTUPgxQ9TtPc=.e9456c95-cc78-4bd5-a5c2-ab057a7a3cf0@github.com> References: <6Ph9qhPT5ITmixDROgt2aFGX0GGTxZxqTUPgxQ9TtPc=.e9456c95-cc78-4bd5-a5c2-ab057a7a3cf0@github.com> Message-ID: <-KRzmi_mNzrUPfYZW0_jKt9POn34Mb1QqMQRH_DuKUA=.047a3e69-d074-464a-b9cd-0029dc6234ab@github.com> On Wed, 10 Jun 2020 09:59:14 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that renames `SlackUpdater` to `SlackNotifier`. > > Testing: > - [x] `make test` passes > > Thanks, > Erik This pull request has now been integrated. Changeset: d88ec4d7 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/d88ec4d7 Stats: 318 lines in 5 files changed: 159 ins; 158 del; 1 mod notify: rename SlackUpdater to SlackNotifier Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/649 From rwestberg at openjdk.java.net Wed Jun 10 13:43:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 13:43:23 GMT Subject: RFR: notify: rename IssueUpdater to IssueNotifier In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 13:33:40 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that renames `IssueUpdater` to `IssueNotifier`. > > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good, I'd say! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/650 From ehelin at openjdk.java.net Wed Jun 10 13:43:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 13:43:23 GMT Subject: RFR: notify: rename IssueUpdater to IssueNotifier Message-ID: Hi all, please review this refactoring that renames `IssueUpdater` to `IssueNotifier`. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - notify: rename IssueUpdater to IssueNotifier Changes: https://git.openjdk.java.net/skara/pull/650/files Webrev: https://webrevs.openjdk.java.net/skara/650/webrev.00 Stats: 1194 lines in 10 files changed: 597 ins; 596 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/650.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/650/head:pull/650 PR: https://git.openjdk.java.net/skara/pull/650 From ehelin at openjdk.java.net Wed Jun 10 13:45:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 13:45:27 GMT Subject: [Integrated] RFR: notify: rename IssueUpdater to IssueNotifier In-Reply-To: References: Message-ID: <2AsTgONfjWgvY4ZvRE2bZ_LxOU6ehwRQ7rU3JFVEzKA=.ef541939-a8ce-4e55-9f7e-965ab6bcebad@github.com> On Wed, 10 Jun 2020 13:33:40 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that renames `IssueUpdater` to `IssueNotifier`. > > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 6f35af38 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/6f35af38 Stats: 1194 lines in 10 files changed: 596 ins; 597 del; 1 mod notify: rename IssueUpdater to IssueNotifier Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/650 From ehelin at openjdk.java.net Wed Jun 10 14:06:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 14:06:39 GMT Subject: RFR: notify: use "listener" instead of "consumer"/"updater" in names Message-ID: Hi all, please review this refactoring of the notifier bot that uses the terminology "listener" instead of "consumer"/"updater". I also refactored how listeners are added to the `NotifierBot` (which now implements the `Emitter` interface). Testing: - [x] `make test` on Linux x64 Thanks, Erik ------------- Commit messages: - notify: use "listener" instead of "consumer"/"updater" in names Changes: https://git.openjdk.java.net/skara/pull/651/files Webrev: https://webrevs.openjdk.java.net/skara/651/webrev.00 Stats: 622 lines in 19 files changed: 302 ins; 254 del; 66 mod Patch: https://git.openjdk.java.net/skara/pull/651.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/651/head:pull/651 PR: https://git.openjdk.java.net/skara/pull/651 From rwestberg at openjdk.java.net Wed Jun 10 14:25:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 14:25:57 GMT Subject: RFR: notify: use "listener" instead of "consumer"/"updater" in names In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 13:59:34 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring of the notifier bot that uses the terminology "listener" instead of > "consumer"/"updater". I also refactored how listeners are added to the `NotifierBot` (which now implements the > `Emitter` interface). Testing: > - [x] `make test` on Linux x64 > > Thanks, > Erik Looks great! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/651 From ehelin at openjdk.java.net Wed Jun 10 14:32:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 14:32:27 GMT Subject: [Integrated] RFR: notify: use "listener" instead of "consumer"/"updater" in names In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 13:59:34 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring of the notifier bot that uses the terminology "listener" instead of > "consumer"/"updater". I also refactored how listeners are added to the `NotifierBot` (which now implements the > `Emitter` interface). Testing: > - [x] `make test` on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: c0203e02 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/c0203e02 Stats: 614 lines in 19 files changed: 246 ins; 294 del; 74 mod notify: use "listener" instead of "consumer"/"updater" in names Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/651 From ehelin at openjdk.java.net Wed Jun 10 14:55:30 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 14:55:30 GMT Subject: RFR: notify: create test utils Message-ID: Hi all, please review this patch that moves some static utility functions out from a unit test and into a proper `TestUtils` class. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - notify: create test utils Changes: https://git.openjdk.java.net/skara/pull/652/files Webrev: https://webrevs.openjdk.java.net/skara/652/webrev.00 Stats: 63 lines in 5 files changed: 44 ins; 15 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/652.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/652/head:pull/652 PR: https://git.openjdk.java.net/skara/pull/652 From rwestberg at openjdk.java.net Wed Jun 10 15:14:48 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 15:14:48 GMT Subject: RFR: notify: create test utils In-Reply-To: References: Message-ID: <3aMlxKSY1RAUYEQYa1OlB6qfXclc1avbOsMhJduZ5tc=.d6f5d308-d86b-456d-97fa-ef44c93bad30@github.com> On Wed, 10 Jun 2020 14:48:14 GMT, Erik Helin wrote: > Hi all, > > please review this patch that moves some static utility functions out from a unit test and into a proper `TestUtils` > class. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks fine! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/652 From ehelin at openjdk.java.net Wed Jun 10 15:16:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 15:16:57 GMT Subject: [Integrated] RFR: notify: create test utils In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 14:48:14 GMT, Erik Helin wrote: > Hi all, > > please review this patch that moves some static utility functions out from a unit test and into a proper `TestUtils` > class. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 66b93ca1 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/66b93ca1 Stats: 63 lines in 5 files changed: 15 ins; 44 del; 4 mod notify: create test utils Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/652 From ehelin at openjdk.java.net Wed Jun 10 15:29:30 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 15:29:30 GMT Subject: RFR: notify: prefix event handlers with "on*" Message-ID: Hi all, please review this refactoring that prefix the event handles in the notify bot with `on` instead of `handle` (I also renamed some handlers for consistency). Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - notify: prefix event handlers with "on*" Changes: https://git.openjdk.java.net/skara/pull/653/files Webrev: https://webrevs.openjdk.java.net/skara/653/webrev.00 Stats: 35 lines in 9 files changed: 0 ins; 0 del; 35 mod Patch: https://git.openjdk.java.net/skara/pull/653.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/653/head:pull/653 PR: https://git.openjdk.java.net/skara/pull/653 From rwestberg at openjdk.java.net Wed Jun 10 15:54:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 10 Jun 2020 15:54:37 GMT Subject: RFR: notify: prefix event handlers with "on*" In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 15:22:29 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that prefix the event handles in the notify bot with `on` instead of `handle` (I also > renamed some handlers for consistency). > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks nice! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/653 From ehelin at openjdk.java.net Wed Jun 10 16:04:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 16:04:17 GMT Subject: [Integrated] RFR: notify: prefix event handlers with "on*" In-Reply-To: References: Message-ID: On Wed, 10 Jun 2020 15:22:29 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that prefix the event handles in the notify bot with `on` instead of `handle` (I also > renamed some handlers for consistency). > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 88adf506 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/88adf506 Stats: 35 lines in 9 files changed: 0 ins; 0 del; 35 mod notify: prefix event handlers with "on*" Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/653 From ehelin at openjdk.java.net Wed Jun 10 16:28:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 10 Jun 2020 16:28:43 GMT Subject: RFR: notifier: add commit comment notifier Message-ID: Hi all, please review this patch that adds a new notifier - the commit comment notifier. The notifier is simple, it will add a comment to a pushed commit with links to the pull request and to fixed issues. This allows people to browse the history online and use the links in the comment to directly go to the review and/or issues (this already possible via CLI with the `git info` command). Testing: - [x] Added two new unit tests - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - notifier: add commit comment notifier Changes: https://git.openjdk.java.net/skara/pull/644/files Webrev: https://webrevs.openjdk.java.net/skara/644/webrev.00 Stats: 297 lines in 5 files changed: 296 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/644.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/644/head:pull/644 PR: https://git.openjdk.java.net/skara/pull/644 From rwestberg at openjdk.java.net Thu Jun 11 04:16:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 11 Jun 2020 04:16:17 GMT Subject: RFR: notifier: add commit comment notifier In-Reply-To: References: Message-ID: On Mon, 8 Jun 2020 15:34:16 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a new notifier - the commit comment notifier. The notifier is simple, it will add a > comment to a pushed commit with links to the pull request and to fixed issues. This allows people to browse the history > online and use the links in the comment to directly go to the review and/or issues (this already possible via CLI with > the `git info` command). Testing: > - [x] Added two new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/644 From ehelin at openjdk.java.net Thu Jun 11 04:40:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 11 Jun 2020 04:40:37 GMT Subject: [Integrated] RFR: notifier: add commit comment notifier In-Reply-To: References: Message-ID: On Mon, 8 Jun 2020 15:34:16 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a new notifier - the commit comment notifier. The notifier is simple, it will add a > comment to a pushed commit with links to the pull request and to fixed issues. This allows people to browse the history > online and use the links in the comment to directly go to the review and/or issues (this already possible via CLI with > the `git info` command). Testing: > - [x] Added two new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 08c02734 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/08c02734 Stats: 297 lines in 5 files changed: 0 ins; 296 del; 1 mod notifier: add commit comment notifier Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/644 From rwestberg at openjdk.java.net Thu Jun 11 10:21:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 11 Jun 2020 10:21:14 GMT Subject: FYI: 98: Testing of bot configuration parsing Message-ID: Hi all, Please review this change that contains the first step towards testing bot configuration parsing. Best regards, Robin ------------- Commit messages: - Initial implementation of configuration based test bot instantiation Changes: https://git.openjdk.java.net/skara/pull/654/files Webrev: https://webrevs.openjdk.java.net/skara/654/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-98 Stats: 159 lines in 1 file changed: 159 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/654.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/654/head:pull/654 PR: https://git.openjdk.java.net/skara/pull/654 From ehelin at openjdk.java.net Thu Jun 11 10:21:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 11 Jun 2020 10:21:14 GMT Subject: FYI: 98: Testing of bot configuration parsing In-Reply-To: References: Message-ID: On Thu, 11 Jun 2020 05:04:41 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that contains the first step towards testing bot configuration parsing. > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/654 From rwestberg at openjdk.java.net Thu Jun 11 10:21:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 11 Jun 2020 10:21:15 GMT Subject: [Integrated] FYI: 98: Testing of bot configuration parsing In-Reply-To: References: Message-ID: On Thu, 11 Jun 2020 05:04:41 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that contains the first step towards testing bot configuration parsing. > > Best regards, > Robin This pull request has now been integrated. Changeset: 1b654add Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/1b654add Stats: 159 lines in 1 file changed: 0 ins; 159 del; 0 mod 98: Testing of bot configuration parsing Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/654 From rwestberg at openjdk.java.net Thu Jun 11 10:38:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 11 Jun 2020 10:38:15 GMT Subject: FYI: publish: only exit on error In-Reply-To: References: Message-ID: On Thu, 11 Jun 2020 10:29:58 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that ensures that `GitPublish.main` only calls `System.exit` on error. This is needed > because `GitPrCreate.main` calls `GitPublish.main`, so `GitPublish.main` cannot unconditionally call `System.exit`. > Testing: > - [x] Manual testing of `git publish` > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/655 From ehelin at openjdk.java.net Thu Jun 11 10:38:15 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 11 Jun 2020 10:38:15 GMT Subject: FYI: publish: only exit on error Message-ID: Hi all, please review this small patch that ensures that `GitPublish.main` only calls `System.exit` on error. This is needed because `GitPrCreate.main` calls `GitPublish.main`, so `GitPublish.main` cannot unconditionally call `System.exit`. Testing: - [x] Manual testing of `git publish` Thanks, Erik ------------- Commit messages: - publish: only exit on error Changes: https://git.openjdk.java.net/skara/pull/655/files Webrev: https://webrevs.openjdk.java.net/skara/655/webrev.00 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/655.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/655/head:pull/655 PR: https://git.openjdk.java.net/skara/pull/655 From ehelin at openjdk.java.net Thu Jun 11 10:38:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 11 Jun 2020 10:38:16 GMT Subject: [Integrated] FYI: publish: only exit on error In-Reply-To: References: Message-ID: On Thu, 11 Jun 2020 10:29:58 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that ensures that `GitPublish.main` only calls `System.exit` on error. This is needed > because `GitPrCreate.main` calls `GitPublish.main`, so `GitPublish.main` cannot unconditionally call `System.exit`. > Testing: > - [x] Manual testing of `git publish` > > Thanks, > Erik This pull request has now been integrated. Changeset: e4fbefae Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/e4fbefae Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod publish: only exit on error Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/655 From ehelin at openjdk.java.net Thu Jun 11 16:13:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 11 Jun 2020 16:13:02 GMT Subject: RFR: storage: cache deserialized values in FileStorage Message-ID: Hi all, please review this patch that adds caching of the deserialized value to `FileStorage`. There is no point in deserializing the same `String` over and over again, the deserialized value will remain the same. Testing: - [x] Added a new unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - storage: cache deserialized values in FileStorage Changes: https://git.openjdk.java.net/skara/pull/656/files Webrev: https://webrevs.openjdk.java.net/skara/656/webrev.00 Stats: 54 lines in 2 files changed: 53 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/656.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/656/head:pull/656 PR: https://git.openjdk.java.net/skara/pull/656 From rwestberg at openjdk.java.net Fri Jun 12 06:58:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 06:58:46 GMT Subject: RFR: storage: cache deserialized values in FileStorage In-Reply-To: References: Message-ID: On Thu, 11 Jun 2020 16:03:15 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds caching of the deserialized value to `FileStorage`. There is no point in > deserializing the same `String` over and over again, the deserialized value will remain the same. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/656 From rwestberg at openjdk.java.net Fri Jun 12 07:21:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 07:21:43 GMT Subject: RFR: Upgrade the notifier database lazily Message-ID: Hi all, Please review this change that updates the notifier database for pull requests only for active PRs. Best regards, Robin ------------- Commit messages: - Upgrade the notifier database lazily Changes: https://git.openjdk.java.net/skara/pull/657/files Webrev: https://webrevs.openjdk.java.net/skara/657/webrev.00 Stats: 24 lines in 1 file changed: 11 ins; 7 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/657.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/657/head:pull/657 PR: https://git.openjdk.java.net/skara/pull/657 From ehelin at openjdk.java.net Fri Jun 12 08:08:36 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 08:08:36 GMT Subject: [Integrated] RFR: storage: cache deserialized values in FileStorage In-Reply-To: References: Message-ID: On Thu, 11 Jun 2020 16:03:15 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds caching of the deserialized value to `FileStorage`. There is no point in > deserializing the same `String` over and over again, the deserialized value will remain the same. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 74c4eda7 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/74c4eda7 Stats: 54 lines in 2 files changed: 0 ins; 53 del; 1 mod storage: cache deserialized values in FileStorage Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/656 From rwestberg at openjdk.java.net Fri Jun 12 08:58:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 08:58:31 GMT Subject: [Integrated] RFR: Upgrade the notifier database lazily In-Reply-To: References: Message-ID: On Fri, 12 Jun 2020 07:14:35 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that updates the notifier database for pull requests only for active PRs. > > Best regards, > Robin This pull request has now been integrated. Changeset: 646926f7 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/646926f7 Stats: 25 lines in 1 file changed: 7 ins; 12 del; 6 mod Upgrade the notifier database lazily Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/657 From rwestberg at openjdk.java.net Fri Jun 12 08:58:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 08:58:25 GMT Subject: [Rev 01] RFR: Upgrade the notifier database lazily In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that updates the notifier database for pull requests only for active PRs. > > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Updated schema migration logic ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/657/files - new: https://git.openjdk.java.net/skara/pull/657/files/203cdbe3..c939a1bf Webrevs: - full: https://webrevs.openjdk.java.net/skara/657/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/657/webrev.00-01 Stats: 7 lines in 1 file changed: 1 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/657.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/657/head:pull/657 PR: https://git.openjdk.java.net/skara/pull/657 From ehelin at openjdk.java.net Fri Jun 12 08:58:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 08:58:31 GMT Subject: [Rev 01] RFR: Upgrade the notifier database lazily In-Reply-To: References: Message-ID: On Fri, 12 Jun 2020 08:58:25 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that updates the notifier database for pull requests only for active PRs. >> >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Updated schema migration logic Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/657 From ehelin at openjdk.java.net Fri Jun 12 10:02:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 10:02:33 GMT Subject: RFR: 10: Update git-skara update to show changes Message-ID: Hi all, please review this small patch that makes `git skara update` show the titles of the changes that it fetched. Testing: - [x] Manual testing of `git skara update` on Linux x64 Thanks, Erik ------------- Commit messages: - skara-10 Changes: https://git.openjdk.java.net/skara/pull/658/files Webrev: https://webrevs.openjdk.java.net/skara/658/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-10 Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/658.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/658/head:pull/658 PR: https://git.openjdk.java.net/skara/pull/658 From rwestberg at openjdk.java.net Fri Jun 12 10:25:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 10:25:12 GMT Subject: RFR: 10: Update git-skara update to show changes In-Reply-To: References: Message-ID: <7AcGXRdyMG9fuwBcIncQk37XIkD_QG1tXn5ZTMXSl2g=.be81033b-4ab5-48e1-8f5e-2c718f2522cd@github.com> On Fri, 12 Jun 2020 09:54:17 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git skara update` show the titles of the changes that it fetched. > > Testing: > - [x] Manual testing of `git skara update` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/658 From ehelin at openjdk.java.net Fri Jun 12 10:25:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 10:25:12 GMT Subject: RFR: 10: Update git-skara update to show changes In-Reply-To: References: Message-ID: On Fri, 12 Jun 2020 09:54:17 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git skara update` show the titles of the changes that it fetched. > > Testing: > - [x] Manual testing of `git skara update` on Linux x64 > > Thanks, > Erik Thanks for reviewing @rwestberg! This pull request has now been integrated. Changeset: 96088f46 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/96088f46 Stats: 9 lines in 1 file changed: 0 ins; 6 del; 3 mod 10: Update git-skara update to show changes Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/658 From rwestberg at openjdk.java.net Fri Jun 12 11:50:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 11:50:58 GMT Subject: RFR: Ensure that the notifier looks at both open and closed PRs Message-ID: Hi all, Please review this small change that ensures that the notifier looks at both open and closed PRs, similar to how the mailing list bridge works. Best regards, Robin ------------- Commit messages: - Ensure that the notifier looks at both open and closed PRs Changes: https://git.openjdk.java.net/skara/pull/659/files Webrev: https://webrevs.openjdk.java.net/skara/659/webrev.00 Stats: 18 lines in 2 files changed: 16 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/659.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/659/head:pull/659 PR: https://git.openjdk.java.net/skara/pull/659 From ehelin at openjdk.java.net Fri Jun 12 12:23:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 12:23:42 GMT Subject: RFR: Ensure that the notifier looks at both open and closed PRs In-Reply-To: References: Message-ID: On Fri, 12 Jun 2020 11:43:15 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that ensures that the notifier looks at both open and closed PRs, similar to how the > mailing list bridge works. > Best regards, > Robin Seems reasonable ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/659 From rwestberg at openjdk.java.net Fri Jun 12 13:49:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 13:49:18 GMT Subject: [Integrated] FYI: Update the isReady condition for the notifier In-Reply-To: References: Message-ID: On Fri, 12 Jun 2020 13:34:13 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that updates the isReady condition for the notifier. Instead of having this as a configurable > option, just use the well-known values. > Best regards, > Robin This pull request has now been integrated. Changeset: afa5d0af Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/afa5d0af Stats: 24 lines in 4 files changed: 16 ins; 1 del; 7 mod Update the isReady condition for the notifier Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/660 From rwestberg at openjdk.java.net Fri Jun 12 12:23:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 12:23:42 GMT Subject: [Integrated] RFR: Ensure that the notifier looks at both open and closed PRs In-Reply-To: References: Message-ID: On Fri, 12 Jun 2020 11:43:15 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that ensures that the notifier looks at both open and closed PRs, similar to how the > mailing list bridge works. > Best regards, > Robin This pull request has now been integrated. Changeset: b6390d82 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/b6390d82 Stats: 18 lines in 2 files changed: 1 ins; 16 del; 1 mod Ensure that the notifier looks at both open and closed PRs Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/659 From ehelin at openjdk.java.net Fri Jun 12 14:19:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 14:19:25 GMT Subject: RFR: forge: use commit object in GitHubRepository.commitMetadata Message-ID: <0eVhoq8AH5goH1jPslAJ0onT4HF1sRSQKFLVNyfWPok=.1754798c-e7a8-473c-92dc-ee9500dd2fcd@github.com> Hi all, please review this patch that properly parses the JSON reply from the `/commits` endpoint on GitHub. Testing: - [ ] None, but this time I'm sure I got it right ?? Thanks, Erik ------------- Commit messages: - forge: use commit object in GitHubRepository.commitMetadata Changes: https://git.openjdk.java.net/skara/pull/661/files Webrev: https://webrevs.openjdk.java.net/skara/661/webrev.00 Stats: 10 lines in 1 file changed: 1 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/661.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/661/head:pull/661 PR: https://git.openjdk.java.net/skara/pull/661 From ehelin at openjdk.java.net Fri Jun 12 13:49:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 13:49:17 GMT Subject: FYI: Update the isReady condition for the notifier In-Reply-To: References: Message-ID: <7orOwEJ91uFgXiNOxpdfDtkv_ptxwTArxtX9QpoR28s=.46b155f1-0f77-4ee0-8335-4f853f7003f7@github.com> On Fri, 12 Jun 2020 13:34:13 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that updates the isReady condition for the notifier. Instead of having this as a configurable > option, just use the well-known values. > Best regards, > Robin Looks good! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBot.java line 69: > 68: > 69: private boolean isReady(PullRequest pr) { > 70: var labels = new HashSet<>(pr.labels()); Perhaps rename `isOfInterest`? ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/660 From rwestberg at openjdk.java.net Fri Jun 12 13:49:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 13:49:18 GMT Subject: FYI: Update the isReady condition for the notifier In-Reply-To: <7orOwEJ91uFgXiNOxpdfDtkv_ptxwTArxtX9QpoR28s=.46b155f1-0f77-4ee0-8335-4f853f7003f7@github.com> References: <7orOwEJ91uFgXiNOxpdfDtkv_ptxwTArxtX9QpoR28s=.46b155f1-0f77-4ee0-8335-4f853f7003f7@github.com> Message-ID: <-PtzG908p9sSxcEJwsAuZEzqqmhz_tYQ8zP-7zjSylc=.71f7c59e-7514-48e0-853d-de8a96159468@github.com> On Fri, 12 Jun 2020 13:35:46 GMT, Erik Helin wrote: >> Hi all, >> >> Please review this change that updates the isReady condition for the notifier. Instead of having this as a configurable >> option, just use the well-known values. >> Best regards, >> Robin > > bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBot.java line 69: > >> 68: >> 69: private boolean isReady(PullRequest pr) { >> 70: var labels = new HashSet<>(pr.labels()); > > Perhaps rename `isOfInterest`? Sure, sounds reasonable ------------- PR: https://git.openjdk.java.net/skara/pull/660 From rwestberg at openjdk.java.net Fri Jun 12 15:24:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 15:24:58 GMT Subject: RFR: forge: use commit object in GitHubRepository.commitMetadata In-Reply-To: <0eVhoq8AH5goH1jPslAJ0onT4HF1sRSQKFLVNyfWPok=.1754798c-e7a8-473c-92dc-ee9500dd2fcd@github.com> References: <0eVhoq8AH5goH1jPslAJ0onT4HF1sRSQKFLVNyfWPok=.1754798c-e7a8-473c-92dc-ee9500dd2fcd@github.com> Message-ID: <8XNumPmSU0-UO68c0QZ04tE8dEZIvGB4tiEqGhie1QI=.843b199c-2cd2-435f-8e05-4e0a2ebd00f1@github.com> On Fri, 12 Jun 2020 14:11:53 GMT, Erik Helin wrote: > Hi all, > > please review this patch that properly parses the JSON reply from the `/commits` endpoint on GitHub. > > Testing: > - [ ] None, but this time I'm sure I got it right ?? > > Thanks, > Erik Must surely work! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/661 From ehelin at openjdk.java.net Fri Jun 12 15:28:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 12 Jun 2020 15:28:16 GMT Subject: [Integrated] RFR: forge: use commit object in GitHubRepository.commitMetadata In-Reply-To: <0eVhoq8AH5goH1jPslAJ0onT4HF1sRSQKFLVNyfWPok=.1754798c-e7a8-473c-92dc-ee9500dd2fcd@github.com> References: <0eVhoq8AH5goH1jPslAJ0onT4HF1sRSQKFLVNyfWPok=.1754798c-e7a8-473c-92dc-ee9500dd2fcd@github.com> Message-ID: On Fri, 12 Jun 2020 14:11:53 GMT, Erik Helin wrote: > Hi all, > > please review this patch that properly parses the JSON reply from the `/commits` endpoint on GitHub. > > Testing: > - [ ] None, but this time I'm sure I got it right ?? > > Thanks, > Erik This pull request has now been integrated. Changeset: f89126d5 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/f89126d5 Stats: 10 lines in 1 file changed: 0 ins; 1 del; 9 mod forge: use commit object in GitHubRepository.commitMetadata Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/661 From rwestberg at openjdk.java.net Fri Jun 12 13:49:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 12 Jun 2020 13:49:17 GMT Subject: FYI: Update the isReady condition for the notifier Message-ID: Hi all, Please review this change that updates the isReady condition for the notifier. Instead of having this as a configurable option, just use the well-known values. Best regards, Robin ------------- Commit messages: - Updated after review comments - Update the isReady condition for the notifier Changes: https://git.openjdk.java.net/skara/pull/660/files Webrev: https://webrevs.openjdk.java.net/skara/660/webrev.00 Stats: 24 lines in 4 files changed: 1 ins; 16 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/660.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/660/head:pull/660 PR: https://git.openjdk.java.net/skara/pull/660 From rwestberg at openjdk.java.net Mon Jun 15 11:46:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 15 Jun 2020 11:46:17 GMT Subject: RFR: 410: Update mailing list bridge subject decorations Message-ID: Hi all, Please review this change that updates the subject decorations done by the mailing list bridge bot to reflect the latest consensus. Best regards, Robin ------------- Commit messages: - Updated after latest list discussion Changes: https://git.openjdk.java.net/skara/pull/662/files Webrev: https://webrevs.openjdk.java.net/skara/662/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-410 Stats: 21 lines in 3 files changed: 1 ins; 0 del; 20 mod Patch: https://git.openjdk.java.net/skara/pull/662.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/662/head:pull/662 PR: https://git.openjdk.java.net/skara/pull/662 From ehelin at openjdk.java.net Mon Jun 15 12:28:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 15 Jun 2020 12:28:14 GMT Subject: RFR: 410: Update mailing list bridge subject decorations In-Reply-To: References: Message-ID: <26_sPeOn8SFNq-hfskyRaiuC0eILJrgmw37jgGMtS0M=.db3c7392-f37b-46f2-82b9-3d2715f2bc43@github.com> On Mon, 15 Jun 2020 11:37:59 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that updates the subject decorations done by the mailing list bridge bot to reflect the > latest consensus. > Best regards, > Robin Looks good ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/662 From rwestberg at openjdk.java.net Mon Jun 15 12:28:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 15 Jun 2020 12:28:14 GMT Subject: [Integrated] RFR: 410: Update mailing list bridge subject decorations In-Reply-To: References: Message-ID: On Mon, 15 Jun 2020 11:37:59 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that updates the subject decorations done by the mailing list bridge bot to reflect the > latest consensus. > Best regards, > Robin This pull request has now been integrated. Changeset: ed7df803 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/ed7df803 Stats: 21 lines in 3 files changed: 0 ins; 1 del; 20 mod 410: Update mailing list bridge subject decorations Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/662 From rwestberg at openjdk.java.net Mon Jun 15 12:59:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 15 Jun 2020 12:59:55 GMT Subject: Integrated: Make the new commit comment notifier discoverable In-Reply-To: References: Message-ID: On Mon, 15 Jun 2020 12:45:47 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that ensures that the new commit comment notifier is visible. > > Best regards, > Robin This pull request has now been integrated. Changeset: f92cfb52 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/f92cfb52 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Make the new commit comment notifier discoverable Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/663 From ehelin at openjdk.java.net Mon Jun 15 12:59:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 15 Jun 2020 12:59:55 GMT Subject: Integrated: Make the new commit comment notifier discoverable In-Reply-To: References: Message-ID: On Mon, 15 Jun 2020 12:45:47 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that ensures that the new commit comment notifier is visible. > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/663 From rwestberg at openjdk.java.net Mon Jun 15 12:59:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 15 Jun 2020 12:59:55 GMT Subject: Integrated: Make the new commit comment notifier discoverable Message-ID: Hi all, Please review this small change that ensures that the new commit comment notifier is visible. Best regards, Robin ------------- Commit messages: - Make the new notifier discoverable Changes: https://git.openjdk.java.net/skara/pull/663/files Webrev: https://webrevs.openjdk.java.net/skara/663/webrev.00 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/663.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/663/head:pull/663 PR: https://git.openjdk.java.net/skara/pull/663 From ehelin at openjdk.java.net Mon Jun 15 13:09:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 15 Jun 2020 13:09:29 GMT Subject: RFR: 416: Expose committer date in CommitMetadata Message-ID: Hi all, please review this patch that removes the `date()` method in `CommitMetadata` and adds `authored()` and `committed()`. For Mercurial commits `authored()` will equal `committed()` since Mercurial does not support different author and committer dates. Testing: - [x] `make test` passes on Linux x64 - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - skara-416 Changes: https://git.openjdk.java.net/skara/pull/664/files Webrev: https://webrevs.openjdk.java.net/skara/664/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-416 Stats: 110 lines in 29 files changed: 47 ins; 3 del; 60 mod Patch: https://git.openjdk.java.net/skara/pull/664.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/664/head:pull/664 PR: https://git.openjdk.java.net/skara/pull/664 From rwestberg at openjdk.java.net Mon Jun 15 13:09:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 15 Jun 2020 13:09:36 GMT Subject: RFR: 416: Expose committer date in CommitMetadata In-Reply-To: References: Message-ID: On Mon, 15 Jun 2020 13:00:25 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes the `date()` method in `CommitMetadata` and adds `authored()` and `committed()`. > For Mercurial commits `authored()` will equal `committed()` since Mercurial does not support different author and > committer dates. Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/664 From ehelin at openjdk.java.net Mon Jun 15 13:25:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 15 Jun 2020 13:25:53 GMT Subject: Integrated: 416: Expose committer date in CommitMetadata In-Reply-To: References: Message-ID: On Mon, 15 Jun 2020 13:00:25 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes the `date()` method in `CommitMetadata` and adds `authored()` and `committed()`. > For Mercurial commits `authored()` will equal `committed()` since Mercurial does not support different author and > committer dates. Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: 5397abe4 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/5397abe4 Stats: 110 lines in 29 files changed: 3 ins; 47 del; 60 mod 416: Expose committer date in CommitMetadata Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/664 From ehelin at openjdk.java.net Tue Jun 16 09:37:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 16 Jun 2020 09:37:13 GMT Subject: RFR: 411: Warn when a PR issue is not of a primary type Message-ID: <7IwuH4xeyZp_PIJA6xYUU3jtkSXG7-OiLYiY5qlvdAI=.c4736890-a92e-462d-945f-f8b09a0e72c9@github.com> Hi all, please review this patch that makes it possible the issue types that should be allowed to be referenced from a PR for a repository. Testing: - [x] Added a new unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - 411: Warn when a PR issue is not of a primary type Changes: https://git.openjdk.java.net/skara/pull/665/files Webrev: https://webrevs.openjdk.java.net/skara/665/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-411 Stats: 146 lines in 5 files changed: 134 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/665.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/665/head:pull/665 PR: https://git.openjdk.java.net/skara/pull/665 From rwestberg at openjdk.java.net Tue Jun 16 12:16:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 16 Jun 2020 12:16:04 GMT Subject: RFR: 411: Warn when a PR issue is not of a primary type In-Reply-To: <7IwuH4xeyZp_PIJA6xYUU3jtkSXG7-OiLYiY5qlvdAI=.c4736890-a92e-462d-945f-f8b09a0e72c9@github.com> References: <7IwuH4xeyZp_PIJA6xYUU3jtkSXG7-OiLYiY5qlvdAI=.c4736890-a92e-462d-945f-f8b09a0e72c9@github.com> Message-ID: On Tue, 16 Jun 2020 09:29:31 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it possible the issue types that should be allowed to be referenced from a PR for a > repository. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good, just had one minor comment / question. bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 122: > 121: if (repo.value().contains("issuetypes")) { > 122: var types = repo.value().get("issuetypes").asArray() > 123: .stream() You just do .stream directly here, right? At least I tend to do that.. :) ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/665 From ehelin at openjdk.java.net Tue Jun 16 13:47:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 16 Jun 2020 13:47:24 GMT Subject: RFR: 411: Warn when a PR issue is not of a primary type In-Reply-To: References: <7IwuH4xeyZp_PIJA6xYUU3jtkSXG7-OiLYiY5qlvdAI=.c4736890-a92e-462d-945f-f8b09a0e72c9@github.com> Message-ID: On Tue, 16 Jun 2020 12:11:29 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this patch that makes it possible the issue types that should be allowed to be referenced from a PR for a >> repository. >> Testing: >> - [x] Added a new unit test >> - [x] `make test` passes on Linux x64 >> >> Thanks, >> Erik > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 122: > >> 121: if (repo.value().contains("issuetypes")) { >> 122: var types = repo.value().get("issuetypes").asArray() >> 123: .stream() > > You just do .stream directly here, right? At least I tend to do that.. :) Right, yes, will fix! ------------- PR: https://git.openjdk.java.net/skara/pull/665 From ehelin at openjdk.java.net Tue Jun 16 13:56:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 16 Jun 2020 13:56:44 GMT Subject: RFR: 422: Add CLI tool expand issues in commit message Message-ID: Hi all, please review this patch that adds a tiny new CLI tool called `git expand`. The tool currently only supports one flag, `--issues`, which can be used to expand JBS issue ids in commit message. For example if a commit `HEAD` has the message `skara-420` and a user runs $ git expand --issues HEAD then the commit message will be `420: Expand JBS issues in PR titles`. This is useful for contributors _not_ using `git pr create` (which already does this and more). Testing: - [x] Manual testing of `git expand` on Linux x64 Thanks, Erik ------------- Commit messages: - 422: Add CLI tool expand issues in commit message Changes: https://git.openjdk.java.net/skara/pull/666/files Webrev: https://webrevs.openjdk.java.net/skara/666/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-422 Stats: 184 lines in 5 files changed: 183 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/666.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/666/head:pull/666 PR: https://git.openjdk.java.net/skara/pull/666 From rwestberg at openjdk.java.net Tue Jun 16 14:05:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 16 Jun 2020 14:05:03 GMT Subject: RFR: 422: Add CLI tool expand issues in commit message In-Reply-To: References: Message-ID: On Tue, 16 Jun 2020 13:48:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a tiny new CLI tool called `git expand`. The tool currently only supports one flag, > `--issues`, which can be used to expand JBS issue ids in commit message. For example if a commit `HEAD` has the message > `skara-420` and a user runs $ git expand --issues HEAD > > then the commit message will be `420: Expand JBS issues in PR titles`. This is useful for contributors _not_ using `git > pr create` (which already does this and more). > Testing: > - [x] Manual testing of `git expand` on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/666 From ehelin at openjdk.java.net Tue Jun 16 14:10:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 16 Jun 2020 14:10:03 GMT Subject: Integrated: 422: Add CLI tool expand issues in commit message In-Reply-To: References: Message-ID: On Tue, 16 Jun 2020 13:48:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a tiny new CLI tool called `git expand`. The tool currently only supports one flag, > `--issues`, which can be used to expand JBS issue ids in commit message. For example if a commit `HEAD` has the message > `skara-420` and a user runs $ git expand --issues HEAD > > then the commit message will be `420: Expand JBS issues in PR titles`. This is useful for contributors _not_ using `git > pr create` (which already does this and more). > Testing: > - [x] Manual testing of `git expand` on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 9af4807f Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/9af4807f Stats: 184 lines in 5 files changed: 0 ins; 183 del; 1 mod 422: Add CLI tool expand issues in commit message Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/666 From ehelin at openjdk.java.net Tue Jun 16 14:11:48 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 16 Jun 2020 14:11:48 GMT Subject: RFR: 411: Warn when a PR issue is not of a primary type [v2] In-Reply-To: <7IwuH4xeyZp_PIJA6xYUU3jtkSXG7-OiLYiY5qlvdAI=.c4736890-a92e-462d-945f-f8b09a0e72c9@github.com> References: <7IwuH4xeyZp_PIJA6xYUU3jtkSXG7-OiLYiY5qlvdAI=.c4736890-a92e-462d-945f-f8b09a0e72c9@github.com> Message-ID: > Hi all, > > please review this patch that makes it possible the issue types that should be allowed to be referenced from a PR for a > repository. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: No need to use asArray when using stream This pull request has now been integrated. Changeset: ddb6dc7c Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ddb6dc7c Stats: 145 lines in 5 files changed: 3 ins; 133 del; 9 mod 411: Warn when a PR issue is not of a primary type 415: A repository should be configurable to only accept backports Reviewed-by: rwestberg ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/665/files - new: https://git.openjdk.java.net/skara/pull/665/files/580d6cde..2b73d315 Webrevs: - full: https://webrevs.openjdk.java.net/skara/665/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/665/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/665.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/665/head:pull/665 PR: https://git.openjdk.java.net/skara/pull/665 From kcr at openjdk.java.net Tue Jun 16 14:26:13 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 16 Jun 2020 14:26:13 GMT Subject: RFR: 411: Warn when a PR issue is not of a primary type [v2] In-Reply-To: References: <7IwuH4xeyZp_PIJA6xYUU3jtkSXG7-OiLYiY5qlvdAI=.c4736890-a92e-462d-945f-f8b09a0e72c9@github.com> Message-ID: On Tue, 16 Jun 2020 12:13:55 GMT, Robin Westberg wrote: >> Erik Helin has updated the pull request incrementally with one additional commit since the last revision: >> >> No need to use asArray when using stream > > Looks good, just had one minor comment / question. > 415: A repository should be configurable to only accept backports Actually, it's quite the opposite: we want to ensure that a backport record is *never* used as the bug ID. This PR makes the list of issue types configurable, which is good. ------------- PR: https://git.openjdk.java.net/skara/pull/665 From rwestberg at openjdk.java.net Wed Jun 17 07:53:59 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 07:53:59 GMT Subject: RFR: 427: Allow bridging PR updates to multiple recipients Message-ID: Hi all, Please review this change that allows the mailing list bridge bot to send mails to multiple recipient lists, depending on PR labels and configuration. Best regards, Robin ------------- Commit messages: - Determine recipients based on labels if configured Changes: https://git.openjdk.java.net/skara/pull/667/files Webrev: https://webrevs.openjdk.java.net/skara/667/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-427 Stats: 352 lines in 13 files changed: 244 ins; 13 del; 95 mod Patch: https://git.openjdk.java.net/skara/pull/667.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/667/head:pull/667 PR: https://git.openjdk.java.net/skara/pull/667 From ehelin at openjdk.java.net Wed Jun 17 08:05:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 08:05:32 GMT Subject: RFR: 427: Allow bridging PR updates to multiple recipients In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 07:46:08 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows the mailing list bridge bot to send mails to multiple recipient lists, depending > on PR labels and configuration. > Best regards, > Robin Looks great! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/667 From rwestberg at openjdk.java.net Wed Jun 17 09:04:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 09:04:23 GMT Subject: Integrated: 427: Allow bridging PR updates to multiple recipients In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 07:46:08 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows the mailing list bridge bot to send mails to multiple recipient lists, depending > on PR labels and configuration. > Best regards, > Robin This pull request has now been integrated. Changeset: 3431a9e7 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/3431a9e7 Stats: 352 lines in 13 files changed: 13 ins; 244 del; 95 mod 427: Allow bridging PR updates to multiple recipients Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/667 From ehelin at openjdk.java.net Wed Jun 17 09:11:56 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 09:11:56 GMT Subject: RFR: 423: Avoid combining messages with different subjects In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 09:03:40 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that avoids combining mailinglist messages with different subjects, to enure that > integration notices are sent separately. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/668 From rwestberg at openjdk.java.net Wed Jun 17 09:11:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 09:11:56 GMT Subject: RFR: 423: Avoid combining messages with different subjects Message-ID: Hi all, Please review this small change that avoids combining mailinglist messages with different subjects, to enure that integration notices are sent separately. Best regards, Robin ------------- Commit messages: - Avoid combining messages with different subjects Changes: https://git.openjdk.java.net/skara/pull/668/files Webrev: https://webrevs.openjdk.java.net/skara/668/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-423 Stats: 7 lines in 2 files changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/668.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/668/head:pull/668 PR: https://git.openjdk.java.net/skara/pull/668 From rwestberg at openjdk.java.net Wed Jun 17 09:17:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 09:17:43 GMT Subject: Integrated: 423: Avoid combining messages with different subjects In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 09:03:40 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that avoids combining mailinglist messages with different subjects, to enure that > integration notices are sent separately. > Best regards, > Robin This pull request has now been integrated. Changeset: 1f6b3236 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/1f6b3236 Stats: 7 lines in 2 files changed: 0 ins; 7 del; 0 mod 423: Avoid combining messages with different subjects Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/668 From ehelin at openjdk.java.net Wed Jun 17 09:51:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 09:51:03 GMT Subject: RFR: 419: /issue add should allow project names in lower case In-Reply-To: <5i1NVhNAcBL2e1BwGgp1eR9P5udrilZlYZ9UJQh2FnU=.0c598ae9-c486-4066-82b7-36f373e576a8@github.com> References: <5i1NVhNAcBL2e1BwGgp1eR9P5udrilZlYZ9UJQh2FnU=.0c598ae9-c486-4066-82b7-36f373e576a8@github.com> Message-ID: On Wed, 17 Jun 2020 09:42:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this simple change that matches project names without case sensitivity. > > Best regards, > Robin Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/669 From rwestberg at openjdk.java.net Wed Jun 17 09:51:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 09:51:03 GMT Subject: RFR: 419: /issue add should allow project names in lower case Message-ID: <5i1NVhNAcBL2e1BwGgp1eR9P5udrilZlYZ9UJQh2FnU=.0c598ae9-c486-4066-82b7-36f373e576a8@github.com> Hi all, Please review this simple change that matches project names without case sensitivity. Best regards, Robin ------------- Commit messages: - Match issue project names case-insensitive Changes: https://git.openjdk.java.net/skara/pull/669/files Webrev: https://webrevs.openjdk.java.net/skara/669/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-419 Stats: 68 lines in 2 files changed: 67 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/669.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/669/head:pull/669 PR: https://git.openjdk.java.net/skara/pull/669 From rwestberg at openjdk.java.net Wed Jun 17 10:17:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 10:17:13 GMT Subject: Integrated: 419: /issue add should allow project names in lower case In-Reply-To: <5i1NVhNAcBL2e1BwGgp1eR9P5udrilZlYZ9UJQh2FnU=.0c598ae9-c486-4066-82b7-36f373e576a8@github.com> References: <5i1NVhNAcBL2e1BwGgp1eR9P5udrilZlYZ9UJQh2FnU=.0c598ae9-c486-4066-82b7-36f373e576a8@github.com> Message-ID: On Wed, 17 Jun 2020 09:42:03 GMT, Robin Westberg wrote: > Hi all, > > Please review this simple change that matches project names without case sensitivity. > > Best regards, > Robin This pull request has now been integrated. Changeset: ca39c57b Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/ca39c57b Stats: 68 lines in 2 files changed: 0 ins; 67 del; 1 mod 419: /issue add should allow project names in lower case Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/669 From ehelin at openjdk.java.net Wed Jun 17 10:20:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 10:20:37 GMT Subject: RFR: vcs: handle lightweight tags in Git Message-ID: Hi all, please review this patch that makes `GitRepository.annotate` handle lightweight tags gracefully. Testing: - [x] Added a unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - vcs: handle lightweight tags in Git Changes: https://git.openjdk.java.net/skara/pull/670/files Webrev: https://webrevs.openjdk.java.net/skara/670/webrev.00 Stats: 38 lines in 2 files changed: 35 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/670.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/670/head:pull/670 PR: https://git.openjdk.java.net/skara/pull/670 From rwestberg at openjdk.java.net Wed Jun 17 10:20:45 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 10:20:45 GMT Subject: RFR: vcs: handle lightweight tags in Git In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 10:13:10 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `GitRepository.annotate` handle lightweight tags gracefully. > > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/670 From ehelin at openjdk.java.net Wed Jun 17 12:31:56 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 12:31:56 GMT Subject: Integrated: vcs: handle lightweight tags in Git In-Reply-To: References: Message-ID: <4ZGDrOv_OZT71t7C1MV74UrfOWIUHWMdsX-aH0faASk=.06e011cf-a6eb-4a62-8432-e48ca09defd3@github.com> On Wed, 17 Jun 2020 10:13:10 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `GitRepository.annotate` handle lightweight tags gracefully. > > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 28456f5d Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/28456f5d Stats: 38 lines in 2 files changed: 0 ins; 35 del; 3 mod vcs: handle lightweight tags in Git Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/670 From ehelin at openjdk.java.net Wed Jun 17 15:16:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 15:16:34 GMT Subject: RFR: forge: use correct endpoints for commits in GitLab Message-ID: Hi all, please review this patch that uses the correct REST API endpoint for commits for GitLab. Testing: - [x] Manual verification of endpoints - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - forge: use correct endpoints for commits in GitLab Changes: https://git.openjdk.java.net/skara/pull/671/files Webrev: https://webrevs.openjdk.java.net/skara/671/webrev.00 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/671.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/671/head:pull/671 PR: https://git.openjdk.java.net/skara/pull/671 From rwestberg at openjdk.java.net Wed Jun 17 15:16:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 15:16:35 GMT Subject: RFR: forge: use correct endpoints for commits in GitLab In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 15:07:33 GMT, Erik Helin wrote: > Hi all, > > please review this patch that uses the correct REST API endpoint for commits for GitLab. > > Testing: > - [x] Manual verification of endpoints > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/671 From ehelin at openjdk.java.net Wed Jun 17 16:11:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 16:11:17 GMT Subject: Integrated: forge: use correct endpoints for commits in GitLab In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 15:07:33 GMT, Erik Helin wrote: > Hi all, > > please review this patch that uses the correct REST API endpoint for commits for GitLab. > > Testing: > - [x] Manual verification of endpoints > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 2f4d5a83 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/2f4d5a83 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod forge: use correct endpoints for commits in GitLab Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/671 From ehelin at openjdk.java.net Wed Jun 17 16:16:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 16:16:51 GMT Subject: RFR: 420: Expand JBS issues in PR titles Message-ID: Hi all, please review this small patch that automatically expands issue ids in pull request titles to the "id: title" format. For example if a pull request for the [skara](https://github.com/openjdk/skara) repository has the title `420`, then the pull request title will be automatically set to `420: Expand JBS issues in PR titles`. I have been fairly conservative in what we expand, we only expand titles exactly matching `PROJECT-ID` or `ID`, i.e. `SKARA-420` or `420`. Testing: - [x] Added two new unit tests - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - 420: Expand JBS issues in PR titles Changes: https://git.openjdk.java.net/skara/pull/672/files Webrev: https://webrevs.openjdk.java.net/skara/672/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-420 Stats: 105 lines in 2 files changed: 104 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/672.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/672/head:pull/672 PR: https://git.openjdk.java.net/skara/pull/672 From rwestberg at openjdk.java.net Wed Jun 17 16:36:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 16:36:25 GMT Subject: RFR: 420: Expand JBS issues in PR titles In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 16:08:38 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that automatically expands issue ids in pull request titles to the "id: title" format. > For example if a pull request for the [skara](https://github.com/openjdk/skara) repository has the title `420`, then > the pull request title will be automatically set to `420: Expand JBS issues in PR titles`. I have been fairly > conservative in what we expand, we only expand titles exactly matching `PROJECT-ID` or `ID`, i.e. `SKARA-420` or > `420`. Testing: > - [x] Added two new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! Perhaps it would be nice with a test that checks that non-matching titles aren't expanded, but it looks like it should work correctly. ) ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/672 From rwestberg at openjdk.java.net Wed Jun 17 17:00:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 17:00:18 GMT Subject: RFR: Fix typo in property name for GitLab commitMetadata Message-ID: Hi all, Please review this minor fix that corrects a property name in the GitLab commitMetadata function. Best regards, Robin ------------- Commit messages: - Fix typo in property name Changes: https://git.openjdk.java.net/skara/pull/673/files Webrev: https://webrevs.openjdk.java.net/skara/673/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/673.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/673/head:pull/673 PR: https://git.openjdk.java.net/skara/pull/673 From ehelin at openjdk.java.net Wed Jun 17 17:12:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 17:12:55 GMT Subject: RFR: Fix typo in property name for GitLab commitMetadata In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 16:52:13 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor fix that corrects a property name in the GitLab commitMetadata function. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/673 From ehelin at openjdk.java.net Wed Jun 17 17:14:06 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 17 Jun 2020 17:14:06 GMT Subject: Integrated: 420: Expand JBS issues in PR titles In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 16:08:38 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that automatically expands issue ids in pull request titles to the "id: title" format. > For example if a pull request for the [skara](https://github.com/openjdk/skara) repository has the title `420`, then > the pull request title will be automatically set to `420: Expand JBS issues in PR titles`. I have been fairly > conservative in what we expand, we only expand titles exactly matching `PROJECT-ID` or `ID`, i.e. `SKARA-420` or > `420`. Testing: > - [x] Added two new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 2c0df39f Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/2c0df39f Stats: 105 lines in 2 files changed: 0 ins; 104 del; 1 mod 420: Expand JBS issues in PR titles Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/672 From rwestberg at openjdk.java.net Wed Jun 17 17:57:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 17 Jun 2020 17:57:55 GMT Subject: Integrated: Fix typo in property name for GitLab commitMetadata In-Reply-To: References: Message-ID: On Wed, 17 Jun 2020 16:52:13 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor fix that corrects a property name in the GitLab commitMetadata function. > > Best regards, > Robin This pull request has now been integrated. Changeset: c817a8fa Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/c817a8fa Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Fix typo in property name for GitLab commitMetadata Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/673 From ehelin at openjdk.java.net Thu Jun 18 12:12:38 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 18 Jun 2020 12:12:38 GMT Subject: RFR: webrev: add logging Message-ID: Hi all, please review this small patch that add some additional logging to `Webrev` and dereferences `Optional`s a bit more carefully in `ModifiedFileView`. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - webrev: add logging Changes: https://git.openjdk.java.net/skara/pull/674/files Webrev: https://webrevs.openjdk.java.net/skara/674/webrev.00 Stats: 32 lines in 3 files changed: 15 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/skara/pull/674.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/674/head:pull/674 PR: https://git.openjdk.java.net/skara/pull/674 From jvernee at openjdk.java.net Thu Jun 18 12:40:06 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Thu, 18 Jun 2020 12:40:06 GMT Subject: RFR: webrev: add logging In-Reply-To: References: Message-ID: On Thu, 18 Jun 2020 12:04:58 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that add some additional logging to `Webrev` and dereferences `Optional`s a bit more > carefully in `ModifiedFileView`. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Marked as reviewed by jvernee (Reviewer). webrev/src/main/java/org/openjdk/skara/webrev/ModifiedFileView.java line 56: > 55: patch.source().hash() + " with target path" + > 56: patch.target().path().get()) > 57: ); Is this `get()` safe though? Maybe you want to extract the target path into a variable as well, since the `patch.target().path().get()` is used a few times below as well? (It would reduce the number of `get()` calls`, so less scrutiny needed). webrev/src/main/java/org/openjdk/skara/webrev/Webrev.java line 207: > 206: " for files " + > 207: String.join(", ", files.stream().map(Path::toString).collect(Collectors.toList())); > 208: log.fine("Generating webrev from " + tailEnd + " to " + headHash + filesDesc); You could also use [`Collectors.joining`](https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/util/stream/Collectors.html#joining(java.lang.CharSequence)) here Suggestion: files.stream().map(Path::toString).collect(Collectors.joining(", ")); ------------- PR: https://git.openjdk.java.net/skara/pull/674 From ehelin at openjdk.java.net Thu Jun 18 13:41:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 18 Jun 2020 13:41:44 GMT Subject: RFR: webrev: add logging [v2] In-Reply-To: References: Message-ID: On Thu, 18 Jun 2020 12:32:30 GMT, Jorn Vernee wrote: >> Erik Helin has updated the pull request incrementally with one additional commit since the last revision: >> >> Use `Collectors.joining` >> >> Co-authored-by: Jorn Vernee > > webrev/src/main/java/org/openjdk/skara/webrev/ModifiedFileView.java line 56: > >> 55: patch.source().hash() + " with target path" + >> 56: patch.target().path().get()) >> 57: ); > > Is this `get()` safe though? Maybe you want to extract the target path into a variable as well, since the > `patch.target().path().get()` is used a few times below as well? (It would reduce the number of `get()` calls`, so less > scrutiny needed). Yeah, `path.target().path().get()` _should_ be safe. If the patch does not have `source` path nor have a `target` path, then something is seriously wrong ?? ------------- PR: https://git.openjdk.java.net/skara/pull/674 From ehelin at openjdk.java.net Thu Jun 18 13:41:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 18 Jun 2020 13:41:43 GMT Subject: RFR: webrev: add logging [v2] In-Reply-To: References: Message-ID: > Hi all, > > please review this small patch that add some additional logging to `Webrev` and dereferences `Optional`s a bit more > carefully in `ModifiedFileView`. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Use `Collectors.joining` Co-authored-by: Jorn Vernee ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/674/files - new: https://git.openjdk.java.net/skara/pull/674/files/df7bb77c..3dfb8885 Webrevs: - full: https://webrevs.openjdk.java.net/skara/674/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/674/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/674.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/674/head:pull/674 PR: https://git.openjdk.java.net/skara/pull/674 From ehelin at openjdk.java.net Thu Jun 18 14:06:06 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 18 Jun 2020 14:06:06 GMT Subject: Integrated: webrev: add logging In-Reply-To: References: Message-ID: On Thu, 18 Jun 2020 12:04:58 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that add some additional logging to `Webrev` and dereferences `Optional`s a bit more > carefully in `ModifiedFileView`. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 9f5bf30e Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/9f5bf30e Stats: 32 lines in 3 files changed: 0 ins; 15 del; 17 mod webrev: add logging Reviewed-by: jvernee ------------- PR: https://git.openjdk.java.net/skara/pull/674 From ehelin at openjdk.java.net Sun Jun 21 13:35:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sun, 21 Jun 2020 13:35:16 GMT Subject: RFR: vcs: proper source paths for merge commits Message-ID: Hi all, please review this patch that fixes an issue with parsing Git merge commits. Without the `--combined-all-paths` the "RAW" diff format of `git diff --combined` will only print the resulting (target) path for a rename. This mean that `patch.source().path()` would `Optional.empty()` for such a patch. This patch fixes this by passing the `--combined-all-paths` flag to `git log` and updating the `GitCombinedDiffParser`. Testing: - [x] Added a new unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - vcs: proper source paths for merge commits Changes: https://git.openjdk.java.net/skara/pull/675/files Webrev: https://webrevs.openjdk.java.net/skara/675/webrev.00 Stats: 60 lines in 3 files changed: 54 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/675.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/675/head:pull/675 PR: https://git.openjdk.java.net/skara/pull/675 From rwestberg at openjdk.java.net Mon Jun 22 04:58:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 22 Jun 2020 04:58:06 GMT Subject: RFR: vcs: proper source paths for merge commits In-Reply-To: References: Message-ID: On Sun, 21 Jun 2020 13:27:30 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes an issue with parsing Git merge commits. Without the `--combined-all-paths` the > "RAW" diff format of `git diff --combined` will only print the resulting (target) path for a rename. This mean that > `patch.source().path()` would `Optional.empty()` for such a patch. This patch fixes this by passing the > `--combined-all-paths` flag to `git log` and updating the `GitCombinedDiffParser`. Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/675 From ehelin at openjdk.java.net Mon Jun 22 06:18:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 22 Jun 2020 06:18:55 GMT Subject: Integrated: vcs: proper source paths for merge commits In-Reply-To: References: Message-ID: On Sun, 21 Jun 2020 13:27:30 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes an issue with parsing Git merge commits. Without the `--combined-all-paths` the > "RAW" diff format of `git diff --combined` will only print the resulting (target) path for a rename. This mean that > `patch.source().path()` would `Optional.empty()` for such a patch. This patch fixes this by passing the > `--combined-all-paths` flag to `git log` and updating the `GitCombinedDiffParser`. Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 7f84ac80 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/7f84ac80 Stats: 60 lines in 3 files changed: 0 ins; 54 del; 6 mod vcs: proper source paths for merge commits Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/675 From ehelin at openjdk.java.net Wed Jun 24 07:59:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 07:59:16 GMT Subject: RFR: 428: git-jcheck does not work on repositories without default or maser branch Message-ID: <9aygwZTIlqpCV1YFT2NKZm-6qB1gn38CdtHQYF57QUM=.4c2f3091-cd35-462f-9e8d-55541470ea6d@github.com> Hi all, please review this small patch that makes `JCheck` work on repositories _without_ a remotee `HEAD` ref being present (i.e. `refs/remotes/origin/HEAD`) and _without_ a `master` ref being present (i.e. `refs/heads/master`). In such a case `JCheck` will now fall back to configuration values for allowed tags and branches as specified in the configuration file at `HEAD` (`HEAD` is always present). Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - skara-428 Changes: https://git.openjdk.java.net/skara/pull/676/files Webrev: https://webrevs.openjdk.java.net/skara/676/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-428 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/676.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/676/head:pull/676 PR: https://git.openjdk.java.net/skara/pull/676 From rwestberg at openjdk.java.net Wed Jun 24 08:17:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 24 Jun 2020 08:17:38 GMT Subject: RFR: 428: git-jcheck does not work on repositories without default or maser branch In-Reply-To: <9aygwZTIlqpCV1YFT2NKZm-6qB1gn38CdtHQYF57QUM=.4c2f3091-cd35-462f-9e8d-55541470ea6d@github.com> References: <9aygwZTIlqpCV1YFT2NKZm-6qB1gn38CdtHQYF57QUM=.4c2f3091-cd35-462f-9e8d-55541470ea6d@github.com> Message-ID: On Wed, 24 Jun 2020 07:49:34 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `JCheck` work on repositories _without_ a remotee `HEAD` ref being present > (i.e. `refs/remotes/origin/HEAD`) and _without_ a `master` ref being present (i.e. `refs/heads/master`). In such a case > `JCheck` will now fall back to configuration values for allowed tags and branches as specified in the configuration > file at `HEAD` (`HEAD` is always present). Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good, just a spelling error in the title :) ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/676 From ehelin at openjdk.java.net Wed Jun 24 08:22:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 08:22:37 GMT Subject: Integrated: 428: git-jcheck does not work on repositories without default or maser branch In-Reply-To: <9aygwZTIlqpCV1YFT2NKZm-6qB1gn38CdtHQYF57QUM=.4c2f3091-cd35-462f-9e8d-55541470ea6d@github.com> References: <9aygwZTIlqpCV1YFT2NKZm-6qB1gn38CdtHQYF57QUM=.4c2f3091-cd35-462f-9e8d-55541470ea6d@github.com> Message-ID: On Wed, 24 Jun 2020 07:49:34 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `JCheck` work on repositories _without_ a remotee `HEAD` ref being present > (i.e. `refs/remotes/origin/HEAD`) and _without_ a `master` ref being present (i.e. `refs/heads/master`). In such a case > `JCheck` will now fall back to configuration values for allowed tags and branches as specified in the configuration > file at `HEAD` (`HEAD` is always present). Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 645a73cd Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/645a73cd Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod 428: git-jcheck does not work on repositories without default or maser branch Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/676 From rwestberg at openjdk.java.net Wed Jun 24 09:09:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 24 Jun 2020 09:09:09 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. Message-ID: Hi all, Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of the issue will be copied from the pull request. The command is only available for committers and above (who already have access to creating issues manually). Best regards, Robin ------------- Commit messages: - Initial implementation of create subcommand to issue Changes: https://git.openjdk.java.net/skara/pull/677/files Webrev: https://webrevs.openjdk.java.net/skara/677/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-372 Stats: 673 lines in 14 files changed: 453 ins; 167 del; 53 mod Patch: https://git.openjdk.java.net/skara/pull/677.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/677/head:pull/677 PR: https://git.openjdk.java.net/skara/pull/677 From rwestberg at openjdk.java.net Wed Jun 24 10:18:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 24 Jun 2020 10:18:44 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v2] In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of > the issue will be copied from the pull request. The command is only available for committers and above (who already > have access to creating issues manually). Best regards, > Robin Robin Westberg has updated the pull request incrementally with two additional commits since the last revision: - Allow using / as a component/subcomponent separator Remove debug print statement - Only allow creating issues of type "enhancement" for now ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/677/files - new: https://git.openjdk.java.net/skara/pull/677/files/5f873536..17374612 Webrevs: - full: https://webrevs.openjdk.java.net/skara/677/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/677/webrev.00-01 Stats: 30 lines in 3 files changed: 0 ins; 23 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/677.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/677/head:pull/677 PR: https://git.openjdk.java.net/skara/pull/677 From ehelin at openjdk.java.net Wed Jun 24 12:02:59 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 12:02:59 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v2] In-Reply-To: References: Message-ID: <0xx3uwtuFsjOzAiJ5oPFynEFPuNsZnBCjdDn56YHt1E=.6f23b4f0-a7c2-4aa0-a602-d0ba769b1605@github.com> On Wed, 24 Jun 2020 10:18:44 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of >> the issue will be copied from the pull request. The command is only available for committers and above (who already >> have access to creating issues manually). Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with two additional commits since the last revision: > > - Allow using / as a component/subcomponent separator > Remove debug print statement > - Only allow creating issues of type "enhancement" for now Looks good overall, just a few inline comments on how to specify component and subcomponent. bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 62: > 61: reply.println(" * `/" + name + " [add] : `"); > 62: reply.println(" * `/" + name + " create [pX] [subcomponent]"); > 63: reply.println(); Suggestion: reply.println(" * `/" + name + " create [PX] /[subcomponent]"); bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 69: > 68: reply.println(" * `/" + name + " 1234567: Use this exact title`"); > 69: reply.println(" * `/" + name + " create hotspot jfr"); > 70: reply.println(" * `/" + name + " create P4 core-libs java.nio"); Suggestion: reply.println(" * `/" + name + " create hotspot/jfr"); bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 70: > 69: reply.println(" * `/" + name + " create hotspot jfr"); > 70: reply.println(" * `/" + name + " create P4 core-libs java.nio"); > 71: reply.println(); Suggestion: reply.println(" * `/" + name + " create P4 core-libs/java.nio"); bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 216: > 215: private void createIssue(PullRequestBot bot, PullRequest pr, String args, CensusInstance censusInstance, > HostUser author, PrintWriter reply) { 216: if (!censusInstance.isAuthor(author)) { > 217: reply.println("Only [Authors](https://openjdk.java.net/bylaws#author) are allowed to create issues."); DId you mean to check for committer status? In the description of the PR you wrote for "Committers" and above, but here you are checking for "Author" and above ------------- Changes requested by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/677 From ehelin at openjdk.java.net Wed Jun 24 12:47:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 12:47:16 GMT Subject: RFR: 430: /summary command does not support multi-line summaries Message-ID: Hi all, please review this patch that makes the `/summary` pull request command accept multi-line summaries. As described on the [Skara wiki](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/summary) the `/summary` command should this, since the commit message format allow for this. Testing: - [x] Added a new unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - 430 Changes: https://git.openjdk.java.net/skara/pull/678/files Webrev: https://webrevs.openjdk.java.net/skara/678/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-430 Stats: 112 lines in 2 files changed: 101 ins; 1 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/678.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/678/head:pull/678 PR: https://git.openjdk.java.net/skara/pull/678 From rwestberg at openjdk.java.net Wed Jun 24 13:07:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 24 Jun 2020 13:07:29 GMT Subject: RFR: 430: /summary command does not support multi-line summaries In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 12:37:57 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the `/summary` pull request command accept multi-line summaries. As described on > the [Skara wiki](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/summary) the > `/summary` command should this, since the commit message format allow for this. Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good, I'm a little bit concerned about what happens if we start to support multiple commands per comment, but I guess that can be taken care of at that time.. :) bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java line 250: > 249: > 250: // Finllay update it to a single line summary > 251: pr.addComment("/summary single line"); Suggestion: // Finally update it to a single line summary bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java line 64: > 63: } else { > 64: // A single-line summary > 65: var summary = args.strip(); Check if lines.size > 1 here? Perhaps that should be an error / warning? ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/678 From rwestberg at openjdk.java.net Wed Jun 24 13:38:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 24 Jun 2020 13:38:39 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v3] In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of > the issue will be copied from the pull request. The command is only available for committers and above (who already > have access to creating issues manually). Best regards, > Robin Robin Westberg has updated the pull request incrementally with three additional commits since the last revision: - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java Co-authored-by: Erik Duveblad - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java Co-authored-by: Erik Duveblad - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java Co-authored-by: Erik Duveblad ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/677/files - new: https://git.openjdk.java.net/skara/pull/677/files/17374612..7cf75071 Webrevs: - full: https://webrevs.openjdk.java.net/skara/677/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/677/webrev.01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/677.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/677/head:pull/677 PR: https://git.openjdk.java.net/skara/pull/677 From kcr at openjdk.java.net Wed Jun 24 13:38:39 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Wed, 24 Jun 2020 13:38:39 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v2] In-Reply-To: <0xx3uwtuFsjOzAiJ5oPFynEFPuNsZnBCjdDn56YHt1E=.6f23b4f0-a7c2-4aa0-a602-d0ba769b1605@github.com> References: <0xx3uwtuFsjOzAiJ5oPFynEFPuNsZnBCjdDn56YHt1E=.6f23b4f0-a7c2-4aa0-a602-d0ba769b1605@github.com> Message-ID: On Wed, 24 Jun 2020 12:00:46 GMT, Erik Helin wrote: >> Robin Westberg has updated the pull request incrementally with two additional commits since the last revision: >> >> - Allow using / as a component/subcomponent separator >> Remove debug print statement >> - Only allow creating issues of type "enhancement" for now > > Looks good overall, just a few inline comments on how to specify component and subcomponent. > The command is only available for committers and above (who already have access to creating issues manually). An author also has access to create an issue manually (which it looks like what you actually implemented). ------------- PR: https://git.openjdk.java.net/skara/pull/677 From rwestberg at openjdk.java.net Wed Jun 24 13:38:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 24 Jun 2020 13:38:40 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v2] In-Reply-To: <0xx3uwtuFsjOzAiJ5oPFynEFPuNsZnBCjdDn56YHt1E=.6f23b4f0-a7c2-4aa0-a602-d0ba769b1605@github.com> References: <0xx3uwtuFsjOzAiJ5oPFynEFPuNsZnBCjdDn56YHt1E=.6f23b4f0-a7c2-4aa0-a602-d0ba769b1605@github.com> Message-ID: On Wed, 24 Jun 2020 10:15:32 GMT, Erik Helin wrote: >> Robin Westberg has updated the pull request incrementally with two additional commits since the last revision: >> >> - Allow using / as a component/subcomponent separator >> Remove debug print statement >> - Only allow creating issues of type "enhancement" for now > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 216: > >> 215: private void createIssue(PullRequestBot bot, PullRequest pr, String args, CensusInstance censusInstance, >> HostUser author, PrintWriter reply) { 216: if (!censusInstance.isAuthor(author)) { >> 217: reply.println("Only [Authors](https://openjdk.java.net/bylaws#author) are allowed to create issues."); > > DId you mean to check for committer status? In the description of the PR you wrote for "Committers" and above, but here > you are checking for "Author" and above No, I should have written Author in the PR description, think that check is sufficient as all authors have permissions to create issues manually in JBS. ------------- PR: https://git.openjdk.java.net/skara/pull/677 From ehelin at openjdk.java.net Wed Jun 24 13:44:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 13:44:04 GMT Subject: RFR: 430: /summary command does not support multi-line summaries [v2] In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 13:05:01 GMT, Robin Westberg wrote: >> Erik Helin has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix spelling >> >> Co-authored-by: Robin Westberg > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java line 64: > >> 63: } else { >> 64: // A single-line summary >> 65: var summary = args.strip(); > > Check if lines.size > 1 here? Perhaps that should be an error / warning? Hm, yeah, good comment. Let me fix that! ------------- PR: https://git.openjdk.java.net/skara/pull/678 From ehelin at openjdk.java.net Wed Jun 24 13:44:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 13:44:03 GMT Subject: RFR: 430: /summary command does not support multi-line summaries [v2] In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that makes the `/summary` pull request command accept multi-line summaries. As described on > the [Skara wiki](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/summary) the > `/summary` command should this, since the commit message format allow for this. Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Fix spelling Co-authored-by: Robin Westberg ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/678/files - new: https://git.openjdk.java.net/skara/pull/678/files/c0ca352e..6d612ddf Webrevs: - full: https://webrevs.openjdk.java.net/skara/678/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/678/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/678.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/678/head:pull/678 PR: https://git.openjdk.java.net/skara/pull/678 From ehelin at openjdk.java.net Wed Jun 24 15:09:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 15:09:10 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v3] In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 13:38:39 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of >> the issue will be copied from the pull request. The command is only available for committers and above (who already >> have access to creating issues manually). Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with three additional commits since the last revision: > > - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java > > Co-authored-by: Erik Duveblad > - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java > > Co-authored-by: Erik Duveblad > - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java > > Co-authored-by: Erik Duveblad bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 245: > 244: } > 245: var component = next; > 246: next = argSplit.pollFirst(); Given that you incorporated my changes to the help text I think you need to add some code here to handle the case when `component` is something like `"hotspot/gc"` ?? ------------- PR: https://git.openjdk.java.net/skara/pull/677 From ehelin at openjdk.java.net Wed Jun 24 15:09:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 15:09:09 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v2] In-Reply-To: References: <0xx3uwtuFsjOzAiJ5oPFynEFPuNsZnBCjdDn56YHt1E=.6f23b4f0-a7c2-4aa0-a602-d0ba769b1605@github.com> Message-ID: On Wed, 24 Jun 2020 13:23:26 GMT, Robin Westberg wrote: >> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 216: >> >>> 215: private void createIssue(PullRequestBot bot, PullRequest pr, String args, CensusInstance censusInstance, >>> HostUser author, PrintWriter reply) { 216: if (!censusInstance.isAuthor(author)) { >>> 217: reply.println("Only [Authors](https://openjdk.java.net/bylaws#author) are allowed to create issues."); >> >> DId you mean to check for committer status? In the description of the PR you wrote for "Committers" and above, but here >> you are checking for "Author" and above > > No, I should have written Author in the PR description, think that check is sufficient as all authors have permissions > to create issues manually in JBS. Ok! ------------- PR: https://git.openjdk.java.net/skara/pull/677 From ehelin at openjdk.java.net Wed Jun 24 16:11:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 16:11:29 GMT Subject: RFR: 430: /summary command does not support multi-line summaries [v3] In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that makes the `/summary` pull request command accept multi-line summaries. As described on > the [Skara wiki](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/summary) the > `/summary` command should this, since the commit message format allow for this. Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Updates based on reviewer feedback - Handle preceeding empty lines - Handle trailing empty lines - Show error when command is used for both single- and multi-line summaries ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/678/files - new: https://git.openjdk.java.net/skara/pull/678/files/6d612ddf..202a7d37 Webrevs: - full: https://webrevs.openjdk.java.net/skara/678/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/678/webrev.01-02 Stats: 161 lines in 2 files changed: 148 ins; 1 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/678.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/678/head:pull/678 PR: https://git.openjdk.java.net/skara/pull/678 From ehelin at openjdk.java.net Wed Jun 24 16:11:36 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 24 Jun 2020 16:11:36 GMT Subject: RFR: 430: /summary command does not support multi-line summaries [v3] In-Reply-To: References: Message-ID: <-aqP_JKDOr_52jHDYJRTJBnIiM4VZx-jdDrk3LMoY7U=.1bc0ebc5-392b-4e7f-836b-24ece0982a45@github.com> On Wed, 24 Jun 2020 13:30:48 GMT, Erik Helin wrote: >> bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java line 64: >> >>> 63: } else { >>> 64: // A single-line summary >>> 65: var summary = args.strip(); >> >> Check if lines.size > 1 here? Perhaps that should be an error / warning? > > Hm, yeah, good comment. Let me fix that! Fixed in 202a7d3 ------------- PR: https://git.openjdk.java.net/skara/pull/678 From rwestberg at openjdk.java.net Thu Jun 25 05:56:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 25 Jun 2020 05:56:19 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v3] In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 15:07:05 GMT, Erik Helin wrote: >> Robin Westberg has updated the pull request incrementally with three additional commits since the last revision: >> >> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java >> >> Co-authored-by: Erik Duveblad >> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java >> >> Co-authored-by: Erik Duveblad >> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java >> >> Co-authored-by: Erik Duveblad > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 245: > >> 244: } >> 245: var component = next; >> 246: next = argSplit.pollFirst(); > > Given that you incorporated my changes to the help text I think you need to add some code here to handle the case when > `component` is something like `"hotspot/gc"` ?? But it does work, there's even a test for it. :) ------------- PR: https://git.openjdk.java.net/skara/pull/677 From ehelin at openjdk.java.net Thu Jun 25 08:34:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 25 Jun 2020 08:34:19 GMT Subject: Integrated: 430: /summary command does not support multi-line summaries In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 12:37:57 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the `/summary` pull request command accept multi-line summaries. As described on > the [Skara wiki](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/summary) the > `/summary` command should this, since the commit message format allow for this. Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 5b5c3a53 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/5b5c3a53 Stats: 257 lines in 2 files changed: 1 ins; 248 del; 8 mod 430: /summary command does not support multi-line summaries Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/678 From ehelin at openjdk.java.net Thu Jun 25 08:36:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 25 Jun 2020 08:36:29 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v3] In-Reply-To: References: Message-ID: On Thu, 25 Jun 2020 05:54:10 GMT, Robin Westberg wrote: >> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 245: >> >>> 244: } >>> 245: var component = next; >>> 246: next = argSplit.pollFirst(); >> >> Given that you incorporated my changes to the help text I think you need to add some code here to handle the case when >> `component` is something like `"hotspot/gc"` ?? > > But it does work, there's even a test for it. :) Sigh, I didn't notice the regular expression in `args.split("(?:\\s+|/)"))` ?? Looks good then ?? ------------- PR: https://git.openjdk.java.net/skara/pull/677 From ehelin at openjdk.java.net Thu Jun 25 08:36:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 25 Jun 2020 08:36:28 GMT Subject: RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v3] In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 13:38:39 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of >> the issue will be copied from the pull request. The command is only available for committers and above (who already >> have access to creating issues manually). Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with three additional commits since the last revision: > > - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java > > Co-authored-by: Erik Duveblad > - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java > > Co-authored-by: Erik Duveblad > - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java > > Co-authored-by: Erik Duveblad Marked as reviewed by ehelin (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/677 From ihse at openjdk.java.net Thu Jun 25 09:21:19 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 25 Jun 2020 09:21:19 GMT Subject: RFR: json patches introduced to the OpenJDK copy in JDK-8246435 In-Reply-To: References: <2eLIommtltG2RelQZeNdsQDcJiSrxnlvCiNF84EERvA=.b67af610-2b16-49c4-8970-82a3c9fc5cd7@github.com> Message-ID: On Wed, 3 Jun 2020 12:45:22 GMT, Erik Helin wrote: >> This PR contains the proposed changes to the json system made in JDK-8246435. If the same changes are made in Skara, >> tthe two code bases are kept from diverging. > > Hi Magnus, > > thanks for contributing! Looks really nice in general, I just had two small comments about the changes to `JSONArray`. > > Thanks! > Erik Yeah, yeah... Stop whining, bot. ------------- PR: https://git.openjdk.java.net/skara/pull/636 From rwestberg at openjdk.java.net Thu Jun 25 13:33:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 25 Jun 2020 13:33:18 GMT Subject: Integrated: 372: Tool support for small/minor/trivial "fast-track" changes. In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 09:00:32 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of > the issue will be copied from the pull request. The command is only available for committers and above (who already > have access to creating issues manually). Best regards, > Robin This pull request has now been integrated. Changeset: 971c746c Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/971c746c Stats: 650 lines in 14 files changed: 167 ins; 430 del; 53 mod 372: Tool support for small/minor/trivial "fast-track" changes. Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/677 From rwestberg at openjdk.java.net Fri Jun 26 11:28:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 26 Jun 2020 11:28:09 GMT Subject: RFR: 342: Pull request bot should warn on merge commits with non-target branch parent Message-ID: Hi all, Please review this change that checks if a PR contains merges from outside the current project, and suggests using a merge-style PR. Best regards, Robin ------------- Commit messages: - Detect when a merge PR could be appropriate Changes: https://git.openjdk.java.net/skara/pull/679/files Webrev: https://webrevs.openjdk.java.net/skara/679/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-342 Stats: 103 lines in 3 files changed: 103 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/679.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/679/head:pull/679 PR: https://git.openjdk.java.net/skara/pull/679 From rwestberg at openjdk.java.net Fri Jun 26 13:50:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 26 Jun 2020 13:50:39 GMT Subject: RFR: 342: Pull request bot should warn on merge commits with non-target branch parent [v2] In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that checks if a PR contains merges from outside the current project, and suggests using a > merge-style PR. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Updated foreign merge detection ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/679/files - new: https://git.openjdk.java.net/skara/pull/679/files/25da5701..48e5663f Webrevs: - full: https://webrevs.openjdk.java.net/skara/679/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/679/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/679.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/679/head:pull/679 PR: https://git.openjdk.java.net/skara/pull/679 From ehelin at openjdk.java.net Fri Jun 26 13:50:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 26 Jun 2020 13:50:46 GMT Subject: RFR: 342: Pull request bot should warn on merge commits with non-target branch parent [v2] In-Reply-To: References: Message-ID: <6sONGydqKNxsV-KKNWNmMz4sK4KiwEX9ZcmRQb5Lygo=.50721d19-2f26-47b1-bf65-49dc95dc363b@github.com> On Fri, 26 Jun 2020 13:50:39 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this change that checks if a PR contains merges from outside the current project, and suggests using a >> merge-style PR. >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Updated foreign merge detection Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/679 From ihse at openjdk.java.net Fri Jun 26 14:53:20 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 26 Jun 2020 14:53:20 GMT Subject: RFR: Add info about MANPATH to README. Message-ID: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> Add info about MANPATH to README. ------------- Commit messages: - Add info about MANPATH to README. Changes: https://git.openjdk.java.net/skara/pull/680/files Webrev: https://webrevs.openjdk.java.net/skara/680/webrev.00 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/680.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/680/head:pull/680 PR: https://git.openjdk.java.net/skara/pull/680 From rwestberg at openjdk.java.net Sat Jun 27 10:26:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 27 Jun 2020 10:26:47 GMT Subject: Integrated: 342: Pull request bot should warn on merge commits with non-target branch parent In-Reply-To: References: Message-ID: On Fri, 26 Jun 2020 11:16:58 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that checks if a PR contains merges from outside the current project, and suggests using a > merge-style PR. > Best regards, > Robin This pull request has now been integrated. Changeset: 8f94a62a Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/8f94a62a Stats: 103 lines in 3 files changed: 0 ins; 103 del; 0 mod 342: Pull request bot should warn on merge commits with non-target branch parent Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/679 From rwestberg at openjdk.java.net Sat Jun 27 10:31:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 27 Jun 2020 10:31:36 GMT Subject: RFR: Add support for paginated fields Message-ID: Hi all, Please review this change that add support for automatic decoding of paginated results where the pagination is done on a field in the result object, instead of across the entire result. Best regards, Robin ------------- Commit messages: - Add support for a paginated field in an object - Initial support for testing pagination Changes: https://git.openjdk.java.net/skara/pull/681/files Webrev: https://webrevs.openjdk.java.net/skara/681/webrev.00 Stats: 104 lines in 2 files changed: 88 ins; 1 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/681.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/681/head:pull/681 PR: https://git.openjdk.java.net/skara/pull/681 From ehelin at openjdk.java.net Mon Jun 29 06:29:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 29 Jun 2020 06:29:37 GMT Subject: RFR: Add support for paginated fields In-Reply-To: References: Message-ID: On Sat, 27 Jun 2020 10:23:18 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that add support for automatic decoding of paginated results where the pagination is done on > a field in the result object, instead of across the entire result. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/681 From rwestberg at openjdk.java.net Mon Jun 29 06:43:08 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 29 Jun 2020 06:43:08 GMT Subject: Integrated: Add support for paginated fields In-Reply-To: References: Message-ID: On Sat, 27 Jun 2020 10:23:18 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that add support for automatic decoding of paginated results where the pagination is done on > a field in the result object, instead of across the entire result. > Best regards, > Robin This pull request has now been integrated. Changeset: 38d782ad Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/38d782ad Stats: 104 lines in 2 files changed: 1 ins; 88 del; 15 mod Add support for paginated fields Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/681 From ihse at openjdk.java.net Mon Jun 29 11:15:58 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Mon, 29 Jun 2020 11:15:58 GMT Subject: RFR: Add info about MANPATH to README. [v2] In-Reply-To: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> References: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> Message-ID: > Add info about MANPATH to README. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Point user to build output instead of man page sources. ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/680/files - new: https://git.openjdk.java.net/skara/pull/680/files/ec7361f4..105721f4 Webrevs: - full: https://webrevs.openjdk.java.net/skara/680/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/680/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/680.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/680/head:pull/680 PR: https://git.openjdk.java.net/skara/pull/680 From ehelin at openjdk.java.net Mon Jun 29 12:05:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 29 Jun 2020 12:05:50 GMT Subject: RFR: Add info about MANPATH to README. In-Reply-To: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> References: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> Message-ID: <1UUFvFV3_TWTG2WbgRu6O6hs-dn9n6UKks-ntrByNsw=.baefea5f-c001-4254-a8fa-2d67940dea49@github.com> On Fri, 26 Jun 2020 14:34:53 GMT, Magnus Ihse Bursie wrote: > Add info about MANPATH to README. Thanks @magicus! Just a very minor nit - the custom is to _not_ end pull request titles with a period (just like we don't end commit message titles with a period). You can edit the title of this pull request by either clicking the "Edit" button in a browser or if you are using the Skara CLI tools: `git pr set --title`. ------------- PR: https://git.openjdk.java.net/skara/pull/680 From ehelin at openjdk.java.net Mon Jun 29 12:10:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 29 Jun 2020 12:10:50 GMT Subject: RFR: Add info about MANPATH to README. [v2] In-Reply-To: References: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> Message-ID: On Mon, 29 Jun 2020 11:15:58 GMT, Magnus Ihse Bursie wrote: >> Add info about MANPATH to README. > > Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: > > Point user to build output instead of man page sources. Looks good, just a minor comment inline. README.md line 171: > 170: > 171: ``` > 172: echo "export MANPATH=\$MANPATH":$PWD/build/bin/man >> ~/.bashrc Suggestion: GitHub Flavored Markdown (and regular Markdown) support an [info string](https://github.github.com/gfm/#info-string) after the opening code fence symbols (```). This info string is commonly used to describe the programming language used in a code block (`bash` in this example). This enables for example syntax highlighting etc. ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/680 From ihse at openjdk.java.net Mon Jun 29 12:37:42 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Mon, 29 Jun 2020 12:37:42 GMT Subject: RFR: Add info about MANPATH to README [v3] In-Reply-To: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> References: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> Message-ID: > Add info about MANPATH to README. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Update README.md Co-authored-by: Erik Duveblad ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/680/files - new: https://git.openjdk.java.net/skara/pull/680/files/105721f4..c443e8e9 Webrevs: - full: https://webrevs.openjdk.java.net/skara/680/webrev.02 - incr: https://webrevs.openjdk.java.net/skara/680/webrev.01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/680.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/680/head:pull/680 PR: https://git.openjdk.java.net/skara/pull/680 From ihse at openjdk.java.net Mon Jun 29 12:37:49 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Mon, 29 Jun 2020 12:37:49 GMT Subject: Integrated: Add info about MANPATH to README In-Reply-To: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> References: <33y-4sVul1zzXcqaR6V6Qszg0KiZZa8fYYCG5G_EwKw=.071c2596-f62f-4964-9e29-f42d60953fa5@github.com> Message-ID: <8XrYcvC4GPPYPhFFrfjlMYxiJBXXD2EPFzlFPcLUqLk=.6bba5725-6340-4e65-986c-073ae576431c@github.com> On Fri, 26 Jun 2020 14:34:53 GMT, Magnus Ihse Bursie wrote: > Add info about MANPATH to README. This pull request has now been integrated. Changeset: 0d451355 Author: Magnus Ihse Bursie Committer: Erik Helin URL: https://git.openjdk.java.net/skara/commit/0d451355 Stats: 9 lines in 1 file changed: 0 ins; 9 del; 0 mod Add info about MANPATH to README Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/680 From rwestberg at openjdk.java.net Mon Jun 29 12:50:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 29 Jun 2020 12:50:06 GMT Subject: RFR: 330: Allow commands at end of PR body Message-ID: Hi all, Please review this change that allows commands in the PR body. It also adds support for multiple commands in a single comment, and centralizes the multiline command handling. Best regards, Robin ------------- Commit messages: - Update tests now that commands always run after checks - Support body commands, only parse commands after a completed check - Drop multi-line parsing from the summary command - Adapt to the new interface - Extract commands into invocations - wip Changes: https://git.openjdk.java.net/skara/pull/682/files Webrev: https://webrevs.openjdk.java.net/skara/682/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-330 Stats: 425 lines in 20 files changed: 288 ins; 43 del; 94 mod Patch: https://git.openjdk.java.net/skara/pull/682.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/682/head:pull/682 PR: https://git.openjdk.java.net/skara/pull/682 From ehelin at openjdk.java.net Mon Jun 29 12:51:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 29 Jun 2020 12:51:40 GMT Subject: RFR: 330: Allow commands at end of PR body In-Reply-To: References: Message-ID: <0zcC7_H8Xlhe_PDD9re9BUJZdd45Zz3CYXYin-hv0cE=.aaf13fbe-38e4-4679-b9fb-5c7e397ff67b@github.com> On Mon, 29 Jun 2020 12:41:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows commands in the PR body. It also adds support for multiple commands in a single > comment, and centralizes the multiline command handling. > Best regards, > Robin Super nice work Robin! ?? :partying_face: Really liked that you enabled multiple commands per comment as well, seems generally useful. See inline for a very minor nit on formatting. bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandHandler.java line 39: > 38: } > 39: default boolean allowedInBody() { return false; } > 40: } Suggestion: default boolean allowedInBody() { return false; } Suggestion to be consistent with style ?? ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/682 From rwestberg at openjdk.java.net Mon Jun 29 15:10:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 29 Jun 2020 15:10:06 GMT Subject: Integrated: 330: Allow commands at end of PR body In-Reply-To: References: Message-ID: On Mon, 29 Jun 2020 12:41:38 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows commands in the PR body. It also adds support for multiple commands in a single > comment, and centralizes the multiline command handling. > Best regards, > Robin This pull request has now been integrated. Changeset: 95d655d5 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/95d655d5 Stats: 427 lines in 20 files changed: 43 ins; 290 del; 94 mod 330: Allow commands at end of PR body Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/682 From rwestberg at openjdk.java.net Mon Jun 29 15:10:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 29 Jun 2020 15:10:06 GMT Subject: RFR: 330: Allow commands at end of PR body [v2] In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that allows commands in the PR body. It also adds support for multiple commands in a single > comment, and centralizes the multiline command handling. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandHandler.java Co-authored-by: Erik Duveblad ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/682/files - new: https://git.openjdk.java.net/skara/pull/682/files/fb8119d2..bb4cf12a Webrevs: - full: https://webrevs.openjdk.java.net/skara/682/webrev.01 - incr: https://webrevs.openjdk.java.net/skara/682/webrev.00-01 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/682.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/682/head:pull/682 PR: https://git.openjdk.java.net/skara/pull/682 From rwestberg at openjdk.java.net Tue Jun 30 06:10:52 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 30 Jun 2020 06:10:52 GMT Subject: RFR: 434: Adding a contributor without a full name gives a NPE Message-ID: Hi all, Please review this change that ensures that an additional contributor is properly specified. Best regards, Robin ------------- Commit messages: - Check that full name is present Changes: https://git.openjdk.java.net/skara/pull/683/files Webrev: https://webrevs.openjdk.java.net/skara/683/webrev.00 Issue: https://bugs.openjdk.java.net/browse/SKARA-434 Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/683.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/683/head:pull/683 PR: https://git.openjdk.java.net/skara/pull/683 From ehelin at openjdk.java.net Tue Jun 30 12:44:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 30 Jun 2020 12:44:40 GMT Subject: RFR: 434: Adding a contributor without a full name gives a NPE In-Reply-To: References: Message-ID: <86ZU5iUKP1NLx99wsMCyIckgtHk9bPKBbim7RnobS6M=.d868e696-afee-4982-87c1-2bbac285dc2a@github.com> On Tue, 30 Jun 2020 06:02:16 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that an additional contributor is properly specified. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/683 From rwestberg at openjdk.java.net Tue Jun 30 13:01:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 30 Jun 2020 13:01:10 GMT Subject: Integrated: 434: Adding a contributor without a full name gives a NPE In-Reply-To: References: Message-ID: <6FZESEKEp6FS1pxVGLo8n_pxud4-SKh_qeaHroXjBbk=.4d34a82d-2c43-4c17-bc7f-a5c53a215a4e@github.com> On Tue, 30 Jun 2020 06:02:16 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that an additional contributor is properly specified. > > Best regards, > Robin This pull request has now been integrated. Changeset: dbc85017 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/dbc85017 Stats: 12 lines in 2 files changed: 0 ins; 10 del; 2 mod 434: Adding a contributor without a full name gives a NPE Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/683