RFR: storage: cache deserialized values in FileStorage

Robin Westberg rwestberg at openjdk.java.net
Fri Jun 12 06:58:46 UTC 2020

On Thu, 11 Jun 2020 16:03:15 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that adds caching of the deserialized value to `FileStorage`. There is no point in
> deserializing the same `String` over and over again, the deserialized value will remain the same.
> Testing:
> - [x] Added a new unit test
> - [x] `make test` passes on Linux x64
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/656

More information about the skara-dev mailing list