RFR: 411: Warn when a PR issue is not of a primary type

Erik Helin ehelin at openjdk.java.net
Tue Jun 16 13:47:24 UTC 2020


On Tue, 16 Jun 2020 12:11:29 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that makes it possible the issue types that should be allowed to be referenced from a PR for a
>> repository.
>> Testing:
>> - [x] Added a new unit test
>> - [x] `make test` passes on Linux x64
>> 
>> Thanks,
>> Erik
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 122:
> 
>> 121:             if (repo.value().contains("issuetypes")) {
>> 122:                 var types = repo.value().get("issuetypes").asArray()
>> 123:                                                           .stream()
> 
> You just do .stream directly here, right? At least I tend to do that.. :)

Right, yes, will fix!

-------------

PR: https://git.openjdk.java.net/skara/pull/665


More information about the skara-dev mailing list