RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v2]
Erik Helin
ehelin at openjdk.java.net
Wed Jun 24 12:02:59 UTC 2020
On Wed, 24 Jun 2020 10:18:44 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this change that adds the possibility of issuing an `/issue create` command. The title and the body of
>> the issue will be copied from the pull request. The command is only available for committers and above (who already
>> have access to creating issues manually). Best regards,
>> Robin
>
> Robin Westberg has updated the pull request incrementally with two additional commits since the last revision:
>
> - Allow using / as a component/subcomponent separator
> Remove debug print statement
> - Only allow creating issues of type "enhancement" for now
Looks good overall, just a few inline comments on how to specify component and subcomponent.
bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 62:
> 61: reply.println(" * `/" + name + " [add] <id>: <description>`");
> 62: reply.println(" * `/" + name + " create [pX] <component> [subcomponent]");
> 63: reply.println();
Suggestion:
reply.println(" * `/" + name + " create [PX] <component>/[subcomponent]");
bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 69:
> 68: reply.println(" * `/" + name + " 1234567: Use this exact title`");
> 69: reply.println(" * `/" + name + " create hotspot jfr");
> 70: reply.println(" * `/" + name + " create P4 core-libs java.nio");
Suggestion:
reply.println(" * `/" + name + " create hotspot/jfr");
bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 70:
> 69: reply.println(" * `/" + name + " create hotspot jfr");
> 70: reply.println(" * `/" + name + " create P4 core-libs java.nio");
> 71: reply.println();
Suggestion:
reply.println(" * `/" + name + " create P4 core-libs/java.nio");
bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 216:
> 215: private void createIssue(PullRequestBot bot, PullRequest pr, String args, CensusInstance censusInstance,
> HostUser author, PrintWriter reply) { 216: if (!censusInstance.isAuthor(author)) {
> 217: reply.println("Only [Authors](https://openjdk.java.net/bylaws#author) are allowed to create issues.");
DId you mean to check for committer status? In the description of the PR you wrote for "Committers" and above, but here
you are checking for "Author" and above
-------------
Changes requested by ehelin (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/677
More information about the skara-dev
mailing list