RFR: 330: Allow commands at end of PR body

Erik Helin ehelin at openjdk.java.net
Mon Jun 29 12:51:40 UTC 2020

On Mon, 29 Jun 2020 12:41:38 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> Please review this change that allows commands in the PR body. It also adds support for multiple commands in a single
> comment, and centralizes the multiline command handling.
> Best regards,
> Robin

Super nice work Robin! �� :partying_face: Really liked that you enabled multiple commands per comment as well, seems
generally useful. See inline for a very minor nit on formatting.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandHandler.java line 39:

> 38:     }
> 39:     default boolean allowedInBody() { return false; }
> 40: }


    default boolean allowedInBody() {
        return false;

Suggestion to be consistent with style ��


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/682

More information about the skara-dev mailing list