RFR: 292: Add comment to PR when it becomes outdated

Erik Helin ehelin at openjdk.java.net
Wed Mar 18 09:26:38 UTC 2020


On Tue, 17 Mar 2020 15:42:52 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Hi all,
> 
> Please review this change that posts an instructional message on how to sync with the target branch the first time a PR
> is marked as outdated.
> Best regards,
> Robin

Looks good, just a small nit regarding the comment!

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 545:

> 544:                 "`" + pr.targetRef() + "` due to one or more merge conflicts. To resolve these merge conflicts " +
> 545:                 "and update this pull request you can run the following commands:\n" +
> 546:                 "```bash\n" +

Suggestion:

                "and update this pull request you can run the following commands in the local repository for your personal fork:\n" +

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/513


More information about the skara-dev mailing list